D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau added a comment. In D17086#366120 , @ngraham wrote: > Looks great to me then! > > But how do I make this work? I compiled and installed the icon and verified that it's installed in the right place. But my AppImage isn't getting the n

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham added a comment. "transferred" done request @ngraham @dfaure @bruns to give thumbs up again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham updated this revision to Diff 46235. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=46174&id=46235 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubha

D17167: Provide a method of assigning custom default icons for non-XDG dirs

ngraham updated this revision to Diff 46234. ngraham added a comment. Match existing brace style for inline initializer REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17167?vs=46233&id=46234 BRANCH custom-icons-for-non-xdg-dirs (branched from master) REVISI

D17167: Provide a method of assigning custom default icons for non-XDG dirs

ngraham updated this revision to Diff 46233. ngraham added a comment. Correct typo in the comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17167?vs=46232&id=46233 BRANCH custom-icons-for-non-xdg-dirs (branched from master) REVISION DETAIL https://ph

D17167: Provide a method of assigning custom default icons for non-XDG dirs

ngraham created this revision. ngraham added reviewers: Frameworks, cfeck, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adds a new folder-to-icon map that makes it possible to

D17013: Show menu bar, how to re-enable, common shortcut dialog

ngraham added a comment. Even though a lot of inline comments have been marked as resolved, I don't actually see that the requested changes have been made. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_appli

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

ngraham added a comment. Looks great to me then! But how do I make this work? I compiled and installed the icon and verified that it's installed in the right place. But my AppImage isn't getting the new icon, not even after running `update-desktop-database`. F6441744: Weird.png

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau added a comment. In D17086#366111 , @ngraham wrote: > Thanks, that looks great! As for the background color, I'd say it's okay to use a different shade of blue if it would better match the AppImage branding. For now I favor breez

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau retitled this revision from "Add icons for application-vnd.appimage" to "Add icons for application-vnd.appimage/x-iso9660-appimage". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham Cc: TheAssassin, ngraham, kde-frameworks-

D17086: Add icons for application-vnd.appimage

kossebau updated this revision to Diff 46231. kossebau added a comment. - add symlinks for application-x-iso9660-appimage to application-vnd.appimage REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17086?vs=46229&id=46231 BRANCH addappimageiconv2 RE

D17086: Add icons for application-vnd.appimage

ngraham added a comment. Thanks, that looks great! As for the background color, I'd say it's okay to use a different shade of blue if it would better match the AppImage branding. Don't worry about participating in the style change discussion; if that ever bears any fruit, we'll change th

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. Quoting myself: > You might also add a 1 somewhere in there to indicate the type, but as both are still relevant and should mostly work equally, that's not really necessary. I think more and more that there shouldn't be different icons. The user shouldn'

D17086: Add icons for application-vnd.appimage

kossebau added a comment. F6441665: Screenshot_20181126_014024.png for an updated example usage. @ngraham How do you create those summary pictures you used above for the comparison previews? In D17086#366097

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. AFAIK `vnd.appimage` resolves to type 2, whereas `x-[iso9660-]appimage` resolves to type 1. At least that's the MIME data I've been working with all the time so far. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kosseba

D17086: Add icons for application-vnd.appimage

kossebau added a comment. In D17086#363977 , @ngraham wrote: > We have two options here: > > 1. Follow the style and make the AppImage icon look like a document with a folded-over corner that has an the AppImage logo in the middle > 2. Eng

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. The new logos look great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage

kossebau updated this revision to Diff 46229. kossebau added a comment. - use document-style icon shape, to match other existing icons for executables - use Breeze palette color that is more close to AppImage logo one REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabri

D17161: Replace Latin1 character remnant with escaped UTF-8 sequence

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17161 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

bruns added inline comments. INLINE COMMENTS > bruns wrote in job_error.cpp:1079 > "transeferred" "transeferred"? - not done ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, brun

D17162: Harmonize handling of underscore in query parser

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The engine differentiates between independent terms, and a

D17161: Replace Latin1 character remnant with escaped UTF-8 sequence

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN ctest REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL

D17160: Remove extra spaces from Debug output, insert delimiters between fields

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When a single query is streamed, the fields may be separat

D16919: Re-add DBus test

hindenburg added a comment. Yes, I was actually surprised I managed to get it all to run. Are there official docs on how to setup an ci image and run applications? If not, it would be helpful. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmunds

D17048: Restore sendfile support

sefaeyeoglu added a comment. Can someone benchmark this? Would be nice to know how much this affects performance. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17048 To: davidedmundson, dfaure Cc: sefaeyeoglu, ngraham, apol, kde-frameworks-devel, michaelh, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham added a comment. @bruns is it good to go? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17139: Add highlighting file for Wayland Debug Traces

This revision was automatically updated to reflect the committed changes. Closed by commit R216:abb86831466b: Add highlighting file for Wayland Debug Traces (authored by cordlandwehr). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17139?vs=46148&i

D16412: Add the possibility to have a keyboard shortcut to create a file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8100e99e1465: Add the possibility to have a keyboard shortcut to create a file (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16412?vs=45292&id=

D17128: DocumentPrivate: Remove comment mark when joining lines

cullmann added a comment. > An extra action looks to me at first sight a little overdone, but an option how join behaves may appropriate. An option in the settings would work for me, too. I just don't want to destroy the work-flow of people that rely on the current behavior. REPOSITOR

T10112: KDEInstallDirs on Mac

rjvbb added a comment. You will notice that I plan to maintain an option to disable the Apple-specific behaviour for anyone who depends on the current behaviour (that includes me, but your script would also continue to work). Cf. the `APPLE_FORCE_X11` option A priori /Library/Applicatio

T10112: KDEInstallDirs on Mac

yurikoles added a comment. /Library/Application Support/kf5 This will be incompatible with homebrew packages , since they are built inside sandbox and own prefix. I had created a shell script

D17017: Fix assert when cleaning up symlinks in PreviewJob

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17017 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH newfileshortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D16412 To: thsurrel, #frameworks, dfaure, elvisangelaccio Cc: elvisangelaccio, kde-framewo

D16919: Re-add DBus test

bcooksley added a comment. Okay, that is odd. I'll try reproducing the issue on the CI nodes in the next day or so - you changed 'kcalcore' in that example to 'konsole' I assume? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole

D16370: KTextEditor : syntax definition priority UI usability

rjvbb added a comment. > Allowing negative prios makes sense. Yes, they do make life a bit more bearable but aren't the ultimate solution either, at least not on Mac. The other day I had to work my way through the entire list to set a whole bunch of positive priorities (which I never s

D16370: KTextEditor : syntax definition priority UI usability

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4009bc1e919d: Allow negative syntax definition priorities. (authored by rjvbb). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16370?vs=45380&id=46185 REVISION D

D17128: DocumentPrivate: Remove comment mark when joining lines

loh.tar added a comment. > I am not sure if the normal join lines should try to be that clever. But consider the "auto comment" feature after you hit "Return", it's also somehow "special clever" but very useful. This tries to add the corresponding functionality. Well, the true opposite w

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham