D17245: Add string formatting function to property info

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:83 > IMHO thats not better at all - what does "top, left" refer to? And whats the > difference to "left, top"? > > Every orientation save "normal" and "rotated 180" is ambiguous without > further description. I

D15960: Don't check if file is directory based on mime-type

astippich accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns, astippich Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D17160: Remove extra spaces from Debug output, insert delimiters between fields

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17160 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippic

D16617: fix extraction of GPS altitude for exif data

astippich added a comment. Thanks INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:217 > This is bogus, why am I not allowed to take photos at sea level? Or in > Greenwhich, at the Equator? > > Invalid data should **not** be signaled by 0.0 Yep, I will change that in another diff REPOS

<    1   2