D7446: [Places panel] Revamp the Recently Saved section

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. We need to update `kfileplacesmodeltest` (as well as `placesitemmodeltest` in dolphin). REPOSITORY R241 KIO REVISION DETAIL

D17300: add result to baloo namespace

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY it is the only file not using the Baloo namespace REPOSITORY

D17301: add documentation to result class

yurchor added inline comments. INLINE COMMENTS > result.h:56 > + * > + * \p property This specifies a property name. It should be one of the > + * properties from the list of properties from KFileMetaData. This should be `\param`

D17302: add simple test for string merging

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY adds a simple test for the result class that tests how multiple

D17245: Add string formatting function to property info

astippich updated this revision to Diff 46688. astippich added a comment. - update strings for image orientation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46509=46688 BRANCH display_value REVISION DETAIL

D17309: Add flashlight action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH flashlight-icons (branched from master) REVISION DETAIL

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8efa39d4bbf1: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17298: remove unused doc_id from result

bruns added a dependent revision: D17312: Remove unused map() getter from Result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17298: remove unused doc_id from result

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The doc id in result class is never set and never read, so remove

D17301: add documentation to result class

astippich added a comment. I had the impression that I have to read a lot of code just to know which variable does what, so I wrote some simple documentation. Please check if I got anything wrong. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich,

D17310: Improve Kile icon with LaTeX font

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D17312: Remove unused map() getter from Result

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The m_map is only used internally as a intermediate

D17302: add simple test for string merging

bruns added inline comments. INLINE COMMENTS > astippich wrote in resulttest.cpp:40 > Actually it is. The TermGenerators are otherwise only initialized with > nullptr, and consequently will crash. That is something that should be fixed > (separately). D17315

D17281: Add icon to KBuildSycocaProgressDialog cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kbuildsycocaprogressdialog.cpp:71 > setAutoClose(false); > +QDialogButtonBox* dialogButtonBox = new > QDialogButtonBox(QDialogButtonBox::Cancel); > +setCancelButton(dialogButtonBox->button(QDialogButtonBox::Cancel)); Please

D17295: BrightScript: Add function/sub folding

This revision was automatically updated to reflect the committed changes. Closed by commit R216:50a65cb06c37: BrightScript: Add function/sub folding (authored by dlevin, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17305: Add KDE Connect SMS plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Enable sharing links via KDE Connect SMS TEST PLAN Send a page from

D17285: Add plugin type for sharing URLs

nicolasfella added a dependent revision: D17305: Add KDE Connect SMS plugin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17292: [SMS App] Allow passing a message via args. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham,

D17302: add simple test for string merging

bruns added inline comments. INLINE COMMENTS > resulttest.cpp:2 > +/* > + * > + * Copyright (C) 2018 Alexander Stippich ^_^ > resulttest.cpp:39 > + > +Result > result(QStringLiteral("test"),QStringLiteral("audo/mpeg3"),KFileMetaData::ExtractionResult::ExtractEverything); > +

D17298: remove unused doc_id from result

bruns added a comment. Addition - the document id is also stored and can be retrieved from the Baloo::Document. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D17295: BrightScript: Add function/sub folding

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17295 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh,

D17310: Improve Kile icon with LaTeX font

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL

D17313: Use Compact json formatting for storing document metadata

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Document metadata is stored json encoded in the

D17299: move implementation of document get to cpp file

bruns added a comment. yes, please. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/17/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 02 Dec 2018 06:17:37 + Build duration: 2 hr 11 min and counting JUnit Tests

D17252: ovs-patch and ovs-port setting

pranavgade updated this revision to Diff 46674. pranavgade marked 4 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17252?vs=46543=46674 REVISION DETAIL https://phabricator.kde.org/D17252 AFFECTED FILES

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 updated this revision to Diff 46677. GB_2 added a comment. Improve code (pass `this` as parent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46637=46677 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FILES

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna,

D17281: Add icon to KBuildSycocaProgressDialog cancel button

elvisangelaccio accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef,

D16826: Treat uints the same as ints

astippich retitled this revision from "Treat uints and doubles the same as integers" to "Treat uints the same as ints". astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham,

D16826: Treat uints and doubles the same as integers

astippich updated this revision to Diff 46679. astippich added a comment. - only add uints for now REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16826?vs=46625=46679 BRANCH uint_double REVISION DETAIL https://phabricator.kde.org/D16826 AFFECTED FILES

D17299: move implementation of document get to cpp file

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY for consistency REPOSITORY R293 Baloo BRANCH result_doc

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

bruns added a comment. Because the original file is latin1, thus not decodable as utf8, so it has to be binary ... Stupid arc/phabricator REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17282 To: bruns, #baloo, #frameworks, ngraham, astippich Cc:

D16826: Treat uints the same as ints

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH uint_double REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D17299: move implementation of document get to cpp file

bruns added a comment. Why? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

bruns added inline comments. INLINE COMMENTS > result.h:83 > + */ > void setDocument(const Baloo::Document& doc); > The use case is missing here. `Can be used to add extraction results to an existing Baloo::Document. Has to be called before passing the Result to

D17317: match and tc setting

jgrulich added inline comments. INLINE COMMENTS > matchsettingtest.cpp:43 > + > +map.insert(QLatin1String(NM_SETTING_MATCH_INTERFACE_NAME), > interfaceName); > + This define won't exist for NM < 1.12.0 > tcsettingtest.cpp:58 > + > +

D17252: ovs-patch and ovs-port setting

jgrulich added inline comments. INLINE COMMENTS > ovsportsettingtest.cpp:29 > + > +#if NM_CHECK_VERSION(1, 10, 0) > +#define NM_SETTING_OVS_PORT_SETTING_NAME"ovs-port" #if !NM_CHECK_VERSION(1, 10, 0) > ovsportsetting.cpp:26 > + > +#if NM_CHECK_VERSION(1, 10, 0) > +#define

D17298: remove unused doc_id from result

astippich added a dependent revision: D17299: move implementation of document get to cpp file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D16826: Treat uints the same as ints

astippich added a dependent revision: D17298: remove unused doc_id from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D17298: remove unused doc_id from result

astippich added a dependency: D16826: Treat uints the same as ints. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

astippich added a dependency: D17298: remove unused doc_id from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R293 Baloo BRANCH result_documentation REVISION DETAIL

D17302: add simple test for string merging

astippich added a comment. Didn't found what I wanted to find, but since the code is there we can add it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D17301: add documentation to result class

astippich marked 4 inline comments as done. astippich added a comment. Thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46687. astippich added a comment. - use param REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46684=46687 BRANCH result_documentation REVISION DETAIL https://phabricator.kde.org/D17301 AFFECTED FILES

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17282 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

astippich added a comment. In D17282#369617 , @ngraham wrote: > Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file? I'm wondering the same. REPOSITORY R293 Baloo REVISION DETAIL

D17305: Add KDE Connect SMS plugin

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17285: Add plugin type for sharing URLs. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17299: move implementation of document get to cpp file

astippich added a comment. Really just a cosmetic change for consistency, if you don't want it in, I'm fine with dropping it REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D17309: Add flashlight action icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D16832: fix empty runner list after switching to new locale

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Dead runners will surely be empty on the first load. You could still have had a locale change then. Also, now I'm re-reading it you're relying on locales to

D17301: add documentation to result class

astippich marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46706. astippich added a comment. - implement feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46687=46706 BRANCH result_documentation REVISION DETAIL https://phabricator.kde.org/D17301 AFFECTED

D17252: ovs-patch and ovs-port setting

pranavgade updated this revision to Diff 46708. pranavgade marked 2 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17252?vs=46674=46708 REVISION DETAIL https://phabricator.kde.org/D17252 AFFECTED FILES

D16826: Treat uints the same as ints

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f6f9ecb2a17e: Treat uints the same as ints (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16826?vs=46679=46709 REVISION DETAIL

D17302: add simple test for string merging

astippich updated this revision to Diff 46710. astippich marked 2 inline comments as done. astippich added a comment. - small fixes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=46686=46710 BRANCH test_result REVISION DETAIL

D17302: add simple test for string merging

astippich added inline comments. INLINE COMMENTS > bruns wrote in resulttest.cpp:40 > No need to reset the default constructed `Baloo::Document` with a default > constructed one. Actually it is. The TermGenerators are otherwise only initialized with nullptr, and consequently will crash. That

D17315: Avoid potential nullptr access for Document use reference instead

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Using a TermGenerator without backing document is

D17317: match and tc setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added match and tc setting according to:

D17313: Use Compact json formatting for storing document metadata

ngraham added a comment. This is backwards-compatible with the existing formal for retrieval, right? REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17313 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov,

D17313: Use Compact json formatting for storing document metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b891716d336a: Use Compact json formatting for storing document metadata (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17313?vs=46716=46745

D17315: Avoid potential nullptr access for Document use reference instead

astippich added a comment. In D17315#370404 , @bruns wrote: > In D17315#370298 , @astippich wrote: > > > This one doesn't apply, looks like D17824 is a dependency? > > > D17312

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 02 Dec 2018 20:38:31 + Build duration: 5 min 34 sec and counting JUnit Tests Name: (root)

D15464: [server] Touch drag support

This revision was automatically updated to reflect the committed changes. Closed by commit R127:09b5adee94ad: [server] Touch drag support (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15464?vs=45164=46753 REVISION DETAIL

D17284: RFC: Add unit test for splitting of numbers in TermGenerator

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17284 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

ngraham added a comment. This can land now! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17245: Add string formatting function to property info

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:63 > +PropertyInfo sampleRate(Property::SampleRate); > +QCOMPARE(sampleRate.formatAsDisplayString(QVariant(44100)), > QStringLiteral("44,1 kHz")); > +PropertyInfo bitRate(Property::BitRate); I think this should be

D17309: Add flashlight action icons

ndavis added a comment. Reminds me of these: http://store.t-studious.com/wp-content/uploads/2016/12/Maglite-2D-LED-Torch-.jpg I like the 32px version, but it kind of just looks like a tube with the 16px `flashlight-off` icon. What if you turned the head of the flashlight to the right?

D17299: move implementation of document get to cpp file

astippich added a dependent revision: D17300: add result to baloo namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17300: add result to baloo namespace

astippich added a dependent revision: D17301: add documentation to result class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17300 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17300: add result to baloo namespace

astippich added a dependency: D17299: move implementation of document get to cpp file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17300 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich added a dependency: D17300: add result to baloo namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

bruns added a comment. I think methods reimplemented from and documented in KFileMetaData::ExtractionResult should **not** be documented here. INLINE COMMENTS > result.h:38 > + * \brief The result class is where all the data extracted by > + * the KFileMetaData extractors is saved to a

D17312: Remove unused map() getter from Result

bruns added a dependent revision: D17301: add documentation to result class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17312 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D17301: add documentation to result class

bruns added a dependency: D17312: Remove unused map() getter from Result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > result.h:105 > +/** > + * Contains all indexed data from the extractors > + */ Only properties REPOSITORY R293 Baloo REVISION DETAIL

D17252: ovs-patch and ovs-port setting

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ovspatchsettingtest.cpp:30 > +#if !NM_CHECK_VERSION(1, 10, 0) > +#define NM_SETTING_OVS_PATCH_SETTING_NAME "ovs-patch" > +#define NM_SETTING_OVS_PATCH_PEER

D17252: ovs-patch and ovs-port setting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:15670b62146f: ovs-patch and ovs-port setting (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17252?vs=46708=46719#toc REPOSITORY R282

D17317: match and tc setting

jgrulich added a comment. Why did you add my test for tun setting? REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17312: Remove unused map() getter from Result

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17312 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17298: remove unused docId from result

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH remove_result_id REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D17298: remove unused docId from result

ngraham accepted this revision. ngraham added a comment. Ah, of course, duh! REPOSITORY R293 Baloo BRANCH remove_result_id REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17309: Add flashlight action icons

trickyricky26 added a comment. The main issue is that the added lines are too much complexity for 16px icons. They are probably possible for 22px and up, at the expense of making the flashlight look a bit short. REPOSITORY R266 Breeze Icons REVISION DETAIL

D17298: remove unused docId from result

astippich retitled this revision from "remove unused doc_id from result" to "remove unused docId from result". astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel,

D17310: Improve Kile icon with LaTeX font

ngraham accepted this revision. ngraham added a reviewer: Kile. ngraham added a comment. This revision is now accepted and ready to land. Looks great to me! Let's make sure the Kile folks agree. :) REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION

D16671: Refactor embedded image extractor for greater extensibility

astippich added a comment. anyone? I would like to extend the support to the same file types as supported by the taglibextractor REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16671 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo,

D17312: Remove unused map() getter from Result

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17312 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17313: Use Compact json formatting for storing document metadata

bruns added a comment. In D17313#370345 , @ngraham wrote: > This is backwards-compatible with the existing formal for retrieval, right? From the json standpoint, both are equivalent. REPOSITORY R293 Baloo BRANCH submit REVISION

D17298: remove unused docId from result

This revision was automatically updated to reflect the committed changes. Closed by commit R293:647823d36592: remove unused docId from result (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17298?vs=46680=46743 REVISION DETAIL

D17312: Remove unused map() getter from Result

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f614d56285bf: Remove unused map() getter from Result (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17312?vs=46715=46744 REVISION DETAIL

D17301: add documentation to result class

astippich marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

bruns added a dependency: D17315: Avoid potential nullptr access for Document, use reference instead. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17324 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17315: Avoid potential nullptr access for Document, use reference instead

bruns added a dependent revision: D17324: Move internal helper from BasicIndexingJob to anonymous namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D17298: remove unused docId from result

astippich removed a dependency: D16826: Treat uints the same as ints. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16826: Treat uints the same as ints

astippich removed a dependent revision: D17298: remove unused docId from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D17310: Improve Kile icon with LaTeX font

ndavis added a comment. The original design was more consistent with the usual style for text characters used in Breeze icons, but I think using actual LaTeX fonts in this context works just as well or better for LaTeX users. +1 REPOSITORY R266 Breeze Icons BRANCH

D16931: Extract more tags from exif metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0b35de4243aa: Extract more tags from exif metadata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16931?vs=45608=46757 REVISION

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Also remove the return value, as it not evaluated, and

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 added a comment. In D17281#370253 , @ngraham wrote: > @GB_2, can you provide an email address so we can land this for you? Thanks! How can I provide an email address in the Phabriactor webinterface? I already provided an email in

  1   2   >