D17441: tune editing actions for large number of small edits

anthonyfieroni added inline comments. INLINE COMMENTS > katetextblock.cpp:153 > // remember all ranges modified > -QSet changedRanges; > +std::vector changedRanges; > foreach (TextCursor *cursor, m_cursors) { You can use unordered_set, so you don't need

D17441: tune editing actions for large number of small edits

loh.tar added a comment. I have tried this one. Yes, works much more better! Nice to see that my own (unloved) patch wake your interest to dig into that issue :-) As usual understand I most of your talk here not really, and these perf protocols give me no light on the first sight.

D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin

mpyne created this revision. mpyne added reviewers: Frameworks, elvisangelaccio, apol, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mpyne requested review of this revision. REVISION SUMMARY As reported in bug 401888

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

ngraham added a comment. I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and [Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those. REPOSITORY R39

D17441: tune editing actions for large number of small edits

cullmann added a comment. 85.51% 0.00% kwrite kwrite [.] main 85.49% 0.00% kwrite libc-2.28.so[.] __libc_start_main 85.47% 0.00% kwrite kwrite [.] _start

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47160. cullmann added a comment. save expensive buildReplacement call if no place holders around REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47159=47160 BRANCH master REVISION DETAIL

D17441: tune editing actions for large number of small edits

cullmann added a comment. 2.54% 0.10% kwrite libKF5TextEditor.so.5.53.0 [.] KTextEditor::DocumentCursor::atEndOfDocument :P ROFL REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc:

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47159. cullmann added a comment. avoid costly lineLength computation this really is expensive, as we do a lookup of the line that kills the cache in the block lookup + we can skip that easily for non-last lines costs 2% for large replaces

D17441: tune editing actions for large number of small edits

cullmann added a comment. New state: 85.24% 0.00% kwrite kwrite [.] main 85.21% 0.00% kwrite libc-2.28.so[.] __libc_start_main 85.19% 0.00% kwrite kwrite

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47157. cullmann added a comment. only update edit position stack once per transaction with last position of any primitive REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47155=47157 BRANCH master

D17406: add attributes `shared` and `__gshared`

This revision was automatically updated to reflect the committed changes. Closed by commit R216:8741ced7fe71: add attributes `shared` and `__gshared` (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17406?vs=47037=47156

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47155. cullmann added a comment. avoid massive moving range creation use now 1 moving range, not 1 per replacement REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47151=47155 BRANCH master REVISION

D17355: Align Plasma QML button content in center if it has an icon

davidedmundson added a comment. > Any changes to PlasmaStyle need to happen in the QQC2 (PlasmaComponents3) version too before shipping INLINE COMMENTS > ButtonStyle.qml:41 > +label: Item { > +implicitWidth: row.implicitWidth > +RowLayout { why this Item wrapper

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

gregormi edited the summary of this revision. gregormi added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

gregormi created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gregormi requested review of this revision. REVISION SUMMARY The idea is to use F6 and Shift+F6 in Kate for Next and Previous Search Match. These shortcuts

D17441: tune editing actions for large number of small edits

cullmann added a comment. :=) at least we now beat atom, with the test case file and replace all \t >= ; it just crashed here after "non responding". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: kwrite-devel,

D17441: tune editing actions for large number of small edits

cullmann added a comment. Same issue with the marks of the vimode. Perhaps they should not triggered at all if vi mode is off ;=) In any case, this test shows a lot of bottlenecks. e.g. even the l->toVirtualColumn that is used for block mode did show up like hell because it was

D17441: tune editing actions for large number of small edits

dhaumann added a comment. Hm indeed. I remember when the patch was added that added the editing positions. At that time I was not convinced about this, and now even performance problems show up. What I wonder is: Usually, these editing positions should just be the ones the user really

D17441: tune editing actions for large number of small edits

cullmann added a comment. Yes, even after this optimization :P 10% Here is the flat profile, after all this (using the test case from the bug, replacing \t with ; and terminating kwrite afterwards) 86.90% 2.05% kwrite libQt5Core.so.5.11.2[.]

D17441: tune editing actions for large number of small edits

dhaumann added a comment. Just curious: Do the editing positions really show up in perf? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,

D17441: tune editing actions for large number of small edits

cullmann added a reviewer: loh.tar. cullmann added a comment. Could you try this patch? With it, the test case from the bug properly works with < 3GB of memory. It is still VERY slow, but it doesn't lead to an unusable state. Before, alone the replacement moving ranges that are used for

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47150. cullmann added a comment. limit number of highlightings for replace more than 2^16 things will not be marked REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47148=47150 BRANCH master REVISION

D17419: Add view-private icon

ndavis added a comment. In D17419#373590 , @ngraham wrote: > If view-private-symbolic is just a symlink to the regular icon, do we really need it? I think the whole *-symbolic thing is a GNOME-ism. It's their way of specifying whether

D17419: Add view-private icon

GB_2 added a comment. In D17419#373590 , @ngraham wrote: > If view-private-symbolic is just a symlink to the regular icon, do we really need it? It's for compatibility, because other icons in Breeze and also other icon themes do it.

D17437: SearchBar: Avoid malfunction with very large files

cullmann added a comment. I am still not that happy with a hard limit, I will first work a bit on the root causes: that the speed sucks ;=) https://phabricator.kde.org/D17441 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17437 To: loh.tar, #ktexteditor,

D17441: tune editing actions for large number of small edits

cullmann added reviewers: dhaumann, Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY example workload that triggers these bottlenecks: mass replace of a character in a large

D17419: Add view-private icon

ngraham added a comment. If view-private-symbolic is just a symlink to the regular icon, do we really need it? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg,

D17419: Add view-private icon

GB_2 updated this revision to Diff 47147. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons (wider hat brim). It's perfect now :-) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47145=47147 REVISION DETAIL

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

sars added a comment. @zetazeta I'm not sure the highlighting length limit is worth an option as the editing of the document is not effected. I it is just a bit inconvenient that the highlighting disappears... REPOSITORY R39 KTextEditor REVISION DETAIL

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

sars marked 2 inline comments as done. sars added a comment. @dhaumann: You are right, the highlighting of the document still takes place and it is only KateRenderer that stops using the highlighting info for all lines longer than 1024 characters. All shorter lines are highlighted. So

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

sars updated this revision to Diff 47146. sars added a comment. - Use a bit different config key to force a value reset for the limit. - Fix reading the config value. - Update the line-highlight disabled info message and position. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17419: Add view-private icon

GB_2 added a comment. Wait, but I thought if the hat brim is wider, the margins are not big enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel,

D17419: Add view-private icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks right. I might prefer a wider hat brim or a mask like @filipf suggested, but I'm not going to make that a requirement since it seems more like a matter of taste. Here's roughly

D17419: Add view-private icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh,

D17419: Add view-private icon

GB_2 updated this revision to Diff 47145. GB_2 retitled this revision from "Add private-mode icon" to "Add view-private icon". GB_2 added a comment. Change name to the more common "view-private" and add a symlink for the symbolic icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D17419: Add private-mode icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I noticed that the 24px version is now aligned to the grid, but the margins aren't right. The 16 and 22px versions are still not aligned to the grid. The correct margin size

D17437: SearchBar: Avoid malfunction with very large files

loh.tar added a comment. Would be good you take the time and do that test @cullmann When you then think it is still useful to soften that limit let me know how. To become that code more smart as you suggest I have right now not the mood, sorry. I think this patch is good enough to avaoid

D17437: SearchBar: Avoid malfunction with very large files

cullmann added a comment. For the: I like to suggest to get rid of most of that S code and use instead code from the Search plugin. There is the S done in an own thread and did not block the UI. I would for sure like to have batched search/replace, e.g. that one does the stuff in

D17425: dcb settings

pranavgade added a comment. Hey! Could you please check and let me know which of the first two commits you prefer? Thanks! REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

pranavgade updated this revision to Diff 47139. pranavgade added a comment. Alternate way to do a part of the task CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47092=47139 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES

D17437: SearchBar: Avoid malfunction with very large files

loh.tar added a comment. - The mentioned crash could I not reproduce, but after 5 million hits and a felt eternity I had killed Kate - There is an issue now with the wrap message, where is now the same close button. Any ideas what's wrong? - I like to suggest to get rid of most of that S

D17437: SearchBar: Avoid malfunction with very large files

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hmm, I don't like such hard limits. e.g. in our company, more or less all machines have 32 or 64 GB of memory and that should work fine. (not that I say we should use that

D17437: SearchBar: Avoid malfunction with very large files

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This is only a workaround to avoid cases where Kate can

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: cullmann, #kdevelop, #ktexteditor, #kate, mwolff, intelfx Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, kwrite-devel, hase, michaelh, ngraham, bruns,

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

cullmann commandeered this revision. cullmann added a reviewer: intelfx. cullmann added a comment. As nobody will be working on this, I abandon this now. If somebody steps up to do the work, feel free to reopen it again. REPOSITORY R39 KTextEditor REVISION DETAIL

D9175: Migrate some more QRegExps to QRegularExpression

dhaumann added a comment. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Curent state: This patch is only almost good to go in... :-P INLINE COMMENTS > cullmann wrote in kateview.cpp:3595 > I think the old code tried to ensure we only add

D9077: Bug 377342 Question

cullmann abandoned this revision. cullmann added a comment. Abandoned in favor of https://phabricator.kde.org/D9175 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9077 To: cullmann, christofg Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase,

D9077: Bug 377342 Question

cullmann commandeered this revision. cullmann added a reviewer: christofg. cullmann added a comment. :( Sorry that this never got attention. We have already https://phabricator.kde.org/D9175 for this, that includes this change and more, but was never finalized. If somebody can

D17436: BrightScript: Remove unused keyword list 'end'

dhaumann updated this revision to Diff 47134. dhaumann added a comment. - increase version number only by one :-) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17436?vs=47131=47134 BRANCH fix_brightscript REVISION DETAIL

D17436: BrightScript: Remove unused keyword list 'end'

dhaumann created this revision. dhaumann added reviewers: dlevin, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This warning was introduced with D17295

D17295: BrightScript: Add function/sub folding

dhaumann added inline comments. INLINE COMMENTS > brightscript.xml:290 > > - > - Since this context is not used anymore, we gen a warning while creating the highlighting index: [ 9%] Generating index.katesyntax testkatehighlightingindexer(31350)/(default)

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann added a comment. For: Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended. Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI

D17413: stay in context Linkage2/Pragma2 until closing paren

This revision was automatically updated to reflect the committed changes. Closed by commit R216:66367f8e6366: stay in context Linkage2/Pragma2 until closing paren (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17413?vs=47069=47129#toc REPOSITORY R216 Syntax

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

zetazeta added a comment. Guys this is great work. Can we please make the limits configurable? Each developer will have a different sweet spot. I don't want to burden this revision, maybe we can make a bug about configuring the limits and leave that part to someone confortable with the

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi added a comment. +1 for leaving Save As on top level. Just for reference the File menu of the current master on my screen :) F6464245: grafik.png As for me, at least all the Close actions could be moved into a submenu. REPOSITORY

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

dhaumann added a comment. Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended. Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI merging?

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann added a comment. I think grouping these not that often used things is ok. I would keep "save as" toplevel. One thing to clarify: How do we get the "Save All" of Kate inside the file_save2 menu? I assume we should name the menu better and reuse that name inside kateui.rc.

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

dhaumann added a comment. Is it correct that highlighting in the document (i.e. KSyntaxHighlighting) still takes place for the entire line, and this change simply only changes the fact that KateRenderer stops using the highlighting info after 10 columns? Prior to accepting this

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

dhaumann added a subscriber: cullmann. dhaumann added a comment. @cullmann You did not seem to have strong objections to this. Can you comment on this here again? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: cullmann,

D15999: Add icons with added background to system.svgz

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can you also bump the version numbers in the `metadata.desktop` files? REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D15999 REVISION DETAIL

D17392: Fix checkDesktopFile function

elvisangelaccio added a comment. Already fixed by c08ee4577168070896a4a46220cd39df4e4e32cf REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17392 To: i.Dark_Templar, davidedmundson, #frameworks

D17419: Add private-mode icon

GB_2 added a comment. Oh, thanks for reminding me about Cuttlefish... I forgot about it, but now I don't need a QML for testing icons anymore :P REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis,

D17419: Add private-mode icon

GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, crozbo,

D17419: Add private-mode icon

ngraham added a comment. Oh, probably a Cuttlefish bug then. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros,

D17430: highlight token strings and delimited strings

aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH tokenstring-delimitedstring REVISION DETAIL

D17419: Add private-mode icon

GB_2 added a comment. How is that even possible? There is no 48 px size icon and the one you showed was and older version of the icon... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis, filipf,

D17419: Add private-mode icon

ngraham added a comment. Hmm, now it seems like his hat gets flat at the 48px size: F6464036: flat hat.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham Cc: ndavis,

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. I have made the root a and root capital K design with the pen added: F6463710: kile-background-alt.svg.png F6463712: kile-background-alt2.svg.png At 100% scaling:

D17413: stay in context Linkage2/Pragma2 until closing paren

aG0aep6G added a comment. In D17413#372902 , @dhaumann wrote: > Could you use your real name please? no REPOSITORY R216 Syntax Highlighting BRANCH stay-in-context-until-closing-paren REVISION DETAIL

D17128: DocumentPrivate: Remove comment mark when joining lines

loh.tar added a comment. Thanks for your input Dominik. In the meanwhile I noticed (again) these "Smart-Return" function (I noticed, and used that a couple of years for a short time period, but forgot that somehow) A reverse version of that should be nice. And somehow the possibility to

D17425: dcb settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY added dcb settings according to :

D17419: Add private-mode icon

GB_2 updated this revision to Diff 47093. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47081=47093 REVISION DETAIL https://phabricator.kde.org/D17419

D17419: Add private-mode icon

GB_2 added a comment. Is this better? F6463614: private-mode Breeze Icon (2).png F6463613: private-mode.svg REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2,

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

loh.tar added a comment. In D17382#372925 , @dhaumann wrote: > sorry for the delay :( What? No, it was pretty fast :-) But I have a couple of Sonnet stuff where no progress happens :-/ REPOSITORY R39 KTextEditor REVISION DETAIL

D15763: Set correct image attributes on directory thumbnail

anthonyfieroni added a comment. To 18.12 ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun,

D9077: Bug 377342 Question

loh.tar added subscribers: cullmann, loh.tar. loh.tar added a comment. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. @cullmann I thing you could give a short hint But perhaps is @christofg no longer interested to work on this issue REPOSITORY