D17441: tune editing actions for large number of small edits

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katetextblock.cpp:153
>  // remember all ranges modified
> -QSet changedRanges;
> +std::vector changedRanges;
>  foreach (TextCursor *cursor, m_cursors) {

You can use unordered_set, so you don't need m_isCheckValidityRequired any 
more. It can be applied to other places as well.

> katesearchbar.cpp:815
> +const int maxHighlightings = 65536;
> +std::vector highlightRanges;
> +

You can preserve say 1024 i think.

> katesearchbar.cpp:852
>  } else {
> -// Highlight and continue after original match
> -//highlightMatch(match);
> -highlightRanges << match.range();
> -matchCounter++;
> +highlightRanges.clear();
>  }

Why you clear highlights, you can break and continue with stored ones no?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[loh tar]

loh.tar added a comment.


  I have tried this one. Yes, works much more better! 
  Nice to see that my own (unloved) patch wake your interest to dig into that 
issue :-)
  
  As usual understand I most of your talk here not really, and these perf 
protocols give me no light on the first sight. But thank you that you let me 
participate.
  
  - Now, just find all of a char in that fat file is done very quickly
  - Doing these tab->semicolon S still takes quite a while but works here. 
System monitor told 1.8G memory was eaten
  
  I think with this patch need KateSearchBar still some improvement. Like to 
give a hint that S is running and the possibility to abort. Would be good to 
add some test if a S may run out of memory. Not everyone has a lot of RAM 
available.
  
  Um, just a stupid question: Is there a need to do the S just as it is done 
currently? So far I understand that, is the only reason why that is so 
f**antastic slow caused by tons off calls which are intend to track a normal 
editing.
  
  Why not simple do the S on the raw file, make a diff, highlight the changes 
and we are done(?) 
  I did the tab->semicolon S by sed, just for interest, and it takes 2-3 
seconds :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin

[Michael Pyne]

mpyne created this revision.
mpyne added reviewers: Frameworks, elvisangelaccio, apol, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mpyne requested review of this revision.

REVISION SUMMARY
  As reported in bug 401888 , the 
current `kcoreaddons_add_plugin` CMake macro causes deprecation warnings in 
extra-cmake-module's `KDEInstallDirs` since we use an old-style install path 
variable (`PLUGIN_INSTALL_DIR`).
  
  This should just be `KDE_INSTALL_PLUGINDIR` and so that's all my fix is, but 
since I'm not very familiar with the CMake stuff or the plugin loading code I 
wanted to get a review on it before I commit.

TEST PLAN
  Built and installed kcoreaddons successfully, and then built and installed 
kactivitymanagerd (which uses kcoreaddons_add_plugin pervasively) and verified 
that kactivitymanagerd still builds and installs and that the plugin install 
dir, including its install namespace, is properly updated.
  
  I also manually forced `KDE_INSTALL_DIRS_NO_DEPRECATED` to a true value in 
kactivitymanagerd as recommended in the bug, and still rebuilt/installed 
without deprecation warnings.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17446

AFFECTED FILES
  KF5CoreAddonsMacros.cmake

To: mpyne, #frameworks, elvisangelaccio, apol, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Nathaniel Graham]

ngraham added a comment.


  I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and 
[Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party 
apps, as well as all GNOME and macOS apps. It might make more sense to 
standardize on those.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


85.51% 0.00%  kwrite   kwrite  [.] 
main
85.49% 0.00%  kwrite   libc-2.28.so[.] 
__libc_start_main
85.47% 0.00%  kwrite   kwrite  [.] 
_start
85.09% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QApplicationPrivate::notify_helper
85.09% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QApplication::notify
85.08% 0.00%  kwrite   libQt5Core.so.5.11.2[.] 
QCoreApplication::notifyInternal2
84.95% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QWidget::event
84.82% 0.00%  kwrite   libQt5Core.so.5.11.2[.] 
QEventLoop::exec
84.81% 0.00%  kwrite   libQt5Core.so.5.11.2[.] 
QCoreApplication::exec
83.75% 2.45%  kwrite   libQt5Core.so.5.11.2[.] 
QMetaObject::activate
83.66% 0.00%  kwrite   libQt5Gui.so.5.11.2 [.] 
QGuiApplicationPrivate::processWindowSystemEvent
83.66% 0.00%  kwrite   libQt5Gui.so.5.11.2 [.] 
QWindowSystemInterface::sendWindowSystemEvents
83.66% 0.00%  kwrite   libQt5XcbQpa.so.5.11.2  [.] 
0x7f8e008eadac
83.64% 0.00%  kwrite   libQt5Gui.so.5.11.2 [.] 
QGuiApplicationPrivate::processMouseEvent
83.64% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7f8e084575d4
83.64% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QApplicationPrivate::sendMouseEvent
83.64% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7f8e0845498b
83.63% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QAbstractButton::mouseReleaseEvent
83.01% 0.00%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::qt_static_metacall
83.01% 0.00%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::replaceAll
83.01% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QAbstractButton::clicked
83.01% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7f8e084e4a1b
83.01% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7f8e084e5e11
82.95% 0.28%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::findAll
69.05% 0.17%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateMatch::replace
65.42% 0.12%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::replaceText
34.14% 0.19%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::insertText
32.93% 0.22%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::editInsertText
31.05% 0.18%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::removeText
29.85% 0.32%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::editRemoveText
17.63% 0.17%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::removeText
17.45% 0.22%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::insertText
10.64% 0.87%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBlock::removeText
 9.25% 0.02%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::textInserted
 9.20% 0.06%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateMatch::searchText
 8.96% 0.98%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBlock::insertText
 7.97% 0.11%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::searchText
 7.65% 0.04%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::textInserted
 6.54% 0.04%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::QSlotObject, void>::impl
 6.54% 0.07%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctionPointer::call, void>
 6.46% 0.08%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctorCall, 
QtPrivate::List, void, void 
(KateVi::NormalViMode::*)(KTextEditor::Document*, KTextEditor::Range)>::call
 5.81% 0.09%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::textRemoved
 5.12% 0.05%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::textRemoved
 4.92% 0.29%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateBuffer::plainLine
 4.88% 0.09%  kwrite   

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47160.
cullmann added a comment.


  save expensive buildReplacement call if no place holders around

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47159=47160

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h
  src/buffer/katetextcursor.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  2.54% 0.10%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentCursor::atEndOfDocument
  
  :P ROFL

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47159.
cullmann added a comment.


  avoid costly lineLength computation
  
  this really is expensive, as we do a lookup of the line that kills
  the cache in the block lookup + we can skip that easily for non-last lines
  
  costs 2% for large replaces

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47157=47159

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h
  src/buffer/katetextcursor.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/utils/documentcursor.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  New state:
  
85.24% 0.00%  kwrite   kwrite  [.] 
main
85.21% 0.00%  kwrite   libc-2.28.so[.] 
__libc_start_main
85.19% 0.00%  kwrite   kwrite  [.] 
_start
84.96% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QApplicationPrivate::notify_helper
84.96% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QApplication::notify
84.95% 0.00%  kwrite   libQt5Core.so.5.11.2[.] 
QCoreApplication::notifyInternal2
84.84% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QWidget::event
84.63% 0.00%  kwrite   libQt5Core.so.5.11.2[.] 
QEventLoop::exec
84.62% 0.00%  kwrite   libQt5Core.so.5.11.2[.] 
QCoreApplication::exec
83.54% 2.38%  kwrite   libQt5Core.so.5.11.2[.] 
QMetaObject::activate
83.43% 0.00%  kwrite   libQt5Gui.so.5.11.2 [.] 
QWindowSystemInterface::sendWindowSystemEvents
83.43% 0.00%  kwrite   libQt5XcbQpa.so.5.11.2  [.] 
0x7fd225febdac
83.43% 0.00%  kwrite   libQt5Gui.so.5.11.2 [.] 
QGuiApplicationPrivate::processWindowSystemEvent
83.42% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7fd22db585d4
83.42% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QApplicationPrivate::sendMouseEvent
83.42% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7fd22db5598b
83.42% 0.00%  kwrite   libQt5Gui.so.5.11.2 [.] 
QGuiApplicationPrivate::processMouseEvent
83.42% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QAbstractButton::mouseReleaseEvent
82.87% 0.00%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::qt_static_metacall
82.87% 0.00%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::replaceAll
82.87% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QAbstractButton::clicked
82.87% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7fd22dbe5a1b
82.87% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
0x7fd22dbe6e11
82.81% 0.25%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::findAll
66.79% 0.24%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateMatch::replace
59.00% 0.10%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::replaceText
29.71% 0.22%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::insertText
29.14% 0.12%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::removeText
28.54% 0.18%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::editInsertText
28.09% 0.27%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::editRemoveText
16.95% 0.19%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::removeText
15.63% 0.17%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::insertText
 9.52% 0.82%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBlock::removeText
 9.29% 0.05%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateMatch::searchText
 8.37% 0.24%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::searchText
 7.89% 0.83%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBlock::insertText
 7.82% 0.28%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateBuffer::plainLine
 7.75% 0.03%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::textInserted
 7.34% 0.27%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::line
 7.01% 0.12%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::textInserted
 6.25% 0.14%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::textRemoved
 5.96% 0.06%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::QSlotObject, void>::impl
 5.95% 0.09%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctionPointer::call, void>
 5.87% 0.08%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctorCall, 
QtPrivate::List, void, void 
(KateVi::NormalViMode::*)(KTextEditor::Document*, KTextEditor::Range)>::call
 5.03% 0.09%  kwrite   

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47157.
cullmann added a comment.


  only update edit position stack once per transaction with last position of 
any primitive

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47155=47157

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h
  src/buffer/katetextcursor.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17406: add attributes `shared` and `__gshared`

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:8741ced7fe71: add attributes `shared` and `__gshared` 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17406?vs=47037=47156

REVISION DETAIL
  https://phabricator.kde.org/D17406

AFFECTED FILES
  data/syntax/d.xml

To: aG0aep6G, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47155.
cullmann added a comment.


  avoid massive moving range creation
  
  use now 1 moving range, not 1 per replacement

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47151=47155

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h
  src/buffer/katetextcursor.cpp
  src/buffer/katetextrange.h
  src/document/katedocument.cpp
  src/search/katematch.cpp
  src/search/katematch.h
  src/search/katesearchbar.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17355: Align Plasma QML button content in center if it has an icon

[David Edmundson]

davidedmundson added a comment.


  > Any changes to PlasmaStyle need to happen in the QQC2 (PlasmaComponents3) 
version too before shipping

INLINE COMMENTS

> ButtonStyle.qml:41
> +label: Item {
> +implicitWidth: row.implicitWidth
> +RowLayout {

why this Item wrapper

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17355

To: GB_2, #plasma, #vdg
Cc: davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, alexde, 
IohannesPetros, trickyricky26, ragreen, Pitel, michaelh, crozbo, ndavis, 
ZrenBot, firef, bruns, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, mbohlender, mart

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi edited the summary of this revision.
gregormi added a reviewer: Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[gregormi]

gregormi created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gregormi requested review of this revision.

REVISION SUMMARY
  The idea is to use F6 and Shift+F6 in Kate for Next and Previous Search
  Match. These shortcuts are also used by QtCreator for that.
  
  Since F6 is currently used for "Show Icon Border", here is a proposal to
  adapt.
  
  1. Change shortcut for "Show Icon Border" to "Ctrl+E, Ctrl+B" because it
  
  is used not that often to deserve an F key.
  
  Why "Ctrl+E, ..."? Because Qt Creator uses it as start key combination
  for various functions. The alternative would be "Ctrl+D, ..." which is
  used by Visual Studio.
  
  Ctrl+E is currently used for "Go to previous edit" (Ctrl+Shift+E: go to
  next edit). Ctrl+D is currently used to comment a line. I choose to
  change "Go to previous edit".
  
  2. Set new shortcut Alt+F6 and Alt+Shift+F6 for "Go to previous/next
  
  edit".
  
  While at it, I made some additions with the newly freed Ctrl+E shortcut:
  
  3. Add Ctrl+E, Ctrl+W for "Dynamic Word Wrap" (like in Qt Creator) (the
  
  current F10 could be freed later)
  
  4. Use Ctrl+E, Ctrl+I for "Clean Indentation" which is a useful feature
  
  (which could later be extended by a more powerful code formatter)
  
  5. Use Ctrl+E, Ctrl+S for "Show non-printable spaces" (for comparison:
  
  in Qt Creator it is Ctrl+E, Ctrl+V for "Visualize Whitespace")
  
  6. Use Ctrl+E, Ctrl+L for "Show Line Numbers" (as alternative to F11
  
  which could later be used for something else)

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17442

AFFECTED FILES
  src/view/kateview.cpp

To: gregormi
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  :=) at least we now beat atom, with the test case file and replace all \t >= 
; it just crashed here after "non responding".

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  Same issue with the marks of the vimode.
  Perhaps they should not triggered at all if vi mode is off ;=)
  In any case, this test shows a lot of bottlenecks.
  e.g. even the l->toVirtualColumn that is used for block mode did show up like 
hell because it was accidently done always ;=)
  that had a >> 10% usage here for some runs during patching.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Dominik Haumann]

dhaumann added a comment.


  Hm indeed. I remember when the patch was added that added the editing 
positions. At that time I was not convinced about this, and now even 
performance problems show up.
  
  What I wonder is: Usually, these editing positions should just be the ones 
the user really jumped to or actively did something. But when you do a search & 
replace, this should completely be disabled imho... Maybe that would also be a 
fix to remove this bottleneck entirely for specific use cases. (or remove this 
feature altogether again :p )

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a comment.


  Yes, even after this optimization :P 10%
  
  Here is the flat profile, after all this (using the test case from the bug, 
replacing \t with ; and terminating kwrite afterwards)
  
86.90% 2.05%  kwrite   libQt5Core.so.5.11.2[.] 
QMetaObject::activate
86.50% 0.00%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::qt_static_metacall
86.48% 0.00%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::replaceAll
86.48% 0.00%  kwrite   libQt5Widgets.so.5.11.2 [.] 
QAbstractButton::clicked
86.48% 0.00%  kwrite   [unknown]   [.] 
0x7ff1fbcecb00
86.08% 0.13%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateSearchBar::findAll
72.36% 0.17%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateMatch::replace
58.83% 0.08%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::replaceText
30.05% 0.10%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::removeText
29.33% 0.18%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::editRemoveText
28.24% 0.09%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::insertText
27.38% 0.14%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::editInsertText
14.03% 0.15%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::removeText
13.01% 0.07%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::insertText
10.65% 0.03%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::textRemoved
10.56% 0.76%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextCursor::setPosition
10.24% 0.01%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::textInserted
10.10% 0.02%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::QSlotObject, void>::impl
10.09% 0.03%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctionPointer::call, void>
10.05% 0.04%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctorCall, 
QtPrivate::List, void, void 
(KateVi::NormalViMode::*)(KTextEditor::Document*, KTextEditor::Range)>::call
 9.04% 1.36%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBlock::removeText
 9.04% 0.11%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextCursor::setPosition
 8.42% 1.23%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBlock::insertText
 8.39% 0.02%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::QSlotObject, 
void>::impl
 8.38% 0.03%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctionPointer::call, void>
 8.34% 0.06%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QtPrivate::FunctorCall, 
QtPrivate::List, void, void 
(KTextEditor::DocumentPrivate::*)(KTextEditor::Document*, KTextEditor::Range 
const&)>::call
 8.13% 0.25%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::saveEditingPositions
 7.63% 0.54%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateVi::Marks::setMark
 6.48% 0.40%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextRange::fixLookup
 6.45% 0.03%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateMatch::searchText
 5.84% 0.19%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateBuffer::plainLine
 5.48% 0.04%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::newMovingRange
 5.48% 0.06%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KTextEditor::DocumentPrivate::searchText
 5.47% 0.20%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::line
 5.36% 0.14%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextRange::TextRange
 4.99% 0.11%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextRange::checkValidity
 4.92% 0.13%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateVi::NormalViMode::textInserted
 4.85% 0.12%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
KateVi::NormalViMode::textRemoved
 4.69% 1.65%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
Kate::TextBuffer::blockForLine
 4.04% 1.08%  kwrite   libKF5TextEditor.so.5.53.0  [.] 
QBasicAtomicInteger::load
 3.89% 0.04%  kwrite   libKF5TextEditor.so.5.53.0  

D17441: tune editing actions for large number of small edits

[Dominik Haumann]

dhaumann added a comment.


  Just curious: Do the editing positions really show up in perf?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added a reviewer: loh.tar.
cullmann added a comment.


  Could you try this patch?
  With it, the test case from the bug properly works with < 3GB of memory.
  It is still VERY slow, but it doesn't lead to an unusable state.
  Before, alone the replacement moving ranges that are used for the hl at the 
end did take extra 4-5 GB of memory.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann updated this revision to Diff 47150.
cullmann added a comment.


  limit number of highlightings for replace
  more than 2^16 things will not be marked

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17441?vs=47148=47150

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann, dhaumann, #kate
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17419: Add view-private icon

[Noah Davis]

ndavis added a comment.


  In D17419#373590 , @ngraham wrote:
  
  > If view-private-symbolic is just a symlink to the regular icon, do we 
really need it?
  
  
  I think the whole *-symbolic thing is a GNOME-ism. It's their way of 
specifying whether to use a color icon or a monochrome icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add view-private icon

[Björn Feber]

GB_2 added a comment.


  In D17419#373590 , @ngraham wrote:
  
  > If view-private-symbolic is just a symlink to the regular icon, do we 
really need it?
  
  
  It's for compatibility, because other icons in Breeze and also other icon 
themes do it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann added a comment.


  I am still not that happy with a hard limit, I will first work a bit on the 
root causes: that the speed sucks ;=)
  
  https://phabricator.kde.org/D17441

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann added reviewers: dhaumann, Kate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17441: tune editing actions for large number of small edits

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  example workload that triggers these bottlenecks: mass replace of a character 
in a large
  document
  
  see: https://phabricator.kde.org/D17437
  
  bug report with test case file: https://bugs.kde.org/show_bug.cgi?id=333517
  
  these changes are not sufficient to have it working properly but perf already 
tells it is much better

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17441

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/vimode/marks.cpp
  src/vimode/marks.h

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17419: Add view-private icon

[Nathaniel Graham]

ngraham added a comment.


  If view-private-symbolic is just a symlink to the regular icon, do we really 
need it?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add view-private icon

[Björn Feber]

GB_2 updated this revision to Diff 47147.
GB_2 edited the summary of this revision.
GB_2 added a comment.


  Improve icons (wider hat brim).
  It's perfect now :-)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17419?vs=47145=47147

REVISION DETAIL
  https://phabricator.kde.org/D17419

AFFECTED FILES
  icons-dark/actions/16/view-private.svg
  icons-dark/actions/symbolic/view-private-symbolic.svg
  icons/actions/16/view-private.svg
  icons/actions/symbolic/view-private-symbolic.svg

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars added a comment.


  @zetazeta I'm not sure the highlighting length limit is worth an option as 
the editing of the document is not effected. I it is just a bit inconvenient 
that the highlighting disappears...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars marked 2 inline comments as done.
sars added a comment.


  @dhaumann: You are right, the highlighting of the document still takes place 
and it is only KateRenderer that stops using the highlighting info for all 
lines longer than 1024 characters. All shorter lines are highlighted.
  
  So the length limit option is still the same: Wrapping long lines on opening 
a document, just 25 times longer ;)
  
  The disabled high-lighting **is** a workaround, but if we don't bring in some 
radical changes it will choke at some point anyways. So I would say that the 
target is to get the limits as high as possible.
  
  I saw that Visualstudio code uses a similar limit for highlighting lines, but 
I don't know if that disables the highlighting totally
  
  I found this workaround by running Kate in Hotspot ;) I can continue a bit to 
see if I can get the 1024 limit raised...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars updated this revision to Diff 47146.
sars added a comment.


  - Use a bit different config key to force a value reset for the limit.
  - Fix reading the config value.
  - Update the line-highlight disabled info message and position.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17241?vs=46957=47146

BRANCH
  disable_hl2

REVISION DETAIL
  https://phabricator.kde.org/D17241

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/document/katedocument.cpp
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17419: Add view-private icon

[Björn Feber]

GB_2 added a comment.


  Wait, but I thought if the hat brim is wider, the margins are not big enough?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add view-private icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Looks right. I might prefer a wider hat brim or a mask like @filipf 
suggested, but I'm not going to make that a requirement since it seems more 
like a matter of taste.
  
  Here's roughly how it will look in Falkon:
  F6464527: Screenshot_20181208_145146.png 

  
  Here it is with a wider brim on the hat:
  F6464530: Screenshot_20181208_145156.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add view-private icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add view-private icon

[Björn Feber]

GB_2 updated this revision to Diff 47145.
GB_2 retitled this revision from "Add private-mode icon" to "Add view-private 
icon".
GB_2 added a comment.


  Change name to the more common "view-private" and add a symlink for the 
symbolic icon.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17419?vs=47143=47145

REVISION DETAIL
  https://phabricator.kde.org/D17419

AFFECTED FILES
  icons-dark/actions/16/view-private.svg
  icons-dark/actions/symbolic/view-private-symbolic.svg
  icons/actions/16/view-private.svg
  icons/actions/symbolic/view-private-symbolic.svg

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add private-mode icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I noticed that the 24px version is now aligned to the grid, but the margins 
aren't right. The 16 and 22px versions are still not aligned to the grid.
  
  The correct margin size for 24px is 4px on each side, but left and right 
margins can be exceeded if necessary. The 24px size is really only for 
applications that require 24px icons, such as some GTK applications. Do you 
actually need to use this size? There is no issue with adding it as long as 
it's correct, but it is slightly more work for you.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17437: SearchBar: Avoid malfunction with very large files

[loh tar]

loh.tar added a comment.


  Would be good you take the time and do that test @cullmann When you then 
think it is still useful to soften that limit let me know how.
  To become that code more smart as you suggest I have right now not the mood, 
sorry.
  I think this patch is good enough to avaoid the biggest trouble.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann added a comment.


  For the: I like to suggest to get rid of most of that S code and use 
instead code from the Search plugin. There is the S done in an own thread and 
did not block the UI.
  
  I would for sure like to have batched search/replace, e.g. that one does the 
stuff in chunks via single-shot timers and doesn't block the UI for e.g. 
incremental search that would be really nifty.
  
  That would allow people to abort long running stuff, too.
  
  (even no threads needed, just batch the stuff in e.g. 1000 line chunks)
  
  I would really love to have this improved, I think there are some bugs around 
that wish for non-blocking search/replace, too, like other proper editors have 
(and we not, shame on us)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17425: dcb settings

[Pranav Gade]

pranavgade added a comment.


  Hey!
  Could you please check and let me know which of the first two commits you 
prefer?
  Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

[Pranav Gade]

pranavgade updated this revision to Diff 47139.
pranavgade added a comment.


  Alternate way to do a part of the task

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47092=47139

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17437: SearchBar: Avoid malfunction with very large files

[loh tar]

loh.tar added a comment.


  - The mentioned crash could I not reproduce, but after 5 million hits and a 
felt eternity I had killed Kate
  - There is an issue now with the wrap message, where is now the same close 
button. Any ideas what's wrong?
  - I like to suggest to get rid of most of that S code and use instead code 
from the Search plugin. There is the S done in an own thread and did not 
block the UI.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hmm, I don't like such hard limits.
  e.g. in our company, more or less all machines have 32 or 64 GB of memory and 
that should work fine.
  (not that I say we should use that much memory).
  
  I would more like either a fix for the memory hogging or a soft-limit, like 
you report "oh, we already do x replacements, that might take a lot of 
memory, do you want to continue? x remember that choice..)
  
  That will rescue people that replace stuff by accident and still let people 
with "a lot" memory use the tool like they want ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This is only a workaround to avoid cases where Kate can crash due to a
  run out of memory.
  

  
  CCBUG: 333517

TEST PLAN
  Search warning
  F6464367: 1544290032.png 
  Replace warning
  F6464368: 1544290055.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

AFFECTED FILES
  src/search/katesearchbar.cpp

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: cullmann, #kdevelop, #ktexteditor, #kate, mwolff, intelfx
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, 
kwrite-devel, hase, michaelh, ngraham, bruns, demsking, sars

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann added a reviewer: intelfx.
cullmann added a comment.


  As nobody will be working on this, I abandon this now.
  If somebody steps up to do the work, feel free to reopen it again.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: cullmann, #kdevelop, #ktexteditor, #kate, mwolff, intelfx
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, 
kwrite-devel, hase, michaelh, ngraham, bruns, demsking, sars

D9175: Migrate some more QRegExps to QRegularExpression

[Dominik Haumann]

dhaumann added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  Curent state: This patch is only almost good to go in... :-P

INLINE COMMENTS

> cullmann wrote in kateview.cpp:3595
> I think the old code tried to ensure we only add word-boundary if we still 
> can find the string then. e.g. if the string that you highlight contains 
> spaces or stuff like that at the borders, you don't add \b.

This part is still not done. Besides that, this patch should be fine.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9175

To: dhaumann, cullmann, kfunk, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann, #frameworks

D9077: Bug 377342 Question

[Christoph Cullmann]

cullmann abandoned this revision.
cullmann added a comment.


  Abandoned in favor of https://phabricator.kde.org/D9175

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

To: cullmann, christofg
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann

D9077: Bug 377342 Question

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann added a reviewer: christofg.
cullmann added a comment.


  :( Sorry that this never got attention.
  
  We have already
  
  https://phabricator.kde.org/D9175
  
  for this, that includes this change and more, but was never finalized.
  If somebody can pick that other thing up, might be most useful, I will close 
this one.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

To: cullmann, christofg
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann

D17436: BrightScript: Remove unused keyword list 'end'

[Dominik Haumann]

dhaumann updated this revision to Diff 47134.
dhaumann added a comment.


  - increase version number only by one :-)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17436?vs=47131=47134

BRANCH
  fix_brightscript

REVISION DETAIL
  https://phabricator.kde.org/D17436

AFFECTED FILES
  data/syntax/brightscript.xml

To: dhaumann, dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17436: BrightScript: Remove unused keyword list 'end'

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: dlevin, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This warning was introduced with D17295  
- this is a proposed fix.
  
  Is there a better fix? Looking into the code, we can find more
  StringDetect rules that use "end". Maybe the keyword list should
  be used instead?

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_brightscript

REVISION DETAIL
  https://phabricator.kde.org/D17436

AFFECTED FILES
  data/syntax/brightscript.xml

To: dhaumann, dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17295: BrightScript: Add function/sub folding

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> brightscript.xml:290
>   
> - 
> - 

Since this context is not used anymore, we gen a warning while creating the 
highlighting index:

  [  9%] Generating index.katesyntax
  testkatehighlightingindexer(31350)/(default) ::KeywordChecker::check: 
"/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml"
 Unused keyword lists: QSet("end")

--> the keyword list end should be removed, since unused.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17295

To: dlevin, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Christoph Cullmann]

cullmann added a comment.


  For:
  
  Maybe file_save_alternatives or as Gregor once suggested file_save_variants. 
Or file_save_extended.
  
  Btw, do we have an issue that Kate (kateui.rc) and KTextEditor 
(katepart5ui.rc) use different release schedules? Does that imply issues with 
XMLGUI merging?
  
  > I think if we use the new sub-menu in kateui.rc and we have a old 
ktexteditor, we will have a submenu with just one entry until you get a more 
up-to-date KTextEditor.
  

  
  But as normally the frameworks are more up-to-date then the application, the 
only thing normal users should see is a submenu with the KTextEditor stuff 
inside and the save all toplevel.
  
  Btw., I think the menus do lack the *_merge markers.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, sars

D17413: stay in context Linkage2/Pragma2 until closing paren

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:66367f8e6366: stay in context Linkage2/Pragma2 until 
closing paren (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17413?vs=47069=47129#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17413?vs=47069=47129

REVISION DETAIL
  https://phabricator.kde.org/D17413

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Francisco de Zuviría]

zetazeta added a comment.


  Guys this is great work. Can we please make the limits configurable? Each 
developer will have a different sweet spot. I don't want to burden this 
revision, maybe we can make a bug about configuring the limits and leave that 
part to someone confortable with the configs.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[gregormi]

gregormi added a comment.


  +1 for leaving Save As on top level.
  
  Just for reference the File menu of the current master on my screen :)
  
  F6464245: grafik.png 
  
  As for me, at least all the Close actions could be moved into a submenu.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Dominik Haumann]

dhaumann added a comment.


  Maybe file_save_alternatives or as Gregor once suggested file_save_variants. 
Or file_save_extended.
  
  Btw, do we have an issue that Kate (kateui.rc) and KTextEditor 
(katepart5ui.rc) use different release schedules? Does that imply issues with 
XMLGUI merging?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Christoph Cullmann]

cullmann added a comment.


  I think grouping these not that often used things is ok.
  I would keep "save as" toplevel.
  One thing to clarify: How do we get the "Save All" of Kate inside the 
file_save2 menu? I assume we should name the menu better and reuse that name 
inside kateui.rc.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, sars

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

[Dominik Haumann]

dhaumann added a comment.


  Is it correct that highlighting in the document (i.e. KSyntaxHighlighting) 
still takes place for the entire line, and this change simply only changes the 
fact that KateRenderer stops using the highlighting info after 10 columns?
  
  Prior to accepting this patch, would it be possible to fix this differently, 
i.e. by profiling and fixing this properly instead of applying a workaround?

INLINE COMMENTS

> katetextbuffer.cpp:71
>  , m_newLineAtEof(false)
> -, m_lineLengthLimit(4096)
> +, m_lineLengthLimit(10)
>  , m_alwaysUseKAuthForSave(alwaysUseKAuth)

Hm, isn't the line length limit configurable in kateconfig.cpp? There you will 
find a key called

  const char KEY_LINE_LENGTH_LIMIT[] = "Line Length Limit";

that is used to read/write the config file.

I think if this is changed here to 10, it should be changed to the same 
value in KateDocumentConfig::readValue():

  setLineLengthLimit(config.readEntry(KEY_LINE_LENGTH_LIMIT, 4096));

And I would even suggest to rename as follows:

- const char KEY_LINE_LENGTH_LIMIT[] = "Line Length Limit"; + const char 
KEY_LINE_LENGTH_LIMIT[] = "Line Length Limitation";

Since then, all users will automatically get a reset here. Without this change, 
all users will stay on the 4096 limit.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Dominik Haumann]

dhaumann added a subscriber: cullmann.
dhaumann added a comment.


  @cullmann You did not seem to have strong objections to this. Can you comment 
on this here again?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, sars

D15999: Add icons with added background to system.svgz

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Can you also bump the version numbers in the `metadata.desktop` files?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D15999

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17392: Fix checkDesktopFile function

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Already fixed by c08ee4577168070896a4a46220cd39df4e4e32cf 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17392

To: i.Dark_Templar, davidedmundson, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17419: Add private-mode icon

[Björn Feber]

GB_2 added a comment.


  Oh, thanks for reminding me about Cuttlefish...
  I forgot about it, but now I don't need a QML for testing icons anymore :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add private-mode icon

[Björn Feber]

GB_2 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add private-mode icon

[Nathaniel Graham]

ngraham added a comment.


  Oh, probably a Cuttlefish bug then.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aG0aep6G requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  data/syntax/d.xml

To: aG0aep6G
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17419: Add private-mode icon

[Björn Feber]

GB_2 added a comment.


  How is that even possible? There is no 48 px size icon and the one you showed 
was and older version of the icon...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add private-mode icon

[Nathaniel Graham]

ngraham added a comment.


  Hmm, now it seems like his hat gets flat at the 48px size:
  
  F6464036: flat hat.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17310: Improve Kile icon with LaTeX font

[TrickyRicky]

trickyricky26 added a comment.


  I have made the root a and root capital K design with the pen added:
  F6463710: kile-background-alt.svg.png 
  
  F6463712: kile-background-alt2.svg.png 
  
  At 100% scaling:
  F6463715: Root a with pen screenshot.png 

  
  F6463716: Root capital K with pen screenshot.png 

  
  I think the root "K" is clearer, but looks a bit more cramped.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17413: stay in context Linkage2/Pragma2 until closing paren

[aG0aep6G aG0aep6G]

aG0aep6G added a comment.


  In D17413#372902 , @dhaumann wrote:
  
  > Could you use your real name please?
  
  
  no

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  stay-in-context-until-closing-paren

REVISION DETAIL
  https://phabricator.kde.org/D17413

To: aG0aep6G, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17128: DocumentPrivate: Remove comment mark when joining lines

[loh tar]

loh.tar added a comment.


  Thanks for your input Dominik. 
  In the meanwhile I noticed (again) these "Smart-Return" function (I noticed, 
and used that a couple of years for a short time period, but forgot that 
somehow) A reverse version of that should be nice. And somehow the possibility 
to use that automatically without to todo some special key-stroke when join 
lines by simple remove the newline character by Del-Key.
  
  But how that all could be done in sane way I have no idea. Currently I tend 
to make a new "Smart-Wrap-Paragraph" function, as suggested by Christoph. 
Because that's new, I can try to be as smart as I like without to change old 
behaviour.
  
  As said is from my point of view the existing wrap function broken, not only 
due to the behavior described in that bug report 135737 but also because the 
whole file is wrapped when no selection is done. That's not handy. This way you 
can't wrap quickly only a paragraph by shortcut without to select them 
previous. I have often scrambled a code file when I only want to warp some 
comment block.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D17425: dcb settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  added dcb settings according to :
  https://developer.gnome.org/NetworkManager/stable/settings-dcb.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17419: Add private-mode icon

[Björn Feber]

GB_2 updated this revision to Diff 47093.
GB_2 edited the summary of this revision.
GB_2 added a comment.


  Improve icons.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17419?vs=47081=47093

REVISION DETAIL
  https://phabricator.kde.org/D17419

AFFECTED FILES
  icons-dark/actions/16/private-mode.svg
  icons-dark/actions/22/private-mode.svg
  icons-dark/actions/24/private-mode.svg
  icons/actions/16/private-mode.svg
  icons/actions/22/private-mode.svg
  icons/actions/24/private-mode.svg

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17419: Add private-mode icon

[Björn Feber]

GB_2 added a comment.


  Is this better?
  F6463614: private-mode Breeze Icon (2).png 

  F6463613: private-mode.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17419

To: GB_2, #breeze, #vdg, #falkon, ngraham
Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

[loh tar]

loh.tar added a comment.


  In D17382#372925 , @dhaumann wrote:
  
  > sorry for the delay :(
  
  
  What? No, it was pretty fast :-)
  But I have a couple of Sonnet stuff where no progress happens :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17382

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D15763: Set correct image attributes on directory thumbnail

[Anthony Fieroni]

anthonyfieroni added a comment.


  To 18.12 ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15763

To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D9077: Bug 377342 Question

[loh tar]

loh.tar added subscribers: cullmann, loh.tar.
loh.tar added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  @cullmann I thing you could give a short hint
  
  But perhaps is @christofg no longer interested to work on this issue

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

To: christofg
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann, #frameworks