D17245: Add string formatting function to property info

[Alexander Stippich]

astippich marked 3 inline comments as done.
astippich added a comment.


  Thanks for the review!

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:50
> Why is midnight an invalid time?

Same with the previous discussing around the orientation values, I simply 
copied the code. My plan was to improve it later on, but that did not plan out 
as expected :)

> bruns wrote in propertyinfo.h:93
> I think you should hand in a KFormat here if you want to avoid constructing a 
> new one for each value.

I decided against that and used a local KFormat. Baloo-Widgets would need 
bigger changes otherwise as it handles everything on a per property basis, and 
currently already constructs a KFormat per property. It's also not used 
everywhere in the display functions. Others also seem to construct it locally, 
so I guess it's not expensive.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17245: Add string formatting function to property info

[Alexander Stippich]

astippich updated this revision to Diff 47816.
astippich added a comment.


  - remove static kformat
  - always show time
  - change default display function handling

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17245?vs=47660=47816

BRANCH
  display_value

REVISION DETAIL
  https://phabricator.kde.org/D17245

AFFECTED FILES
  CMakeLists.txt
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h
  src/CMakeLists.txt
  src/formatstrings.cpp
  src/formatstrings.h
  src/propertyinfo.cpp
  src/propertyinfo.h

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17178: Don't ask for confimation when reloading

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok with this, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D17178

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[Christoph Cullmann]

cullmann added a comment.


  I am at the moment a bit busy, if nobody else has time, I will try to take a 
closer look after x-mas.

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

[Dominik Haumann]

dhaumann added a comment.


  Hm, these shortcuts exist for 15+ years... The extended shortcuts are not 
used widely in kde at all. Do we really address issues here?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
bruns, demsking, cullmann, sars

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi updated this revision to Diff 47815.
trmdi edited reviewers, added: bruns; removed: davidedmundson.

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16643?vs=44860=47815

REVISION DETAIL
  https://phabricator.kde.org/D16643

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

To: trmdi, mart, broulik, #plasma, hein, bruns, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  Is it better if I change the line 91 to `event->setAccepted(m_enabled && 
!m_temporaryInhibition)` @bruns ?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  In T3689#170284 , @bcooksley wrote:
  
  > In regards to `akonadi-mime` I have now re-run it, and it seems to work 
fine.
  >  As long as you're relying only on the master manifest.yaml, then it should 
be impossible for any publishing failure to cause issues.
  
  
  Well if if would be just `akonadi-mime`, I would not care. but it is actually 
a lot more failing with the same pattern.
  
  What I did for checking:
  *download this  consoleText: 
https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.10/lastCompletedBuild/consoleText
  
  - than do some simple regex:
- (Successfully created a dump (`^.*Dump path: abi_dumps/.*/ABI\.dump\s*$`)
- search for  "Comparing ABIs"
  
  F6487824: ci-check.py 
  
  And the outcome is overwhelming - a lot of is broken. I checked a lot locally 
via docker and could not reproduce this bug. That's why I think it is something 
with publishing the packages. Is it just one server, or is there any load 
balancing come into account so request are answered by a different sever, that 
isn't synced?
  
  for kde/pim/*:
  
  [ ] kblog
  [ ] mailcommon
  [ ] kmbox
  [ ] kontactinterface
  [ ] kpimtextedit
  [ ] akonadi-import-wizard
  [ ] kpkpass
  [ ] kldap
  [ ] kalarmcal
  [ ] libgravatar
  [ ] libkgapi
  [ ] libkleo
  [ ] grantleetheme
  [ ] kcontacts
  [ ] akonadi-notes
  [ ] kitinerary
  [ ] ktnef
  [ ] akonadi-mime
  [ ] kcalutils
  
  for frameworks:
  
  [ ] kcrash
  [ ] kwallet
  [ ] kpackage
  [ ] kholidays
  [ ] kparts
  [ ] syndication
  [ ] frameworkintegration
  [ ] khtml
  [ ] krunner
  [ ] knotifyconfig
  [ ] kidletime
  [ ] kitemviews
  [ ] kjobwidgets
  [ ] kmediaplayer
  [ ] kpeople
  [ ] prison
  [ ] kxmlrpcclient
  [ ] sonnet
  [ ] kcoreaddons
  [ ] kunitconversion
  [ ] kfilemetadata
  [ ] baloo
  [ ] kitemmodels
  [ ] kpty
  [ ] kconfig
  [ ] kxmlgui
  [ ] kconfigwidgets
  [ ] kdbusaddons
  [ ] kjsembed
  [ ] kplotting
  [ ] kactivities
  [ ] kdesu
  [ ] ki18n
  [ ] knotifications
  [ ] kactivities-stats
  [ ] attica
  [ ] ktexteditor
  [ ] solid
  [ ] kirigami
  [ ] syntax-highlighting
  [ ] kauth
  
  > In terms of the `akonadi-search` issue, using something like that YAML file 
should be fine yes and is historically how we've solved such issues.
  
  okay create D17672  for this.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17672: Move settings for abi-complience-checker to 
own yaml file..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 23:35:30 +
 Build duration:
8 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)90%
(69/77)90%
(69/77)79%
(6804/8622)58%
(3525/6052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(1941/1954)52%
(851/1625)autotests.kconfig_compiler96%
(24/25)96%
(24/25)92%
(277/301)47%
(96/206)src.core88%
(22/25)88%
(22/25)69%
(2382/3428)57%
(1233/2177)src.gui71%
(5/7)71%
(5/7)61%
(432/708)51%
(156/305)src.kconf_update100%
(2/2)100%
(2/2)72%
(423/591)59%
(247/422)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1349/1564)80%
(942/1171)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/146)

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/61/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 18 Dec 2018 23:35:30 +
 Build duration:
8 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)90%
(69/77)90%
(69/77)79%
(6804/8622)58%
(3525/6052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(1941/1954)52%
(851/1625)autotests.kconfig_compiler96%
(24/25)96%
(24/25)92%
(277/301)47%
(96/206)src.core88%
(22/25)88%
(22/25)69%
(2382/3428)57%
(1233/2177)src.gui71%
(5/7)71%
(5/7)61%
(432/708)51%
(156/305)src.kconf_update100%
(2/2)100%
(2/2)72%
(423/591)59%
(247/422)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1349/1564)80%
(942/1171)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/146)

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever marked 2 inline comments as done.
vandenoever added a comment.


  I pushed two encore commits fixing the two raised issues.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> sitter wrote in kf5_entry.desktop:1
> Really good point. I've had a look and we only extract src/*. In fact, we 
> only have Messages.sh in src :)
> 
> This is in line with other frameworks where we have desktop file fixtures. 
> They all only extract src/ and use regular desktop files for test fixtures 
> (e.g. kservice, kpackage, kparts). So, this should be fine.

If you look carefully at Messages.sh, you'll see that they never mention 
.desktop files, that's because .desktop files are extracted automatically for 
translation, so yes, it will be a problem, because translations will be dropped 
(until translators translate them), making the test flaky

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.11 - Build # 3 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.11/3/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 22:36:10 +
 Build duration:
5 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.testholidayregion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(15/17)88%
(15/17)67%
(1484/2223)51%
(767/1498)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)95%
(324/342)54%
(79/146)src100%
(7/7)100%
(7/7)70%
(554/797)58%
(396/681)src.declarative0%
(0/2)0%
(0/2)0%
(0/28)0%
(0/8)src.parsers100%
(2/2)100%
(2/2)45%
(318/705)33%
(132/406)src.parsers.plan2100%
(1/1)100%
(1/1)82%
(288/351)62%
(160/257)

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.9 - Build # 59 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.9/59/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 18 Dec 2018 22:36:10 +
 Build duration:
5 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.testholidayregion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(15/17)88%
(15/17)67%
(1484/2223)51%
(767/1498)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)95%
(324/342)54%
(79/146)src100%
(7/7)100%
(7/7)70%
(554/797)58%
(396/681)src.declarative0%
(0/2)0%
(0/2)0%
(0/28)0%
(0/8)src.parsers100%
(2/2)100%
(2/2)45%
(318/705)33%
(132/406)src.parsers.plan2100%
(1/1)100%
(1/1)82%
(288/351)62%
(160/257)

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.11/23/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 18 Dec 2018 22:36:10 +
 Build duration:
4 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.testholidayregion

D17495: [KMessageBox] Fix minimum dialog size when details are requested

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:032c783b990e: [KMessageBox] Fix minimum dialog size when 
details are requested (authored by cfeck).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17495?vs=47318=47800

REVISION DETAIL
  https://phabricator.kde.org/D17495

AFFECTED FILES
  src/kmessagebox.cpp

To: cfeck, ngraham, elvisangelaccio, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

[David Faure]

dfaure added a comment.


  Thanks!

INLINE COMMENTS

> kconfigtest.cpp:1726
> +QVERIFY(file.open());
> +qWarning() << file.fileName();
> +KConfig config(file.fileName(), KConfig::SimpleConfig);

Remove (or at least degrade to qDebug, this is not a warning)

> kconfigtest.cpp:1739
> +QVERIFY(readFile.open(QFile::ReadOnly));
> +#ifndef Q_OS_WIN
> +QCOMPARE(readFile.readAll(), 
> QByteArrayLiteral("[General]\nUtf8=\\x00\\x01\\x02\\x03\\x04\\x05\\x06\\x07\\x08\\t\\n\\x0b\\x0c\\r\\x0e\\x0f\\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f
>  
> !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[]^_`abcdefghijklmnopqrstuvwxyz{|}~\\x7f\\x80\\x81\\x82\\x83\\x84\\x85\\x86\\x87\\x88\\x89\\x8a\\x8b\\x8c\\x8d\\x8e\\x8f\\x90\\x91\\x92\\x93\\x94\\x95\\x96\\x97\\x98\\x99\\x9a\\x9b\\x9c\\x9d\\x9e\\x9f\\xa0\\xa1\\xa2\\xa3\\xa4\\xa5\\xa6\\xa7\\xa8\\xa9\\xaa\\xab\\xac\\xad\\xae\\xaf\\xb0\\xb1\\xb2\\xb3\\xb4\\xb5\\xb6\\xb7\\xb8\\xb9\\xba\\xbb\\xbc\\xbd\\xbe\\xbf\\xc0\\xc1\\xc2\\xc3\\xc4\\xc5\\xc6\\xc7\\xc8\\xc9\\xca\\xcb\\xcc\\xcd\\xce\\xcf\\xd0\\xd1\\xd2\\xd3\\xd4\\xd5\\xd6\\xd7\\xd8\\xd9\\xda\\xdb\\xdc\\xdd\\xde\\xdf\\xe0\\xe1\\xe2\\xe3\\xe4\\xe5\\xe6\\xe7\\xe8\\xe9\\xea\\xeb\\xec\\xed\\xee\\xef\\xf0\\xf1\\xf2\\xf3\\xf4\\xf5\\xf6\\xf7\\xf8\\xf9\\xfa\\xfb\\xfc\\xfd\\xfe\\xff\n"));

The expected value without trailing newline could have been put into a 
constant, shared between Windows and non-Windows code paths, to avoid all this 
duplication ;-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 175 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/175/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 18 Dec 2018 20:43:14 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5647/9422)43%
(2207/5184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)98%
(865/886)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/146)72%
(33/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(846/1669)41%
(431/1042)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/270)0%
(0/221)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/940)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/71)0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.11 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.11/6/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 20:43:14 +
 Build duration:
4 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5647/9422)43%
(2207/5184)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)98%
(865/886)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/146)72%
(33/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(846/1669)41%
(431/1042)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/270)0%
(0/221)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/940)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/71)0%

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 92 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/92/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Tue, 18 Dec 2018 20:43:14 +
 Build duration:
2 min 31 sec and counting

D15960: Don't check if file is directory based on mime-type

[Igor Poboiko]

poboiko added a comment.


  In D15960#379043 , @aacid wrote:
  
  > @poboiko You broke the build, please fix it.
  
  
  Sorry! Apparently, I've messed up while did `git rebase` on current master.
  Should be fixed by c7416a41 
.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15960

To: poboiko, #baloo, #frameworks, bruns, astippich
Cc: aacid, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:6a185285ae44: Escape bytes that are larger than or equal 
to 127 in config files (authored by vandenoever).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17651?vs=47790=47796

REVISION DETAIL
  https://phabricator.kde.org/D17651

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/10/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 20:10:29 +
 Build duration:
7 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32953/48232)51%
(15851/30984)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1870/3165)47%
(1565/3313)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
(6/6)74%
(1109/1498)64%
 

D17631: class Message: Use inclass member initialization

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ca0f9e3cc011: class Message: Use inclass member 
initialization (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17631?vs=47686=47795

REVISION DETAIL
  https://phabricator.kde.org/D17631

AFFECTED FILES
  src/utils/messageinterface.cpp

To: dhaumann, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 60 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/60/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 18 Dec 2018 19:57:19 +
 Build duration:
8 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)90%
(69/77)90%
(69/77)79%
(6806/8624)58%
(3525/6052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(1943/1956)52%
(851/1625)autotests.kconfig_compiler96%
(24/25)96%
(24/25)92%
(277/301)47%
(96/206)src.core88%
(22/25)88%
(22/25)69%
(2382/3428)57%
(1233/2177)src.gui71%
(5/7)71%
(5/7)61%
(432/708)51%
(156/305)src.kconf_update100%
(2/2)100%
(2/2)72%
(423/591)59%
(247/422)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1349/1564)80%
(942/1171)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/146)

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 4 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 19:57:19 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)90%
(69/77)90%
(69/77)79%
(6806/8624)58%
(3525/6052)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)99%
(1943/1956)52%
(851/1625)autotests.kconfig_compiler96%
(24/25)96%
(24/25)92%
(277/301)47%
(96/206)src.core88%
(22/25)88%
(22/25)69%
(2382/3428)57%
(1233/2177)src.gui71%
(5/7)71%
(5/7)61%
(432/708)51%
(156/305)src.kconf_update100%
(2/2)100%
(2/2)72%
(423/591)59%
(247/422)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1349/1564)80%
(942/1171)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/146)

D17651: Escape bytes that are larger than or equal to 127 in config files

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R237 KConfig

BRANCH
  utf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever updated this revision to Diff 47790.
vandenoever added a comment.


  Add a check for reading in the unit test.

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17651?vs=47788=47790

BRANCH
  utf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17651

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[loh tar]

loh.tar added a comment.


  - No sure if there must be something at other places considered
  - This is my second version where the wrap is done ether at the static 
setting or the view width, whatever is smaller. At first is was always wrapped 
at the static setting. Then I thought it may this way better. But I'm still 
undecided, the other behaviour has also charm. Somehow fit now the naming no 
more perfect.
  - At first I thought there is now an issue with the static wrap marker (the 
line has gaps) and the highlighting when the first word is selected (span the 
unused space at the right) but that seams to be "normal"
  - Only poor tested!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D15960: Don't check if file is directory based on mime-type

[Albert Astals Cid]

aacid added a comment.


  @poboiko You broke the build, please fix it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15960

To: poboiko, #baloo, #frameworks, bruns, astippich
Cc: aacid, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, VDG.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Without this patch is in "Dynamic Wrap Mode" the text always wrapped 
  at the outer end of the view, which may hinder the reading flow with 
  a wide screen.

TEST PLAN
  Normal behaviour
  F6487064: 1545150257.png 
  
  With patch and activated option
  F6487068: 1545150190.png 
  
  Config page, no old one (sorry, but looks almost the same just without the 
new option) 
  F6487072: 1545151316.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever retitled this revision from "Escape bytes that are larger than 127 
in config files" to "Escape bytes that are larger than or equal to 127 in 
config files".
vandenoever edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than 127 in config files

[Jos van den Oever]

vandenoever updated this revision to Diff 47788.
vandenoever edited the summary of this revision.
vandenoever added a comment.


  Added a unit test and changed the code so that 0x7f (DEL) is also 
  escaped.

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17651?vs=47759=47788

BRANCH
  utf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17651

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

[Ahmad Samir]

ahmadsamir added a reviewer: sandsmark.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17629

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Nathaniel Graham]

ngraham added a comment.


  In D17623#378783 , @ndavis wrote:
  
  > 2. It's supposed to be a newspaper. I tried to make it look similar to 
`message-news`: F6486579: Screenshot_20181218_073508.png 

  >   - An alternative newspaper style might be something similar to 
`news-subscribe`: F6486581: Screenshot_20181218_073629.png 

  
  
  Yeah, that might be better. `message-news` itself doesn't really look that 
much like a newspaper lol! Something more like this might be clearer, for both 
icons: https://www.flaticon.com/free-icon/text-lines_254005
  
  > 3. Here's how that looks: F6486584: Screenshot_20181218_073915.png 
F6486586: Screenshot_20181218_074012.png 

  
  That looks better to my eyes! Very nice icon. I think that will look 
fantastic in Dolphin's Settings window for the Services tab as part of the 
"colorize all the icons" initiative (T10165 
).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17528: Refactor SlaveInterface::calcSpeed

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  endless refactoring, for the better :-)

INLINE COMMENTS

> slaveinterface.cpp:119
> +d->transfer_details.clear();
> +d->transfer_details.append({elapsed_time, (d->filesize - 
> d->offset)});
>  }

.append(last) would do the same in a more compact way.

... and then this means we could reduce code size even further by calculating 
lspeed *before* doing the append.

  first = ...
  last = ...
  lspeed = ...
  if (!lspeed) {
  d->transfer_details.clear();
  }
  d->transfer_details.append(last);

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

[Michael Pyne]

This revision was automatically updated to reflect the committed changes.
Closed by commit R268:c96d012b6d47: Fix KGlobalAccel build with Qt 5.13 
prerelease. (authored by mpyne).

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17647?vs=47743=47775

REVISION DETAIL
  https://phabricator.kde.org/D17647

AFFECTED FILES
  src/runtime/component.cpp

To: mpyne, #frameworks, graesslin, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than 127 in config files

[David Faure]

dfaure added a comment.


  +1 from me, although a unittest would be good. Especially in order to check 
that this then gets decoded properly when reading back from the kconfig file...

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than 127 in config files

[Jos van den Oever]

vandenoever retitled this revision from "Escape bytes that larger than 127" to 
"Escape bytes that are larger than 127 in config files".

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 14:34:36 +
 Build duration:
6 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/75/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 18 Dec 2018 14:34:36 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

D16966: Fix typo in i18n message (cmdline option description)

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:49a674d3bdb0: Fix typo in i18n message (cmdline option 
description) (authored by aspotashev).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16966?vs=47770=47771

REVISION DETAIL
  https://phabricator.kde.org/D16966

AFFECTED FILES
  src/kpackagetool/options.h

To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16966: Fix typo in i18n message (cmdline option description)

[Alexander Potashev]

aspotashev updated this revision to Diff 47770.
aspotashev added a comment.


  fix another typo

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16966?vs=45698=47770

BRANCH
  arcpatch-D16966

REVISION DETAIL
  https://phabricator.kde.org/D16966

AFFECTED FILES
  src/kpackagetool/options.h

To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Nathaniel Graham]

ngraham added a comment.


  In D17650#378760 , @lbeltrame 
wrote:
  
  > > umbrello from binary factory is far from been production ready. Windows 
releases are made from the KDE4 branch. See for example 
https://phabricator.kde.org/T7659
  >
  > I would argue this is more of umbrello's problem to keep on supporting 
kdelibs 4.x and KF5 at the same time than anything else.
  
  
  Agreed. Why not put in the effort to port it fully to KF5 instead?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 174 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/174/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 18 Dec 2018 14:06:35 +
 Build duration:
4 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 645 lines...]Scanning dependencies of target orpostingiteratortest[ 40%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/orpostingiteratortest.cpp.o[ 40%] Building CXX object autotests/unit/engine/CMakeFiles/postingdbtest.dir/singledbtest.cpp.o[ 40%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/singledbtest.cpp.o[ 41%] Building CXX object autotests/unit/engine/CMakeFiles/postingdbtest.dir/postingdbtest_autogen/mocs_compilation.cpp.o[ 41%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/orpostingiteratortest_autogen/mocs_compilation.cpp.o[ 41%] Linking CXX executable ../../../bin/postingdbtest[ 41%] Built target postingdbtestScanning dependencies of target transactiontest[ 41%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest.cpp.o[ 42%] Linking CXX executable ../../../bin/orpostingiteratortest[ 42%] Built target orpostingiteratortest[ 42%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/singledbtest.cpp.o[ 43%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Baloo[ 43%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/term.cpp.o[ 43%] Linking CXX executable ../../../bin/transactiontest[ 43%] Built target transactiontest[ 43%] Generating baloowatcherapplication_interface.cpp, baloowatcherapplication_interface.h[ 44%] Generating baloowatcherapplication_interface.mocScanning dependencies of target baloofilecommon[ 44%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/mainhub.cpp.o[ 44%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/query.cpp.o[ 45%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/mainadaptor.cpp.o[ 46%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/queryrunnable.cpp.o[ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileindexerconfig.cpp.o[ 46%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/resultiterator.cpp.o[ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/basicindexingjob.cpp.o[ 46%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/advancedqueryparser.cpp.o[ 46%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/powerstatemonitor.cpp.o[ 46%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/file.cpp.o[ 47%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileindexscheduler.cpp.o[ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/filemonitor.cpp.o[ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/taglistjob.cpp.o[ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/firstrunindexer.cpp.o[ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/indexerconfig.cpp.o[ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/newfileindexer.cpp.o[ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/xattrindexer.cpp.o[ 49%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileindexerconfig.cpp.o[ 50%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[ 50%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/modifiedfileindexer.cpp: In member function ���virtual void Baloo::ModifiedFileIndexer::run()���:/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/modifiedfileindexer.cpp:82:28: error: ���filePath��� was not declared in this scope QFileInfo fileInfo(filePath);^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/modifiedfileindexer.cpp:82:28: note: suggested alternative: ���fileno��� QFileInfo fileInfo(filePath);^~~~fileno/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/modifiedfileindexer.cpp:83:29: error: ���timeInfo��� was not declared in this scope bool mTimeChanged = timeInfo.mTime != fileInfo.lastModified().toTime_t(); ^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/modifiedfileindexer.cpp:83:29: note: suggested alternative: ���fileInfo��� bool mTimeChanged = timeInfo.mTime != fileInfo.lastModified().toTime_t(); ^~~~ fileInfo/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/modifiedfileindexer.cpp:91:13: error: continue statement not within a loop continue; ^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 91 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/91/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Tue, 18 Dec 2018 14:06:36 +
 Build duration:
3 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 518 lines...][ 27%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/query.cpp.o[ 27%] Linking CXX executable ../../bin/documenturldb[ 27%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/app.cpp.o[ 27%] Built target documenturldb[ 27%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/mainadaptor.cpp.o[ 27%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/result.cpp.o[ 28%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/queryrunnable.cpp.o[ 28%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileindexerconfig.cpp.o[ 28%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/basicindexingjob.cpp.o[ 29%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/idlestatemonitor.cpp.o[ 29%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/resultiterator.cpp.o[ 29%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/advancedqueryparser.cpp.o[ 29%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/priority.cpp.o[ 30%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/powerstatemonitor.cpp.o[ 30%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileindexscheduler.cpp.o[ 30%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/basicindexingjob.cpp.o[ 31%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/file.cpp.o[ 31%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/filemonitor.cpp.o[ 31%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/firstrunindexer.cpp.o[ 31%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/newfileindexer.cpp.o[ 31%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o[ 31%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/taglistjob.cpp.o[ 32%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o[ 33%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/xattrindexer.cpp.o[ 33%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/indexerconfig.cpp.o[ 34%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileindexerconfig.cpp.o[ 34%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o[ 34%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[ 34%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[ 34%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:82:28: error: unknown type name 'filePath'; did you mean 'IdFilenameDB::FilePath'?QFileInfo fileInfo(filePath);   ^~~~   IdFilenameDB::FilePath/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/engine/idfilenamedb.h:40:12: note: 'IdFilenameDB::FilePath' declared herestruct FilePath {   ^/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:83:55: error: member reference base type 'QFileInfo (Baloo::IdFilenameDB::FilePath)' is not a structure or unionbool mTimeChanged = timeInfo.mTime != fileInfo.lastModified().toTime_t();  ^/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:83:29: error: use of undeclared identifier 'timeInfo'bool mTimeChanged = timeInfo.mTime != fileInfo.lastModified().toTime_t();^/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:85:55: error: member reference base type 'QFileInfo (Baloo::IdFilenameDB::FilePath)' is not a structure or unionbool cTimeChanged = timeInfo.cTime != fileInfo.metadataChangeTime().toTime_t();  ^~~/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:85:29: error: use of undeclared identifier 'timeInfo'bool cTimeChanged = timeInfo.cTime != fileInfo.metadataChangeTime().toTime_t();^/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:91:13: error: 'continue' statement not in loop statementcontinue;^/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/modifiedfileindexer.cpp:97:30: error: use of undeclared identifier 'filePath' 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 18 Dec 2018 14:06:36 +
 Build duration:
1 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 640 lines...]Scanning dependencies of target documentdbtest[ 42%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest.cpp.o[ 43%] Building CXX object autotests/unit/engine/CMakeFiles/phraseanditeratortest.dir/singledbtest.cpp.oScanning dependencies of target queryparsertest[ 43%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest.cpp.o[ 43%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest_autogen/mocs_compilation.cpp.o[ 43%] Building CXX object autotests/unit/engine/CMakeFiles/phraseanditeratortest.dir/phraseanditeratortest_autogen/mocs_compilation.cpp.o[ 44%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/singledbtest.cpp.o[ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest_autogen/mocs_compilation.cpp.o[ 45%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o[ 45%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.oScanning dependencies of target documenturldbtest[ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/documenturldbtest.cpp.o[ 46%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp: In member function ���virtual void Baloo::ModifiedFileIndexer::run()���:/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:82:28: error: ���filePath��� was not declared in this scope QFileInfo fileInfo(filePath);^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:82:28: note: suggested alternative: ���fileno��� QFileInfo fileInfo(filePath);^~~~fileno/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:83:29: error: ���timeInfo��� was not declared in this scope bool mTimeChanged = timeInfo.mTime != fileInfo.lastModified().toTime_t(); ^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:83:29: note: suggested alternative: ���fileInfo��� bool mTimeChanged = timeInfo.mTime != fileInfo.lastModified().toTime_t(); ^~~~ fileInfo/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:91:13: error: continue statement not within a loop continue; ^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:97:40: error: ���mimetype��� was not declared in this scope BasicIndexingJob job(filePath, mimetype, level);^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:97:40: note: suggested alternative: ���QMimeType��� BasicIndexingJob job(filePath, mimetype, level);^~~~QMimeType/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:99:13: error: continue statement not within a loop continue; ^~~~/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp: At global scope:/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:112:5: error: ���tr��� does not name a type; did you mean ���tm���? tr.commit(); ^~ tm/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:113:18: error: expected constructor, destructor, or type conversion before ���;��� token Q_EMIT done();  ^/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.11/src/file/modifiedfileindexer.cpp:114:1: error: expected declaration before ���}��� token } ^[ 46%] Linking CXX executable ../../../bin/documentiddbtestmake[2]: *** [src/file/CMakeFiles/baloofilecommon.dir/build.make:191: src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:1340: src/file/CMakeFiles/baloofilecommon.dir/all] Error 2make[1]: *** Waiting for unfinished jobsScanning dependencies of target positiondbtest[ 46%] Building CXX object 

D15960: Don't check if file is directory based on mime-type

[Igor Poboiko]

poboiko added a comment.


  In D15960#375517 , @bruns wrote:
  
  > Sorry, fell through the cracks - give a ping next time something is blocked 
for no apparent reason ...
  
  
  Nevermind, I also didn't have much spare time for KDE lately :(

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15960

To: poboiko, #baloo, #frameworks, bruns, astippich
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D15960: Don't check if file is directory based on mime-type

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15960

To: poboiko, #baloo, #frameworks, bruns, astippich
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D17651: Escape bytes that larger than 127

[Jos van den Oever]

vandenoever added reviewers: dfaure, arichardson.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

[Kai Uwe Broulik]

broulik added a comment.


  I'm not blaming anyone, I'm merely stating that there is a potential issue 
with this patch that might not have been addressed and needs @bruns further 
input.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  In D16643#378823 , @broulik wrote:
  
  > Only if that potential issue with inhibition has been addressed
  
  
  You mean @bruns is right and I'm wrong?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Kai Uwe Broulik]

broulik added a comment.


  Only if that potential issue with inhibition has been addressed

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  !ping @hein
  
  Could you land this patch?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17651: Escape bytes that larger than 127

[Jos van den Oever]

vandenoever edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that larger than 127

[Jos van den Oever]

vandenoever edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that larger than 127

[Jos van den Oever]

vandenoever created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.

REVISION SUMMARY
  UserBase tells me that KDE configuration files are encoded in UTF-8.
  https://userbase.kde.org/KDE_System_Administration/Configuration_Files
  
  In practice some *rc files have bytes outside that encoding.
  The problem is that there is no check for bytes larger than 127.

REPOSITORY
  R237 KConfig

BRANCH
  utf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17651

AFFECTED FILES
  src/core/kconfigini.cpp

To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#378670 , @ngraham wrote:
  
  > Also, here are my only aesthetic suggestions:
  >
  > - Messages icon:  how about making this look more like the 
utilities-log-viewer icon? Maybe a 32px version of that?
  > - Release notes icon: I'm not sure this icon really works. I can't tell 
what it is. A fax machine?
  > - Services icon: I don't think the top of the bell should cast a shadow 
here; in general the shadow only seems to overlap the icon itself, not the 
background. When it does that here, it looks kind of weird.
  
  
  
  
  1. Good point, although the actual message viewer doesn't look a lot like 
KSystemLog: F6486567: Screenshot_20181218_072948.png 

- the journal module is just a module for showing the systemd journal, so 
it looks more like KSystemLog: F6486575: Screenshot_20181218_073228.png 

  2. It's supposed to be a newspaper. I tried to make it look similar to 
`message-news`: F6486579: Screenshot_20181218_073508.png 

- An alternative newspaper style might be something similar to 
`news-subscribe`: F6486581: Screenshot_20181218_073629.png 

  3. Here's how that looks: F6486584: Screenshot_20181218_073915.png 
F6486586: Screenshot_20181218_074012.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  The conflict is still presence on opensuse and relates to the packages
  
  mingw32-cross-kde4-tools
  mingw32-cross-kf5-tools

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Hannah von Reth]

vonreth added a comment.


  In D17650#378765 , @habacker wrote:
  
  > On a recent opensuse Leap 42.3 or 15.x system there is
  >
  > > /usr/lib64/kde4/libexec/kioslave
  > >  /usr/lib64/libexec/kf5/kioslave
  >
  > because the distribution provides kdelibs4 and kio packages. it only does 
not conflict because the executables are located in different directories 
because they are installed in 'libexecdir'. On Windows libexecdir points to the 
regular bin dir, which results into a conflict. The conflict need to be fixed 
by choosing a different name, as it is done also with many helper tools like 
meinproc4, meinproc5
  >
  > > $ ls /usr/bin/*5 | wc -l
  > > 73
  > >  $ls /usr/bin/*4 | wc -l
  > > 46
  
  
  I don't think I get your point.
  So you want to install KDE4 and KF5 into the same directory on Windows?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Luca Beltrame]

lbeltrame added a comment.


  In D17650#378765 , @habacker wrote:
  
  > On a recent opensuse Leap 42.3 or 15.x system there is
  >
  > > /usr/lib64/kde4/libexec/kioslave
  > >  /usr/lib64/libexec/kf5/kioslave
  
  
  As a packager of KDE software for said distribution, this is just something 
vestigial due to the kdelibs4.x -> KF5 code, back then when KF5 ported software 
was the minority. At this point in time, such a change does not make sense. If 
you want to push this forward I suggest you find another example aside umbrello 
to use.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  As a rule of thumb, I'd say it's just fine to remove moc includes if there's 
no Q_OBJECT or Q_GADGET on the cpp file.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D17647

To: mpyne, #frameworks, graesslin, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  On opensuse there are the cross compile helper packages
  
  mingw32-cross-kde4-tools 
  mingw32-cross-kf5-tools
  
  both containing docbookl10nhelper and nothing prevents them from been 
installed in parallel

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  On a recent opensuse Leap 42.3 or 15.x system there is
  
  > /usr/lib64/kde4/libexec/kioslave
  >  /usr/lib64/libexec/kf5/kioslave
  
  because the distribution provides kdelibs4 and kio packages. it only does not 
conflict because the executables are located in different directories because 
they are installed in 'libexecdir'. On Windows libexecdir points to the regular 
bin dir, which results into a conflict. The conflict need to be fixed by 
choosing a different name, as it is done also with many helper tools like 
meinproc4, meinproc5
  
  > $ ls /usr/bin/*5 | wc -l
  > 73
  >  $ls /usr/bin/*4 | wc -l
  > 46

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Hannah von Reth]

vonreth added a comment.


  I see no reason for this. Having a KF5 and kde 4 in the path sounds like a 
bad idea in general.
  Is this for cygwin or something like that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Luca Beltrame]

lbeltrame added a reviewer: vonreth.
lbeltrame added a comment.


  That said, let's hear the opinion of someone else as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Luca Beltrame]

lbeltrame added a comment.


  > umbrello from binary factory is far from been production ready. Windows 
releases are made from the KDE4 branch. See for example 
https://phabricator.kde.org/T7659
  
  I would argue this is more of umbrello's problem to keep on supporting 
kdelibs 4.x and KF5 at the same time than anything else.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> aacid wrote in kf5_entry.desktop:1
> This is going to be a problem, scripty is going to come and whipe these 
> .desktop files out and then make the translators translate them again.
> 
> Wonder if we could rename them to .desktop.untransltable or something like 
> that and then use the cmake file copy command to copy them to the build 
> folder and trick the test to find the files there?
> 
> Am i making any sense?

Really good point. I've had a look and we only extract src/*. In fact, we only 
have Messages.sh in src :)

This is in line with other frameworks where we have desktop file fixtures. They 
all only extract src/ and use regular desktop files for test fixtures (e.g. 
kservice, kpackage, kparts). So, this should be fine.

> aacid wrote in klanguagenametest.cpp:32
> initTestCase is too late and was failing for me
> 
> https://paste.kde.org/p8s9js4r3
> 
> makes it work

LGTM, I've added the change to the diff. Thanks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Harald Sitter]

sitter updated this revision to Diff 47758.
sitter added a comment.


  move env setup to qcorestartup to prevent the env from not getting set up in 
time and the tests failing as a result

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10446?vs=47623=47758

BRANCH
  arcpatch-D10446

REVISION DETAIL
  https://phabricator.kde.org/D10446

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kf5_entry_data/locale/ca/kf5_entry.desktop
  autotests/kf5_entry_data/locale/de/kf5_entry.desktop
  autotests/kf5_entry_data/locale/en_US/kf5_entry.desktop
  autotests/kf5_entry_data/locale/fr/kf5_entry.desktop
  autotests/kf5_entry_data/locale/pt/kf5_entry.desktop
  autotests/klanguagenametest.cpp
  src/CMakeLists.txt
  src/klanguagename.cpp
  src/klanguagename.h

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  In D17650#378747 , @lbeltrame 
wrote:
  
  > At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is 
*long* unmaintained, as well as Qt. What are real, **compelling** reasons to do 
this?
  >
  > EDIT: I know it's for Windows, but with the recent work with the 
binary-factory and what not, there are even less reasons to do so there.
  
  
  umbrello from binary factory is far from been production ready. Windows 
releases are made from the KDE4 branch. See for example 
https://phabricator.kde.org/T7659

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

[Ralf Habacker]

habacker added a comment.


  In D17649#378737 , @ltoscano wrote:
  
  > The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is 
exported), and in general it should not exist in the same build root of its 
kdelibs 4.x counterpart.
  
  
  This tools is required for cross compiling kdoctools 
https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win64:KF547/mingw64-kdoctools
 and therefore installed. obs has KDE4 and KF5 packages side by side

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

D17650: Install kioslave as kioslave5 on Windows

[Luca Beltrame]

lbeltrame added a reviewer: Frameworks.
lbeltrame requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Luca Beltrame]

lbeltrame added a comment.


  At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* 
unmaintained, as well as Qt. What are real, **compelling** reasons to do this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  FIXED-IN:5.54.0
  BUG:377687

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17650

AFFECTED FILES
  src/kioslave/CMakeLists.txt

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

[Luigi Toscano]

ltoscano added a comment.


  The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is 
exported), and in general it should not exist in the same build root of its 
kdelibs 4.x counterpart.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

[Ralf Habacker]

habacker created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  FIXED-IN:5.54
  BUG:373928

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17649

AFFECTED FILES
  src/CMakeLists.txt

To: habacker
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna