D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. In D17649#380233 , @habacker wrote: > On opensuse there are the cross compile helper packages > > mingw32-cross-kde4-tools >

D17623: Add YaST icons

ndavis added a comment. In D17623#380549 , @fvogt wrote: > In D17623#380511 , @ndavis wrote: > > > @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it

D17623: Add YaST icons

fvogt added a comment. In D17623#380511 , @ndavis wrote: > @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

cgiboudeaux created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY This also fixes the version in the .pc file. BUG 390225 FIXED-IN: 5.55 REPOSITORY R6 KActivities

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. > Why not joining the effort of the people that are working to get those applications on Windows, You did not get the point. If there is anything left over besides the time I have to maintain the KDE applications and libraries, I go through this list

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. In D17650#380277 , @habacker wrote: > and try to fix the related issue or check if some else has fixed it. See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The different Qt installation layout

D17650: Install kioslave.exe as kioslave5.exe under Windows

vonreth added a comment. In D17650#380329 , @habacker wrote: > In D17650#380309 , @habacker wrote: > > > See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The different Qt

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. In D17650#380243 , @habacker wrote: > > $ rpm -q -f /usr/i686-w64-mingw32/sys-root/mingw/bin/kioslave.exe > mingw32-kdelibs4-4.14.60-30.27.noarch > $ rpm -q -f

D17650: Install kioslave as kioslave5 on Windows

bcooksley added a comment. It is much more than 7 - at least on the Binary Factory. See https://binary-factory.kde.org/view/Windows%2032-bit/ and https://binary-factory.kde.org/view/Windows%2064-bit/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker,

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. Yes there are more 'nightly' releases, which is a good thing :-), but there are only about 6 'release' versions https://binary-factory.kde.org/view/Windows%2064-bit/ : 5 https://binary-factory.kde.org/view/Windows%2032-bit/ : 6 and KMyMoney

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

cgiboudeaux added a comment. Reverted and the version was fixed. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D17718 To: cgiboudeaux, cfeck, #build_system Cc: pino, alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave.exe as kioslave5.exe under Windows

habacker updated this revision to Diff 47944. habacker retitled this revision from "Install kioslave as kioslave5 on Windows" to "Install kioslave.exe as kioslave5.exe under Windows". habacker edited the summary of this revision. habacker removed subscribers: bcooksley, heikobecker, ngraham,

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. > I'd argue that the problem is with your distribution. It is designed in ECM to install mentioned helpers on windows (which are cross compiled packages on obs) in main executable install dir. $ rpm -q -f

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

cgiboudeaux added reviewers: cfeck, Build System. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D17718 To: cgiboudeaux, cfeck, #build_system Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. I tested this, it indeed fixes 390225 Withoug this patch, generated pkgconfig file was: prefix=/usr exec_prefix=bin libdir=lib/x86_64-linux-gnu includedir=include

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

This revision was automatically updated to reflect the committed changes. Closed by commit R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the pkgconfig file. (authored by cgiboudeaux). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE

D17650: Install kioslave as kioslave5 on Windows

heikobecker added a comment. > no, it is only used in kio internally by klauncher to start io slaves. at least kinit disagrees: src/klauncher/klauncher.cpp:1021 arg_list.prepend(QLatin1String("kioslave")); REPOSITORY R241 KIO REVISION DETAIL

D17650: Install kioslave.exe as kioslave5.exe under Windows

lbeltrame added a comment. I would still suggest you get your stuff done with the binary factory and not on the OBS simply because then KDE as a whole can benefit from it. Not doing so will make sure that Windows and other platform-specific issues will never be found. REPOSITORY R241 KIO

D17650: Install kioslave as kioslave5 on Windows

vonreth added a comment. In kde4 we had 104 unmaintained untested applications. The 6 now are much better supported, in general we only add applications to binary factory if a project asks for it and maintain it for some degree. REPOSITORY R241 KIO REVISION DETAIL

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

pino added a comment. In D17718#380261 , @alexeymin wrote: > I tested this, it indeed fixes 390225 > Withoug this patch, generated pkgconfig file was: > > prefix=/usr > exec_prefix=bin > libdir=lib/x86_64-linux-gnu >

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. In D17650#380272 , @vonreth wrote: > In kde4 we had 104 unmaintained untested applications. > The 6 now are much better supported, in general we only add applications to binary factory if a project asks for it and

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

cgiboudeaux removed a reviewer: alexeymin. cgiboudeaux added a comment. In D17718#380267 , @pino wrote: > In D17718#380261 , @alexeymin wrote: > > > I tested this, it indeed fixes 390225 > >

D17719: Fix executable name for kioslave on Windows

habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.54.0 BUG:377687 also see https://phabricator.kde.org/D17650 REPOSITORY R303 KInit BRANCH master

D17650: Install kioslave.exe as kioslave5.exe under Windows

habacker added a comment. In D17650#380309 , @habacker wrote: > See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The different Qt installation layout depending on the platform is a nightmare for cross-platform support and ties

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr updated this revision to Diff 47950. chinmoyr added a comment. update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17528?vs=47726=47950 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17528 AFFECTED FILES

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 21 Dec 2018 13:08:18 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 21 Dec 2018 13:19:03 + Build duration: 4 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/96/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 21 Dec 2018 13:22:22 + Build duration: 4 min 39 sec and counting BUILD ARTIFACTS

D17173: Add error value for job owner dying

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ec31566e4cc7: Add error value for job owner dying (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17173?vs=47464=47958#toc REPOSITORY R241 KIO CHANGES SINCE

D17528: Refactor SlaveInterface::calcSpeed

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17528 To: chinmoyr, dfaure Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17498: Xdg Decoration Support

This revision was automatically updated to reflect the committed changes. Closed by commit R127:46390781daad: Xdg Decoration Support (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17498?vs=47468=47955#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/95/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 21 Dec 2018 13:08:18 + Build duration: 14 min and counting BUILD ARTIFACTS

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux updated this revision to Diff 47962. cgiboudeaux added a comment. Try to find qmake if qmake-qt5 is not found REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17015?vs=46780=47962 BRANCH arcpatch-D17015 REVISION DETAIL

D17726: Add helper function to disable redirections (useful for kde-open)

yurchor added inline comments. INLINE COMMENTS > krun.h:158 > +/** > + * Sets wether KRun should follow URLs redirections. > + * This is enabled by default Typo: wether -> whether > krun.h:160 > + * This is enabled by default > + * @param b wether to follow redirections or

D17726: Add helper function to disable redirections (useful for kde-open)

ngraham edited the summary of this revision. ngraham added reviewers: dfaure, Frameworks, cfeck. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17726 To: achauvel, dfaure, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17726: Add helper function to disable redirections (useful for kde-open)

achauvel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. achauvel requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D15189 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17726

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 47987. achauvel added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Uses new function added in https://phabricator.kde.org/D17726 REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D17727: Get default web browser from xdg-settings if it’s not set in KDE

achauvel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. achauvel requested review of this revision. REVISION SUMMARY This greatly speed up opening URLs from kde-open (avoid ~1 second of wait) REPOSITORY R241 KIO REVISION DETAIL

D17623: Add YaST icons

ndavis added a comment. @fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me figure out why that is, I would appreciate it. REPOSITORY R266 Breeze Icons REVISION

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katesearchbar.cpp:860-865 > Maybe not an issue, but you can try to cache value preventing unwanted lookup > > auto dd = d(this); > dd->... Only here or everywhere? At this particular place may that optimized by the

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47966. loh.tar added a comment. Improve the readability and prevent unwanted lookup by caching d(this) as dd REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47963=47966 REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. I have tried to run two S jobs at the same time on the same document, seems to works nicely - view 1 -> S "tab" -> "-" - view 2 -> S "0" -> "+" I had canceled both jobs and then resume, that's why at the pic are already replacents to see while the job is

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47963. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix crash when the document will closed while a S job is running - Fix crash when the view will closed while a S job is running These fixes seems to

D17459: SearchBar: Add Cancel button to stop long running tasks

anthonyfieroni added inline comments. INLINE COMMENTS > katesearchbar.cpp:860-865 > +d(this)->m_inputRange = inputRange; > +d(this)->m_workingRange = > m_view->doc()->newMovingRange(d(this)->m_inputRange); > +d(this)->m_replacement = replacement; > +d(this)->m_replaceMode =

D16694: Improve visibility for Konsole icon when using Breeze Dark

ngraham added a comment. This doesn't seem to actually work; after applying the patch; the new icon is not actually used with dark themes nor visible in Cuttlefish. Also the `dupe` test is now failing: The following tests FAILED: 4 - dupe (Failed) Errors while