D17956: DocumentPrivate: Fix broken doc links in qCWarning

[Kåre Särs]

sars added a comment.


  Adding as a warning message in the view could be another review and needs 
comments from others first

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17956

To: loh.tar, #ktexteditor, sars
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17956: DocumentPrivate: Fix broken doc links in qCWarning

[Kåre Särs]

sars accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17956

To: loh.tar, #ktexteditor, sars
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 04 Jan 2019 06:56:34 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/108/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 04 Jan 2019 06:56:33 +
 Build duration:
1 min 34 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/21/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 04 Jan 2019 06:56:34 +
 Build duration:
1 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/107/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 04 Jan 2019 06:09:13 +
 Build duration:
1 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/20/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 04 Jan 2019 06:09:13 +
 Build duration:
1 min 35 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 04 Jan 2019 06:09:13 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D17924: Better plasma-media-center icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b66a65bac264: Better plasma-media-center icon (authored 
by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17924?vs=48596=48657

REVISION DETAIL
  https://phabricator.kde.org/D17924

AFFECTED FILES
  icons/apps/48/plasma-media-center.svg

To: GB_2, #breeze, #vdg, ngraham
Cc: rooty, ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17957: WML: fix embedded Lua code & use new default styles

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In the previous diff of WML (D17891 ), I 
forgot to update the styles as mentioned by dhaumann in the comment (sorry!).
  
  I also noticed that the Lua code is incorrectly highlighted, due to the 
incorporation of the Shebang in `lua.xml` (`wml.xml` is older). Searching, this 
is the only file with the inclusion of ##Lua.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-wml

REVISION DETAIL
  https://phabricator.kde.org/D17957

AFFECTED FILES
  autotests/folding/test.pbl.fold
  autotests/html/test.pbl.html
  autotests/reference/test.pbl.ref
  data/syntax/wml.xml

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17956: DocumentPrivate: Fix broken doc links in qCWarning

[loh tar]

loh.tar added a comment.


  How about to change this logging into a warning message in the view? Or will 
it displayed(?)
  I have noticed these while investigating 
https://bugs.kde.org/show_bug.cgi?id=397956

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17956

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17956: DocumentPrivate: Fix broken doc links in qCWarning

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17956

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D15573: replace custom backtracing in SlaveBase with KCrash

[Christoph Feck]

cfeck added a comment.


  This seems to pull in QtGui dependency, but that's also dragged in by 
KService (which also links to KF5::Crash) and KF5DBusAddons (which only needs 
QtX11Extras, which unfortunately also needs QtGui).
  
  Can the KCrash dependency be added to the slaves instead of to the KIOCore 
library? The split into Core/Gui/Widgets got a bit void when linking an 
application against KIOCore effectively drags in QtGui and QtWidgets (I have 
yet to check why QtWidgets is dragged in).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15573

To: sitter, dfaure
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/3/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 03 Jan 2019 22:04:06 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/9/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 03 Jan 2019 22:04:06 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 211 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/211/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 03 Jan 2019 22:04:06 +
 Build duration:
9 min 8 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13322)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in 
MonthView (authored by Zren).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15321?vs=41123=48646

REVISION DETAIL
  https://phabricator.kde.org/D15321

AFFECTED FILES
  src/declarativeimports/calendar/qml/MonthView.qml

To: Zren, broulik
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17939: Haskell: Highlight empty comments after 'import'

[Li-yao Xia]

xialiyao added a comment.


  Thanks a lot for the tip!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17939

To: xialiyao, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17951: Haskell: Make = a special symbol

[Li-yao Xia]

xialiyao created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
xialiyao requested review of this revision.

REVISION SUMMARY
  It was previously parsed as an operator, but it's much less of one than even 
`=>` or `->`.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17951

AFFECTED FILES
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.lhs.ref
  data/syntax/haskell.xml

To: xialiyao
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/8/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 03 Jan 2019 20:42:55 +
 Build duration:
39 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 210 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/210/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 03 Jan 2019 20:42:55 +
 Build duration:
4 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13322)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/2/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 03 Jan 2019 20:42:55 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D17730: Review KateStatusBar

[loh tar]

loh.tar added a comment.


  > Do we loose this property by using real buttons instead of labels as this 
patch proposes?
  
  I don't think so. The buttons are not entire new, only some labels are now 
ALSO buttons.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D17911: Fix failing knewfilemenu test and underlying reason for its failure

[Nathaniel Graham]

ngraham added a comment.


  Tagging is on January 5th, so I'd like to get this in before then. Any 
objections from anyone if I commit this?

REPOSITORY
  R241 KIO

BRANCH
  fix-test-and-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17911

To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17949: ViewPrivate: Make applyWordWrap() more comfortable

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Don't wrap entire document when nothing is selected but wrap current line
  - Join paragraph before wrap to avoid odd result
  
  TODO Update "What this" hint
  This patch may conflict with D17128 , but 
because that need anyway some more love
  I like to offer this one now, to fetch some feedback.
  
  As always fresh and poor tested. But I think it is a handy improvement and 
seems
  to work nicely. As you know I have often mention not so lovely things about 
the
  wrap feature and there are a couple of bug reports.
  
  This patch address not all aspects but should be a step in the right 
direction.

TEST PLAN
  My arbitrary choose test data.
  
  1a    aaa
  2aa aaa aa aaa aaa    aaa aa
  3 aaa aaa aa aaa a   a 
a   aaa aa
  4a    aaa aa
  5aaa    aaa aa  aaa aa aaa
  
  1-    ---
  2-- --- -- --- ---    --- --
  3 --- --- -- --- -   - 
-   --- --
  4-    --- --
  5---    --- --  --- -- ---
  
  1x    xxx
  2xx xxx xx xxx xxx    xxx xx
  3 xxx xxx xx xxx x   x 
x   xxx xx
  4x    xxx xx
  5xxx    xxx xx  xxx xx xxx
  
  Before
  F6523470: 1546546614.png 
  With Patch
  F6523471: 1546546403.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17730: Review KateStatusBar

[Dominik Haumann]

dhaumann added a comment.


  @cullmann I remember that you fiddled around with the status bar quite a lot 
to make it pixel perfect in height, i.e. that the height of the statusbar 
matches the hight of e.g. the search bar. Do we loose this property by using 
real buttons instead of labels as this patch proposes?
  
  PS: I did not look at the patch in detail.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D17938: Add support for passing cursor information to KRun.

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17430: highlight token strings and delimited strings

[Dominik Haumann]

dhaumann added a comment.


  Also committed, hope everything merged nicely and is correct. I had to update 
the folding unit test data again, but I guess that is fine.
  If you find any issues, please provide another patch :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17430

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2a928919366d: highlight token strings and delimited 
strings (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17430?vs=48636=48638#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17430?vs=48636=48638

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  autotests/folding/highlight.d.fold
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G added a comment.


  In D17430#386026 , @dhaumann wrote:
  
  > Unfortunately, this patch also has an issue:
  >
  >   XSDError in data/syntax/d.xml, at line 413, column 53: Element context is 
missing required attribute lineEndContext.
  >   
  >
  > Can you provide an update to fix it?
  
  
  Done.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17430: highlight token strings and delimited strings

[aG0aep6G aG0aep6G]

aG0aep6G updated this revision to Diff 48636.
aG0aep6G added a comment.


  - add missing lineEndContext attribute

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17430?vs=47371=48636

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17460: fixups for `extern` and `pragma`

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:dc79692de359: fixups for `extern` and `pragma` (authored 
by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17460?vs=48634=48635#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17460?vs=48634=48635

REVISION DETAIL
  https://phabricator.kde.org/D17460

AFFECTED FILES
  autotests/folding/highlight.d.fold
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17924: Better plasma-media-center icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good! Shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  better-plasma-media-center-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17924

To: GB_2, #breeze, #vdg, ngraham
Cc: rooty, ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17460: fixups for `extern` and `pragma`

[aG0aep6G aG0aep6G]

aG0aep6G added a comment.


  In D17460#386002 , @dhaumann wrote:
  
  > Can you provide an updated patch to fix this? Or at least tell me what 
lineEndContext should be used here?
  
  
  Fixed, I hope.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  extern-and-pragma

REVISION DETAIL
  https://phabricator.kde.org/D17460

To: aG0aep6G, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17430: highlight token strings and delimited strings

[Dominik Haumann]

dhaumann added a comment.


  Unfortunately, this patch also has an issue:
  
XSDError in data/syntax/d.xml, at line 413, column 53: Element context is 
missing required attribute lineEndContext.
  
  Can you provide an update to fix it?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

To: aG0aep6G, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17460: fixups for `extern` and `pragma`

[aG0aep6G aG0aep6G]

aG0aep6G updated this revision to Diff 48634.
aG0aep6G added a comment.


  - add missing lineEndContext attribute

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17460?vs=47369=48634

BRANCH
  extern-and-pragma

REVISION DETAIL
  https://phabricator.kde.org/D17460

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17904: Highlight CUDA .cu and .cuh files as C++

[Dominik Haumann]

dhaumann added a comment.


  Thanks! More patches welcome :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17904

To: thomassc, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D17904: Highlight CUDA .cu and .cuh files as C++

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:47ca116c74d2: Highlight CUDA .cu and .cuh files as C++ 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17904?vs=48519=48633

REVISION DETAIL
  https://phabricator.kde.org/D17904

AFFECTED FILES
  data/syntax/cpp.xml

To: thomassc, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Ok, will integrate now as well.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D17883

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f8d8a2fbc0f5: TypeScript  TS/JS React: improve types 
detection, fix float-points  other… (authored by nibags, committed by 
dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17883?vs=48628=48631

REVISION DETAIL
  https://phabricator.kde.org/D17883

AFFECTED FILES
  autotests/folding/test.jsx.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.jsx.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.jsx
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.jsx.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17460: fixups for `extern` and `pragma`

[Dominik Haumann]

dhaumann added a comment.


  @aG0aep6G I just tried to commit this, but it does not work due to the 
following issue:
  
XSDError in data/syntax/d.xml, at line 613, column 60: Element context is 
missing required attribute lineEndContext.
  
  Can you provide an updated patch to fix this? Or at least tell me what 
lineEndContext should be used here?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  extern-and-pragma

REVISION DETAIL
  https://phabricator.kde.org/D17460

To: aG0aep6G, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17883

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

[Nibaldo González]

nibags updated this revision to Diff 48628.
nibags added a comment.


  - Small modification in comments

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17883?vs=48433=48628

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D17883

AFFECTED FILES
  autotests/folding/test.jsx.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.jsx.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.jsx
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.jsx.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17939: Haskell: Highlight empty comments after 'import'

[Dominik Haumann]

dhaumann added a comment.


  Committed, I also used some default styles, see patch below. You can find 
more of the available default styles since KF5 here: 
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  If you want, you can use these and post another patch :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17939

To: xialiyao, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17939: Haskell: Highlight empty comments after 'import'

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d173b27c4d37: Haskell: Highlight empty comments after 
import (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17939?vs=48605=48627#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17939?vs=48605=48627

REVISION DETAIL
  https://phabricator.kde.org/D17939

AFFECTED FILES
  autotests/folding/highlight.hs.fold
  autotests/html/highlight.hs.html
  autotests/html/highlight.lhs.html
  autotests/input/highlight.hs
  autotests/reference/highlight.hs.ref
  data/syntax/haskell.xml

To: xialiyao, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c276c7003d35: WML: fix infinite loop in contexts switch 
 only highlight tags with valid names (authored by nibags, committed by 
dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17891?vs=48617=48625

REVISION DETAIL
  https://phabricator.kde.org/D17891

AFFECTED FILES
  autotests/folding/test.pbl.fold
  autotests/html/test.pbl.html
  autotests/input/test.pbl
  autotests/reference/test.pbl.ref
  data/syntax/wml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17905: [frameworks] Do not use light font styles for headings (1/3)

[Nathaniel Graham]

ngraham added a comment.


  In D17905#385834 , @abetts wrote:
  
  > I don't have a problem with the font as much as I have a problem with the 
spacing for the title labels. They seem to be super close to checkboxes, other 
labels and controls. There should be a clear separation. Adding a heavier font 
to the title label helps a lot but because of its weight and the closeness with 
the rest of the elements, it seems crammed.
  
  
  Let's improve the spacings in another patch. :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: #frameworks, #plasma, #vdg, ngraham, abetts, kde-frameworks-devel, 
michaelh, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Nathaniel Graham]

ngraham added a subscriber: rooty.
ngraham added a comment.


  Aesthetics are admittedly subjective, though I must note that pretty much all 
of VDG is in favor of moving away from light header text for aesthetic reasons. 
However there are other important technical arguments as well, which I will 
restate here:
  
  - **Implementation inconsistency:** Many  fonts don't have a dedicated light 
style, many distros don't ship them if they do, and Qt < 5.12 doesn't use them 
even if they're there. As a result, the visual effect is hampered by an 
inability to consistently display it.
  - **Usability problems:** with many fonts, the light styles are very 
difficult to see. Fonts that do not have a dedicated light style often receive 
the ultra light variant instead, which is almost always borderline illegible. A 
great deal of text throughout Plasma and KDE apps use reduced opacity for 
de-emphasis or inactive text and in this case, using a light style results in 
the text often being //actually// illegible. @rooty has posted examples in this 
and other Phab tickets as well as in the linked bug.
  - **Conceptually incorrect:** It's incorrect to have headers use a reduced 
visual weight compared to the content below them. Headers are //supposed// to 
be bigger and bolder than the text in their content area. They're //supposed// 
to draw attention to themselves. That's their reason for existence. A header 
that tries to de-emphasize itself is a contradiction in terms.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

[Kevin Kofler]

kkofler added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Ping? This has been stuck for over a year now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8810

To: kkofler, #frameworks, kfunk, cullmann
Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfunk, michaelh, bruns

D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names

[Nibaldo González]

nibags updated this revision to Diff 48617.
nibags added a comment.


  - Update test file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17891?vs=48510=48617

BRANCH
  fix-wml

REVISION DETAIL
  https://phabricator.kde.org/D17891

AFFECTED FILES
  autotests/folding/test.pbl.fold
  autotests/html/test.pbl.html
  autotests/input/test.pbl
  autotests/reference/test.pbl.ref
  data/syntax/wml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.11/1/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Thu, 03 Jan 2019 16:57:49 +
 Build duration:
3 min 47 sec and counting

D17851: Add Android notification backend

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:a54c7b17045a: Add Android notification backend (authored 
by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17851?vs=48339=48609

REVISION DETAIL
  https://phabricator.kde.org/D17851

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/KF5Notifications-android-dependencies.xml
  src/knotificationmanager.cpp
  src/notifybyandroid.cpp
  src/notifybyandroid.h
  src/org/kde/knotifications/KNotification.java
  src/org/kde/knotifications/NotifyByAndroid.java

To: vkrause, apol
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Filip Fila]

filipf added a subscriber: Frameworks.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Filip Fila]

filipf added subscribers: VDG, Plasma, ngraham.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: ngraham, #plasma, #vdg, abetts, mart, plasma-devel, dkardarakos, apol, 
davidedmundson, hein

D17905: [frameworks] Do not use light font styles for headings (1/3)

[Filip Fila]

filipf added subscribers: ngraham, VDG, Plasma, Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: #frameworks, #plasma, #vdg, ngraham, abetts, kde-frameworks-devel, 
michaelh, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Filip Fila]

filipf added a comment.


  In D17906#385682 , @mart wrote:
  
  > I'm very much against this, I think it looks very bad :/
  
  
  I think the idea to have a light style for big titles is nice and could 
theoretically work, but in our case unfortunately fails in practice :/
  
  The thing is, even if we didn't have a problem with fonts (btw defaults are 
not a guaranteed experience either, e.g. Fedora ships Plasma with "Sans") 
potentially failing, visual hierarchy is still something which doesn't work the 
best with the old code.
  
  Attaching some screenshots from our main competitors for comparison's sake:
  
  **Notifications (D17905 ):**
  
  F6522734: photo_2018-12-31_12-59-40.jpg 
  
  **App stores:**
  
  - Mac App Store
  
  F6522764: image.png 
  
  F6522766: image.png 
  
  - Windows Store
  
  F6522769: image.png 
  
  F6522740: image.png 
  
  F6522969: image.png 
  
  - GNOME Software:
  
  F6522756: image.png 
  
  F6522758: image.png 
  
  F6522760: image.png 
  
  With the exception of the case of the Windows Store (which does nonetheless 
manage to achieve some visual hierarchy with different font sizes and colors), 
others mostly actually have an opposite approach and go the bold/semi-bold 
route for the more prominent titles, which makes sense - you want to highlight 
the information contained in them. But the point of this patch is to just make 
sure the most important information is not made less important or even 
illegible, which is guaranteed if the labels are "regular" style.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: abetts, mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D17905: [frameworks] Do not use light font styles for headings (1/3)

[Andres Betts]

abetts added a comment.


  I don't have a problem with the font as much as I have a problem with the 
spacing for the title labels. They seem to be super close to checkboxes, other 
labels and controls. There should be a clear separation. Adding a heavier font 
to the title label helps a lot but because of its weight and the closeness with 
the rest of the elements, it seems crammed.
  
  Here are some good spacing examples for title labels
  
  https://dribbble.com/shots/5774759-Photo-Album-Application
  
  https://dribbble.com/shots/5779939-Qwick-Platform-Sneak-Peek
  
  https://dribbble.com/shots/5774973-Chris-Jon-Podcast
  
  And some good typographical advise
  
  
https://medium.com/@lukejones/3-typography-tips-for-a-more-comfortable-read-fed478affa8d

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D17939: Haskell: Highlight empty comments after 'import'

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  import-comment

REVISION DETAIL
  https://phabricator.kde.org/D17939

To: xialiyao, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17939: Haskell: Highlight empty comments after 'import'

[Li-yao Xia]

xialiyao updated this revision to Diff 48605.
xialiyao added a comment.


  Added tests and bumped haskell.xml version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17939?vs=48594=48605

BRANCH
  import-comment

REVISION DETAIL
  https://phabricator.kde.org/D17939

AFFECTED FILES
  autotests/folding/highlight.hs.fold
  autotests/html/highlight.hs.html
  autotests/input/highlight.hs
  autotests/reference/highlight.hs.ref
  data/syntax/haskell.xml

To: xialiyao
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Andres Betts]

abetts added a comment.


  Goodness, I think this is all about taste. I am more on the side that it 
looks good. It visually prioritizes hierarchy with labels. @mart Does it just 
look bad for you or do you think this will cause issues somewhere else?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: abetts, mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/2/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 03 Jan 2019 14:32:33 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestFailed: projectroot.autotests.kconfigcore_test_kconf_updateName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

D17924: Better plasma-media-center icon

[Root]

rooty added a comment.


  +1 loving the new icon

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17924

To: GB_2, #breeze, #vdg
Cc: rooty, ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17939: Haskell: Highlight empty comments after 'import'

[Dominik Haumann]

dhaumann added a comment.


  Yes, please add a test line in the autotest folder:
  
https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/highlight.hs
  
  And please also increase the version number in the language xml element.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17939

To: xialiyao
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17924: Better plasma-media-center icon

[Björn Feber]

GB_2 updated this revision to Diff 48596.
GB_2 added a comment.


  Remove dark radial gradient

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17924?vs=48555=48596

BRANCH
  better-plasma-media-center-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17924

AFFECTED FILES
  icons/apps/48/plasma-media-center.svg

To: GB_2, #breeze, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17816: Support for xattrs on kio copy/move

[Pino Toscano]

pino added a comment.


  Nice progresses, thanks for the fixes. I added few more notes, just 
mentioning the first occurrence of each.
  One more thing is to print errno (and possibly its string representation 
using `strerror`/`strerror_r`) on failure, so that the debugging is easier.

INLINE COMMENTS

> jobtest.cpp:454
>  const int perms = 0666;
> +
>  // copy the file with file_copy

extra empty line

> jobtest.cpp:534
> + * Set xattrs on source file using default linux commandline
> + * TODO: port to multiplatfom
> + * TODO: write tests for copyAs

you can use `QStandardPaths::findExecutable()` to check whether `setfattr` is 
available, and QSKIP the test if not

> jobtest.cpp:540
> +QString command = QString("setfattr -n user.baloo.rating -v 1 
> %1").arg(src);
> +xattrwriter.start(command);
> +xattrwriter.waitForFinished(-1);

please use the `QProcess::start(QString,QStringList)` variant, splitting the 
arguments; this way there is no need to manual quoting the paths, and thus 
avoid problems with spaces

> jobtest.cpp:540
> +QString command = QString("setfattr -n user.baloo.rating -v 1 
> %1").arg(src);
> +xattrwriter.start(command);
> +xattrwriter.waitForFinished(-1);

check using `QVERIFY`/`QCOMPARE` that the process was started correctly

> jobtest.cpp:541
> +xattrwriter.start(command);
> +xattrwriter.waitForFinished(-1);
> +command = QString("setfattr -n user.fnoValue %1").arg(src);

check using `QVERIFY`/`QCOMPARE` that the process ended correctly

> CMakeLists.txt:5-6
>  
> +check_include_files(sys/xattr.h HAVE_SYS_XATTR_H)
> +check_include_files(sys/extattr.h HAVE_SYS_EXTATTR_H)
> +

good checks, although they fit better in `ConfigureChecks.cmake` (which is 
there for a reasons ;) )

> copyjob.cpp:2192
> +if (!QFileInfo::exists(source.toLocalFile()) && 
> !QFileInfo::exists(dest.toLocalFile())) {
> +qCWarning(KIO_COPYJOB_DEBUG) << "failed to open source and destiny";
> +return;

destiny is another thing ;) "destination" in this case

> copyjob.cpp:2205-2209
> +if (listlen < 0) {
> +qCWarning(KIO_COPYJOB_DEBUG) << "libc failed to extract xattr from " 
> << xattrsrc;
> +} else if (listlen == 0) {
> +qCDebug(KIO_COPYJOB_DEBUG) << "File " << xattrsrc << " don't have 
> any xattr.";
> +} else {

this is more of a personal taste rather than an issue: IMHO you can avoid the 
"if .. else if ... else" that adds a nesting level more, especially when all 
the checks lead to early return; so something like:

  if (listlen < 0) {
if (errno != ENOTSUP) {
  qCWarning(KIO_COPYJOB_DEBUG) << "failed to extract xattr from" << 
xattrsrc;
}
return;
  } 
  if (listlen == 0) {
qCDebug(KIO_COPYJOB_DEBUG) << "File" << xattrsrc << "doesn't have any 
xattr.";
return;
  }
  [etc..]

> copyjob.cpp:2256
> +if (errno == ENOTSUP) {
> +qCWarning(KIO_COPYJOB_DEBUG) << "destination filesystem 
> don't support xattrs.";
> +} else {

IMHO this is not a warning worth situation

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/34/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 03 Jan 2019 12:29:48 +
 Build duration:
34 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(259/398)65%
(259/398)51%
(30743/60109)36%
(16084/44244)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(56/57)98%
(56/57)94%
(9035/9569)47%
(4271/9025)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8295/14348)50%
(4678/9311)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets70%
(26/37)70%
(26/37)42%
(3382/7961)29%
(1392/4785)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1036)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 395 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/395/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 03 Jan 2019 12:29:48 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(259/398)65%
(259/398)51%
(30740/60108)36%
(16082/44244)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(56/57)98%
(56/57)94%
(9035/9569)47%
(4268/9025)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8289/14347)50%
(4678/9315)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets70%
(26/37)70%
(26/37)42%
(3381/7961)29%
(1391/4785)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/2/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 03 Jan 2019 12:29:48 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D17939: Haskell: Highlight empty comments after 'import'

[Li-yao Xia]

xialiyao added a comment.


  Should I add a test for it?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17939

To: xialiyao
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17939: Haskell: Highlight empty comments after 'import'

[Li-yao Xia]

xialiyao created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
xialiyao requested review of this revision.

REVISION SUMMARY
In the following snippet,

import Bar ()  --

the trailing, empty comment did not get highlighted.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  import-comment

REVISION DETAIL
  https://phabricator.kde.org/D17939

AFFECTED FILES
  data/syntax/haskell.xml

To: xialiyao
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Marco Martin]

mart added a comment.


  I'm very much against this, I think it looks very bad :/

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D17241: WIP:Disable highlighting after 512 characters on a line.

[Kåre Särs]

sars added a comment.


  @dhaumann OK the limit is too low for Kile that is clear. Visual Studio Code 
is limiting the highlighting on a line to 1 characters.
  
  I tried to set the limit to 1, but that was very noticeably slow. 
Selecting a whole line took multiple seconds, which is probably the reason why 
we have had 4096 as the wrap limit ;)
  
  Is it the whole idea of limiting the highlights or just the too low limit 
that you object to?
  
  The main hotspots I see in my perf/hotspot profiling is 
RenderRangeList::advanceTo(...) in  KateRenderer::decorationsForLine() and in 
KateRenderer::paintTextLine() the hotspot is QTextLayout::draw() (especially 
the one with "additionalFormats").
  
  In both places I don't see (right now at least) very many possibilities to 
optimize.
  
  I think the main problem is that we draw the whole line at once even tho we 
only see just a tiny bit of it (when we have long lines).
  
  "Fixing" this problem would probably require that we also start to draw the 
lines in chunks...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: sars, cullmann, vkrause, dhaumann, mwolff
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17905: [frameworks] Do not use light font styles for headings (1/3)

[Filip Fila]

filipf updated this revision to Diff 48579.
filipf added a comment.


  Found another case of the FontLight variable being set

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17905?vs=48495=48579

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Title.qml

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17816: Initial support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 48586.
cochise added a comment.


  Tests added, includes and ifdefs reworked
  
  Initial tests. Not crossplatform of extensive yet.
  The includes and ifdefs were reworked, and I think they are more concise and 
simple, but some feedback is needed, as they were not tested outside linux.
  The debug messages were slighly improved, various @pino sugestions included 
and changes to file_unix reverted for a posterior PR.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=48410=48586

BRANCH
  xattr-copy-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/config-kiocore.h.cmake
  src/core/copyjob.cpp
  src/ioslaves/file/CMakeLists.txt

To: cochise, dfaure
Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17932: Improvements to completion

[Thomas Schöps]

thomassc created this revision.
thomassc added a reviewer: KTextEditor.
thomassc added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
thomassc requested review of this revision.

REVISION SUMMARY
  My goal is to fix two issues with code completion in KDevelop:
  
  First, it seems to be mostly insensitive to upper/lowercasing, which is an 
issue with a case-sensitive language such as C++. I'd like to have all 
(case-insensitive) matches in the completion list, but always sort those to the 
top and have them selected by default which match the case of the typed text.
  
  Second, I'd like to have the completion widget hidden when there is a 
case-sensitive exact match, such that the completion widget does not obstruct 
the view in this case. Currently it never seems to get hidden automatically.
  
  This diff is an attempt to implement a first step towards these goals by 
improving some things in KTextEditor. I'd make more changes to ensure that the 
auto-selected completion item tries to match the case of the typed text, and to 
make this usable in KDevelop, but would like to put this up here for discussion 
first before making further changes. Would you be fine with the proposed 
changes in general? Would you choose a different approach? The changes in this 
initial diff are described below.
  
  1. The diff introduces a new setting m_exactMatchCaseSensitivity next to 
m_matchCaseSensitivity. By setting m_matchCaseSensitivity == 
Qt::CaseInsensitive and m_exactMatchCaseSensitivity == Qt::CaseSensitive, it is 
possible to have all case-insensitive matches in the completion list, while 
only allowing case-sensitive matches to be exact matches (that will hide the 
completion widget).
  2. In KateCompletionModel::Item::operator <, the (case-sensitive) comparison 
with the current typed text is moved up to just below the matchCompletion 
comparison. This means that items with correctly matching case will match 
better than items with incorrect case (if they both start with the typed text), 
regardless of inheritance depth and alphabetical ordering.
  3. This comparison is also modified to only return true or false if only one 
of the items matches the typed text. The original code would yield inconsistent 
results if both items match the typed text, since the comparison would return 
true for both the test (a < b) and the test (b < a).
  4. When determining whether a completion item matches the typed text, the 
diff makes matchesAbbreviation() take model->matchCaseSensitivity() into 
account (as the other match tests already do). This fixes the issue that 
without this change, "test" and "TEST" would be considered to match exactly 
with model->matchCaseSensitivity() == Qt::CaseSensitive, since the abbreviation 
matching would treat it as a match.
  
  Regarding point 2, this change will only sort those completion items by 
case-compatibility that start with the typed text, but not the others. An 
alternative would be to determine case-compatibility of the item with the typed 
text when matching (in KateCompletionModel::Item::match()). Then completion 
items with the same MatchType could be sorted by case-compatibility (either in 
binary form, "matches case" vs. "does not match case", or by counting the 
number of letters with differing case).

TEST PLAN
  completion_test still passes. Added four checks to this test which test 
case-sensitive matching with matchesAbbreviation(). Did some manual testing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

AFFECTED FILES
  autotests/src/completion_test.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionmodel.h

To: thomassc, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D17938: Add support for passing cursor information to KRun.

[Gleb Popov]

arrowd created this revision.
arrowd added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arrowd requested review of this revision.

REVISION SUMMARY
  This is the KIO part of https://bugs.kde.org/show_bug.cgi?id=398998

TEST PLAN
  With another change to `kioclient5` (not submitted yet) running `kioclient5 
exec textfile:12:34` works fine.
  Corner cases also tested.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17938

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: arrowd, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise retitled this revision from "Initial support for xattrs on kio 
copy/move" to "Support for xattrs on kio copy/move".
cochise edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns