D18148: Use HTTPS, if available, in links visible to users

gszymaszek retitled this revision from "Use HTTPS, if available, in links visible by users" to "Use HTTPS, if available, in links visible to users". gszymaszek added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek,

D18148: Use HTTPS, if available, in links visible by users

gszymaszek created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gszymaszek requested review of this revision. REPOSITORY R39 KTextEditor BRANCH https-in-end-user-links (branched from master) REVISION DETAIL

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich updated this revision to Diff 49133. jgrulich added a comment. Drop keyboard support from this review REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49087=49133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release" to "FakeInput: add support for pointer move with absolute coordinates". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION

D18137: delete copy constructor and assignment operator of some public classes

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. The KSharedDataCache change is definitely correct. I've not done much with the kdelibs migrator but I agree with the logic and the implementation. Have you tried building some of the other

Bugzilla Server Move

Hi all, We've just completed the migration of Bugzilla from a previous system to a newer system. While this hasn't changed Bugzilla itself much, it did involve an update from Ubuntu 14.04 to Ubuntu 18.04. >From our testing everything appears to be operating correctly. Should anyone see anything

D10621: Highlighting Indexer: list of suggestions

jpoelen added a comment. I agree that some rules are excessive or even false, but the last time I watched (it was several months ago now), some regexes suggested to be DetectString seemed to have writing errors (mainly `\\` count as 2 characters in xml) and some more or less useful

D18138: KRatingPainter: Delete copy constructor and assignment operator

This revision was automatically updated to reflect the committed changes. Closed by commit R236:1449db57aa67: KRatingPainter: Delete copy constructor and assignment operator (authored by aacid). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D18134: KEncodingProber: Delete copy constructor and assignment operator

apol added a comment. In D18134#390150 , @vkrause wrote: > As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135 ).

D10446: Add KLanguageName

dhaumann added a comment. I don't think you'd have to import .desktop files. But you would need some lookup table of course to map the names. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: vkrause, dhaumann, hein,

D18138: KRatingPainter: Delete copy constructor and assignment operator

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Right. If someone would copy the object using the default implementations, they would only get two instances pointing to the same Private. REPOSITORY R236 KWidgetsAddons BRANCH

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 09 Jan 2019 21:38:32 + Build duration: 1 min 2 sec and counting JUnit Tests Name:

D18138: KRatingPainter: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 09 Jan 2019 21:00:47 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 09 Jan 2019 21:00:46 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS

D18137: delete copy constructor and assignment operator of some public classes

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 09 Jan 2019 21:00:47 + Build duration: 2 min 36 sec and counting JUnit Tests Name:

D18134: KEncodingProber: Delete copy constructor and assignment operator

vkrause added a comment. As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135 ). REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18134 To:

D18136: kconfig_compiler: delete the assignment operator and copy constructor

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY of the generated class that has a pointer and raw copy would be bad. Those generated classes are internal and nobody

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 09 Jan 2019 20:45:56 + Build duration: 7 min 22 sec and counting JUnit Tests Name:

D10446: Add KLanguageName

vkrause added a comment. In D10446#390025 , @aacid wrote: > In D10446#389972 , @dhaumann wrote: > > > Btw, wouldn't this be a good candidate to upstream to Qt itself? > > > You'd have to

D18135: KEmailSettings: Delete copy constructor and assignment operator

aacid updated this revision to Diff 49107. aacid added a comment. typo REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18135?vs=49106=49107 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18135 AFFECTED FILES src/core/kemailsettings.h

D18135: KEmailSettings: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

D18134: KEncodingProber: Delete copy constructor and assignment operator

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY If someone was using them, it'd crash since it was raw-copying the d pointer so you would end up with a double delete.

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 49099. loh.tar added a comment. - Add missing signals to watch dict changes - Ensure button is set on first show Looks fixed, give it a try. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18125?vs=49078=49099 REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/3/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 09 Jan 2019 18:52:16 + Build duration: 6 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 09 Jan 2019 18:52:16 + Build duration: 6 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 09 Jan 2019 18:52:16 + Build duration: 45 sec and counting JUnit Tests Name: projectroot

D18081: Make translations work

aacid closed this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D18081 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

aacid added a comment. In D10446#389972 , @dhaumann wrote: > Btw, wouldn't this be a good candidate to upstream to Qt itself? You'd have to import all our .desktop files containing all the translations of all languages to all langauges.

D10716: handle wrong password when using sudo which asks for another password

jriddell updated this revision to Diff 49091. jriddell added a comment. - add a stub sudo for testing REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=27859=49091 BRANCH arcpatch-D10716 REVISION DETAIL https://phabricator.kde.org/D10716

D17617: Display error instead of silently failing when asked to create folder that already exists

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio, dfaure Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

hein added a comment. As per this , progress on this is currently blocking wrapping up Wayland virtual desktops support for 5.15. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: hein,

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

graesslin added a comment. I'm the author of this interface and I consider it nowadays as a mistake to have added it. If I would restart I would do the whole thing differently: input events need to be injected through a kernel module in a dedicated input device. It would need a user space

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

graesslin added a comment. I don't want to have key press/release in it. It has a reason that I didn't add key press/release from the start. The problem is the mismatch of key events and keysyms. Especially the kdeconnect use case for which this interface was developed has this problem.

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > Isn't en_US too cryptic? Well, yes. > I suggest to use the just added KLanguageName (see D10446 ). With this, you can get a nice name like "English (USA)". Alternatively, you may use

D10446: Add KLanguageName

dhaumann added a comment. Btw, wouldn't this be a good candidate to upstream to Qt itself? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

dhaumann added a comment. Isn't en_US too cryptic? I suggest to use the just added KLanguageName (see D10446 ). With this, you can get a nice name like "English (USA)". Alternatively, you may use QLocale("en_US").nativeLanguageName(), but I did not test

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich updated this revision to Diff 49087. jgrulich added a comment. Fix documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49082=49087 BRANCH fake-input-keyboard-key REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich added a comment. I didn't intent to push this together, but when creating a branch from master which already had first round of changes caused my second part of changes to be pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to get exception from David Faure

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates" to "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49082. jgrulich added a comment. Add support for keyboard key press and release REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49081=49082 BRANCH fake-input-keyboard-key REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart accepted this revision. mart added a comment. bah, seems very tricky to make it work properly across distributions. to me, it speaks mostly as a failure for us to control the look of our product, due to broken fonts in distros and qt font rendering still buggy, issue that

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. The shown dictionary is sometimes "wrong" - Mark a word by double-click and choose a dictionary different from the default for that word - Click/move into the word -> The shown dictionary fit - Double-Click that word again -> The shown dictionary is the

D18125: KateStatusBar: Add dictionary button

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to indicate the current dictionary and for the handy access

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.11 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.11/24/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 09 Jan 2019 15:16:18 + Build duration: 3 min 40 sec and counting JUnit Tests

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49081. jgrulich added a comment. Bump fake interface version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49071=49081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D10446: Add KLanguageName

This revision was automatically updated to reflect the committed changes. Closed by commit R265:91077def022a: Add KLanguageName (authored by aacid, committed by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10446?vs=48854=49079#toc REPOSITORY R265 KConfigWidgets CHANGES

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in klanguagenametest.cpp:80 > Do you think it makes sense adding this? > > void testNoString() > { > // Qt doesn't have za support so no string at all > QCOMPARE(KLanguageName::nameForCode("za"), QString()); > } 

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks! REPOSITORY R276 KItemViews BRANCH master REVISION DETAIL https://phabricator.kde.org/D18046 To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham Cc:

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49071. jgrulich added a comment. Coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49070=49071 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. zzag added inline comments. INLINE COMMENTS > fakeinput.cpp:106 > +Q_ASSERT(d->manager.isValid()); > +if (wl_proxy_get_version(d->manager) < > ORG_KDE_KWIN_FAKE_INPUT_POINTER_MOTION_ABSOLUTE_SINCE_VERSION) > +return; Use curly braces even when the

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49070. jgrulich added a comment. Fix review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49069=49070 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fake-input.xml:86 > > + > + since="3" REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh,

D18114: FakeInput: add support for pointer move with absolute coordinates

davidedmundson accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49069. jgrulich added a comment. Adress review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49066=49069 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES

D18114: FakeInput: add support for pointer move with absolute coordinates

davidedmundson added inline comments. INLINE COMMENTS > fakeinput.cpp:106 > +Q_ASSERT(d->manager.isValid()); > +org_kde_kwin_fake_input_pointer_motion_absolute(d->manager, > wl_fixed_from_double(pos.x()), wl_fixed_from_double(pos.y())); > +} if (wl_proxy_get_version(d->manager) <

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. zzag added a comment. Please wait for @davidedmundson and @graesslin. :-) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham,

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49066. jgrulich added a comment. Add information when new methods were introduced and bump version of FakeInput in registry REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49064=49066 BRANCH master

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fakeinput_interface.cpp:164 > + > + > void FakeInputInterface::Private::axisCallback(wl_client *client, > wl_resource *resource, uint32_t axis, wl_fixed_t value) Please delete one extra empty line. REPOSITORY R127 KWayland REVISION DETAIL

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added a comment. maxVersion in src/client/registry.cpp should be updated as well. INLINE COMMENTS > fakeinput.h:138 > + * Request an absolute pointer motion to @p pos position. > + **/ > +void requestPointerMoveAbsolute(const QPointF ); Missing `@since`. >

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#389751 , @fabianr wrote: > You are not using the default font, are you? In D17906#389713 , @mart wrote: > uuh, that's the wrong color.. that's

D17906: [kirigami] Do not use light font styles for headings (2/3)

fabianr added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D17906: [kirigami] Do not use light font styles for headings (2/3)

fabianr added a comment. The HIG states: "When the visual design calls for an area of exceptional focus, a larger typeface size may be used. In this case use a Light typeface weight to keep the stroke width similar to other styles throughout the interface" I think, if you want to have

D18089: KLauncher: handle processes exiting without error

ahmadsamir added a comment. I don't have commit access, so please commit the diff. Thanks. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in klauncher.cpp:340 > To make this less scary (since it's not an error) I would suggest > > << "exited without error, request done. status=" << Good point. Done. REPOSITORY R303

D18089: KLauncher: handle processes exiting without error

ahmadsamir marked 2 inline comments as done. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

ahmadsamir updated this revision to Diff 49063. ahmadsamir retitled this revision from "KLauncher: handle process dying with exitStatus 0" to "KLauncher: handle processes exiting without error". ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Make commit and debug

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49064. jgrulich added a comment. Revert unwanted changes in CMakeLists REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49046=49064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388803 , @ngraham wrote: > F6531451: Screenshot_20190107_145258.png > In this one, the fact that it's a header is connoted by its much larger font size and wider

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. But wait, can we completely remove `m_oldDragMovePos` ? If the event is accepted in the case `event->pos() == m_oldDragMovePos`, then why don't we generate the move event? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To:

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. @broulik I've updated the patch, can you review it ? In D16643#378823 , @broulik wrote: > Only if that potential issue with inhibition has been addressed REPOSITORY R296 KDeclarative REVISION DETAIL