D18158: Fix elapsed time check

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cd2f67c39b25: Fix elapsed time check (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18158?vs=49166=49314 REVISION DETAIL

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

davidedmundson added a comment. That's bloody clever! +1 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D18204 To: aacid Cc: davidedmundson, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 12 Jan 2019 08:05:44 + Build duration: 5 min 36 sec and counting JUnit Tests Name:

D18038: Fix semantics for ghns_exclude

leinir added a comment. In D18038#391684 , @ngraham wrote: > Thanks, in addition to the testing tool working, this patch seems to actually fix the issue in production (e.g. "Tree on Island" is no longer visible in the wallpaper downloader), and

D18038: Fix semantics for ghns_exclude

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18038 To: leinir, ronaldv, #kde_store, ngraham Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov,

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH arcpatch-D18204 REVISION DETAIL https://phabricator.kde.org/D18204 To: aacid, anthonyfieroni Cc: davidedmundson, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham,

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

aacid updated this revision to Diff 49319. aacid added a comment. Review comments update REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18204?vs=49308=49319 BRANCH arcpatch-D18204 REVISION DETAIL https://phabricator.kde.org/D18204 AFFECTED FILES

D17932: Improvements to completion

thomassc updated this revision to Diff 49343. thomassc added a comment. Update according to Milian's comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17932?vs=48574=49343 BRANCH improvements_to_completion (branched from master) REVISION

D18158: Fix elapsed time check

elvisangelaccio added a comment. What else is missing to fix #402665? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18158 To: davidedmundson, chinmoyr Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

anthonyfieroni added inline comments. INLINE COMMENTS > kcheckaccelerators.cpp:87 > +static bool doCheckAccelerators = true; > + > QCoreApplication *app = QCoreApplication::instance(); We can cheet here if (!doCheckAccelerators) { return; } > kcheckaccelerators.cpp:114 > +

D18010: Allow zero altitude/longitude/latitude exiv gps data

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D18205: test empty and zero gps data

bruns added inline comments. INLINE COMMENTS > exiv2extractortest.cpp:62 > + > +using namespace KFileMetaData::Property; > +QCOMPARE(result.properties().value(PhotoGpsLatitude).toDouble(), 41.411); move this up, as it is not specific to this test case > exiv2extractortest.cpp:65 > +

D17691: Add rows info to the plasma virtual desktop protocol

hein added a task: T4457: [kwayland] Virtual Desktop protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

This revision was automatically updated to reflect the committed changes. Closed by commit R263:02b523bad09a: Make KCheckAccelerators less invasive for apps that dont directly link to… (authored by aacid). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

aacid added a comment. Since i have two +1 i'll commit this next saturday unless someone shouts in disagreement REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

mwolff requested changes to this revision. mwolff added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > textdocument.cpp:691 > -menu->addAction(action); > -} > -} can't you just add a slot here that removes the actions we added once the menu is

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

aacid updated this revision to Diff 49340. aacid added a comment. Change style to make Anthony happy REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18204?vs=49319=49340 BRANCH arcpatch-D18204 REVISION DETAIL https://phabricator.kde.org/D18204

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich updated this revision to Diff 49317. astippich added a comment. - rebase on revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18010?vs=48789=49317 BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010 AFFECTED

D18205: test empty and zero gps data

astippich added a dependent revision: D18010: Allow zero altitude/longitude/latitude exiv gps data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich added a dependency: D18205: test empty and zero gps data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18010 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18205: test empty and zero gps data

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Create a new test that more extensively checks gps data obtained

D18038: Fix semantics for ghns_exclude

This revision was automatically updated to reflect the committed changes. Closed by commit R304:301fe73569ba: Fix semantics for ghns_exclude (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18038?vs=48859=49339 REVISION DETAIL

D17932: Improvements to completion

thomassc marked 4 inline comments as done. thomassc added a comment. Thanks for reviewing. Regarding the question about which models would have an insensitive exact match, and which ones have sensitive exact matches: - An example for case-insensitive exact matches might be plain text, or

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. Milian Wolff wrote on 20190112::12:35:11 re: "D16882 <https://phabricator.kde.org/D16882>: [KDevelop/Shell] prevent duplicate added contextmenu actions" >> mwolff wrote in textdocument.cpp:691 >> can't you just add a slot here that

D18199: Add Kotlin (.kt) mimetype icons

trickyricky26 added a subscriber: alex-l. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D18213: Fill lock in preferences-desktop-user-password

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, much better. REPOSITORY R266 Breeze Icons BRANCH fill-lock-pref-password (branched from master) REVISION DETAIL https://phabricator.kde.org/D18213 To: trickyricky26,

D18213: Fill lock in preferences-desktop-user-password

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6af2171307e8: Fill lock in preferences-desktop-user-password (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18199: Add Kotlin (.kt) mimetype icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That's much better! I like the subtle gradient. #VDG folks, is everyone else good with this? REPOSITORY R266 Breeze Icons BRANCH

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi marked an inline comment as done. gregormi added a comment. This is what is looks like now (together with latest changes from https://phabricator.kde.org/D17138): F6547077: grafik.png REPOSITORY R39 KTextEditor REVISION DETAIL

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18199: Add Kotlin (.kt) mimetype icons

trickyricky26 planned changes to this revision. trickyricky26 added a comment. I'm going to add the gradient to the `32px` as well REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg, ngraham Cc: alex-l, ngraham, kde-frameworks-devel,

D18215: Improve the preferences-desktop-cryptography icon

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Much better than the original, but if we're trying to emulate the existing style, we should come as close to pixel-perfect as we can. :) Compare your new icon to the

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi updated this revision to Diff 49369. gregormi added a comment. - Move "Save As..." out of the submenu REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17137?vs=46132=49369 BRANCH arcpatch-D17137 REVISION DETAIL

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18199: Add Kotlin (.kt) mimetype icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

trickyricky26 updated this revision to Diff 49353. trickyricky26 added a comment. - Use a nicer purple color, similar to the official logo REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18199?vs=49301=49353 BRANCH add-kotlin-icons (branched from

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 updated this revision to Diff 49354. trickyricky26 added a comment. - Remove Plasma logo and shadow of the white label REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18215?vs=49351=49354 BRANCH improve-preferences-cryptography

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 updated this revision to Diff 49360. trickyricky26 added a comment. - widen the right part of the SATA connector to be more symmterical REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18215?vs=49356=49360 BRANCH

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

gregormi retitled this revision from "KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate" to "KTextEditor: Tweak keyboard shortcuts to free F keys". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: cullmann,

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

gregormi added a comment. With respect to bringing this https://phabricator.kde.org/T10279 forward, how should I proceed here? Can this go in as first step (after I removed F10 and F11)? (see also https://phabricator.kde.org/D17443) INLINE COMMENTS > kateview.cpp:700 >

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH improve-preferences-cryptography (branched from master) REVISION DETAIL

D17851: Add Android notification backend

vkrause added inline comments. INLINE COMMENTS > broulik wrote in notifybyandroid.cpp:79 > Can there be multiple instances of this `NotifyByAndroid`? KNotificationManager prevents that IIUC. > broulik wrote in notifybyandroid.cpp:125 > Does this need a `FreeLocalRef` call? Possible, I'll

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 updated this revision to Diff 49356. trickyricky26 added a comment. - Shift the lock upwards a bit, remove bottom left shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18215?vs=49354=49356 BRANCH improve-preferences-cryptography

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

ngraham added a comment. Lookin' pretty good! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D18213: Fill lock in preferences-desktop-user-password

trickyricky26 edited the summary of this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18213 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18213: Fill lock in preferences-desktop-user-password

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fill-lock-pref-password (branched from master) REVISION DETAIL

D17851: Add Android notification backend

broulik added a comment. Pretty cool! INLINE COMMENTS > notifybyandroid.cpp:79 > +{ > +s_instance = this; > +#if __ANDROID_API__ >= 23 Can there be multiple instances of this `NotifyByAndroid`? > notifybyandroid.cpp:125 > +pixmap.save(, "PNG"); > +auto jIconData =

D17730: Review KateStatusBar

gregormi added a comment. @loh.tar: I like the new status bar. > Move the modified label from far right to far left This way have it a more prominent position Now, the "modified label" behaves like a button but with no visible action when it is clicked. Two general observations:

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi added a comment. What I wonder: during the work with the .rc files I noticed that even the Kate which is installed in root got affected by the changes I made in the development version and I had to regularly change the version number to make changes take effect. Is this normal?

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

loh.tar added a comment. Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic. I may like it if these "Variant-Action" could be avoided and merged with one of the

D17797: Include applets/22

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17797 To: nicolasfella, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D17730: Review KateStatusBar

loh.tar added a comment. > I like the new status bar. Thanks :-) > In "modified" state it would be cool to be able to click to save the document Yes, that was also my idea. IIRC I had somewhere asked but got no response. Will do it soon. > Move the modified label from far

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

mwolff added inline comments. INLINE COMMENTS > mwolff wrote in textdocument.cpp:691 > can't you just add a slot here that removes the actions we added once the > menu is closed? that would fix this issue with way less code and with slot I mean an local lambda that takes a copy of the actions