KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 26 Jan 2019 04:31:17 + Build duration: 43 min and counting JUnit Tests Name: projectroot

D18475: Add AsciiDoc support

nibags added a comment. Hi!! Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`. I am not a reviewer, but I want to add some recommendations in relation to the

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#400238 , @nibags wrote: > Hi!! > Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`.

D11236: [KCrash] Establish socket to allow change of ptracer

This revision was automatically updated to reflect the committed changes. Closed by commit R285:2af59ef51f8c: [KCrash] Establish socket to allow change of ptracer (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11236?vs=49711=50214#toc REPOSITORY R285 KCrash

D11235: Request change of ptrace scope from KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R871:9f3cfcff960c: Request change of ptrace scope from KCrash (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11235?vs=49717=50215#toc REPOSITORY R871 DrKonqi CHANGES SINCE

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R127 KWayland BRANCH send-initla-row-event REVISION DETAIL https://phabricator.kde.org/D18521

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D18516: Fix end of folding region in rules with lookAhead=true

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-region-lookahead REVISION DETAIL https://phabricator.kde.org/D18516

D17122: Add option to use wl_display_add_socket_auto

romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_display.cpp:223 > +QVERIFY(runtimeDir.exists()); > +QVERIFY(!runtimeDir.exists("wayland-0")); > +QVERIFY(!runtimeDir.exists("wayland-1"));

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

cullmann added a comment. I thought I had a endless loop/recursion detection, bad :/ Will take a look. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18509 To: jwilbee, #framework_syntax_highlighting, cullmann, dhaumann Cc: nibags, shubham,

D11235: Request change of ptrace scope from KCrash

croick retitled this revision from "[DrKonqi] Request change of ptrace scope from KCrash" to "Request change of ptrace scope from KCrash". croick edited the summary of this revision. REPOSITORY R871 DrKonqi BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 To: croick,

restore dialog sizes and QTBUG-40584

Hi, after having read the documentation of KWindowConfig::restoreWindowSize(), I understood how to properly restore the dialog sizes. I'm in a process of fixing this now in LabPlot (20 dialogs or so): https://cgit.kde.org/labplot.git/commit/? id=ebfa6b4243dec41b6c656483a57401de4b387793

D18516: Fix end of folding region in rules with lookAhead=true

nibags edited the summary of this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, KTextEditor. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18516 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann,

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH send-initla-row-event REVISION DETAIL https://phabricator.kde.org/D18521 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

davidedmundson added inline comments. INLINE COMMENTS > fvogt wrote in test_display.cpp:223 > That won't work reliably either though - if wayland-0 is free, but wayland-1 > is used, it would pick wayland-0 and wayland-2. Maybe it should just check > that starting both displays at the same time

D17122: Add option to use wl_display_add_socket_auto

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d671fcd0c09d: Add option to use wl_display_add_socket_auto (authored by fvogt). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=50238=50241 REVISION

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 25 Jan 2019 12:20:47 + Build duration: 12 min and counting JUnit Tests Name:

D17122: Add option to use wl_display_add_socket_auto

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma, romangg Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 25 Jan 2019 12:32:56 + Build duration: 10 min and counting JUnit Tests Name:

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50263. andreasgr removed projects: Frameworks, Kate. andreasgr added a comment. Herald added projects: Kate, Frameworks. - Add missing allowed leading characters for links. - Add escaping of attribute usage. - Avoid highlighting of spaces inside

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/7/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 Jan 2019 12:32:29 + Build duration: 8 min 52 sec and counting BUILD ARTIFACTS

D18526: Fix memory leak when passing icon data to Java

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18526 AFFECTED FILES

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 25 Jan 2019 12:20:47 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 25 Jan 2019 14:21:39 + Build duration: 1 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 25 Jan 2019 15:00:04 + Build duration: 1 min 9 sec and counting JUnit Tests Name:

D17851: Add Android notification backend

vkrause added inline comments. INLINE COMMENTS > vkrause wrote in notifybyandroid.cpp:125 > Possible, I'll investigate. Addressed in D18526 . REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17851 To: vkrause, apol Cc:

D17122: Add option to use wl_display_add_socket_auto

romangg added inline comments. INLINE COMMENTS > fvogt wrote in test_display.cpp:223 > That won't work reliably either though - if wayland-0 is free, but wayland-1 > is used, it would pick wayland-0 and wayland-2. Maybe it should just check > that starting both displays at the same time

D18507: Add Activities KCM icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. We can always rename it in another commit. REPOSITORY R266 Breeze Icons BRANCH preferences-desktop (branched from master) REVISION DETAIL https://phabricator.kde.org/D18507 To:

D17122: Add option to use wl_display_add_socket_auto

fvogt added inline comments. INLINE COMMENTS > romangg wrote in test_display.cpp:223 > This fails when one tries to run the test inside another Wayland session, > which already uses the wayland-0 socket name. > > What you could do here is loop until you find the first non-existing >

D17122: Add option to use wl_display_add_socket_auto

romangg added a dependent revision: D18522: Name Wayland socket automatically when no socket name was specified. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma, romangg Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh,

D18369: Create tel: links for phone numbers

vkrause added inline comments. INLINE COMMENTS > svuorela wrote in ktexttohtml.cpp:159 > How are the thread safety of the KTextToHTML functions? > > And does that match the thread safety of the QRegularExpression and the const > methods in there? Valid point. This isn't specified in the

D18385: Build without KAuth and D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R265:747f0cdff38b: Build without KAuth and D-Bus on Android (authored by vkrause). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18385?vs=49889=50256 REVISION

D18387: Build without D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R302:080ee499f169: Build without D-Bus on Android (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18387?vs=49891=50260 REVISION DETAIL

D18527: List Android as officially supported

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18527 AFFECTED FILES metainfo.yaml

D17122: Add option to use wl_display_add_socket_auto

fvogt updated this revision to Diff 50238. fvogt added a comment. Replace XDG_RUNTIME_DIR, test still passes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=49806=50238 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17122

D17122: Add option to use wl_display_add_socket_auto

fvogt marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma, romangg Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

This revision was automatically updated to reflect the committed changes. Closed by commit R127:87d9d440919f: [server] Send initial org_kde_plasma_virtual_desktop_management.rows (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 Jan 2019 12:20:47 + Build duration: 5 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/13/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 25 Jan 2019 12:34:24 + Build duration: 16 min and counting BUILD ARTIFACTS

D18386: Build without D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R309:4e8e170580f3: Build without D-Bus on Android (authored by vkrause). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18386?vs=49890=50257 REVISION DETAIL

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar added a comment. > also don't change the behavior of wordwrapping that is used by the view compared to what we would get by calling wordwrap on the document directly It's somehow not the case. The document has no such function. It's similar to ViewPrivate::smartNewline() or

D18389: Build without D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R245:cb1509537cb6: Build without D-Bus on Android (authored by vkrause). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18389?vs=49894=50261 REVISION DETAIL

D18390: Build without D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R294:d5e76df55828: Build without D-Bus on Android (authored by vkrause). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18390?vs=49895=50267 REVISION DETAIL

D18507: Add Activities KCM icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c3981728515f: Add Activities KCM icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18507?vs=50208=50268 REVISION DETAIL

D18527: List Android as officially supported

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18527 To: vkrause, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18388: Build without D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R263:5bbb846dd970: Build without D-Bus on Android (authored by vkrause). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18388?vs=49893=50272 REVISION DETAIL

D18529: Rename Activities KCM icon

ndavis added a dependent revision: D18531: Change icon for Activities config. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

ndavis added a dependent revision: D18530: Change Activities KCM icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:31e1b9977a47: Rename Activities KCM icon (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18529?vs=50273=50282#toc REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D18529: Rename Activities KCM icon

ndavis added a dependent revision: D18532: Change icons for Activities dataengine and runner. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH improve-notification-bell-icon (branched from master) REVISION DETAIL

D18529: Rename Activities KCM icon

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY KCMs should have color icons while widgets should have monochrome icons, so I have changed

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 added a comment. I have made some slight adjustments from the original KAlarm design, such as a shadow line at the bottom instead of orange, to better fir our style. Should I make those changes in the original icon as well? REPOSITORY R266 Breeze Icons REVISION DETAIL

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ed985869924f: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

jwilbee updated this revision to Diff 50286. jwilbee added a comment. Added requested changes to fallthrough context Incremented version number REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18509?vs=50212=50286 BRANCH kconfig-freeze-fix

D18529: Rename Activities KCM icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH preferences-activities (branched from master) REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham,

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va escriure: > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. > Committed on 21/01/2019 at 05:46. > Pushed by bcooksley into branch 'master'. > > Disable execution of tests for plasma-integration. > This is

D18434: exiv2extractor: add support for bmp, gif, webp, tga

kossebau added a comment. In D18434#400106 , @aacid wrote: > is it worth adding files to autotests/exiv2extractortest.cpp ? Shortly considered, but then I saw so far only a jpg file is tested, and thinking about it, the test checks that

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel updated this revision to Diff 50295. thsurrel added a comment. Remove the timer REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16913?vs=45550=50295 BRANCH arc_focussearch (branched from master) REVISION DETAIL

D18434: exiv2extractor: add support for bmp, gif, webp, tga

aacid added a comment. is it worth adding files to autotests/exiv2extractortest.cpp ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18434 To: kossebau, #baloo, #dolphin Cc: aacid, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty edited the test plan for this revision. rooty added reviewers: VDG, ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

ngraham added a comment. Wow, it's amazing how much nicer the After screenshot looks than the Before. Such a difference from a tiny change! +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc:

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

filipf added a comment. Really nice, I think it fits in more with how edges are drawn elsewhere. Could you also add screenshots with Breeze Dark? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: filipf,

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch aims to make the corners of the dialog/notification backgrounds (dialogs/background.svgz) more rounded and more

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty added a comment. In D18545#400214 , @ngraham wrote: > Wow, it's amazing how much nicer the After screenshot looks than the Before. Such a difference from a tiny change! +1 Thanks! And thanks to Noah Davis for giving me a boost

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

rooty added a comment. In D18545#400222 , @rooty wrote: > In D18545#400220 , @filipf wrote: > > > Really nice, I think it fits in more with how edges are drawn elsewhere. > > > > Could you also