D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. How about "Could not create because slashes are not allowed in file and folder names." REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Then we should define a new error message specifically for this case. That's probably material for another patch. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a dependent revision: D18599: Use specific error message if file/folder name contains '/'. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: dfaure,

D18599: Use specific error message if file/folder name contains '/'

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY Depends on D18563 REPOSITORY R241 KIO

D18450: Add extractor for AppImage files

astippich added a comment. The first issue is when BUILD_TESTING is not set to false, cmake fails with CMake Error at lib/CMakeLists.txt:8 (add_subdirectory): The source directory ~/Code/libappimage-0.1.8/lib/gtest does not contain a CMakeLists.txt file.

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

rooty added a comment. In D18545#401802 , @ngraham wrote: > I really like the effect that this gives--not only for notifications, but also for plasma popups, OSDs, window switchers, etc. It's subtle and classy. Let us know when the remaining

D18601: Rewrite taglib writer to use property interface

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Rewrite the taglib writer to use taglib's unified

D18163: Set the color scheme to Printing when print preview'ing

ahmadsamir updated this revision to Diff 50503. ahmadsamir retitled this revision from "KateRenderer: when printing initially set the color scheme to Printing" to "Set the color scheme to Printing when print preview'ing". ahmadsamir edited the summary of this revision. ahmadsamir edited the test

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

davidedmundson added a comment. If you open the file, the mask is the black rectangle on the right. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel,

D18450: Add extractor for AppImage files

kossebau added a comment. @astippich Thanks for the update. I see that myself I built libappimage with USE_SYSTEM_LIBARCHIVE:BOOL=ON, USE_SYSTEM_SQUASHFUSE:BOOL=OFF, USE_SYSTEM_XZ:BOOL=ON, BUILD_TESTING:BOOL=OFF (cannot remember why I configured the build that way when I initially set it

D18237: Fix ResultIterator

apol added a comment. Maybe it could make sense to deprecate the copy constructor and add the move operator? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18563: Don't create directory tree when a new folder has a '/' in the name

elvisangelaccio added a comment. I'm also a bit puzzled: are we removing a feature in order to show an error message instead? REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino

D18563: Don't create directory tree when a new folder has a '/' in the name

markg added a comment. In D18563#401979 , @shubham wrote: > @ndavis UNIX does not allow / in any valid identifier name. > Also looking at the bug report, it feels like people wanted to create a folder named "a/b/c" which UNEXPECTEDLY created

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham Okay with changing error message string, please provide me with the best suitable string. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham The message you suggested is specific, on the other hand failure in creation of directory may also be due to the file/directory name reserved by OS (eg .. ) REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To:

D18237: Fix ResultIterator

apol added a comment. Do you think BC is a problem here then? Won't applications be using it as you described start failing? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov,

D18599: Use specific error message if file/folder name contains '/'

ngraham added reviewers: VDG, Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > knewfilemenu.cpp:905 > KIO::Job *job; > -if (name.contains(QLatin1Char('/'))) { > -// If the name contains any slashes, use mkpath so that

D18599: Use specific error message if file/folder name contains '/'

shubham updated this revision to Diff 50496. shubham marked an inline comment as done. shubham added a comment. Fix trailing spaces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18599?vs=50495=50496 BRANCH err REVISION DETAIL

D18599: Use specific error message if file/folder name contains '/'

shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 Jan 2019 18:13:14 + Build duration: 6 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Jan 2019 18:13:14 + Build duration: 7 min 0 sec and counting BUILD ARTIFACTS

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

rooty added a comment. In D18545#401958 , @davidedmundson wrote: > > "Background Contrast" darkens the background of all the UI elements by adding rectangles (instead of just darkening their backgrounds). > > That's both true and not true.

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ndavis UNIX does not allow / in any valid identifier name. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: ndavis, dfaure, elvisangelaccio, pino,

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

rooty added a comment. F6575069: image.png Before on top After below (I did the same thing to translucent/dialogs/background.svgz too) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty,

D18317: Display an error message if loading a dictionary fails

ahmadsamir updated this revision to Diff 50486. ahmadsamir retitled this revision from "Don't fail if defaultLanguage dictionary can't be loaded" to "Display an error message if loading a dictionary fails". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

ngraham added a comment. I really like the effect that this gives--only only for notifications, but also for plasma popups, OSDs, window switchers, etc. It's subtle and classy. Let us know when the remaining bugs are worked out! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D18599: Use specific error message if file/folder name contains '/'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

shubham updated this revision to Diff 50495. shubham added a comment. 1. #ifndef Q_OS_WIN for the error message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18599?vs=50494=50495 BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 AFFECTED

D18599: Use specific error message if file/folder name contains '/'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18237: Fix ResultIterator

aacid abandoned this revision. aacid added a comment. Hmmm, you're right, this is Source Compatible but not Binary Compatible. I guess i'll discard this and hope people don't really misuses it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid,

D18599: Use specific error message if file/folder name contains '/'

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, thanks. REPOSITORY R241 KIO BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel,

D18603: Implement more tags for taglib writer

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Implement more tags for writing for the taglib writer

D18317: Display an error message if loading a dictionary fails

ahmadsamir added a reviewer: loh.tar. ahmadsamir added a subscriber: pino. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

ahmadsamir added a comment. In D18163#398206 , @dhaumann wrote: > Is KateRenderer::setPrinterFriendly() only called in print preview mode? I think not. > > What is the bahavior currently when you print a page with another schema, and then

D18599: Use specific error message if file/folder name contains '/'

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18599 To: shubham, ngraham, #vdg, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

shubham updated this revision to Diff 50494. shubham added a comment. Remove unintentionally included header REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18599?vs=50493=50494 BRANCH err REVISION DETAIL https://phabricator.kde.org/D18599 AFFECTED FILES

D18604: implement support for writing rating information for taglib writer

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add support for writing the rating tag to all supported

D18604: Implement support for writing rating information for taglib writer

astippich retitled this revision from "implement support for writing rating information for taglib writer" to "Implement support for writing rating information for taglib writer". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham retitled this revision from "Don't allow '/' in new directory's name" to "Don't create directory tree when a new folder has a '/' in the name". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham,

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham accepted this revision as: ngraham. ngraham added reviewers: dfaure, elvisangelaccio, pino. ngraham added subscribers: pino, elvisangelaccio, dfaure. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me. Please don't land this until you receive

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. We might want to also consider improving the error message for this situation. I think it would be appropriate to do so in this patch. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks,

D18599: Use specific error message if file/folder name contains '/'

ngraham added inline comments. INLINE COMMENTS > global.h:251 > ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between > kuiserver and views when the job owner disappears unexpectedly. It should not > be emitted by slaves. @since 5.54 > +

D18563: Don't create directory tree when a new folder has a '/' in the name

ndavis added a comment. So if I want to make 2 folders at once, `~/a` and `~/a/b`, this patch removes that ability? If so, I don't like this change. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

davidedmundson added a comment. > "Background Contrast" darkens the background of all the UI elements by adding rectangles (instead of just darkening their backgrounds). That's both true and not true. We take the frame SVG and run: QBitmap(d->alphaMask().mask()) Which is a

D16894: [ECM] use a macro to add compiler flags conditionally

dfaure added a comment. > SUPPORTED_IF : add the flag(s) if the expression is true? Yes. > TRY_IF: query the compiler if the expression is true? Yes. > How would that intersect with the SUPPORTED_IF test? In addition. AFAICS this is what you implemented, so I like

D18603: Implement more tags for taglib writer

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18450: Add extractor for AppImage files

TheAssassin added a comment. You can use a system Google test installation by setting `-DUSE_SYSTEM_GTEST=ON`, IIRC. But it's easier to simply `git submodule --init --recursive`. `LIBAPPIMAGE_BINARIES` doesn't exist, maybe it existed for a short while but got deleted. @kossebau can you

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) I think I'm

D18237: Fix ResultIterator

aacid reclaimed this revision. aacid added a comment. Ok, that makes sense REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D18450: Add extractor for AppImage files

kossebau added a comment. Given there are now released versions of libappimage which provide cmake config files, I will now update this patch to simply only support those. Distributions will be encouraged to also get the latest version of libappimage anyway. REPOSITORY R286 KFileMetaData

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50535. kossebau added a comment. rely completely on working libappimage cmake config files, as avail with recent releases REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50146=50535 BRANCH

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau created this revision. kossebau added a reviewer: broulik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Recent released versions of libappimage set working imported

D18610: Introduce KF5AuthNoWidgets

aacid added a comment. This is how the dependency graph of backlighthelper looks like at the moment F6575456: current_kauth.png and this is how it looks if we change it to use the KF5AuthNoWidgets library F6575461: patched_kauth.png

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. > In that sentence, one can read "if supported" for the macro name, ... That was my idea too, and the reason the macro ends in "_if_supported". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system,

D18610: Introduce KF5AuthNoWidgets

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's KF5Auth but without kauthobjectdecorator.cpp This will allow us to link helpers just against KF5AuthNoWidgets

D18563: Don't create directory tree when a new folder has a '/' in the name

ndavis added a comment. In D18563#402216 , @ngraham wrote: > It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) > > I think I'm reconsidering.

D18608: Save two KFilterDev::compressionTypeForMimeType calls

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D18608 AFFECTED FILES src/kzip.cpp To: aacid

D18563: Don't create directory tree when a new folder has a '/' in the name

acrouthamel added a comment. -1 from me. I would prefer we stick to Unix methodologies. KDE software is also known to be the more feature-rich and customizable options out there, and as mentioned commonly linked to power users. We would be wise to not introduce a feature

D18237: Fix ResultIterator

aacid updated this revision to Diff 50533. aacid added a comment. update so not to break BC REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18237?vs=49413=50533 BRANCH arcpatch-D18237 REVISION DETAIL https://phabricator.kde.org/D18237 AFFECTED FILES

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Well now I am. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh,

D18603: Implement more tags for taglib writer

astippich added a dependent revision: D18604: Implement support for writing rating information for taglib writer. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc:

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. It's difficult to know the intentions of the user whether they wanted to create a single directory with slash in it or a directory tree. So this patch is stuck in between the two. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To:

D18603: Implement more tags for taglib writer

astippich added a dependency: D18601: Rewrite taglib writer to use property interface. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D18601: Rewrite taglib writer to use property interface

astippich added a dependent revision: D18603: Implement more tags for taglib writer. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D18450: Add extractor for AppImage files

astippich added a comment. In D18450#402175 , @TheAssassin wrote: > `LIBAPPIMAGE_BINARIES` (or, more likely, `LIBAPPIMAGE_LIBRARIES`) doesn't exist, maybe it existed for a short while but got deleted. @kossebau can you please link to

D18604: Implement support for writing rating information for taglib writer

astippich added a dependency: D18603: Implement more tags for taglib writer. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D18603: Implement more tags for taglib writer

astippich added a comment. I forgot to add the dependent revision. Thanks for the review, as it's been hard lately to get a reply to anything related to KFileMetaData REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To:

D18089: KLauncher: handle processes exiting without error

anthonyfieroni added a comment. +1 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#401517 , @dhaumann wrote: > 1. I apply your patch: arc patch D18475 Thanks for the information. And many thanks for your time spent on reviewing. Cheers

D18089: KLauncher: handle processes exiting without error

ahmadsamir added a comment. Ping. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17991: Refactor the way device backends are built and registered

apol added a comment. Looks good to me. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To: pino Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17245: Add string formatting function to property info

astippich added a comment. ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D12950: add test which checks the property types

astippich added a comment. ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams