D18662: Add and rename some YaST icon symlinks

ndavis updated this revision to Diff 50739. ndavis added a comment. Update commit message REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18662?vs=50694=50739 BRANCH more-yast (branched from master) REVISION DETAIL

D18662: Add and rename some YaST icons and symlinks

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:cff0b5794d82: Add and rename some YaST icons and symlinks (authored by ndavis). CHANGED PRIOR TO COMMIT

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 50708. valeriymalov added a comment. - unbreak documentdatadb::contains, oops :( REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=50706=50708 BRANCH master REVISION DETAIL

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:20:01 + Build duration: 33 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:20:46 + Build duration: 44 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:20:31 + Build duration: 43 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:20:02 + Build duration: 1 hr 21 min and counting BUILD ARTIFACTS

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis added a subscriber: hellcp. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f2e7a22be5e5: KateSpellCheckDialog: Remove action Spellcheck Selection (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17932: Improvements to completion

cullmann added a comment. Should we give this some try and merge it? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, hase,

D17932: Improvements to completion

dhaumann added a comment. Well, giving it a try and merge should be postponed ubtil tomorrow: dfaure tags today, so we would then have 1 month of internal testing. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 17:21:40 + Build duration: 26 min and counting BUILD ARTIFACTS

Re: CI for prison: missing dependency

On Sun, Feb 3, 2019 at 12:02 AM David Faure wrote: > > On samedi 2 février 2019 11:20:28 CET CI System wrote: > > -- The following REQUIRED packages have not been found: > > > > * QRencode, The QRencode library, > > Can this be added to the CI? Unfortunately Android doesn't use the standard

D18116: Add TODO KF6 note

loh.tar updated this revision to Diff 50759. loh.tar retitled this revision from "Don't show document load trouble twice" to "Add TODO KF6 note ". loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Revert

D18116: Add TODO KF6 note

loh.tar added a comment. In D18116#403838 , @cullmann wrote: > Just to be sure: > > We can apply D18117 and don't need to change here anything or? It seems so :-) REPOSITORY R39 KTextEditor

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 50709. astippich added a comment. - rebase on latest parent revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=50505=50709 BRANCH rating_write2 REVISION DETAIL

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:14:55 + Build duration: 8 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/16/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 02 Feb 2019 13:18:45 + Build duration: 2 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:19:00 + Build duration: 26 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 13:21:32 + Build duration: 41 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 13:21:32 + Build duration: 48 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 13:21:33 + Build duration: 1 hr 26 min and counting BUILD ARTIFACTS

D18662: Add and rename some YaST icon symlinks

ndavis retitled this revision from "Add and rename some YaST icon symlinks because of Qt bugs" to "Add and rename some YaST icon symlinks". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel,

D18516: Fix end of folding region in rules with lookAhead=true

This revision was automatically updated to reflect the committed changes. Closed by commit R216:941f17e1a979: Fix end of folding region in rules with lookAhead=true (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 15:24:41 + Build duration: 18 min and counting BUILD ARTIFACTS

D18638: Avoid using trimmed method

apol added inline comments. INLINE COMMENTS > highlighter.cpp:299 > > +static bool hasNotEmptyText(const QString ) > +{ how about hasSpaces? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18638 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D18662: Add and rename some YaST icon symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. @ngraham I think this patch is behaving exactly it should be, are you trying for a fix so that these warnings are not used? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann,

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/17/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 02 Feb 2019 17:23:15 + Build duration: 5 min 10 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/7/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 02 Feb 2019 17:25:25 + Build duration: 2 min 37 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 17:21:05 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 102 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/102/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 02 Feb 2019 17:19:19 + Build duration: 22 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 17:24:44 + Build duration: 40 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:21:05 + Build duration: 1 hr 6 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 17:21:40 + Build duration: 1 hr 6 min and counting BUILD ARTIFACTS

D18686: Add Cursors KCM icon

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-cursors (branched from master) REVISION DETAIL

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404090 , @ngraham wrote: > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. Yeah, it's the only X icon, I think we need to

D18675: Use different "None" item icon in grid view KCMs

abetts added a comment. In D18675#404090 , @ngraham wrote: > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. I agree with you here. It may seem that you

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 02 Feb 2019 17:23:15 + Build duration: 4 hr 26 min and counting JUnit Tests

D18688: Check Exiv2::ValueType::typeId before converting it to rational

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks, astippich. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY If one has a malformed image with GPSAltitude key present, but is not rational, an attempt to convert it

D18664: Baloo engine: treat every non-success code as a failure

poboiko added a comment. Nice! I like it, it's definitely much better than `Q_ASSERT_X` macros that are just silently ignored in non-debug builds. Have some nitpicks though: 1. Are we actually sure this is gonna fix all those crashes? Otherwise I would suggest using CCBUG instead

D18688: Check Exiv2::ValueType::typeId before converting it to rational

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH invalid-gps (branched from master) REVISION DETAIL https://phabricator.kde.org/D18688 To: poboiko, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel,

D18675: Use different "None" item icon in grid view KCMs

ngraham added a comment. Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg,

D18686: Add Cursors KCM icon

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18686 To: ndavis, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D18686: Add Cursors KCM icon

GB_2 added a comment. I really like it! REPOSITORY R266 Breeze Icons BRANCH preferences-cursors (branched from master) REVISION DETAIL https://phabricator.kde.org/D18686 To: ndavis, #vdg, ngraham Cc: GB_2, ngraham, abetts, kde-frameworks-devel, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404096 , @GB_2 wrote: > In D18675#404090 , @ngraham wrote: > > > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 103 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/103/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 02 Feb 2019 21:48:32 + Build duration: 3 min 57 sec and counting

D18686: Add Cursors KCM icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:befcc3791d6a: Add Cursors KCM icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18686?vs=50746=50747 REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 23:19:20 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404097 , @abetts wrote: > In D18675#404090 , @ngraham wrote: > > > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404104 , @abetts wrote: > > Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled. > > I see, maybe the label could be more descriptive then? Use something

D18664: Baloo engine: treat every non-success code as a failure

ngraham added subscribers: bruns, ngraham. ngraham added reviewers: bruns, poboiko. ngraham added a comment. Conceptually this seems like it's definitely better than nothing or the status quo. Only checking for `MDB_NOTFOUND` and ignoring other error statuses seems like really bad code

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 23:19:20 + Build duration: 3 min 33 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 23:19:20 + Build duration: 3 min 35 sec and counting JUnit Tests

D18686: Add Cursors KCM icon

ndavis updated this revision to Diff 50746. ndavis added a comment. Fix Breeze Dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18686?vs=50745=50746 BRANCH preferences-cursors (branched from master) REVISION DETAIL

D18686: Add Cursors KCM icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18686 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18675: Use different "None" item icon in grid view KCMs

abetts added a comment. > Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled. I see, maybe the label could be more descriptive then? Use something like "Black", or "No splash"? REPOSITORY R296 KDeclarative REVISION DETAIL

D18686: Add Cursors KCM icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this is great! REPOSITORY R266 Breeze Icons BRANCH preferences-cursors (branched from master) REVISION DETAIL https://phabricator.kde.org/D18686 To: ndavis, #vdg, ngraham

D18675: Use different "None" item icon in grid view KCMs

ngraham added a comment. Yeah, the item already has a "None" label; we're just trying to figure out what the icon should be. I think an X is okay choice for suggesting "there's nothing here". REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2,

<    1   2