D18714: Add some Maxima constans to MaximaVariable list

sirgienko created this revision. sirgienko added a reviewer: Framework: Syntax Highlighting. sirgienko added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sirgienko requested review of this

D18714: Add some Maxima constans to MaximaVariable list

sirgienko updated this revision to Diff 50807. sirgienko added a comment. Add Maxima function REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18714?vs=50805=50807 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18714 AFFECTED

D18714: Add some Maxima constans and function

sirgienko retitled this revision from "Add some Maxima constans to MaximaVariable list" to "Add some Maxima constans and function". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18714 To: sirgienko, #framework_syntax_highlighting Cc: kwrite-devel,

D18714: Add some Maxima constans and function

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, the only missing part is to increase thw "version" number each time a highlighting file is changed. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION

D18714: Add some Maxima constans and function

sirgienko updated this revision to Diff 50809. sirgienko added a comment. Increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18714?vs=50807=50809 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18714 AFFECTED

D18714: Add some Maxima constans and function

sirgienko added a comment. Should I land it via arc? Or mannualy commit it (for short commit message)? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D18714 To: sirgienko, #framework_syntax_highlighting, dhaumann Cc: dhaumann,

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov planned changes to this revision. valeriymalov added a comment. In D18664#404173 , @poboiko wrote: > 1. Are we actually sure this is gonna fix all those crashes? Otherwise I would suggest using CCBUG instead of BUG inside the commit

D17816: Support for xattrs on kio copy/move

cochise added a comment. Can we ship it, or using a subjob on `KIO::copy` is mandatory here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

On vendredi 1 février 2019 10:32:19 CET Ben Cooksley wrote: > On Fri, Feb 1, 2019 at 9:15 PM David Faure wrote: > > I'll try to get around to debugging this, but I'm surprised by one thing: > > doesn't the same issue happen in KIO's own tests? It also has several > > tests > > that make use of

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18680 To: elvisangelaccio, apol, smartins Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

ndavis added a comment. Is this icon used by any other KDE software or 3rd party applications? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

chinmoyr added a reviewer: VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18699 To: chinmoyr, dfaure, ngraham, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

cfeck added a comment. The "Apply to All" button is used for all choices, including "Overwrite", "Skip", and "Rename". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18699 To: chinmoyr, dfaure, ngraham, #vdg Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham,

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Removes the monochrome font preferences icon to prevent showing it instead of the colorful icon

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

elvisangelaccio updated this revision to Diff 50790. elvisangelaccio marked an inline comment as done. elvisangelaccio added a comment. Addressed comments REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18680?vs=50735=50790 BRANCH master

D17816: Support for xattrs on kio copy/move

dfaure added a comment. Using exec() from a job implementation is a big no no, it creates an unexpected re-entrancy, source of all sorts of problems. This cannot be shipped as is. See KCompositeJob's documentation for how to add a subjob - and/or see DirectorySizeJob for a simple

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb updated this revision to Diff 50812. rjvbb added a comment. Now tested more exhaustively and with unittest. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16894?vs=50589=50812 REVISION DETAIL https://phabricator.kde.org/D16894 AFFECTED FILES

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system, kfunk Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system,

D18702: Remove monochrome font preferences icon and improve font selection icon

ngraham added a comment. In D18702#404521 , @ndavis wrote: > Is this icon used by any other KDE software or 3rd party applications? Yes, quite a few: https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-font Those

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This makes sense to me. Thanks for the test, too. REPOSITORY R293 Baloo BRANCH add-watch-moved (branched from master) REVISION DETAIL https://phabricator.kde.org/D18698 To:

D18688: Check Exiv2::ValueType::typeId before converting it to rational

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6e449d44bb5d: Check Exiv2::ValueType::typeId before converting it to rational (authored by poboiko). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

dhaumann added a comment. Related bug report: https://bugs.kde.org/show_bug.cgi?id=403215 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18509 To: jwilbee, #framework_syntax_highlighting, cullmann, dhaumann Cc: kde-frameworks-devel, nibags,

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 50763. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Apply nullptr check - Add non preferred dict to menu chose by user - Reorder actions - Remove gone "Spellcheck Selection" action REPOSITORY R39

D17302: Add test for adding properties to result

astippich added a comment. Since nobody seems to care and this is just testing the status quo, I'll merge it next week unless somebody objects REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov,

D18675: Use different "None" item icon in grid view KCMs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Master only please. REPOSITORY R296 KDeclarative BRANCH use-different-icon-for-none-item (branched from master) REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2,

D18675: Use different "None" item icon in grid view KCMs

GB_2 edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch removes "Apply to All" checkbox and adds a combobox with

D18694: Add edit-none icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH add-edit-none-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18694 To: GB_2, #vdg, ngraham Cc: kde-frameworks-devel, #vdg, michaelh, ngraham,

D18675: Use different "None" item icon in grid view KCMs

GB_2 updated this revision to Diff 50774. GB_2 added a comment. Use new `edit-none` icon REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18675?vs=50724=50774 BRANCH use-different-icon-for-none-item (branched from master) REVISION DETAIL

D18699: [KIO/RenameDialog] Add new apply behaviour

broulik added a comment. I find the wording and usability a bit confusing, "Older Dest", "Newer Dest", etc. I think that dialog needs to be overhauled entirely for this approach to work, cf. to how windows uses command links for that (they're also quite hard to grasp at a glance imho), not

D18694: Add edit-none icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds an `edit-none` icon, needed by D18675 . F6584574:

D18694: Add edit-none icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f3d16cb641ea: Add edit-none icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18694?vs=50767=50772 REVISION DETAIL

D18675: Use different "None" item icon in grid view KCMs

This revision was automatically updated to reflect the committed changes. Closed by commit R296:e22529eeed0c: Use different None item icon in grid view KCMs (authored by GB_2). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18675?vs=50774=50775 REVISION

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY If a folder was moved from an unwatched place, `KInotify` will receive an `EventMoveTo` event, which doesn't have

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Feb 2019 11:19:34 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Feb 2019 11:19:34 + Build duration: 15 min and counting BUILD ARTIFACTS

D18699: [KIO/RenameDialog] Add new apply behaviour

chinmoyr updated this revision to Diff 50778. chinmoyr edited the summary of this revision. chinmoyr added a comment. Add bug id. Remove old code. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18699?vs=50777=50778 BRANCH master REVISION DETAIL

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added a comment. To which "file1"/"file2" are you referring in the summary? The commit log should be self contained. INLINE COMMENTS > kinotify.cpp:431 > +} > +addWatch(QFile::decodeName(path), d->mode, d->flags); > +} else {

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. In general, these changes seem worthwhile. But as already said, splitting these into two parts - QDebug etc vs. Error handling - is a must. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc:

D18664: Baloo engine: treat every non-success code as a failure

cullmann added a comment. I think this is a step into the right direction. Thought I am still not sure if we not should go away from a own storage db for all this and port that over to e.g. use the tracker stuff. Given that fixing the issues will be more or less a complete rewrite, too.

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 added a comment. In D18702#404695 , @ngraham wrote: > In D18702#404521 , @ndavis wrote: > > > Is this icon used by any other KDE software or 3rd party applications? > > > Yes, quite a few: