D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Now that I think about it, Elisa also has a variant of this UI that would be much better if it adopted this visual style, and i think that one would look good with dark buttons too. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ba3341c83b18: Fix ENABLE_CLAZY option with clazy = 1.5 (authored by elvisangelaccio). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D16643: Correct the accept flag of the event object on DragMove

bcooksley added a comment. Phabricator can take up to 30 minutes to become aware of commits depending on how active a repository normally is. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc:

D16643: Correct the accept flag of the event object on DragMove

fvogt closed this revision. fvogt added a comment. Landed (phab didn't notice): https://cgit.kde.org/kdeclarative.git/commit/?id=856672f370fb32c7a3c3d1a13d873fb8b767d0e8 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma,

D16643: Correct the accept flag of the event object on DragMove

ngraham added a comment. Never mind, missed that this was for a Frameworks repo. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18768: Extend Open Document thumbnailer to Office Open XML

broulik created this revision. broulik added reviewers: Plasma, VDG, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This tries to extract the `docProps/thumbnail.*`

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2,

D18768: Extend Open Document thumbnailer to Office Open XML

acrouthamel added a comment. Thanks for expanding the thumbnailer lately, awesome work with this and the eBook one. :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18768 To: broulik, #plasma, #vdg, #frameworks Cc: acrouthamel, kde-frameworks-devel, kfm-devel,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

broulik added a comment. +1 I think this is a fine tradeoff between aesthetics and usability REPOSITORY R296 KDeclarative BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R296:6258f33fce3a: [GridViewKCM] improve contrast and legibility for delegates inline hover… (authored by ngraham). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. Nice, my first patch finally has been accepted. Thanks everyone! Btw, can you @bcooksley help me to change my name in my profile? Tranter Madi REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham updated this revision to Diff 50990. ngraham added a comment. Reverse the order of clicking and triggering, since it looks a bit nicer this way REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18649?vs=50982=50990 BRANCH

D18738: Add ebook thumbnailer

elvisangelaccio added a comment. LGTM INLINE COMMENTS > CMakeLists.txt:265 > + > +install(TARGETS ebookthumbnail DESTINATION ${PLUGIN_INSTALL_DIR}) > + `PLUGIN_INSTALL_DIR` is deprecated, new code should use `KDE_INSTALL_PLUGINDIR` REPOSITORY R320 KIO Extras REVISION DETAIL

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Actually there is a real issue here. Disabled button icons are much less legible with the dark version. The enabled version of the delete button is less legible too (red-on-black vs red-on-gray) I think we need to go with the version that 100% follows the color

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham updated this revision to Diff 50982. ngraham added a comment. Use theme-following version for various reasons REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18649?vs=50976=50982 BRANCH improve-grid-view-kcm-inline-hover-button-contrast

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ndavis accepted this revision. REPOSITORY R296 KDeclarative BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis Cc: Codezela, bruns, rizzitello, ndavis,

D17245: Add string formatting function to property info

astippich added a comment. Can someone please give this a yes or a no? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16643: Correct the accept flag of the event object on DragMove

bcooksley added a comment. Please update your name on Identity, then i'll sync it from there. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham,

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#406076 , @bcooksley wrote: > Please update your name on Identity, then i'll sync it from there. Done. Thank you! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R296 KDeclarative BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham,

D16643: Correct the accept flag of the event object on DragMove

bcooksley added a comment. Your name has now been updated. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18776: Make sure only directories are added to the inotify watcher

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Maybe add a comment above this line explaining the reasoning that you put in the patch's summary section. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D18604: Implement support for writing rating information for taglib writer

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:229 > No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not > possible. but in case file.tag() returns an ApeTag, the dynamic_cast will return a nullptr. This is a dynamic_cast, not a

D18772: Mark KCodecs::uuencode does nothing

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D18772 AFFECTED FILES CMakeLists.txt

D18776: Make sure only directories are added to the inotify watcher

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Although watchFolder is only called for directories,

D18770: [KStatusNotifierItem] use fallback sizes when none is available

pino created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY When converting a QIcon to a vector of images to D-Bus, the list of available sizes is used to extract the pixmaps of the

D18604: Implement support for writing rating information for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:229 > but in case file.tag() returns an ApeTag, the dynamic_cast will return a > nullptr. This is a dynamic_cast, not a static_cast. It always returns a nullptr REPOSITORY R286 KFileMetaData REVISION DETAIL

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY If System Settings > Applications > Default Applications > Web Browser is

D18762: Add support for portals in KRun

jgrulich added a comment. Looks good from the portal point of view, but I would rather wait for someone who knows KRun internally to approve this review. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc:

D18762: Add support for portals in KRun

GeeXT updated this revision to Diff 51017. GeeXT added a comment. The result should be negated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=50972=51017 BRANCH flatpak_open_url (branched from master) REVISION DETAIL

D18612: Cache the default KColorScheme configuration

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

broulik added a comment. I think `QIcon::fromTheme` also handles absolute paths, if given. This should be fine. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18731 To: vkrause, davidedmundson Cc: broulik, cfeck, kde-frameworks-devel, michaelh,

D18730: Use breeze icons for search providers

broulik added a comment. Yeah -1, `filterData.iconNameForPreferredSearchProvider` should give us a proper icon. https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps needs to have icons added REPOSITORY R223 Okular REVISION DETAIL

D16643: Correct the accept flag of the event object on DragMove

fvogt added a comment. > The second change fvogt mentioned is IMHO handled quite strangely here - !m_enabled || m_temporaryInhibition is the inverse of !m_enabled || m_temporaryInhibition, so doing a event->ignore() === event->setAccepted(false) prior to the first return statement would

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY When

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko added a comment. > I am not sure if I understood your description correctly, but I am quite sure this race condition does not exist - the files/folders inside the moved folder are not created/moved one by one, but the containing folder ist just "renamed" - it is unlinked from the

D18730: Use breeze icons for search providers

shubham added a comment. @broulik Adding icons to the .desktop files does not work, I tried. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes,

D18755: Read IKWS search provider icon from desktop file

shubham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18755 To: broulik, #frameworks, shubham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18755: Read IKWS search provider icon from desktop file

broulik created this revision. broulik added reviewers: Frameworks, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to give them more meaningful icons rather than the one derived

D18730: Use breeze icons for search providers

broulik added a comment. Check out D18730 Then you can put `Icon=foo` in the respective search provider desktop file REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc:

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko updated this revision to Diff 50932. poboiko added a comment. Added code to work with first entry that pops from FilteredDirIterator (that is the directory itself) Test still works; but we should emit `created()` signal for it as well. REPOSITORY R293 Baloo CHANGES SINCE LAST

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 05 Feb 2019 12:01:59 + Build duration: 7 min 32 sec and counting JUnit Tests Name:

D18755: Read IKWS search provider icon from desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e1c386f04303: Read IKWS search provider icon from desktop file (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18755?vs=50934=50938 REVISION

D18163: Set the color scheme to Printing for Print Preview

This revision was automatically updated to reflect the committed changes. Closed by commit R39:28e59740d070: Set the color scheme to Printing for Print Preview (authored by ahmadsamir, committed by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D18163: Set the color scheme to Printing for Print Preview

dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18116: Add TODO KF6 note

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:574b08d08111: Add TODO KF6 note (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D18761: Add icon name to service providers in .desktop file

shubham added reviewers: VDG, Okular. shubham added projects: Okular, VDG. shubham added a subscriber: Okular. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh,

D18761: Add icon name to service providers in .desktop file

shubham added a comment. In the rest of service providers, very few have any icon specified, and most don't have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh,

D18761: Add icon name to service providers in .desktop file

shubham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular, #frameworks Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty,

D16643: Correct the accept flag of the event object on DragMove

fvogt added a comment. @trmdi: Can you do the small change @bruns suggested? ^ Then it can be landed and everyone's happy :-) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: fvogt, aacid, bruns, dkorth,

D15910: Implement wl_surface::damage_buffer

zzag added a comment. Is it good now? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15910 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18761: Add icon name to service providers in .desktop file

shubham created this revision. shubham added reviewers: broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY Earlier all entries had same icon ie. "text-html" See also D18755

D18730: Use breeze icons for search providers

shubham abandoned this revision. shubham added a comment. Abandoned in favour of D18761 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: broulik, #vdg, okular-devel,

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. In D16643#405468 , @fvogt wrote: > > The second change fvogt mentioned is IMHO handled quite strangely here - !m_enabled || m_temporaryInhibition is the inverse of !m_enabled || m_temporaryInhibition, so doing a

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#405368 , @ngraham wrote: > One thing I will not do in this patch is synthesize a fake button that has different behaviors from the standard button. If there's a problem with our buttons we need to fix it

D18738: Add ebook thumbnailer

ngraham added a comment. Quite lovely. With the latest changes, this now generates thumbnails for all my my ePubs that have a cover page defined. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham,

D15910: Implement wl_surface::damage_buffer

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH damageBuffer REVISION DETAIL https://phabricator.kde.org/D15910 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham,

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. Okay seeing as I'm seeing this corner problem with my icons as well, F6589150: image.png vs F6589155: image.png I think it's safe to land this. Also it's way past Saturday so :D

D18738: Add ebook thumbnailer

ngraham accepted this revision as: VDG. ngraham added a comment. VDG,approved, still needs a proper code review. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde,

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dda4edcc6eb0: [breeze desktop theme/dialogs] Add rounded corners to dialogs (authored by rooty). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 05 Feb 2019 16:00:16 + Build duration: 2 min 5 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/14/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Feb 2019 16:00:17 + Build duration: 3 min 39 sec and counting BUILD ARTIFACTS

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

bruns added a comment. The inline version looks a little bit more polished, while the other one looks literally "just put on top". The "button" version though somewhat resembles the "selection" buttons/emblems in dolphin. There is a very tiny issue with the button version, although the

D18487: Reparse background contrast settings when colors changed

broulik added inline comments. INLINE COMMENTS > mart wrote in theme_p.cpp:754 > but it wouldn't be guaranteed to be the same of the value stored in the > config file no? If the theme does not supply background contrast values, they are auto-determined from the background color (dark or

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. Well, I really don't like that this is the only thing that has dark buttons. It is inconsistent and just looks out of place. We should probably do some more discussion elsewhere if we want do this in other places too. REPOSITORY R296 KDeclarative REVISION DETAIL

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#406051 , @fvogt wrote: > @trmdi: Do you have push access? If not, which name should be used for the commit? No, I don't. tr...@yandex.com / Tranter Madi REPOSITORY R296 KDeclarative REVISION DETAIL

D16643: Correct the accept flag of the event object on DragMove

ngraham added a comment. Hmm, should this go to the 5.15 branch too? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 05 Feb 2019 16:00:17 + Build duration: 12 min and counting BUILD ARTIFACTS

D18734: Update octave.xml to Octave 4.2.0

sirgienko added a comment. @dhaumann, look on the `eps` (this word contained in command list) on this image. The word have wrong highlighting. F6589241: изображение.png I am testing my `octave.xml` file on v5.49.0 (current master need ecm 5.55 and I

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added a comment. Addendum: I have just checked, https://phabricator.kde.org/source/baloo/browse/master/src/file/filewatch.cpp$144 filewatch relies on the code here to emit created events for all children, so we need the traversal code not only for "moved", but also for

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:429 > This is broken now, as you fail to emit created for any child. Ignore, looked at the wrong line ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks,

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

On Mon, Feb 4, 2019 at 6:35 AM David Faure wrote: > > On vendredi 1 février 2019 10:32:19 CET Ben Cooksley wrote: > > On Fri, Feb 1, 2019 at 9:15 PM David Faure wrote: > > > I'll try to get around to debugging this, but I'm surprised by one thing: > > > doesn't the same issue happen in KIO's own

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

Codezela added a comment. how about make it global under beside add image button aligned left tow buttons disablef by default REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: Codezela, bruns, rizzitello, ndavis,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Well, this view is used in a lot of different places, so it's not like only one thing does it this way now. But we could do it in Gwenview too, which has the same basic UI but uses light buttons. Also maybe we could think about adjusting Dolphin's selection

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko updated this revision to Diff 50967. poboiko added a comment. Cosmetics REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18698?vs=50932=50967 BRANCH add-watch-moved (branched from master) REVISION DETAIL https://phabricator.kde.org/D18698

D18762: Add support for portals in KRun

GeeXT created this revision. GeeXT added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GeeXT requested review of this revision. REVISION SUMMARY Currently KRun in Flatpak/Snap doesn't support portals so it can't launch an application

D18763: [client] Fix typos

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R127 KWayland BRANCH fix-typos REVISION DETAIL https://phabricator.kde.org/D18763 AFFECTED

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added inline comments. INLINE COMMENTS > kinotify.cpp:429 > +if (!it.next().isEmpty()) { > +d->addWatch(it.filePath()); > +} This is broken now, as you fail to emit created for any child. REPOSITORY R293 Baloo REVISION

D18763: [client] Fix typos

apol added a comment. These are not typos. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18763 To: zzag, #kwin Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18763: [client] Fix typos

zzag abandoned this revision. zzag added a comment. Well ok. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18763 To: zzag, #kwin Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. In D18649#406019 , @Codezela wrote: > how about make it global under > beside add image button aligned left > tow buttons disablef by default No, that was the old design we moved away from. The new thing is

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > When you make this > `void writeGenericProperties(Taglib::File *file, const PropertyMap > )`, you can do `file->properties(); {/* merge */}; > file->setProperties(...);` here, saving most of the duplicate

D18604: Implement support for writing rating information for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:229 > Is this the same as > > auto id3Tags = dynamic_cast(file.tag()); > if (id3Tags) { ... } > > ? No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not possible. REPOSITORY R286

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added a comment. In D18698#405504 , @poboiko wrote: > > I am not sure if I understood your description correctly, but I am quite sure this race condition does not exist - the files/folders inside the moved folder are not created/moved one

D18734: Update octave.xml to Octave 4.2.0

sirgienko updated this revision to Diff 50963. sirgienko added a comment. Add requested changes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18734?vs=50877=50963 BRANCH octave REVISION DETAIL https://phabricator.kde.org/D18734 AFFECTED

D18487: Reparse background contrast settings when colors changed

mart added inline comments. INLINE COMMENTS > broulik wrote in theme_p.cpp:754 > An alternative approach would be to store those values and then do the > default fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) < > 127` stuff on the fly on demand. > It's runtime cpu cycles vs

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. In D16643#405814 , @fvogt wrote: > @trmdi: Can you do the small change @bruns suggested? ^ Then it can be landed and everyone's happy :-)  REPOSITORY R296 KDeclarative REVISION DETAIL

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. The buttons are dynamic and are chosen by the individual KCM; what you propose would be out of scope even if it were possible. I think we're going to stay with this basic design. REPOSITORY R296 KDeclarative REVISION DETAIL

D18761: Add icon name to service providers in .desktop file

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH icon REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular, #frameworks Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 05 Feb 2019 17:02:37 + Build duration: 7 min 1 sec and counting JUnit Tests Name:

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham updated this revision to Diff 50976. ngraham added a comment. Go with the dark version REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18649?vs=50879=50976 BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Yeah, the dark version has grown on me too. I'm going to go with that for now. The diff is smaller too. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: bruns, rizzitello, ndavis, andreask,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2,

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added a comment. In D18698#405636 , @poboiko wrote: > Added code to work with first entry that pops from FilteredDirIterator (that is the directory itself) > Test still works; but we should emit `created()` signal for it as well.

D18734: Update octave.xml to Octave 4.2.0

sirgienko marked an inline comment as done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18734 To: sirgienko, #framework_syntax_highlighting Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, ngraham, bruns,

D18734: Update octave.xml to Octave 4.2.0

sirgienko added inline comments. INLINE COMMENTS > octave.xml:2745 > + String="end_try_catch" endRegion="Try" /> > > + endRegion="block" /> Could one word (`end`) be in several region? Because, in Octave, you could end `if` statement by `endif` or just `end`. In this

D18761: Add icon name to service providers in .desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8657a239a28d: Add icon name to service providers in .desktop file (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18761?vs=50953=50969 REVISION

D18762: Add support for portals in KRun

GeeXT updated this revision to Diff 50972. GeeXT added a comment. Restored the accidentally deleted empty line... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=50968=50972 BRANCH flatpak_open_url (branched from master) REVISION DETAIL

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

Codezela added a comment. another option we put the delete button only and align it to the corner of the thumbnail make it circle button and ditch the other one no need for it here what do u think REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649

  1   2   >