D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

trickyricky26 added a comment. Try rendering pngs of these icons with the montage-breeze commands found here: https://invent.kde.org/ndavis/hig-kde-org/wikis/home REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik Cc: trickyricky26,

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added inline comments. INLINE COMMENTS > poboiko wrote in kinotify.cpp:390 > I'm a bit lost, why is it a problem? Or do you mean it's a costly operation > and suggest to do the following? > > const QString& fname = QFile::decodeName(path); > Q_EMIT created(fname); > [...] >

D18957: Use natural sorting in ActivityModel

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Clever! I believe the bug is about the switcher though, not the KCM. REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D18957 To:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 13:46:49 + Build duration: 8 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 14:04:39 + Build duration: 6 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 14:15:30 + Build duration: 4 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 14:14:44 + Build duration: 5 min 29 sec and counting JUnit Tests Name:

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty updated this revision to Diff 51510. rooty added a comment. Flip horizontal bars REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18959?vs=51509=51510 BRANCH flash-monochrome-icon (branched from master) REVISION DETAIL

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty edited the summary of this revision. rooty edited the test plan for this revision. rooty added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

vkrause added a comment. +1 This makes sense to me, considering how broken some vendor [E]GL stacks are. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18954: Add missing XdgShellPopup::ackConfigure

zzag added inline comments. INLINE COMMENTS > xdgshell_v6.cpp:588 > +} > + > here as well REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18954 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18954: Add missing XdgShellPopup::ackConfigure

zzag added inline comments. INLINE COMMENTS > xdgshell.h:595 > + * request, passing along the @p serial of the configure event. > + * @see configureRequested > + **/ Also, maybe @since? REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

Force reset of kwayland

I merged someone else's commit by mistake which wasn't accepted. It was force reset immediately afterwards. Hopefully won't have affected anyone Sorry David

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty added a reviewer: broulik. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18940: Add battery icons

filipf added a comment. Nice. Shouldn't the plug here be green, same as everywhere else? F6611280: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: filipf, trickyricky26,

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

hausmann created this revision. hausmann added a reviewer: vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hausmann requested review of this revision. REVISION SUMMARY Perform additional sanity checking REPOSITORY

D18953: Update copy paste error in XdgShellPopupStable member vars

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18953 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/16/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 13:46:49 + Build duration: 5 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 13:53:39 + Build duration: 9 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 14:04:39 + Build duration: 10 min and counting BUILD ARTIFACTS

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

apol added a comment. Would it make sense to just install it in libexec and remove the difference between platforms? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18725 To: sitter, davidedmundson, dfaure Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added a comment. Oh, we could maybe use GNUInstallDirs.cmake's LIBEXECDIR on !Win32? like so: https://phabricator.kde.org/P317 I am not sure if there are any downsides to this. CMake code-wise I am not sure we should workaround implementation details of ECM in such a way.

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty added a comment. Wait, I forgot the dark versions :D REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik Cc: trickyricky26, kde-frameworks-devel, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

vkrause updated this revision to Diff 51524. vkrause added a comment. Update indentation, add docs link, remove ancient copy from attic. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18943?vs=51473=51524 BRANCH master REVISION DETAIL

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik, ngraham Cc: ngraham, trickyricky26, kde-frameworks-devel, michaelh, bruns

D18957: Use natural sorting in ActivityModel

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY ActivityModel sorts internally. It currently does a non-locale

D18954: Add missing XdgShellPopup::ackConfigure

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > xdgshell.cpp:367 > +} > + > + Please remove one extra new line. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18954 To:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 13:55:35 + Build duration: 4 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/17/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 13:53:39 + Build duration: 5 min 1 sec and counting BUILD ARTIFACTS

D18582: Add explicit SurfaceInterface::commited signal

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b2f67e1db7ea: Add explicit SurfaceInterface::commited signal (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18582?vs=50431=51502#toc REPOSITORY R127 KWayland

D14661: Force reevaluation of Predicates if interfaces are removed

volkov added a comment. I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the device's properties still have Optical=true. Adding "updateBackend(udi);" before "emit

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 13:46:49 + Build duration: 5 min 39 sec and counting JUnit Tests Name:

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added a comment. Generally yes, I am not sure we can do that very well for 5.x though. The LIBEXEC_INSTALL_DIR where `kioslave` is installed is controlled by ECM, that's where the conditional split between suffix-or-not happens, so unless we add another LIBEXEC_INSTALL_DIR_REAL which

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH flash-monochrome-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18959

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty added a comment. In D18959#410830 , @ngraham wrote: > Looks great! Thanks! :D REPOSITORY R266 Breeze Icons BRANCH flash-monochrome-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty,

D18940: Add battery icons

trickyricky26 added a comment. I like it! Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part ends? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940

D18952: new find module for Canberra

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18954: Add missing XdgShellPopup::ackConfigure

davidedmundson marked 3 inline comments as done. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18954 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

kossebau added a comment. Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik Cc: trickyricky26, kde-frameworks-devel, michaelh, ngraham, bruns

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great! REPOSITORY R266 Breeze Icons BRANCH flash-monochrome-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18959 To: rooty, #vdg, broulik, ngraham

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. eh... LGTM and nobody seems to have a big problem with it either. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18725 To: sitter, davidedmundson,

D18954: Add missing XdgShellPopup::ackConfigure

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9c95e203eae7: Add missing XdgShellPopup::ackConfigure (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18954?vs=51493=51500#toc REPOSITORY R127 KWayland CHANGES

D18953: Update copy paste error in XdgShellPopupStable member vars

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6ddb12dc7304: Update copy paste error in XdgShellPopupStable member vars (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D18813: Filter out invalid content in lists

This revision was automatically updated to reflect the committed changes. Closed by commit R304:1f4e1a6db756: Filter out invalid content in lists (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18813?vs=51169=51501 REVISION DETAIL

D18950: KCompressionDevice: reset error in open() to allow reuse of object

apol added inline comments. INLINE COMMENTS > kcompressiondevice.cpp:159 > } > +d->resetErrorCode(); > d->bOpenedUnderlyingDevice = false; Can't you just reset it here without creating a new function that is just used once? REPOSITORY R243 KArchive REVISION DETAIL

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty updated this revision to Diff 51513. rooty added a comment. Raise horizontal bars (memory stick icons) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18959?vs=51510=51513 BRANCH flash-monochrome-icon (branched from master) REVISION DETAIL

D18959: [breeze-icons] Add monochrome/smaller SD card and memory stick icons

rooty updated this revision to Diff 51517. rooty added a comment. Add dark versions REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18959?vs=51513=51517 BRANCH flash-monochrome-icon (branched from master) REVISION DETAIL

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:390 > yes, but just `const QString fname = ...` Right, sorry, misprinted. Actually, since there are a lot of `decodeName` calls around, probably it would be better to decode it just once, right before `event->mask`

D18952: new find module for Canberra

apol added inline comments. INLINE COMMENTS > FindCanberra.cmake:4 > +# > +# CANBERRA_FOUND- true if libcanberra was found > +# CANBERRA_LIBRARIES- libcanberra libraries to link against Maybe you can follow the style (rst syntax?) that Volker used here D18944

D18949: R Markdown: improve folding of blocks

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, at least as far I read the diff in the folding test. REPOSITORY R216 Syntax Highlighting BRANCH improve-rmarkdown REVISION DETAIL

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 19:56:24 + Build duration: 5 min 10 sec and counting BUILD ARTIFACTS

D18965: Guard KCompressionDevice::open being called with no backend available

ngraham added reviewers: Plasma, Frameworks. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixes the crash for me and makes logical sense. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D18940: Add battery icons

ndavis added a comment. In D18940#410649 , @trickyricky26 wrote: > I like it! > Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part

D18734: Update octave.xml to Octave 4.2.0

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think this is fine now, but I would like to have some autotests input file to have something we can later check for regressions. Could you provide some MIT or otherwise

D18949: R Markdown: improve folding of blocks

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7e5803a22374: R Markdown: improve folding of blocks (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D18734: Update octave.xml to Octave 4.2.0

sirgienko added a comment. In D18734#410977 , @cullmann wrote: > I think this is fine now, but I would like to have some autotests input file to have something we can later check for regressions. > Could you provide some MIT or otherwise

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

nibags accepted this revision. nibags added a comment. It's good, I think it's a better solution ;D REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel,

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

cullmann added a comment. I am ok with the change, but I would like to have one test case in REVISION DETAIL https://phabricator.kde.org/D17949 To: loh.tar, #ktexteditor, mwolff Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, michaelh, ngraham,

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is a useful addition, the license is ok, there is a test case and no old tests regress. I am not sure how good the coverage for the generated highlightings is, but at

D18793: Handle text completion with block selection mode

cullmann added a reviewer: KDevelop. cullmann added a comment. KDevelop uses the completion extensively, perhaps there is some opinion about this change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir, #ktexteditor, cullmann, dhaumann,

D18894: [RFC] General config interface

cullmann added a comment. First: the current framework for settings suck, I feel guilty. Second: I think a QVariant based approach would be nicer. I should think about how to do that best. Dominik, didn't you have some generic property stuff in your TikzKit? REPOSITORY R39

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 20:01:35 + Build duration: 1 min 55 sec and counting BUILD ARTIFACTS

D18960: Add compile check to FindEGL

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hmm, is source == binary directory allowed at all? I would prefer to generate the files into a different directory, e.g. ${CMAKE_CURRENT_BINARY_DIR}/syntax/generated, that

D18968: Word-drap KMessageWidget text

ngraham updated this revision to Diff 51538. ngraham added a comment. Add a TODO: to the comment REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51536=51538 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:47:34 + Build duration: 6 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 124 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/124/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 12 Feb 2019 20:07:04 + Build duration: 3 min 37 sec and counting JUnit

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann commandeered this revision. cullmann edited reviewers, added: nibags; removed: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel,

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann updated this revision to Diff 51542. cullmann added a comment. I would propose this, OK for you? REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18746?vs=50913=51542 REVISION DETAIL https://phabricator.kde.org/D18746 AFFECTED FILES

D18972: Format EXIF photo flash data

astippich added a comment. The data is taken from exiv2 library: https://github.com/Exiv2/exiv2/blob/master/src/tags_int.cpp#L348 Unfortunately, reusing that data would introduce a lot of #ifdefs in the code, hence I added it to KFileMetaData. This is the only property remaining that

D18968: Word-drap KMessageWidget text

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. ngraham requested review of this revision. REVISION SUMMARY Word-wrap KMessageWidget text to prevent the window from being widened when the text

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 2 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 1 min 40 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 19:56:24 + Build duration: 1 min 21 sec and counting JUnit Tests

D18968: Word-drap KMessageWidget text

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. I would just remove the comment. The commit references the bug anyway, and a bug reference in the code is only helpful if the code is wrong, and someone wants to understand why. REPOSITORY

D18957: Use natural sorting in ActivityModel

apol added inline comments. INLINE COMMENTS > activitymodel.h:132 > struct InfoPtrComparator { > bool operator() (const InfoPtr& left, const InfoPtr& right) const > { Do you think it would be possible to store the collator elsewhere? Re-creating it is a bit expensive to

D18948: CubeScript: fixes line continuation escape in strings

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. You can add a unit test, you just need to add a small .syntax file in addition to the test, e.g. see

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 122 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/122/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 7 min 10 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 19:57:48 + Build duration: 1 min 18 sec and counting JUnit Tests

D18734: Update octave.xml to Octave 4.2.0

cullmann added a comment. Good question: I added a minimal howto to the README.md: https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978 Does that help you? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:56:24 + Build duration: 1 min 55 sec and counting BUILD ARTIFACTS

D18972: Format EXIF photo flash data

astippich created this revision. astippich added a reviewer: ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Translate the number of the EXIF photo data to a human readable

D18965: Guard KCompressionDevice::open being called with no backend available

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If KArchive is built without support for a compression type, such as bzip2, d->filter ends up as null.

D18940: Add battery icons

ndavis added a comment. In D18940#410688 , @filipf wrote: > Nice. Shouldn't the plug here be green, same as everywhere else? > > F6611280: image.png This was fixed in the last change REPOSITORY

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:58:20 + Build duration: 1 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 20:07:04 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. In D18907#410973 , @cullmann wrote: > I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. The **this** pointer of Loader::createSpeller is const, so the

D18968: Word-drap KMessageWidget text

ngraham added a comment. Well, the code is not wrong but rather incomplete. :) Do you want me to remove the `TODO: ` too? REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To:

D18907: Handle the case if createSpeller is passed an unavailable language

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. I would appreciate a comment what the "lang" param is and that

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 19:44:24 + Build duration: 3 min 14 sec and counting BUILD ARTIFACTS

D12950: add test which checks the property types

astippich updated this revision to Diff 51550. astippich added a comment. - fix space REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12950?vs=48691=51550 BRANCH property_tests REVISION DETAIL https://phabricator.kde.org/D12950 AFFECTED FILES

D12950: add test which checks the property types

astippich added a comment. If no-one objects, I will land this next week REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D18972: Format EXIF photo flash data

astippich added inline comments. INLINE COMMENTS > ngraham wrote in formatstrings.cpp:103 > Does this one mean "present but did not fire" or "there is no flash with this > hardware"? If the latter, I might suggest instead "None". Otherwise this is > fine the way it is. Strictly this means

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Feb 2019 06:12:38 + Build duration: 1 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Feb 2019 04:54:22 + Build duration: 9 min 49 sec and counting BUILD ARTIFACTS

D18940: Add battery icons

ndavis added a comment. In D18940#411154 , @ngraham wrote: > So I guess this means some duplication between the Breeze icon theme and the Breeze Plasma theme for a while, right? Not 100%. I need to make a device icon for an

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Feb 2019 06:12:38 + Build duration: 2 min 5 sec and counting BUILD ARTIFACTS

D18968: Word-wrap KMessageWidget text

ngraham updated this revision to Diff 51551. ngraham added a comment. Remove bug number in comment REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51538=51551 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION

  1   2   >