Re: CI system maintainability

On Thursday, 28 March 2019 09:50:47 CET Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote: > > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto: > > > at your screen or pair with you" in the past. Clearly this compromise > > > gets > >

D20085: Expose a method to show the context menu of an applet from QML

apol added a dependent revision: D20093: Show a context menu on pressAndHold. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20085 To: apol, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18845: authority: add support for passing details to polkit

mgerstner added a comment. In D18845#439430 , @ngraham wrote: > @mgerstner can you provide your email address so we can land this patch with correct authorship information? It's matthias.gerst...@suse.com. REVISION DETAIL

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 11:27:44 CET Daniel Vrátil wrote: > I'm completely fine with mandatory code review for everything and I'd be > happy to have this in PIM. I think the biggest problem in PIM to overcome > will be finding the reviewers - I dare say I'm currently the only one who >

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > I'm completely fine with mandatory code review for everything and I'd be > happy to have this in PIM. I think the biggest problem in PIM to overcome > will be finding the reviewers - I dare say I'm currently the only one who > has

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens: > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

D20092: New class KOSRelease - a parser for os-release files

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY Imported form KInfoCenter along with test case. This also includes a license change from GPL to LGPL. When working

D19092: Add bison minimum version of 2.4.1 due to %code

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I'm for this. I never created such a patch because I wasn't sure what minimum version was needed. On Mac, what I do is install the homebrew bison and export

D20085: Expose a method to show the context menu of an applet from QML

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. looking at D20093 made me rething this, the least intrusive one in the end seems really the first version, with explicit check of formfactor

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: > I am against to force mandatory review, as it will create a lot of lose of > time, As I said, unpopular. > and we will not be sure that review is correct (see comment from > Volker about "transaction lock regression") This

D20063: Sublime Merge Icon.

otavva added a comment. Updated it. @ndavis Done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh,

D20092: New class KOSRelease - a parser for os-release files

sitter added a reviewer: apol. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

otavva updated this revision to Diff 54981. otavva edited the summary of this revision. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54935=54981 REVISION DETAIL https://phabricator.kde.org/D20063 AFFECTED FILES

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. Whoops. I have a mix-up between two machines on which code is on, this compiles on one I've developed it on (no _urls/urls change), but not on one I've pushed from. I'll update this in several hours. REPOSITORY R241 KIO REVISION DETAIL

Re: CI system maintainability

In data giovedì 28 marzo 2019 10:17:18 CET, Tomaz Canabrava ha scritto: > The problem is that a git comit is a git commit, there's no way that a > typo will be treated differently then another commit. It's a "social" problem and not a technical one: you can see it across repositories managed by

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 10:08:54 CET Luca Beltrame wrote: > In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto: > > I'd argue we're loosing more with the current state of PIM than we'd loose > > with mandatory reviews. > > Perhaps, instead of an all-or-nothing

Re: CI system maintainability

In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto: > OK, to be fair not 100% today's situation because of the above. It was based > on best judgment maybe we're missing such a set of guidelines. I admit I'm > slightly doubtful though. I can't claim it may work 100%, but I've

D20085: Expose a method to show the context menu of an applet from QML

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20085 To: apol, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: CI system maintainability

On Thu, Mar 28, 2019 at 7:56 PM Konstantin Kharlamov wrote: > > > > On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote: > > Hi all, > > > > We currently have a rather substantial issue, in that the CI system > > has been once again left in a position where it isn't possible to make > > any changes

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann accepted this revision. cullmann added a comment. I am ok with this ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19876 To: nibags, #ktexteditor, #kate, cullmann, mwolff Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad,

Re: CI system maintainability

In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto: > at your screen or pair with you" in the past. Clearly this compromise gets > somewhat exploited and that's especially bad in the case of a fragile and > central component like KDE PIM. I'm not sure I agree. I can't speak for

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote: > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto: > > at your screen or pair with you" in the past. Clearly this compromise gets > > somewhat exploited and that's especially bad in the case of a fragile and >

Re: CI system maintainability

In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto: > I'd argue we're loosing more with the current state of PIM than we'd loose > with mandatory reviews. Perhaps, instead of an all-or-nothing approach, why not a minimal set of "requirements" that would require a review? Yes, it

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > Please note that the commits in this instance were pushed without > review, so restrictions on merge requests wouldn't make a difference > in this case unfortunately. Maybe it's about time to make reviews mandatory... I know

D20083: Multiple level of autobrace

cactus added a comment. Oh, I'm sorry. I did not see that. I'm waiting this feature for a while. I am glad this is fix. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20083 To: cactus Cc: loh.tar, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,

Re: CI system maintainability

Kevin Ottens schrieb am Do., 28. März 2019, 09:29: > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

Re: CI system maintainability

Hi Laurent, Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > For example I works all days on kde (pim or other) when I wake up, or at > noon after my lunch or the evening, I will not wait several days for a > review because nobody has time to do it. > > (For example I make ~

Re: CI system maintainability

In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto: > In this case, it seems like the problem is that there are certain > individuals or teams that are pushing risky, breaking changes without code > review, and then ignoring failures in the CI. I think we might do well to > try to

D20085: Expose a method to show the context menu of an applet from QML

apol updated this revision to Diff 54991. apol added a comment. boop REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20085?vs=54967=54991 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20085 AFFECTED FILES

Re: CI system maintainability

On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > > I'm completely fine with mandatory code review for everything and I'd be > > happy to have this in PIM. I think the biggest problem in PIM to overcome

Re: CI system maintainability

Thanks for reply. More below: Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > Hi Laurent, > > > > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > > For example I works all days

Re: CI system maintainability

Hi, > Hi, > > On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote: > >> Hello, >> >> On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: >> > I am against to force mandatory review, as it will create a lot of lose >> of >> > time, >> >> As I said, unpopular. >> > > I don't get why

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 10:35:37 CET Luca Beltrame wrote: > In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto: > > OK, to be fair not 100% today's situation because of the above. It was > > based on best judgment maybe we're missing such a set of guidelines. I > >

D20077: Accept any HTTP status between 100 and 199 as benign

This revision was automatically updated to reflect the committed changes. Closed by commit R235:7e988d655db2: Accept any HTTP status between 100 and 199 as benign (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20077?vs=54928=54972

Re: CI system maintainability

On Thursday, 28 March 2019 16:32:34 CET Luca Beltrame wrote: > In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto: > > In this case, it seems like the problem is that there are certain > > individuals or teams that are pushing risky, breaking changes without code > > review, and

Re: CI system maintainability

On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote: > I agree. Mandatory reviews might work if there is a team of active people > working on a project, but if there is only one person with real knowledge of > the code We do have common ownership of code, so if there is only one person with

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

apol added inline comments. INLINE COMMENTS > qtquicksettings.cpp:47 > +if (s.graphicsResetNotifications() || > +QLibraryInfo::version() >= QVersionNumber(5, 13, 0)) { > format.setOption(QSurfaceFormat::ResetNotification); Shouldn't this check be in

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I will not wait several days for

Re: CI system maintainability

On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I will not wait several days for a > >

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY glibc 2.28 provides a statx function that is stubbed on old linux systems or file

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

davidedmundson added a comment. It's autogenerated, so non-trivial REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20087 To: davidedmundson Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kosrelease.h:34 > + * > + * os-release is a free software standard for describing an operating system. > + * This class parses and models os-release files. it's

Re: CI system maintainability

Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > Hi Laurent, > > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I will not wait several

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. ¯\_(ツ)_/¯ REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D20087 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D20095: Reduce the importance of some debug information so actual warnings can be seen.

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D20092: New class KOSRelease - a parser for os-release files

sitter updated this revision to Diff 54993. sitter added a comment. - doc wording - disable cctor. no real use case for copy at this point REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20092?vs=54985=54993 BRANCH master REVISION DETAIL

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 54997. meven added a comment. Removed empty file. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=54996=54997 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. @ngraham , I have a problem with toLocalFile() which I'm not sure how to solve. Namely, from docs: > qDebug() << QUrl("file.txt").toLocalFile(); // ""; wasn't a local file as it had no scheme KUrlNavigator's locationUrl() doesn't

D20032: Convert string formatting tests to be data driven

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Re: CI system maintainability

In data giovedì 28 marzo 2019 16:04:01 CET, Boudhayan Gupta ha scritto: > I don't get why mandatory code reviews are so unpopular. It's not "unpopular". As far as the discussion goes, the opinions (from several parties) say that they're not a silver bullet, and that some projects benefit from

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 16:04:01 CET schrieb Boudhayan Gupta: > I don't care if you lose time. I don't want the guys building my house to > cut corners mixing my concrete because it's going to save time. There is a difference here though, no? The people building your house will not live in

D20092: New class KOSRelease - a parser for os-release files

apol added a subscriber: mpyne. apol added a comment. @mpyne is KCoreAddons maintainer, maybe he has some comments on the new class. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: mpyne, kde-frameworks-devel,

Re: CI system maintainability

Hi, On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: > > I am against to force mandatory review, as it will create a lot of lose > of > > time, > > As I said, unpopular. > I don't get why mandatory code reviews are so

Re: CI system maintainability

Hi, (Sorry for top-posting) I fear that a mandatory reviews would add too juch strain on smaller teams. If there's just one person with an intimate knowledge of the code-base, plus two co-developers, then who should do the reviews? How about a distinction based on importance of a project

Re: CI system maintainability

On Thu, Mar 28, 2019, 6:36 AM Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens: > > Hello, > > > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > > Please note that the commits in this instance were pushed without > > > review, so

Re: CI system maintainability

On Thursday, March 28, 2019 9:50:47 AM CET Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote: > > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto: > > > at your screen or pair with you" in the past. Clearly this compromise > > > gets

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY I added support in Qt for handling Nvidia's glGetGraphicsResetStatus flag, which reports when it has

Re: CI system maintainability

Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit : > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a comment. ping? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: CI system maintainability

With regards to the discussion about mandatory code review, I think it's important to avoid immediately rushing to create new policy as a result of a particular event or abuse. It's always tempting to try to put in place a rule that would have avoided the problem if it had existed and was being

Re: CI system maintainability

On Thu, Mar 28, 2019 at 10:09 AM Luca Beltrame wrote: > > In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto: > > I'd argue we're loosing more with the current state of PIM than we'd loose > > with mandatory reviews. > > Perhaps, instead of an all-or-nothing approach, why not a

Re: CI system maintainability

On 28 March 2019 13:33:59 GMT, laurent Montel wrote: > Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit : > > Hello, > > > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > > Please note that the commits in this instance were pushed without > > > review, so

Re: CI system maintainability

On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote: Hi all, We currently have a rather substantial issue, in that the CI system has been once again left in a position where it isn't possible to make any changes to the system. This means we can't update to newer versions of packages, add new

D20104: [balooshow] Several extensions basic file information output

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the file is specified by name, but the file name

D20105: ecm_add_wayland_client_protocol: Improve error messages

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of passing the data from stdin, pass the path,

D20092: New class KOSRelease - a parser for os-release files

apol added a comment. LGTM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a comment. Is it OK to commit this now? It looks like the next tagging is April 6th REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks, winterz Cc: winterz,

D20105: ecm_add_wayland_client_protocol: Improve error messages

apol updated this revision to Diff 55012. apol added a comment. for generating server files too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20105?vs=55011=55012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20105 AFFECTED

D20101: [timeline] Canonicalize Url

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case someone removes everything but the

D20100: [timeline] Fix warning, add missing UDS entry for "."

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY kf5.kio.core: UDSEntry for '.' not found,

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileitem.cpp:86 > * Computes the text and mode from the UDSEntry > * Called by constructor, but can be called again later > * Nothing does

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/67/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Mar 2019 21:34:53 + Build duration: 10 min and counting BUILD ARTIFACTS

Re: CI system maintainability

Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > Thanks for reply. More below: > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > > Hi Laurent, > > > > > > Am Donnerstag,

Re: CI system maintainability

Hi, On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote: > Hi, > > On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote: > > Hello, > > > > On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: > > > I am against to force mandatory review, as it will create a lot of lose > > > > of > >

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Remember to update the commit log so it doesn't keep saying "First attempt, not necessarily the right one." :-) REPOSITORY R241 KIO BRANCH arcpatch-D19824 REVISION DETAIL

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven added a comment. In D19824#439896 , @dfaure wrote: > Remember to update the commit log so it doesn't keep saying "First attempt, not necessarily the right one." :-) Thanks ! REPOSITORY R241 KIO REVISION DETAIL

D20102: [timeline] Fix missing/misplaced SlaveBase::finished() calls

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Each stat()/mimetype()/listDir() call has to

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D19824 REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bea5b68142e4: KFileWidget In saving single file mode an enter/return press on the… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/53/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Mar 2019 21:34:53 + Build duration: 7 min 48 sec and counting BUILD ARTIFACTS

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags updated this revision to Diff 55004. nibags marked an inline comment as done. nibags added a comment. - Fix attributes in "KDE" and "Vim (dark)" themes I found a small bug in this patch. In the "KDE" and "Vim (dark)" schemas, hard colors and text backgrounds, defined in XML files,

CI system maintainability

Hi all, We currently have a rather substantial issue, in that the CI system has been once again left in a position where it isn't possible to make any changes to the system. This means we can't update to newer versions of packages, add new packages or correct for binary incompatible changes