KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/78/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 13 min and counting BUILD ARTIFACTS

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich retitled this revision from "Restore mobipocket extractor" to "Get mobipocket extractor up-to-date, but keep disabled". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc:

D17500: Restore mobipocket extractor

astippich updated this revision to Diff 55848. astippich added a comment. - rebase and update - update test - disable mobi extractor REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47335=55848 BRANCH mobi REVISION DETAIL

D17500: Get mobipocket extractor up-to-date, but keep disabled

ltoscano added a comment. So no plans for moving it to kdegraphics-mobipocket? It's a dependency loop. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson,

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think a KIO dependency for such a library is inconvenient. REPOSITORY R286

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

broulik abandoned this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D14290 To: broulik, dfaure Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

broulik abandoned this revision. broulik added a comment. Herald added a subscriber: kde-frameworks-devel. Superseded by D10657 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 145 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/145/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 9 min 32 sec and counting CONSOLE OUTPUT

D19908: [ConfigModule] Pass initial properties

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19908: [ConfigModule] Pass initial properties

broulik added a comment. Pingeliping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 2 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/78/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 18:49:32 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 21:55:02 + Build duration: 26 min and counting BUILD ARTIFACTS

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55850. meven added a comment. Fix src/ioslaves/file/ConfigureChecks.cmake REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55849=55850 BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in file.cpp:850-870 > No, he means using a const& for the argument, e.g: > > inline static uint16_t stat_mode(struct statx ) { return buf.stx_mode; } Thanks REPOSITORY R241 KIO BRANCH

D20367: Add alternatives icon

Codezela added a comment. I think in small size it will be difficult to recognize this icon because it has a lot of datils we need to use more simple version of it I found this on the web as example of what I mean we can review them as a base

D17500: Get mobipocket extractor up-to-date, but keep disabled

aacid added a comment. In D17500#446937 , @astippich wrote: > The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think

D20422: KZip: fix Heap-use-after-free in broken files

aacid added a subscriber: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20422 To: aacid Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20422: KZip: fix Heap-use-after-free in broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY when compiling with no asserts Broken oss-fuzz file doesn't crash anymore REPOSITORY R243 KArchive BRANCH master

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55849. meven added a comment. Use passing references to stat_xxx accessors, use a signed long long for file size REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55709=55849 BRANCH arcpatch-D20096 REVISION DETAIL

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

bruns added a comment. In D10657#446950 , @broulik wrote: > Superseded by D10657 Superseded by itself? D19677 ? REPOSITORY R245 Solid REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure added inline comments. INLINE COMMENTS > arrowd wrote in urlinfo.h:39 > > const QString & > > There is `path.chop(match.capturedLength());`, which requires non-const > `QString`. > > > And what if it's a URL? At this point this string is pathOrUrl. > > Well, `if (QFile::exists(path))`

D20042: Show the plasmoid context menu on long tap

apol added a comment. In D20042#446770 , @ngraham wrote: > That seems... quite sub-optimal to me. > > Is all of this to preserve press-and-hold for moving widgets? Is there a centralized place for this discussion? If not I can create a Phab

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

aacid added a comment. In the "Add Action..." combo you should have an "Abandon" option REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh,

D20358: Force en locale for propertyinfotest

astippich added a comment. https://bugreports.qt.io/browse/QTBUG-75069 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

astippich added a comment. windows build fails https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/143/console REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20133 To: bruns, #baloo, #frameworks, #windows, #freebsd,

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added a comment. In D20312#446923 , @svuorela wrote: > In D20312#445122 , @ahmedbilal wrote: > > > > > > > > > @svuorela If system have user with same Real Name it would return

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

svuorela added a comment. In D20312#445122 , @ahmedbilal wrote: > > @svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there

D19445: Handle variant list in formatting functions

apol added inline comments. INLINE COMMENTS > propertyinfo.cpp:650 > +for (const auto& entry : valueList) { > +displayList << (d->formatAsString)(entry); > +} `displayList << d->formatAsString(entry);` REPOSITORY R286 KFileMetaData

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/67/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 21:55:02 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/63/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Apr 2019 21:55:02 + Build duration: 17 min and counting BUILD ARTIFACTS

D20417: Add invokable public API for emitting contextualActionsAboutToShow

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This signal is emitted just before showing the context menu to

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/79/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/80/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 10 Apr 2019 00:42:51 + Build duration: 1 min 13 sec and counting JUnit Tests Name:

D20422: KZip: fix Heap-use-after-free in broken files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20422 To: aacid, apol Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 34 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 146 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/146/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 31 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 147 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/147/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Apr 2019 00:42:50 + Build duration: 3 min 7 sec and counting JUnit Tests

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

nhiga created this revision. nhiga added a reviewer: kde-frameworks-devel. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY If Krusader is installed, the `krarc` protocol is available and Dolphin may use it to open ZIP archives. In this case, when

D20425: KateIconBorder: Code cosmetic

loh.tar created this revision. loh.tar added a reviewer: cullmann. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY There should be no logic

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/75/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 00:42:50 + Build duration: 8 min 54 sec and counting BUILD ARTIFACTS

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

nathanshearer added a comment. Hi Christoph, I just wanted to say thanks for working on this. It will be great when I can interact with these files again via KDE and its suite of apps. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18161 To: cfeck, #frameworks,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/74/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/79/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 00:05:33 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/80/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Apr 2019 00:42:51 + Build duration: 8 min 25 sec and counting BUILD ARTIFACTS

D20233: Add syntax highlighting for fish shell

adiestelhorst added a comment. I found nothing helpfull for this question. There is still the list of Unix commands, where I did only small additions and which is nearly half the lines of code. When in doubt, I think it is better to stick to the rules. So I would like to keep it LGPL.

D19913: [plasma-desktop] make it compiles without foreach

mlaurent added inline comments. INLINE COMMENTS > broulik wrote in coronatest.cpp:216 > why not make the container `const`? Because this variable is use in code see line 228 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure

D19913: [plasma-desktop] make it compiles without foreach

broulik added inline comments. INLINE COMMENTS > coronatest.cpp:150 > +const auto containments = m_corona->containments(); > +for (auto cont : containments) { > switch (cont->id()) { Please always annotate `auto` with e.g. asterisk or ampersand depending on type >

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 55796. mlaurent added a comment. Rename some variables REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=54920=55796 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19960: bluez-qt: remove warnings

tcanabrava added a comment. ping? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D15318: Automatically re-upload saved files located on remote locations instead of asking first

maverick74 added a comment. That would be great! It looks very bad the way it is ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: maverick74, elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/62/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Apr 2019 13:41:00 + Build duration: 7 min 7 sec and counting BUILD ARTIFACTS

D20342: Update KDE logo to be closer to original

This revision was automatically updated to reflect the committed changes. Closed by commit R266:1bc240faf1c0: Update KDE logo to be closer to original (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20342?vs=55772=55818 REVISION

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/66/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 13:41:00 + Build duration: 3 min 42 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 13:41:00 + Build duration: 4 min 22 sec and counting BUILD ARTIFACTS

D19736: Add screen-rotate-auto-on/off

ndavis updated this revision to Diff 55804. ndavis added a comment. - Change to 3 icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=53826=55804 BRANCH rotate (branched from master) REVISION DETAIL https://phabricator.kde.org/D19736

D19736: Add view-orientation-auto/landscape/portrait

ndavis retitled this revision from "Add screen-rotate-auto-on/off" to "Add view-orientation-auto/landscape/portrait". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736

D18933: Allow compositors to send discrete axis values

zzag retitled this revision from "Allow compositors to send discrete axis deltas" to "Allow compositors to send discrete axis values". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh,

D19736: Add view-orientation-auto/landscape/portrait

ngraham added a comment. How about a lock icon inside the rectangles to show that they're locked to that orientation? Those vertical and horizontal lines in the current version conjure up movement in my mind, which doesn't seem appropriate. REPOSITORY R266 Breeze Icons REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

ngraham added a comment. So are we ready to land this, or is there anything left to do? REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D18933: Allow compositors to send discrete axis deltas

zzag retitled this revision from "Send optional events from wl_pointer v5" to "Allow compositors to send discrete axis deltas". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham,

D20042: Show the plasmoid context menu on long tap

ngraham added a comment. That seems... quite sub-optimal to me. Is all of this to preserve press-and-hold for moving widgets? Is there a centralized place for this discussion? If not I can create a Phab task for it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D19445: Handle variant list in formatting functions

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19960: bluez-qt: remove warnings

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH remove_compile_warnings REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca Cc: pino, kde-frameworks-devel,

Re: New framework: KCalCore

On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > covering the

D19960: bluez-qt: remove warnings

ngraham added a comment. @drosca I think you'll have to land this for @carneirogustavo. REPOSITORY R269 BluezQt BRANCH remove_compile_warnings REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric, drosca Cc: ngraham, pino,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

anthonyfieroni added inline comments. INLINE COMMENTS > file.cpp:850-870 > +inline static uint16_t stat_mode(struct statx buf) { return buf.stx_mode; } > +inline static uint32_t stat_dev(struct statx buf) { return > buf.stx_dev_major; } > +inline static uint64_t stat_ino(struct statx buf) {

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

ngraham added a dependent revision: D20404: Allow the baloo widgets to display creation date and access date.. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino,

Re: New framework: KContacts

On Tuesday, 9 April 2019 03:11:57 CEST Aleix Pol wrote: > On Sat, Apr 6, 2019 at 6:02 PM Volker Krause wrote: > > Hi, > > > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > > > KContacts is essentially an implementation of the vCard standard, covering > > the data

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in file.cpp:850-870 > We can get all stat_xxx functions buf as reference, struct is not needed when > you use C++. Do you mean the struct keyword in the argument in "inline static uint16_t stat_mode(struct statx buf) { return

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in file.cpp:850-870 > Do you mean the struct keyword in the argument in "inline static uint16_t > stat_mode(struct statx buf) { return buf.stx_mode; } " for instance ? Unfortunately this is not

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19960: bluez-qt: remove warnings

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Actually ... INLINE COMMENTS > a2dp-codecs.c:59 > AAC_OBJECT_TYPE_MPEG4_AAC_SCA, */ > -AAC_INIT_FREQUENCY( > +AAC_INIT_FREQUENCY(( > /*AAC_SAMPLING_FREQ_8000 |

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

pino added inline comments. INLINE COMMENTS > meven wrote in file.cpp:850-870 > Unfortunately this is not possible here : statx is also a function, the > compiler gets messed up when removing the struct keyword interpreting it as a > function call. > > > /file/file.cpp:850:34: warning: inline