D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent updated this revision to Diff 56136. mlaurent added a comment. Add missing qAsConst REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20489?vs=56058=56136 BRANCH port_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20489

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent added a comment. "But yeah, if people could add NO_CHANGELOG somewhere in the commit log it would make this easier. Laurent, can you do that for mechanical commits such as this one?" no problem for adding [NO_CHANGELOG] in commit message REPOSITORY R241 KIO REVISION DETAIL

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. FYI NO_CHANGELOG doesn't have to be in the first line (which would make noise in phab review titles for new requests, etc). It can be a line of its own, for example towards the end of the

D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. KF5 coding style: if (...) { ... } REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20506 To: dfaure, cfeck Cc:

D20508: [udisks2] fix media change detection for external optical drives

ngraham retitled this revision from "frameworks-solid: udisks2: fix media change detection for external optical drives" to "[udisks2] fix media change detection for external optical drives". ngraham edited the summary of this revision. ngraham added reviewers: bruns, broulik, dfaure, Frameworks.

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

kossebau added inline comments. INLINE COMMENTS > iconitem.h:72 > - */ > -//KF6 Remove, this just shadows QQuickItem::smooth > -Q_PROPERTY(bool smooth READ smooth WRITE setSmooth NOTIFY smoothChanged) Actually unsure about whether we can remove this, other than claimed in prepared

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a comment. I believe QFile::decodeName returns fileNames without a trailing '/' It could be that it is the unmounted device that would need to remove its ending '/' REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik

D19450: DocumentPrivate: Respect indention mode when block selection

ngraham edited the summary of this revision. ngraham set the repository for this revision to R39 KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson,

D19450: DocumentPrivate: Respect indention mode when block selection

ngraham added reviewers: Kate, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking,

D19450: DocumentPrivate: Respect indention mode when block selection

This revision was automatically updated to reflect the committed changes. Closed by commit R39:78a2e5d1daa5: DocumentPrivate: Respect indention mode when block selection (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. F6771060: simplescreenrecorder-(2).mkv REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: kfm-devel, alexde, feverfew, meven, spoorun,

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56168. bruns added a comment. remove obsolete include REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56167=56168 BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20525 AFFECTED FILES

D20525: [InformationPanel] Use the new inline configuration mode

bruns created this revision. bruns added reviewers: Dolphin, Baloo, Frameworks, ngraham, astippich. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. bruns requested review of this revision. REVISION SUMMARY Depends on D20524 REPOSITORY

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added a dependent revision: D20525: [InformationPanel] Use the new inline configuration mode. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: gennad, domson, ashaposhnikov, astippich,

D20525: [InformationPanel] Use the new inline configuration mode

bruns added a comment. After selecting "Configure ..." from the context menu: F6771063: Screenshot_20190414_061013.png REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks,

D19608: DocumentPrivate: Make bracket handling smart

meven added a comment. I could have made the commit, but heh. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19608 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: meven, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns,

D20426: Improve "widget-alternatives" icon

GB_2 updated this revision to Diff 56111. GB_2 added a comment. Re-clean SVGs REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=55933=56111 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 70 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/70/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 07:25:52 + Build duration: 6 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/87/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 07:25:52 + Build duration: 5 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/84/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 07:25:52 + Build duration: 22 min and counting BUILD ARTIFACTS

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

meven edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D19254 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D20493: Introduce and use KArchiveDirectory::addEntryV2

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20493 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar updated this revision to Diff 56110. loh.tar added a comment. - Rebase on master to keep it compile - Not further investigated if changes by D19163 needs more tweeks here > PS: Better naming for foobar ? :-) Yes :-) > I think this

D19450: DocumentPrivate: Respect indention mode when block selection

loh.tar updated this revision to Diff 56115. loh.tar edited the summary of this revision. loh.tar added a comment. - Rebase on master No interest in this? An autotest (place) for this may KateDocumentTest::testReplaceTabs, but not sure. There are slightly other things checked. CHANGES

<    1   2