KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Apr 2019 09:31:46 + Build duration: 3 min 41 sec and counting BUILD ARTIFACTS

D20570: [FrameSvgItem] Respect smooth property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2a636d66712f: [FrameSvgItem] Respect smooth property (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56289=56290

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/79/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 11:40:11 + Build duration: 16 min and counting JUnit Tests Name:

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b9ac83d4d7f5: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: New framework: KCalCore

On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote: > On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote: > > On 14 April 2019 12:31:41 BST, David Faure wrote: > > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > > > Hi, > > > > > > > > I'd like to propose KCalCore

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/68/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 07:51:29 + Build duration: 2 hr 49 min and counting JUnit Tests Name:

D20570: [FrameSvgItem] Respect smooth property

broulik updated this revision to Diff 56289. broulik added a comment. - Also update corner nodes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56288=56289 REVISION DETAIL https://phabricator.kde.org/D20570 AFFECTED FILES

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56287. bruns marked 3 inline comments as done. bruns added a comment. bump baloo widgets version cleanup REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56194=56287 BRANCH cleanup REVISION DETAIL

D20525: [InformationPanel] Use the new inline configuration mode

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in informationpanelcontent.cpp:237 > Coding style: brace should go to next line (the function below is also > wrong...) The glory of copy and paste ;-) REPOSITORY R318 Dolphin REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/85/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:00:20 + Build duration: 2 days 0 hr and counting JUnit Tests Name:

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e70ebb44a17d: Retitle button Close to Close file when a file has been removed on disk (authored by meven). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20556: Keep empty Json metadata docs out of DocumentData DB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5a8f402b56de: Keep empty Json metadata docs out of DocumentData DB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20556?vs=56241=56278 REVISION

D20570: [FrameSvgItem] Respect smooth property

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > framesvgitem.cpp:95 > { > +setFiltering(filtering); > m_lastParent->appendChildNode(this); could have here frameSvg->smooth() ? QSGTexture::Linear :

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/86/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 10:22:00 + Build duration: 1 hr 28 min and counting JUnit Tests Name:

D20570: [FrameSvgItem] Respect smooth property

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Set `smooth: true`, rotated it, didn't look jagged anymore REPOSITORY R242 Plasma

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/76/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Apr 2019 10:46:41 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/78/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 09:31:46 + Build duration: 2 hr 8 min and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/68/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 15 Apr 2019 09:31:46 + Build duration: 40 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/69/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 15 Apr 2019 10:46:47 + Build duration: 10 min and counting BUILD ARTIFACTS

D20570: [FrameSvgItem] Respect smooth property

broulik planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

mart added a comment. FrameItemNode needs the same REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

On 15 April 2019 13:25:56 BST, Allen Winter wrote: > On Monday, April 15, 2019 6:40:06 AM EDT Daniel Vrátil wrote: > > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote: > > > On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote: > > > > On 14 April 2019 12:31:41 BST, David Faure

Re: New framework: KCalCore

On Mon, Apr 15, 2019 at 2:52 PM David Jarvie wrote: > > > > On 15 April 2019 13:25:56 BST, Allen Winter wrote: > > On Monday, April 15, 2019 6:40:06 AM EDT Daniel Vrátil wrote: > > > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote: > > > > On dimanche 14 avril 2019 19:46:02 CEST David

D18824: Implement wl_eglstream_controller Server Interface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:e208389cc68c: Implement wl_eglstream_controller Server Interface (authored by ekurzinger). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18824?vs=56078=56299

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/32/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Apr 2019 14:26:30 + Build duration: 15 min and counting BUILD ARTIFACTS

D20565: Ensure not to fold the end marker

loh.tar updated this revision to Diff 56306. loh.tar edited the test plan for this revision. loh.tar added a comment. - Adjust only on token based folding CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20565?vs=56267=56306 REVISION DETAIL https://phabricator.kde.org/D20565

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/36/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 14:26:29 + Build duration: 5 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 15 Apr 2019 14:26:30 + Build duration: 5 min 59 sec and counting BUILD ARTIFACTS

D20579: [FrameSvgItem] Update filtering on smooth changes

kossebau created this revision. kossebau added reviewers: Plasma, broulik, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When just the smooth property is changed, this also results in a

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56311. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56257=56311 BRANCH arcpatch-D20558 REVISION DETAIL

D20534: avoid conflicting shortcuts for switching tabs

ngraham added a comment. Thank you for this! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. In D20140#450349 , @GB_2 wrote: > Ping Sorry, I'm just busy right now and I'm not that familiar with QML, so it won't be quick and easy for me. REPOSITORY R296 KDeclarative REVISION DETAIL

D20534: avoid conflicting shortcuts for switching tabs

dhaumann added a comment. lgtm REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

cullmann added reviewers: dhaumann, ngraham. cullmann added a comment. I like the idea, its nice for e.g. if then else cascades, you get then out of stuff like if (blockwise || range.onSingleLine()) { lineStart = range.start().column(); remainingChars =

D20586: Sharpen Z's in system-suspend* icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY They weren't aligned to the pixel grid before. REPOSITORY R266 Breeze Icons BRANCH

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

GB_2 added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20283 To: ngraham, #plasma, mart Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

Re: grantlee commit access

[CC kde-frameworks-devel for information] Hi Stephen, Thanks for the merge of the Qt 5.13 build fix. I would certainly welcome grantlee as a KF5 framework, I think it makes things easier from a KDE point of view, and it reduces the bus factor in terms of who can actually push to the

D20586: Sharpen Z's in system-suspend* icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20586 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20586 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20589: Add QML to source code types

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R293 Baloo BRANCH qml REVISION DETAIL

D20428: separe mobile text selection to avoid recursive imports

broulik added inline comments. INLINE COMMENTS > ComboBox.qml:174 > id: mobileCursor > Private.MobileCursor { > target: textField Does this not need to be adjusted? `ComboBox` is broken here. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns updated this revision to Diff 56337. bruns added a comment. correct since version REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20524?vs=56206=56337 BRANCH metadata_config_inline REVISION DETAIL https://phabricator.kde.org/D20524

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns marked an inline comment as done. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

davidedmundson added a comment. > And @mart if you have some time, I could use a hand figuring out why flickable.contentHeight is always evaluating to 0 here. so right now this patch does nothing? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20283 To:

D20589: Add QML to source code types

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH qml REVISION DETAIL https://phabricator.kde.org/D20589 To: nicolasfella, #baloo, ngraham Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20586: Sharpen Z's in system-suspend* icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sharp-z (branched from master) REVISION DETAIL https://phabricator.kde.org/D20586 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

apol accepted this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol, mpyne Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns