KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 52 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/52/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 04 Jun 2019 11:30:23 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.59.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(451/2243)17%
(170/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(144/156)51%
(51/100)src100%
(8/8)100%
(8/8)68%
(223/329)49%
(88/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
   

D21574: Update KBruch icon

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Inspired from application-edu and cantor icon

TEST PLAN
  Screenshot comming

REPOSITORY
  R266 Breeze Icons

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons/apps/48/kbruch.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb edited the test plan for this revision.
ognarb added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb abandoned this revision.
ognarb added a comment.


  I don't have time and the motivation for this revision anymore.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, 
kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking, sars

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Méven Car]

meven added a comment.


  I have tested the new patch.
  It is a bit a workaround but does not edit any udi.
  What do you think ?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D21574: Update KBruch icon

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21565: phabricator: Fix fallthrough in switch

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:a520d9ea1800: phabricator: Fix fallthrough in switch 
(authored by aspotashev).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21565?vs=59080=59122

REVISION DETAIL
  https://phabricator.kde.org/D21565

AFFECTED FILES
  src/plugins/phabricator/quick/difflistmodel.cpp

To: aspotashev, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Nathaniel Graham]

ngraham added a comment.


  Nice! A line of dark pixels on the bottom would help it fit the style even 
better too. See https://hig.kde.org/style/icon.html#shadows

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D17595: Upstream Dolphin's file rename dialog

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much! \o/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: ngraham, #frameworks, #dolphin, broulik
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case a file is not in the index, either because it is new, or as it
  should not be indexed, there is no need to retrieve the timestamps from
  the file (it will be different).

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21577

AFFECTED FILES
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21574: Update KBruch icon

[Noah Davis]

ndavis added a comment.


  In D21574#474173 , @ognarb wrote:
  
  > Sorry it arc who also uploaded the png that I created for the review, I 
will fix it.
  
  
  Ah, fair enough. Easy mistake to make.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb updated this revision to Diff 59131.
ognarb added a comment.


  Add shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21574?vs=59123=59131

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons/apps/48/kbruch.png
  icons/apps/48/kbruch.svg

To: ognarb, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko, broulik.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Quite a few of the filter strings are exact matches without wildcards,
  add an extra QSet for these. This saves about 30% of the runtime cost
  of the FilteredDirIterator.

TEST PLAN
  valgrind --tool=callgrind baloo_file

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21579

AFFECTED FILES
  src/file/regexpcache.cpp
  src/file/regexpcache.h

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21581: Detect valgrind, avoid database removal when using valgrind

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Hah, wow

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21581

To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien
Cc: mgallien, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21581: Detect valgrind, avoid database removal when using valgrind

[Matthieu Gallien]

mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Very nice. Thank you

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21581

To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien
Cc: mgallien, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21581: Detect valgrind, avoid database removal when using valgrind

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:446aeb07d922: Detect valgrind, avoid database removal 
when using valgrind (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21581?vs=59137=59139

REVISION DETAIL
  https://phabricator.kde.org/D21581

AFFECTED FILES
  src/engine/database.cpp
  src/engine/valgrind.h

To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien
Cc: mgallien, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  A file may be deleted after it has been picked up by the iterator,
  causing the fileId to be 0. This is not an error, remove the Q_ASSERT
  and silently skip the file.

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21576

AFFECTED FILES
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21574: Update KBruch icon

[Carl Schwan]

ognarb added a comment.


  In D21574#474171 , @ndavis wrote:
  
  > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in 
breeze-icons.
  
  
  Sorry it arc who also uploaded the png that I created for the review, I will 
fix it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21581: Detect valgrind, avoid database removal when using valgrind

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko, broulik.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The mmap size supported by valgrind is set at valgrind compile time. If
  the application tries to mmap in total more than the supported size,
  the mmap fails. As a result lmdb fails to open the DB which is
  interpreted as a broken DB, thus the DB is deleted.
  
  Valgrind can be detected at runtime using the RUNNING_ON_VALGRIND
  macro from valgrind.h, which is added to the sources:
  
  > You are encouraged to copy the valgrind/*.h headers into your project's
  
include directory, so your program doesn't have a compile-time
dependency on Valgrind being installed. The Valgrind headers, unlike
most of the rest of the code, are under a BSD-style license so you may
include them without worrying about license incompatibility.

TEST PLAN
  valgrind --tool=callgrind baloo_file
  
  > org.kde.baloo.engine: Valgrind detected, limiting DB mmap to 40 GByte

REPOSITORY
  R293 Baloo

BRANCH
  base

REVISION DETAIL
  https://phabricator.kde.org/D21581

AFFECTED FILES
  src/engine/database.cpp
  src/engine/valgrind.h

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21581: Detect valgrind, avoid database removal when using valgrind

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21581

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

[Igor Poboiko]

poboiko accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21576

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D12647: Move the inline preview button into the menu

[Nathaniel Graham]

ngraham added a comment.


  Oops, sorry I missed your comments! Yes, removing it from the task 
description makes sense.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12647

To: ngraham, #frameworks
Cc: meven, kde-frameworks-devel, anemeth, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis added a comment.


  Wait, is this a PNG? This needs to be an SVG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  There needs to be a copy in breeze dark as well. Nice job though!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The mimetype is only required if all the other checks pass, i.e. when
  the file has been modified or added.
  
  It is beneficial to swap the order of timestamp and mimetype checks, as
  the mimetype determination is much more expensive than the timestamp
  retrieval, and the mimetype filter will only reject files occasionally
  while the mtime filter will reject files most of the times.
  
  Skip the mimetype determination for directories which would return
  wrong results anyway, either "application/octet-stream" or even
  "text/plain" for a directory named "test.log".

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21578

AFFECTED FILES
  src/file/unindexedfileiterator.cpp
  src/file/unindexedfileiterator.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21574: Update KBruch icon

[Noah Davis]

ndavis added a comment.


  Once you're done with the SVG, make sure you clean it: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 174 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/174/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 04 Jun 2019 16:32:48 +
 Build duration:
4 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 396 lines...][2019-06-04T16:36:51.499Z] [  7%] Built target KF5BalooCodecs_autogen[2019-06-04T16:36:51.499Z] [  1%] Generating org.kde.baloo.main.xml[2019-06-04T16:36:51.499Z] [  3%] Generating org.kde.baloo.scheduler.xml[2019-06-04T16:36:51.499Z] [  5%] Generating org.kde.baloo.fileindexer.xml[2019-06-04T16:36:51.499Z] [  7%] Generating maininterface.cpp, maininterface.h[2019-06-04T16:36:51.499Z] [  6%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2019-06-04T16:36:51.499Z] [  9%] Generating schedulerinterface.cpp, schedulerinterface.h[2019-06-04T16:36:51.499Z] [ 10%] Generating fileindexerinterface.cpp, fileindexerinterface.h[2019-06-04T16:36:51.769Z] [ 11%] Generating maininterface.moc[2019-06-04T16:36:51.769Z] [ 12%] Generating schedulerinterface.moc[2019-06-04T16:36:51.769Z] Scanning dependencies of target KF5BalooCodecs[2019-06-04T16:36:52.032Z] [ 14%] Generating fileindexerinterface.moc[2019-06-04T16:36:52.032Z] [ 18%] Built target BalooDBusInterfaces[2019-06-04T16:36:52.032Z] [ 15%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.obj[2019-06-04T16:36:52.032Z] [ 16%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.obj[2019-06-04T16:36:52.032Z] [ 18%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.obj[2019-06-04T16:36:52.032Z] doctermscodec.cpp[2019-06-04T16:36:52.032Z] [ 19%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.obj[2019-06-04T16:36:52.032Z] [ 20%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.obj[2019-06-04T16:36:52.294Z] mocs_compilation.cpp[2019-06-04T16:36:52.863Z] [ 20%] Built target KF5Baloo_QCH[2019-06-04T16:36:53.435Z] positioncodec.cpp[2019-06-04T16:36:53.435Z] postingcodec.cpp[2019-06-04T16:36:53.435Z] coding.cpp[2019-06-04T16:36:54.005Z] [ 22%] Linking CXX static library ..\..\lib\KF5BalooCodecs.lib[2019-06-04T16:36:54.272Z] [ 22%] Built target KF5BalooCodecs[2019-06-04T16:36:54.272Z] Scanning dependencies of target KF5BalooEngine_autogen[2019-06-04T16:36:54.272Z] [ 23%] Automatic MOC for target KF5BalooEngine[2019-06-04T16:36:54.272Z] [ 23%] Built target KF5BalooEngine_autogen[2019-06-04T16:36:54.847Z] Scanning dependencies of target KF5BalooEngine[2019-06-04T16:36:54.847Z] [ 25%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/andpostingiterator.cpp.obj[2019-06-04T16:36:54.847Z] [ 25%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/database.cpp.obj[2019-06-04T16:36:54.847Z] [ 27%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/document.cpp.obj[2019-06-04T16:36:54.847Z] [ 28%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdb.cpp.obj[2019-06-04T16:36:54.847Z] [ 29%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdatadb.cpp.obj[2019-06-04T16:36:55.123Z] andpostingiterator.cpp[2019-06-04T16:36:55.123Z] [ 31%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documenturldb.cpp.obj[2019-06-04T16:36:55.123Z] [ 32%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documenttimedb.cpp.obj[2019-06-04T16:36:55.123Z] [ 33%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentiddb.cpp.obj[2019-06-04T16:36:55.399Z] [ 35%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/enginequery.cpp.obj[2019-06-04T16:36:55.399Z] [ 36%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/idtreedb.cpp.obj[2019-06-04T16:36:55.677Z] [ 37%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/idfilenamedb.cpp.obj[2019-06-04T16:36:55.677Z] [ 38%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/mtimedb.cpp.obj[2019-06-04T16:36:59.946Z] database.cpp[2019-06-04T16:36:59.946Z] document.cpp[2019-06-04T16:36:59.946Z] documentdb.cpp[2019-06-04T16:36:59.946Z] documentdatadb.cpp[2019-06-04T16:36:59.946Z] documenturldb.cpp[2019-06-04T16:36:59.946Z] documenttimedb.cpp[2019-06-04T16:36:59.946Z] documentiddb.cpp[2019-06-04T16:36:59.946Z] enginequery.cpp[2019-06-04T16:36:59.946Z] idtreedb.cpp[2019-06-04T16:36:59.946Z] idfilenamedb.cpp[2019-06-04T16:36:59.946Z] mtimedb.cpp[2019-06-04T16:36:59.946Z] [ 40%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/orpostingiterator.cpp.obj[2019-06-04T16:37:00.221Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdatadb.cpp(97): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-04T16:37:00.221Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdatadb.cpp(151): warning C4267: 'argument': conversion from 'size_t' to 'int', 

D21581: Detect valgrind, avoid database removal when using valgrind

[Stefan Brüns]

bruns updated this revision to Diff 59137.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21581?vs=59136=59137

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21581

AFFECTED FILES
  src/engine/database.cpp
  src/engine/valgrind.h

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Buh!

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21576

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in unindexedfileiterator.cpp:109
> Why do we need it here?

leftover

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21415: Fix the alignment of the label of the toolbutton

[Dimitris Kardarakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:cd8b6b71cebc: Fix the alignment of the label of the 
toolbutton (authored by dkardarakos).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21415?vs=58686=59141

REVISION DETAIL
  https://phabricator.kde.org/D21415

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: dkardarakos, #plasma, #vdg, filipf
Cc: filipf, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21576: [UnindexedFileIndexer] Do not try to add nonexistant file to index

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7ab4cc5611a3: [UnindexedFileIndexer] Do not try to add 
nonexistant file to index (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21576?vs=59127=59143

REVISION DETAIL
  https://phabricator.kde.org/D21576

AFFECTED FILES
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Stefan Brüns]

bruns updated this revision to Diff 59148.
bruns added a comment.


  replace one QLatin1String with QStringLiteral

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21583?vs=59146=59148

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21583

AFFECTED FILES
  src/file/regexpcache.cpp

To: bruns, #baloo, ngraham, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15739: [Places panel] Don't show Root by default

[Méven Car]

meven added a comment.


  gentle ping @ngraham 
  How ironic ;)
  
  Unless you would rather let someone else take care of this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[jonathan poelen]

jpoelen edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21587

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Makes perfect sense.

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21578

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 04 Jun 2019 17:18:44 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 11 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.bluezqt_adaptertestFailed: projectroot.autotests.bluezqt_agentmanagertestFailed: projectroot.autotests.bluezqt_devicetestFailed: projectroot.autotests.bluezqt_gattmanagertestFailed: projectroot.autotests.bluezqt_inputtestFailed: projectroot.autotests.bluezqt_leadvertisingmanagertestFailed: projectroot.autotests.bluezqt_managertestFailed: projectroot.autotests.bluezqt_mediaplayertestFailed: projectroot.autotests.bluezqt_mediatestFailed: projectroot.autotests.bluezqt_obexmanagertestFailed: projectroot.autotests.bluezqt_qmltests

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Brilliant!

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21579

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/120/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 04 Jun 2019 17:47:09 +
 Build duration:
5 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13386)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:cdcad139a529: [UnindexedFileIterator] Delay mimetype 
determination until it is needed (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21578?vs=59129=59144#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21578?vs=59129=59144

REVISION DETAIL
  https://phabricator.kde.org/D21578

AFFECTED FILES
  src/file/unindexedfileiterator.cpp
  src/file/unindexedfileiterator.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:be59ea539ba8: [FilteredDirIterator] Avoid RegExp overhead 
for exact matches (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21579?vs=59132=59145

REVISION DETAIL
  https://phabricator.kde.org/D21579

AFFECTED FILES
  src/file/regexpcache.cpp
  src/file/regexpcache.h

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer added a reviewer: drosca.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21586: Add syntax definition for ninja build

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ninja (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21586

AFFECTED FILES
  autotests/folding/build.ninja.fold
  autotests/html/build.ninja.html
  autotests/input/build.ninja
  autotests/reference/build.ninja.ref
  data/syntax/ninja.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches

[Igor Poboiko]

poboiko added inline comments.

INLINE COMMENTS

> regexpcache.cpp:60
> +}
>  f.replace(QLatin1Char('.'), QStringLiteral("\\."));
>  f.replace(QLatin1Char('?'), QLatin1Char('.'));

A quick note for future. There is 
`QRegularExpression::wildcardToRegularExpression()`, which apparently does 
precicely this.
It is there since Qt 5.12 though, while we depend on Qt 5.10. But Plasma 
already bumped dependency to 5.12, so so we can change it when Frameworks will 
follow this bump.

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21579

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21581: Detect valgrind, avoid database removal when using valgrind

[Ben Cooksley]

bcooksley added a comment.


  This changes breaks the build on Windows/MSVC because 'valgrind.h' doesn't 
support MSVC.
  Can you please correct this / disable this check on Windows?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21581

To: bruns, #baloo, ngraham, astippich, poboiko, broulik, mgallien
Cc: bcooksley, mgallien, kde-frameworks-devel, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 123 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/123/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 04 Jun 2019 17:47:09 +
 Build duration:
1 hr 12 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 127 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/127/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 04 Jun 2019 17:52:45 +
 Build duration:
1 hr 15 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21585: C++: update for C++20

[jonathan poelen]

jpoelen updated this revision to Diff 59156.
jpoelen added a comment.


  oops, missing version increase

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21585?vs=59152=59156

BRANCH
  cpp2a (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21585

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Stefan Brüns]

bruns updated this revision to Diff 59147.
bruns added a comment.


  remove leftover double timeinfo fetch
  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21577?vs=59128=59147

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21577

AFFECTED FILES
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 175 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/175/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 04 Jun 2019 17:58:39 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 376 lines...][2019-06-04T18:09:04.829Z] -- Generating done[2019-06-04T18:09:05.099Z] -- Build files have been written to: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-06-04T18:09:06.542Z] [2019-06-04T18:09:06.542Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-06-04T18:09:07.998Z] **[2019-06-04T18:09:07.998Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-06-04T18:09:07.998Z] ** Copyright (c) 2019 Microsoft Corporation[2019-06-04T18:09:07.998Z] **[2019-06-04T18:09:14.734Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-06-04T18:09:15.016Z] [2019-06-04T18:09:15.016Z] jom 1.1.2 - empower your cores[2019-06-04T18:09:15.016Z] [2019-06-04T18:09:15.308Z] jom: parallel job execution disabled for Makefile[2019-06-04T18:09:15.308Z] Scanning dependencies of target KF5BalooCodecs_autogen[2019-06-04T18:09:15.573Z] Scanning dependencies of target BalooDBusInterfaces[2019-06-04T18:09:15.573Z] Scanning dependencies of target KF5Baloo_QCH[2019-06-04T18:09:15.573Z] [  1%] Automatic MOC for target KF5BalooCodecs[2019-06-04T18:09:16.206Z] [ 10%] Built target KF5BalooCodecs_autogen[2019-06-04T18:09:16.206Z] [  2%] Generating org.kde.baloo.main.xml[2019-06-04T18:09:16.206Z] [  6%] Generating org.kde.baloo.scheduler.xml[2019-06-04T18:09:16.206Z] [  6%] Generating org.kde.baloo.fileindexer.xml[2019-06-04T18:09:16.206Z] [  9%] Generating fileindexerinterface.cpp, fileindexerinterface.h[2019-06-04T18:09:16.206Z] [  9%] Generating maininterface.cpp, maininterface.h[2019-06-04T18:09:16.206Z] [  3%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2019-06-04T18:09:16.206Z] [ 10%] Generating schedulerinterface.cpp, schedulerinterface.h[2019-06-04T18:09:16.481Z] [ 11%] Generating fileindexerinterface.moc[2019-06-04T18:09:16.753Z] [ 12%] Generating schedulerinterface.moc[2019-06-04T18:09:16.753Z] [ 14%] Generating maininterface.moc[2019-06-04T18:09:16.753Z] Scanning dependencies of target KF5BalooCodecs[2019-06-04T18:09:17.018Z] [ 18%] Built target BalooDBusInterfaces[2019-06-04T18:09:17.018Z] [ 18%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.obj[2019-06-04T18:09:17.018Z] [ 16%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.obj[2019-06-04T18:09:17.018Z] [ 19%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.obj[2019-06-04T18:09:17.018Z] [ 19%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.obj[2019-06-04T18:09:17.018Z] doctermscodec.cpp[2019-06-04T18:09:17.285Z] [ 20%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.obj[2019-06-04T18:09:17.878Z] mocs_compilation.cpp[2019-06-04T18:09:19.793Z] positioncodec.cpp[2019-06-04T18:09:19.793Z] postingcodec.cpp[2019-06-04T18:09:20.727Z] coding.cpp[2019-06-04T18:09:20.727Z] [ 22%] Linking CXX static library ..\..\lib\KF5BalooCodecs.lib[2019-06-04T18:09:23.260Z] [ 22%] Built target KF5BalooCodecs[2019-06-04T18:09:23.260Z] Scanning dependencies of target KF5BalooEngine_autogen[2019-06-04T18:09:23.260Z] [ 23%] Automatic MOC for target KF5BalooEngine[2019-06-04T18:09:23.260Z] [ 23%] Built target KF5BalooEngine_autogen[2019-06-04T18:09:23.862Z] Scanning dependencies of target KF5BalooEngine[2019-06-04T18:09:23.862Z] [ 32%] Built target KF5Baloo_QCH[2019-06-04T18:09:23.862Z] [ 27%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/andpostingiterator.cpp.obj[2019-06-04T18:09:23.862Z] [ 27%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/database.cpp.obj[2019-06-04T18:09:23.862Z] [ 27%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/document.cpp.obj[2019-06-04T18:09:23.862Z] [ 28%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdb.cpp.obj[2019-06-04T18:09:23.862Z] [ 29%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdatadb.cpp.obj[2019-06-04T18:09:23.862Z] [ 31%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documenturldb.cpp.obj[2019-06-04T18:09:23.862Z] andpostingiterator.cpp[2019-06-04T18:09:23.862Z] [ 32%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documenttimedb.cpp.obj[2019-06-04T18:09:23.862Z] [ 33%] Building CXX object 

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 04 Jun 2019 17:18:44 +
 Build duration:
3 min 35 sec and counting
   BUILD ARTIFACTS
  acc/KF5BluezQt-5.59.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 11 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.bluezqt_adaptertestFailed: projectroot.autotests.bluezqt_agentmanagertestFailed: projectroot.autotests.bluezqt_devicetestFailed: projectroot.autotests.bluezqt_gattmanagertestFailed: projectroot.autotests.bluezqt_inputtestFailed: projectroot.autotests.bluezqt_leadvertisingmanagertestFailed: projectroot.autotests.bluezqt_managertestFailed: projectroot.autotests.bluezqt_mediaplayertestFailed: projectroot.autotests.bluezqt_mediatestFailed: projectroot.autotests.bluezqt_obexmanagertestFailed: projectroot.autotests.bluezqt_qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)25%
(29/114)25%
(29/114)17%
(1045/6118)4%
(198/4537)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)47%
(731/1563)6%
(144/2598)autotests.fakebluez0%
(0/19)0%
(0/19)0%
(0/785)0%
(0/252)src25%
(14/57)25%
(14/57)11%
(288/2623)4%
(53/1208)src.imports29%
(2/7)29%
(2/7)7%
(26/400)3%
(1/40)tests0%
(0/5)0%
(0/5)0%
(0/225)0%
(0/58)tools.bluezapi2qt0%
(0/13)0%
(0/13)0%
(0/522)0%
(0/381)

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Igor Poboiko]

poboiko added a comment.


  I didn't know `QFileInfo` fetches information on demand (and caches it). That 
is the reason for this change, right?
  I think it would be nice to elaborate on that in summary, or maybe as a brief 
comment in the code.

INLINE COMMENTS

> unindexedfileiterator.cpp:109
> +} else {
> +timeInfo = m_transaction->documentTimeInfo(fileId);
> +if (timeInfo.mTime != fileInfo.lastModified().toSecsSinceEpoch()) {

Why do we need it here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Stefan Brüns]

bruns added a comment.


  In D21577#474212 , @poboiko wrote:
  
  > I didn't know `QFileInfo` fetches information on demand (and caches it). 
That is the reason for this change, right?
  >  I think it would be nice to elaborate on that in summary, or maybe as a 
brief comment in the code.
  
  
  As far as I can see, the time is actually spent in converting from statbuf to 
QDateTime, and the underlying data is filled in when QFileInfo is instantiated 
in the QDirIterator.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Nathaniel Graham]

ngraham added a comment.


  Would it be make more sense to just have a single file type regex in the 
config file rather than parsing the existing data and re-processing it in the 
code?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21583

To: bruns, #baloo, ngraham, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21508: Jam: various improvements and fixes

[jonathan poelen]

jpoelen updated this revision to Diff 59150.
jpoelen added a comment.


  - fix module
  - remove hard coded color

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21508?vs=58930=59150

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21508

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mweichselbaumer requested review of this revision.

REPOSITORY
  R269 BluezQt

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  src/CMakeLists.txt
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/interfaces/org.bluez.GattCharacteristic1.xml
  src/interfaces/org.bluez.GattManager1.xml
  src/interfaces/org.bluez.LEAdvertisement1.xml
  src/interfaces/org.bluez.LEAdvertisingManager1.xml
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/mediaendpoint.cpp
  src/objectmanager.cpp
  src/objectmanager.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/leserver.cpp
  tests/leserver.h

To: mweichselbaumer
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21585: C++: update for C++20

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  - new attributes: assert, ensures and expects
  - new types: char8_t
  - new keywords: consteval, import, module, concept, requires, co_await, 
co_return, co_yield

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp2a (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21585

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21578: [UnindexedFileIterator] Delay mimetype determination until it is needed

[Igor Poboiko]

poboiko accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21578

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Jun 2019 17:18:44 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5BluezQt-5.59.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 11 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.bluezqt_adaptertestFailed: projectroot.autotests.bluezqt_agentmanagertestFailed: projectroot.autotests.bluezqt_devicetestFailed: projectroot.autotests.bluezqt_gattmanagertestFailed: projectroot.autotests.bluezqt_inputtestFailed: projectroot.autotests.bluezqt_leadvertisingmanagertestFailed: projectroot.autotests.bluezqt_managertestFailed: projectroot.autotests.bluezqt_mediaplayertestFailed: projectroot.autotests.bluezqt_mediatestFailed: projectroot.autotests.bluezqt_obexmanagertestFailed: projectroot.autotests.bluezqt_qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)25%
(29/114)25%
(29/114)17%
(1045/6118)4%
(198/4537)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)47%
(731/1563)6%
(144/2598)autotests.fakebluez0%
(0/19)0%
(0/19)0%
(0/785)0%
(0/252)src25%
(14/57)25%
(14/57)11%
(288/2623)4%
(53/1208)src.imports29%
(2/7)29%
(2/7)7%
(26/400)3%
(1/40)tests0%
(0/5)0%
(0/5)0%
(0/225)0%
(0/58)tools.bluezapi2qt0%
(0/13)0%
(0/13)0%
(0/522)0%
(0/381)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/113/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Jun 2019 17:47:09 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13386)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 117 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/117/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 04 Jun 2019 17:52:44 +
 Build duration:
8 min 46 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.59.0.xmllogs/KF5KIO/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33346/61056)39%
(17036/43988)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9403/9853)48%
(4329/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8479/14467)51%
(4701/9230)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4474/8175)41%
(1946/4747)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(370/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
 

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Most of the about 50 default filters are suffix matches, which can be
  easily combined into one large regular expression. Doing so reduces
  the matching cost by about 80%.

TEST PLAN
  valgrind --tool=callgrind baloo_file

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21583

AFFECTED FILES
  src/file/regexpcache.cpp

To: bruns, #baloo, ngraham, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  function foo()
  
if x then
end <--- Control Flow
  
  end <--- Keyword

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua54 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21587

AFFECTED FILES
  autotests/html/highlight.lua.html
  autotests/html/test.pbl.html
  autotests/reference/highlight.lua.ref
  autotests/reference/test.pbl.ref
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 176 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/176/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 04 Jun 2019 18:10:03 +
 Build duration:
21 min and counting
   CONSOLE OUTPUT
  [...truncated 369 lines...][2019-06-04T18:29:14.928Z]  * EXP, Build experimental features[2019-06-04T18:29:14.928Z] [2019-06-04T18:29:14.928Z] -- The following OPTIONAL packages have not been found:[2019-06-04T18:29:14.928Z] [2019-06-04T18:29:14.928Z]  * Inotify[2019-06-04T18:29:14.928Z]Filesystem alteration notifications using inotify[2019-06-04T18:29:14.928Z] [2019-06-04T18:29:15.450Z] -- Configuring done[2019-06-04T18:29:52.403Z] -- Generating done[2019-06-04T18:29:56.689Z] -- Build files have been written to: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-06-04T18:30:00.032Z] [2019-06-04T18:30:00.032Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-06-04T18:30:00.557Z] **[2019-06-04T18:30:00.557Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-06-04T18:30:00.557Z] ** Copyright (c) 2019 Microsoft Corporation[2019-06-04T18:30:00.557Z] **[2019-06-04T18:30:08.223Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-06-04T18:30:08.223Z] [2019-06-04T18:30:08.223Z] jom 1.1.2 - empower your cores[2019-06-04T18:30:08.223Z] [2019-06-04T18:30:09.957Z] jom: parallel job execution disabled for Makefile[2019-06-04T18:30:09.957Z] Scanning dependencies of target KF5BalooCodecs_autogen[2019-06-04T18:30:09.957Z] Scanning dependencies of target KF5Baloo_QCH[2019-06-04T18:30:09.957Z] Scanning dependencies of target BalooDBusInterfaces[2019-06-04T18:30:10.497Z] [  6%] Automatic MOC for target KF5BalooCodecs[2019-06-04T18:30:10.497Z] [ 10%] Built target KF5BalooCodecs_autogen[2019-06-04T18:30:10.497Z] [  3%] Generating org.kde.baloo.main.xml[2019-06-04T18:30:10.497Z] [  3%] Generating org.kde.baloo.scheduler.xml[2019-06-04T18:30:10.497Z] [  5%] Generating org.kde.baloo.fileindexer.xml[2019-06-04T18:30:10.497Z] [  7%] Generating maininterface.cpp, maininterface.h[2019-06-04T18:30:10.497Z] [ 10%] Generating schedulerinterface.cpp, schedulerinterface.h[2019-06-04T18:30:10.497Z] [ 10%] Generating fileindexerinterface.cpp, fileindexerinterface.h[2019-06-04T18:30:10.497Z] [  1%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2019-06-04T18:30:10.497Z] [ 11%] Generating maininterface.moc[2019-06-04T18:30:10.497Z] [ 12%] Generating schedulerinterface.moc[2019-06-04T18:30:11.020Z] [ 14%] Generating fileindexerinterface.moc[2019-06-04T18:30:11.020Z] [ 14%] Built target BalooDBusInterfaces[2019-06-04T18:30:11.562Z] Scanning dependencies of target KF5BalooCodecs[2019-06-04T18:30:11.562Z] [ 18%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.obj[2019-06-04T18:30:11.562Z] [ 18%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.obj[2019-06-04T18:30:11.562Z] [ 18%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.obj[2019-06-04T18:30:11.562Z] [ 20%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.obj[2019-06-04T18:30:11.562Z] [ 20%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.obj[2019-06-04T18:30:12.093Z] doctermscodec.cpp[2019-06-04T18:30:12.093Z] mocs_compilation.cpp[2019-06-04T18:30:13.223Z] [ 20%] Built target KF5Baloo_QCH[2019-06-04T18:30:15.668Z] postingcodec.cpp[2019-06-04T18:30:16.193Z] positioncodec.cpp[2019-06-04T18:30:16.193Z] coding.cpp[2019-06-04T18:30:25.713Z] [ 22%] Linking CXX static library ..\..\lib\KF5BalooCodecs.lib[2019-06-04T18:30:25.713Z] [ 22%] Built target KF5BalooCodecs[2019-06-04T18:30:25.713Z] Scanning dependencies of target KF5BalooEngine_autogen[2019-06-04T18:30:25.713Z] [ 23%] Automatic MOC for target KF5BalooEngine[2019-06-04T18:30:26.867Z] [ 23%] Built target KF5BalooEngine_autogen[2019-06-04T18:30:29.513Z] Scanning dependencies of target KF5BalooEngine[2019-06-04T18:30:30.751Z] [ 25%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/andpostingiterator.cpp.obj[2019-06-04T18:30:30.751Z] [ 25%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/database.cpp.obj[2019-06-04T18:30:31.375Z] [ 27%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/document.cpp.obj[2019-06-04T18:30:31.375Z] [ 28%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdb.cpp.obj[2019-06-04T18:30:31.375Z] andpostingiterator.cpp[2019-06-04T18:30:31.375Z] [ 29%] Building CXX object 

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:602bbc7b7397: Lua: update for Lua54 and end of function 
as Keyword rather than Control (authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21587?vs=59155=59163

REVISION DETAIL
  https://phabricator.kde.org/D21587

AFFECTED FILES
  autotests/html/highlight.lua.html
  autotests/html/test.pbl.html
  autotests/reference/highlight.lua.ref
  autotests/reference/test.pbl.ref
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21508: Jam: various improvements and fixes

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21508?vs=59150=59164

REVISION DETAIL
  https://phabricator.kde.org/D21508

AFFECTED FILES
  autotests/folding/Jamroot.fold
  autotests/html/Jamroot.html
  autotests/input/Jamroot
  autotests/reference/Jamroot.ref
  data/syntax/jam.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21585: C++: update for C++20

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Thanks for the update!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp2a (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21585

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Lgtm

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua54 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21587

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21508: Jam: various improvements and fixes

[Dominik Haumann]

dhaumann accepted this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21508

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Stefan Brüns]

bruns added a comment.


  In D21583#474266 , @ngraham wrote:
  
  > Would it be make more sense to just have a single file type regex in the 
config file rather than parsing the existing data and re-processing it in the 
code?
  
  
  The config is quite messy in this regard - there are actually two distinct 
filters in the sources, one for directories and one for files. Currently, both 
are fed into the same regex, and both are merged into one config key. Also, the 
config does not diffferentiate between filters deleted from the defaults, or 
filters added to the defaults, everything is flattened into one config key. 
This makes config updates quite problematic.
  
  I think having file globs in the config is fine, converting these into 
regexes wouldn' t be a benefit. Converting the globs into regexes is a 
insignificant overhead, it is just an implementation detail. Doing the 
conversion in a low overhead way is nice, but out of scope for the config file 
syntax.
  
  Ideally, the filter were "default - deleted + added", instead of a flattened 
list (the config would only save deleted and added filters). File globs are 
sufficient here.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21583

To: bruns, #baloo, ngraham, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21585: C++: update for C++20

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9ba02971123d: C++: update for C++20 (authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21585?vs=59156=59162

REVISION DETAIL
  https://phabricator.kde.org/D21585

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right, sounds good for now then. We can refactor the config file later.

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21583

To: bruns, #baloo, ngraham, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven added a comment.


  In D17595#473826 , @ngraham wrote:
  
  > Would you be interested in doing that and taking over this patch? I'm 
afraid I don't think I have the time right now for the kind of deep dive that 
it requires. If not, that's okay. :)
  
  
  I can take over ;)
  
  I still have some unclear area .
  relicensecheck.pl does not seem to allow to re-license from GPL to LGPL, just 
to update the version of the license used.
  Only the +eV option seems to allow this. 
  It seems to me I should ask the author to allow KDE e.V. to re-license their 
work.
  I have contacted KDE e.V board to ask for some guidance.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: ngraham, #frameworks, #dolphin, broulik
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Avoid detach of QStringList in for loop.
  Move invariant IndexingLevel out of the loop.

TEST PLAN
  make

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21572

AFFECTED FILES
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4fcc08d86881: [UnindexedFileIndexer] Loop optimizations 
(avoid detach, invariants) (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21572?vs=59117=59118

REVISION DETAIL
  https://phabricator.kde.org/D21572

AFFECTED FILES
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21572

To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/86/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 04 Jun 2019 08:58:26 +
 Build duration:
5 min 8 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns