D21940: Make automatic spellcheck work after reloading a document

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. You don't need the extra function. Could you update the patch? INLINE COMMENTS > ontheflycheck.cpp:75 > > +connect(document, ::Document::reloaded, > +this,

D14467: Auth Support: Drop privileges if target is not owned by root

maltek requested changes to this revision. maltek added a comment. This revision now requires changes to proceed. I noticed a few more things on the second read. INLINE COMMENTS > filehelper.cpp:123 > +const QByteArray baseName = basename(tempPath2.data()); > +int parent_fd =

D21953: Replace "Details" button with KCollapsibleGroupBox

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21953 To: chinmoyr, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel, LeGast00n,

D21957: Add disk-quota icons

nicolasfella created this revision. nicolasfella added reviewers: Breeze, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The disk quota applet ships its own icon, causing issues when

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added inline comments. INLINE COMMENTS > maltek wrote in filehelper.cpp:133 > For `chown`, dropping privileges here means that the `chown` later can't > succeed - it's not possible to 'gift' a file to another user. I think it > should be handled more like `DEL/RMDIR/MKDIR` etc. Ah!

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

anthonyfieroni added a comment. QList should be QList>, don't leave ownership to consumers. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21957: Add disk-quota icons

ngraham accepted this revision. ngraham added a comment. Afterwards please fix the stylesheet so that the icons show up properly in dark themes. :) REPOSITORY R266 Breeze Icons BRANCH diskquota REVISION DETAIL https://phabricator.kde.org/D21957 To: nicolasfella, #breeze, ndavis,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60214. leinir added a comment. Address anthonyfieroni's comment about manual memory management in the comments fetching system - Switch to a shared_ptr list for comments (less manual memory mgmnt) REPOSITORY R304 KNewStuff CHANGES SINCE LAST

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in ontheflycheck.cpp:75 > Directly connect to this, refreshSpellCheck. That wouldn't work, reloaded() takes a Document pointer parameter whereas refreshSpellcheck takes a Range parameter. REPOSITORY R39 KTextEditor REVISION

D21830: Format photo exposure bias value

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60204. leinir added a comment. - Sort the default sizing on the Dialog to be more pleasant - Rejig the Dialog's button implementation, so it's now got shortcuts - Set the default column width of the test dialog REPOSITORY R304 KNewStuff CHANGES

D21957: Add disk-quota icons

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=389311 and/or https://bugs.kde.org/show_bug.cgi?id=403506? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21957 To: nicolasfella, #breeze, ndavis Cc: ngraham, kde-frameworks-devel,

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1709 > Wouldn't mtime.isNull() or mtime.isValid() be simpler? I don't think mtime would be null or invalid in this case, but I'll check. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To:

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60181. leinir added a comment. - A pile of style cleaning - Implement the adoptItem function in KNSQuick::ItemsModel REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60052=60181 BRANCH

D21953: Replace "Details" button with KCollapsibleGroupBox

chinmoyr created this revision. chinmoyr added reviewers: VDG, ngraham, GB_2. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Remove "Details" button and use KCollapsibleGroupBox to display more

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: wbauer, #frameworks Cc: kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D21957: Add disk-quota icons

nicolasfella added a comment. In D21957#483195 , @ngraham wrote: > Does this fix https://bugs.kde.org/show_bug.cgi?id=389311 and/or https://bugs.kde.org/show_bug.cgi?id=403506? The first one yes, after we change the desktop file to match

D21955: [copyjob] Only set modification time if the kio-slave provided it

dfaure added inline comments. INLINE COMMENTS > copyjob.cpp:1709 > moveJob->setSourceSize((*it).size); > -moveJob->setModificationTime((*it).mtime); // #55804 > +if ((*it).mtime.toMSecsSinceEpoch() != 1000 * (-1)) { > +

D21830: Format photo exposure bias value

astippich added a comment. friendly ping, would be great to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

D21957: Add disk-quota icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH diskquota REVISION DETAIL https://phabricator.kde.org/D21957 To: nicolasfella, #breeze, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21955: [copyjob] Only set modification time if the kio-slave provided it

ngraham added reviewers: bruns, dfaure. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh goodness. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: wbauer, #frameworks, bruns, dfaure, ngraham Cc:

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

wbauer created this revision. wbauer added a reviewer: Frameworks. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY `sPartInfo` refers to the .part file which might not exist in the first place,

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: wbauer, #frameworks Cc: kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

This revision was automatically updated to reflect the committed changes. Closed by commit R304:e319993e8fb5: [kmoretools] Add icons to download and install actions (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer created this revision. wbauer added a reviewer: Frameworks. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY If the slave didn't pass a modification time (e.g. the http slave doesn't), it is

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 60215. chinmoyr marked 6 inline comments as done. chinmoyr added a comment. Addresed the issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=60167=60215 BRANCH arcpatch-D14467 REVISION DETAIL

D21960: AppArmor: update syntax

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Changes: - Add new

D21940: Make automatic spellcheck work after reloading a document

dhaumann added inline comments. INLINE COMMENTS > ahmadsamir wrote in ontheflycheck.cpp:75 > That wouldn't work, reloaded() takes a Document pointer parameter whereas > refreshSpellcheck takes a Range parameter. But refreshSpellCheck() has a default parameter, so this function exists without

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in ontheflycheck.cpp:75 > But refreshSpellCheck() has a default parameter, so this function exists > without any parameter. Afaik this should work?! In file included from /usr/include/qt5/QtCore/qalgorithms.h:43,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/124/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 13:26:05 + Build duration: 22 min and counting BUILD ARTIFACTS

D14467: Auth Support: Drop privileges if target is not owned by root

maltek added inline comments. INLINE COMMENTS > chinmoyr wrote in filehelper.cpp:133 > Ah! Since I was testing inside /opt I didn't notice. I think the order here > should be: drop privilege -> change grp -> gain privilege -> change user. IMO, it's fine (and less complicated) to just do both

D21966: Add disk-quota icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH icon REVISION DETAIL https://phabricator.kde.org/D21966 To: nicolasfella, #plasma, #breeze, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, michaelh,

D21966: Add disk-quota icons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Breeze, ngraham, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add disk-quota icons to Plasma theme

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/128/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 14:29:11 + Build duration: 6 min 5 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 14:29:11 + Build duration: 9 min 56 sec and counting BUILD ARTIFACTS

D21955: [copyjob] Only set modification time if the kio-slave provided it

dfaure added a comment. Ah sorry that was in your commit log. info.mtime = QDateTime::fromMSecsSinceEpoch(1000 * entry.numberValue(KIO::UDSEntry::UDS_MODIFICATION_TIME, -1), Qt::UTC); should be changed to: const auto timeVal =

D21788: Make Plasma::Svg::elementRect a bit leaner

This revision was automatically updated to reflect the committed changes. Closed by commit R242:097f0e83e7bf: Make Plasma::Svg::elementRect a bit leaner (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21788?vs=59837=60234

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/133/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 13:41:25 + Build duration: 9 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/133/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 13:41:25 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D21957: Add disk-quota icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b30b08bfc59b: Add disk-quota icons (authored by nicolasfella). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21957?vs=60211=60245 REVISION DETAIL

D21966: Add disk-quota icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eddc6dec6939: Add disk-quota icons (authored by nicolasfella). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21966?vs=60241=60243 REVISION

D21955: [copyjob] Only set modification time if the kio-slave provided it

dfaure accepted this revision. dfaure added a comment. I like this code. It's as good as if I had written it myself :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: wbauer, #frameworks, bruns, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, #dolphin,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/117/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 13:26:05 + Build duration: 5 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/127/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 13:26:05 + Build duration: 10 min and counting JUnit Tests Name:

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added a comment. Qt docs say that the signal must have at least as many arguments as the slot, and there is an implicit conversion between the types of the corresponding arguments in the signal and the slot. REPOSITORY R39 KTextEditor REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/125/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 14:29:11 + Build duration: 7 min 41 sec and counting BUILD ARTIFACTS

D21953: Replace "Details" button with KCollapsibleGroupBox

GB_2 accepted this revision. GB_2 added a comment. Thanks! Perhaps just "Details" would be enough. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21953 To: chinmoyr, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham,

D21955: [copyjob] Only set modification time if the kio-slave provided it

dfaure added a comment. Then the bug is on the other side. Whoever is putting that value into a QDateTime, is doing something wrong. 31-Dec-1969 is NOT the normal way to represent an invalid time. Can you find out who is converting -1 to a QDateTime, and fix that instead? REPOSITORY

D21960: AppArmor: update syntax

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R216 Syntax Highlighting BRANCH update-apparmor-hl REVISION DETAIL https://phabricator.kde.org/D21960 To: nibags, #framework_syntax_highlighting, dhaumann,

D21788: Make Plasma::Svg::elementRect a bit leaner

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D21788 To: apol, #plasma, #frameworks, davidedmundson Cc: bruns, kde-frameworks-devel, LeGast00n,

D21959: Fix selectedNameFilter() multiple matches

ngraham added reviewers: Frameworks, apol, dfaure. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/123/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 13:41:25 + Build duration: 17 min and counting BUILD ARTIFACTS

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer marked an inline comment as done. wbauer added inline comments. INLINE COMMENTS > wbauer wrote in copyjob.cpp:1709 > I don't think mtime would be null or invalid in this case, but I'll check. Nope. I added this debug line: qDebug() << "mtime=" << (*it).mtime << "null:" <<

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer updated this revision to Diff 60227. wbauer edited the summary of this revision. wbauer added a comment. Check already when setting info.mtime in CopyJobPrivate::addCopyInfoFromUDSEntry(). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21966: Add disk-quota icons

nicolasfella edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH icon REVISION DETAIL https://phabricator.kde.org/D21966 To: nicolasfella, #plasma, #breeze, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21957: Add disk-quota icons

nicolasfella edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH diskquota REVISION DETAIL https://phabricator.kde.org/D21957 To: nicolasfella, #breeze, ndavis, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21955: [copyjob] Only set modification time if the kio-slave provided it

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5e791ef216c2: [copyjob] Only set modification time if the kio-slave provided it (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21967: Fix warning when reading plugin metadata

aacid added a comment. You only changed the debug line? Doesn't feel like the right fix REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21967 To: nicolasfella, apol, aacid Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/134/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 15:47:07 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/135/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 16:01:27 + Build duration: 6 min 50 sec and counting BUILD ARTIFACTS

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella updated this revision to Diff 60261. nicolasfella added a comment. - Implement Nates suggestion - Look for Kirigami REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19646?vs=60258=60261 BRANCH arcpatch-D19646 REVISION DETAIL

D19646: Redesign config pages

nicolasfella retitled this revision from "Redesign KDE Connect and bluetooth config pages" to "Redesign config pages". REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel,

D19646: Redesign config pages

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Super better! Code looks perfect. REPOSITORY R495 Purpose Library BRANCH arcpatch-D19646 REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 103 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/103/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 21 Jun 2019 16:53:57 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/52/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 16:53:57 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...truncated

D21967: Fix warning when reading plugin metadata

nicolasfella updated this revision to Diff 60248. nicolasfella edited the test plan for this revision. nicolasfella added a comment. - Whitespace REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21967?vs=60247=60248 BRANCH warning REVISION DETAIL

D21953: Replace "Details" button with KCollapsibleGroupBox

chinmoyr closed this revision. chinmoyr added a comment. https://commits.kde.org/kwidgetsaddons/89606c1ecb571e3ae9137cab18ceadeff57666e3 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21953 To: chinmoyr, #vdg, ngraham, GB_2 Cc: kde-frameworks-devel,

D21967: Fix warning when reading plugin metadata

nicolasfella added a comment. It is the only place I found where KPluginMetaData.value is called on a list REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21967 To: nicolasfella, apol, aacid Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

ngraham added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks Cc: mreeves, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham,

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/57/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 16:53:57 + Build duration: 38 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/57/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 16:53:57 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated 236

D19646: Redesign config pages

This revision was automatically updated to reflect the committed changes. Closed by commit R495:1eef04076c31: Redesign config pages (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19646?vs=60261=60263 REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 17:28:57 + Build duration: 4 min 33 sec and counting BUILD ARTIFACTS

D21967: Fix warning when reading plugin metadata

nicolasfella retitled this revision from "Fix warning when reading plugin metadata # NEW DIFFERENTIAL REVISION # Describe the changes in this new revision. # # Included commits in branch warning: # # bcbf41157e8b Fix warning when reading plugin metadata # # arc could not identify..." to

D21967: Fix warning when reading plugin metadata# NEW DIFFERENTIAL REVISION# Describe the changes in this new revision.## Included commits in branch warning:## bcbf41157e8b Fix warning when reading pl

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY ...any existing revision in your working copy. 1. If you intended to update an existing revision, use: #

D21953: Replace "Details" button with KCollapsibleGroupBox

chinmoyr updated this revision to Diff 60250. chinmoyr added a comment. "More Details" -> "Details" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21953?vs=60198=60250 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21953 AFFECTED

D14467: Auth Support: Drop privileges if target is not owned by root

maltek accepted this revision. maltek added a comment. This revision is now accepted and ready to land. Looks good to me now! REPOSITORY R241 KIO BRANCH arcpatch-D14467 REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 135 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 16:01:27 + Build duration: 1 min 15 sec and counting CONSOLE OUTPUT

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella updated this revision to Diff 60258. nicolasfella added a comment. - Implement Nates suggestion REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19646?vs=53554=60258 BRANCH arcpatch-D19646 REVISION DETAIL

D19646: Redesign config pages

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19646: Redesign config pages

apol accepted this revision. REPOSITORY R495 Purpose Library BRANCH arcpatch-D19646 REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19646: Redesign config pages

GB_2 added a comment. It would be great if you also improved the JobDialog buttons: - put them on the right - give them icons REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: GB_2, trmdi, abetts,

D21830: Format photo exposure bias value

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0a042beb5568: Format photo exposure bias value (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59875=60265 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/129/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 15:20:41 + Build duration: 2 min 47 sec and counting JUnit Tests

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 60249. chinmoyr added a comment. Separated (l)chown since it's to be done with elavated privileges. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=60215=60249 BRANCH arcpatch-D14467 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 134 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/134/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 21 Jun 2019 15:47:07 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...truncated

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in kdeconnectplugin_config.qml:41 > Use icon.name. iconName comes from the DeviceModel. We just expose the name, not the actual ico from KDE Connect REPOSITORY R495 Purpose Library REVISION DETAIL

D19646: Redesign config pages

trmdi added a comment. Does this window have too much empty space? Can it have less? - I guess we wouldn't have too many devices in most of the cases. - The device name is not often too long. So can the default window size be reduced a bit? We wouldn't have to move the mouse too

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/110/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 17:28:57 + Build duration: 9 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/126/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 21 Jun 2019 15:20:41 + Build duration: 4 min 52 sec and counting BUILD ARTIFACTS

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr added a comment. Thanks for your help! REPOSITORY R241 KIO BRANCH arcpatch-D14467 REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 15:20:41 + Build duration: 12 min and counting BUILD ARTIFACTS

D14467: Auth Support: Drop privileges if target is not owned by root

This revision was automatically updated to reflect the committed changes. Closed by commit R241:efeede07c8eb: Auth Support: Drop privileges if target is not owned by root (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14467?vs=60249=60255#toc REPOSITORY R241

D21967: Fix warning when reading plugin metadata

aacid added a comment. Right, i see the point now, would make more sense to change the line to qDebug() << "discarding" << meta.name() << obj.value(QStringLiteral("X-Purpose-PluginTypes")).toArray() << "doesn't contain" << m_pluginType; ? REPOSITORY R495 Purpose Library

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr updated this revision to Diff 60264. chinmoyr added a comment. Updated the implementation. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21782?vs=59735=60264 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 AFFECTED

D21782: Add a warning dialog with details, continue, and cancel button

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n,

D21967: Fix warning when reading plugin metadata

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Improving the string like Albert says could make sense. Also porting to qCDebug. :) REPOSITORY R495 Purpose Library BRANCH warning REVISION DETAIL https://phabricator.kde.org/D21967

D19646: Redesign config pages

ngraham added a comment. In D19646#483588 , @trmdi wrote: > Does this window have too much empty space? Can it have less? > > - I guess we wouldn't have too many devices in most of the cases. > - The device name is not often too long. So