D22018: Install KFileCustomDialog

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY API docs advertise this as public API, and it seems to be intended as such. REPOSITORY R241 KIO BRANCH master

D22022: Downgrade "Could not change permissions" dialog box to a qWarning

dfaure created this revision. dfaure added reviewers: chinmoyr, ngraham, maltek. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY We already silenced that annoying messagebox for filesystems like

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21894 To: sitter, cfeck Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20210: [Label] Bump import version so padding properties are available

broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20210 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH ellipsis REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh,

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

apol abandoned this revision. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D20193 To: apol, romangg, dfaure Cc: alexeymin, zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22015: [KUiServerJobTracker] Handle ownership change

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D22015 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22015: [KUiServerJobTracker] Handle ownership change

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Just look whether we have a new service instead of

D22018: Install KFileCustomDialog

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D22018 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir updated this revision to Diff 60467. ahmadsamir removed a subscriber: dhaumann. ahmadsamir added a comment. Use a lambda instead of adding a standalone method REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21940?vs=60154=60467 BRANCH

D22022: Downgrade "Could not change permissions" dialog box to a qWarning

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22022 To: dfaure, chinmoyr, ngraham, maltek Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60429. romangg added a comment. - Update protocol xml to wayland-protocols master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60366=60429 BRANCH dmaBuf REVISION DETAIL

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/61/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 23 Jun 2019 10:54:57 + Build duration: 1 min 19 sec and counting JUnit Tests Name:

D13150: Add ellipsis where appropriate

This revision was automatically updated to reflect the committed changes. Closed by commit R495:2eb66cbd8666: Add ellipsis where appropriate (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=60441=60445 REVISION

D22015: [KUiServerJobTracker] Handle ownership change

This revision was automatically updated to reflect the committed changes. Closed by commit R288:cf6cdbb3ad9b: [KUiServerJobTracker] Handle ownership change (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22015?vs=60417=60419

D13150: Add ellipsis where appropriate

apol added a comment. X-Purpose-Action won't get translations. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 56 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Jun 2019 10:54:57 + Build duration: 3 min 8 sec and counting BUILD ARTIFACTS

D21960: AppArmor: update syntax

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21960 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

Re: KInit - Current state and benchmarks

On Sat, 22 Jun 2019 at 11:21, David Edmundson wrote: > > Benchmarks of dolphin on a low end ARM laptop: > Dolphin via QProcess: 1233ms > Dolphin via Kinit: 1144ms > > again a consistent saving in the order of ~7% > > Initially I had wanted to scrap it, I'm now very conflicted. > > I'll try to

D13150: Add ellipsis where appropriate

nicolasfella updated this revision to Diff 60441. nicolasfella added a comment. - rename role - add file for extra translations REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=60346=60441 BRANCH ellipsis REVISION DETAIL

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir marked 5 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 138 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/138/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 23 Jun 2019 12:17:23 + Build duration: 6 min 44 sec and counting JUnit Tests Name:

D21863: [TermGenerator] Insert an empty position between independent terms

This revision was automatically updated to reflect the committed changes. Closed by commit R293:60e03a38ec61: [TermGenerator] Insert an empty position between independent terms (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. Now that we have creation date support, what do you think about adjusting the timeline to show files that were either created or modified during a given time period? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/60/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 03:06:15 + Build duration: 10 min and counting BUILD ARTIFACTS

D7446: [Places panel] Revamp the Recently Saved section

meven commandeered this revision. meven added a reviewer: ngraham. meven added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:289 > KFilePlacesItem::createSystemBookmark(d->bookmarkManager, > - QStringLiteral("Today"), >

D22061: Add a logging category for logs warnings

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Disable logs unless the logging category kf5.kconfig.kdesktopfile is enabled

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 65 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/65/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 24 Jun 2019 03:06:22 + Build duration: 3 min 13 sec and counting BUILD ARTIFACTS

D22022: Downgrade "Could not change permissions" dialog box to a qWarning

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D22022 To: dfaure, chinmoyr, ngraham, maltek Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

apol added inline comments. INLINE COMMENTS > kdesktopfile.h:27 > > +#include > +Q_DECLARE_LOGGING_CATEGORY(kconfigLoggingDesktop) Use ecm_qt_declare_logging_category from cmake. This should never be in header files too, or it would spill on applications otherwise. See for example how

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#485714 , @ngraham wrote: > Now that we have creation date support, what do you think about adjusting the timeline to show files that were either created or modified during a given time period? Well

D7446: [Places panel] Revamp the Recently Saved section

meven added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:113 > case KFilePlacesModel::RecentlySavedType: > -m_groupName = i18nc("@item", "Recently Saved"); > +m_groupName = i18nc("@item", "Recents"); > break; Rename to "Recent" REPOSITORY R241 KIO

D22061: Add a logging category for logs warnings

meven added a comment. Thank you very much again @apol for your guidance. I am not sure my naming scheme is ideal. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60547. meven added a comment. Removed blank line REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60546=60547 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22061 AFFECTED FILES

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60546. meven added a comment. Use KCONF_DESKTOP_LOG to setup logging REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60545=60546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22061 AFFECTED

D21864: [QueryTest] Test if independent phrases are really independent

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ba5de13364ed: [QueryTest] Test if independent phrases are really independent (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21864?vs=59962=60477

D21862: [QueryTest] Restructure tests to allow easier extension

This revision was automatically updated to reflect the committed changes. Closed by commit R293:dea183a02e2b: [QueryTest] Restructure tests to allow easier extension (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21862?vs=59960=60475

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 128 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/128/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 23 Jun 2019 12:32:23 + Build duration: 3 min 3 sec and counting JUnit Tests Name:

D15645: Add scheme selection menu with a "System" entry.

amhndu added a comment. Thanks for picking this up again! I'm definitely interested to resume but I've been a little busy this week. I can take a look again this weekend. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks,

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. "Recent" sounds fine to me. Feel free to commandeer this revision if you'd like to finish it up and handle the tests. These places panel tests are the bane of my existence! :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 64 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/64/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 23 Jun 2019 21:36:06 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 59 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Jun 2019 21:36:06 + Build duration: 3 min 3 sec and counting BUILD ARTIFACTS

D15739: [Places panel] Don't show Root by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:639ba4ca8e83: [Places panel] Dont show Root by default (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15739?vs=59751=60490 REVISION DETAIL

D15645: Add scheme selection menu with a "System" entry.

ngraham added a comment. @amhndu are you interested in resuming work on this? If not, please let us know so we can find someone else to take it over. Thanks! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck,

D15645: Add scheme selection menu with a "System" entry.

ngraham added a comment. OK, sounds good! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. It fixes this bug: https://bugs.kde.org/show_bug.cgi?id=348598 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking,

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#367532 , @ngraham wrote: > Using "Recently Used" as the section header label presents the following problems: > > - One of the items is named "Recently Used" > - The other items actually do not display a list

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Jun 2019 14:09:38 + Build duration: 9 min 24 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/139/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 23 Jun 2019 14:09:38 + Build duration: 8 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/139/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 23 Jun 2019 14:09:38 + Build duration: 7 min 55 sec and counting JUnit Tests Name:

D22049: pluginloader: Change behavior of X-KDE-ParentApp

bshah created this revision. bshah added reviewers: mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY X-KDE-ParentApp is the key in desktop file to display that given service or

T8349: Improve Places panel usability and presentation

meven updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham, meven Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fprice, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas,

T8349: Improve Places panel usability and presentation

meven updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham, meven Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fprice, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas,

D22055: Improve Job Dialog buttons' icons and text

ngraham created this revision. ngraham added reviewers: nicolasfella, apol, GB_2, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The buttons were on the wrong side of the window, lacked icons,

D22055: Improve Job Dialog buttons' icons and text

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R495 Purpose Library BRANCH better-job-dialog-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22055 To: ngraham, nicolasfella, apol,

D19646: Redesign config pages

ngraham added a comment. In D19646#483593 , @GB_2 wrote: > It would be great if you also improved the JobDialog buttons: > > - put them on the right > - give them icons Done with D22055

D21563: Fix empty pages in print preview and lines printed twice

ngraham edited the summary of this revision. ngraham added reviewers: Kate, KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

D21146: KProcessInfoList -- add proclist backend for FreeBSD

adridg added inline comments. INLINE COMMENTS > adridg wrote in kprocesslist_unix_procstat.cpp:38 > I absolutely have Opinions on C++ style that apply here, so I'm going to talk > to Tobias elsewhere. In order to simplify cleanup, I'd use a RAII class as well: /** @brief Wrapper around

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/128/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Jun 2019 12:17:23 + Build duration: 20 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 138 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/138/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 23 Jun 2019 12:17:23 + Build duration: 17 min and counting BUILD ARTIFACTS

D22047: Fix translation of actiondisplay

nicolasfella added a comment. @aacid and I have been working on making it possible to translate arbitrary JSON entries. See https://phabricator.kde.org/R883:1544734 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22047 To: nicolasfella, apol, aacid Cc:

D22047: Fix translation of actiondisplay

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. okay REPOSITORY R495 Purpose Library BRANCH unfuckup REVISION DETAIL https://phabricator.kde.org/D22047 To: nicolasfella, apol, aacid Cc: pino, kde-frameworks-devel, LeGast00n,

D22047: Fix translation of actiondisplay

This revision was automatically updated to reflect the committed changes. Closed by commit R495:1405e495ccab: Fix translation of actiondisplay (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22047?vs=60498=60504 REVISION

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#473734 , @ngraham wrote: > Fixes https://bugs.kde.org/show_bug.cgi?id=376270? No, that's something different. That is apparently a duplicate of https://bugs.kde.org/show_bug.cgi?id=391678 which

D21986: RFC: Change initial size of the config dialog

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I looked into what it would take to make the size adjust to its contents and I don't think it's worth the effort here due to the way this dialog is constructed. Porting to use a real

D21940: Make automatic spellcheck work after reloading a document

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me now :) REPOSITORY R39 KTextEditor BRANCH document-reloaded-spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir,

D21940: Make automatic spellcheck work after reloading a document

ahmadsamir added a comment. Great :). Please commit it too (as I don't have access to kde git). REPOSITORY R39 KTextEditor BRANCH document-reloaded-spellcheck (branched from master) REVISION DETAIL https://phabricator.kde.org/D21940 To: ahmadsamir, #ktexteditor, cullmann, dhaumann

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 57 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Jun 2019 13:23:38 + Build duration: 6 min 33 sec and counting BUILD ARTIFACTS

D22047: Fix translation of actiondisplay

nicolasfella created this revision. nicolasfella added reviewers: apol, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY To be able to be translated the entries need to be subentry of

D22047: Fix translation of actiondisplay

pino added a comment. I do not see how this is supposed to fix the translations. Nothing translates the strings statically (like the various `Name`/`Comment`/etc), nor at runtime. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22047 To: nicolasfella, apol,

D22055: Improve Job Dialog buttons' icons and text

nicolasfella accepted this revision. REPOSITORY R495 Purpose Library BRANCH better-job-dialog-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22055 To: ngraham, nicolasfella, apol, GB_2, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. Many years ago I also stumbled over this bug, and I know for sure it never was fixed. If this fix really works then this would be really great! That said I have not yet tried the patch but am positive to get this in soon! REPOSITORY R39 KTextEditor REVISION

D22055: Improve Job Dialog buttons' icons and text

This revision was automatically updated to reflect the committed changes. Closed by commit R495:cad3d131b9b9: Improve Job Dialog buttons icons and text (authored by ngraham). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22055?vs=60529=60540