D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added a comment. Ping :D REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22108: [TabBar] Remove exterior margins

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D22108#487329 , @filipf wrote: > In D22108#487218 , @ndavis wrote: > > > 1+ visually. How

D21402: Avoid double overwrite check

cullmann added a comment. Hmm, doesn't this only rely on the behavior of QFileDialog::getSaveFileUrl? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D21402 To: meven, #kate, #frameworks, cullmann Cc: kossebau, apol, dhaumann, kwrite-devel, domson, michaelh, ngraham,

D19585: [CopyJob] Report results after finishing copy

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK I see what you mean, after looking more at slotReport(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19585 To: broulik, dfaure, chinmoyr Cc:

D21882: RFC: [CopyJob] Batch reporting processed amount

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent point. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21882 To: broulik, #frameworks, dfaure, chinmoyr, ngraham Cc: kde-frameworks-devel, LeGast00n,

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > global.cpp:251 > +KIO::UDSEntry entry = job->statResult(); > +const KFileItem item = KFileItem(entry, url); > +i =

D21959: Fix selectedNameFilter() multiple matches

dfaure closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D17071: Don't include any directory sizes in DirectorySizeJob

sasch added a comment. @davidedmundson any reference or version when you plan to make this "live"? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: bruns, sasch, adridg, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22108: [TabBar] Remove exterior margins

filipf added a comment. In D22108#487218 , @ndavis wrote: > 1+ visually. How does it look with a vertical panel? Still not gliding on the line, but that should be resolved in Kickoff somehow: F6938487: image.png

D21901: Calendar events: allow plugins to show event details

dvratil added a reviewer: mart. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. On the breeze side, asside from the layout margins/spacing issues, there is at least one hard-coded pixel in the frame rendering that must be removed. In fact I have this committed in my local breeze version already. The corresponding patch is rather simple

D21901: Calendar events: allow plugins to show event details

broulik added a comment. Adding a new `virtual` to a non-leaf class is never ABI compatible. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D10747: Implement zwp_linux_dmabuf_v1

romangg added a dependent revision: D10750: wayland: Add support for zwp_linux_dmabuf. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik Cc: kde-frameworks-devel, romangg, plasma-devel,

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60729. leinir added a comment. - Work on the comments delegate's look some REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=60689=60729 BRANCH knsquick-feature-parity-with-kns (branched from master)

D21901: Calendar events: allow plugins to show event details

dvratil added a comment. So, we are doomed to `CalendarEventsPluginV2`? *sadpanda* REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21402: Avoid double overwrite check

kossebau added a comment. As wm4 just pointed out on irc, this might need fallback code for older versions of KF, no? Currently Kate has KF5_DEP_VERSION 5.40, so you might either want to bump that min dep to match the version of ktexteditor which does the check itself, or add some

D21882: RFC: [CopyJob] Batch reporting processed amount

broulik added a comment. Well, that would just be another symptom of the "doesn't call `slotReport` when finishing the call, no? cf. D19585 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21882 To: broulik, #frameworks, dfaure,

D22108: [TabBar] Remove exterior margins

apol added a comment. Makes sense to me, but why are the computer icons different? ^^' REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22108: [TabBar] Remove exterior margins

ndavis added a comment. 1+ visually. How does it look with a vertical panel? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22108: [TabBar] Remove exterior margins

filipf added a comment. In D22108#487140 , @apol wrote: > Makes sense to me, but why are the computer icons different? ^^' Some bug in Kickoff or with the icon, sometimes (maybe after you change a desktop theme) it shows the laptop icon,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

vonreth added reviewers: sitter, dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: andriusr, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven,

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60708. meven added a comment. - Add a logging category kf5.kactivity.stat REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60676=60708 BRANCH add-logging REVISION DETAIL

D22107: Add MediaTransport API

mweichselbaumer marked an inline comment as done. mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in a2dp-codecs.h:33 > Are you sure about this? Yes, this has also been fixed by bluez as of 2018-12-28. > drosca wrote in tpendingcall.h:45 > Is this really needed? In the

D22107: Add MediaTransport API

ltoscano added inline comments. INLINE COMMENTS > mweichselbaumer wrote in a2dp-codecs.h:33 > Yes, this has also been fixed by bluez as of 2018-12-28. Will it work with older versions of bluez? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22107 To:

D22107: Add MediaTransport API

mweichselbaumer added inline comments. INLINE COMMENTS > ltoscano wrote in a2dp-codecs.h:33 > Will it work with older versions of bluez? Bluez just defines this constant, but does not use it internally (nor we do). So, yes, this works with any version of bluez. REPOSITORY R269 BluezQt