D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#487307 , @hpereiradacosta wrote: > On the breeze side, asside from the layout margins/spacing issues, there is at least one hard-coded pixel in the frame rendering that must be removed. In fact I have this

D22082: WIP Add an ioslave to access KActivityStat data

meven planned changes to this revision. meven added a comment. recentlyused:/ will be moved to kio-extras. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham, ivan Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh,

D22107: Add MediaTransport API

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > mweichselbaumer wrote in tpendingcall.h:45 > Actually, my intention was to provide a type-safe way to obtain return values > from PendingCall and to express

D22107: Add MediaTransport API

mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in tpendingcall.h:45 > Alright, that makes sense. > > With KF6 we can convert all PendingCalls to this form. It would be a good > idea to add `TODO: KF6` somewhere to not forget it. Ok, i will update this patch and land it

D21427: Always skip trailing slashes in FilderedDirIterator

poboiko added a comment. Ping. I've found a way to reproduce a related issue: $ mkdir ~/test $ balooctl config add includeFolders ~/test $ balooctl stop $ balooctl start This prints an error: replace called with invalid arguments, docId: url: "~/test/"

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. ather simple and attached. Feel free to add this or something similar to any other modification you plan to do. F6938398: patch.diff > Thank you very much Hugo.. that pixel was driving me mad ;) > Do you want to

D22082: WIP Add an ioslave to access KActivityStat data

meven planned changes to this revision. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham, ivan Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60779. meven added a comment. - Add proper logging using ECMQtDeclareLoggingCategory REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60708=60779 BRANCH add-logging REVISION DETAIL

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60782. meven added a comment. - Add proper logging using ECMQtDeclareLoggingCategory REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60779=60782 BRANCH add-logging REVISION DETAIL

D22082: WIP Add an ioslave to access KActivityStat data

meven planned changes to this revision. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham, ivan Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

ngraham added reviewers: Frameworks, cfeck, dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, cfeck, dfaure Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 60781. leinir added a comment. Bunch of work on the comments (especially avatar stuff). In progress, of course, but the concept is there - Add an Author component to the QtQuick bits - Add Providers functionality for fetching person data - Add

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN Build kdeinit5 kdebugsettings REPOSITORY R159 KActivities Statistics BRANCH

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:19 > As we want to reuse the source files also with the tests, better store in a > separate var here, e.g. named `KActivitiesStats_LOG_SRCS`. > And add this manually to KActivitiesStats_LIB_SRCS and for the test as

D22147: Better use of Qt APIs in Plasma::Theme

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Try not to access hashes repeatedly. QRegExp -> QRegularExpression. REPOSITORY

D21563: Fix empty pages in print preview and lines printed twice

cullmann added a comment. I tried to reproduce the issue with and without this fix but I somehow fail. Has somebody else more luck? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: cullmann, dhaumann, ngraham,

D21563: Fix empty pages in print preview and lines printed twice

dhaumann added a comment. I will test tomorrow ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert, #kate, #ktexteditor Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking,

D22069: Localize long number strings

ilic added a comment. The way forward is to find out why making that one dot-to-comma change and having fr_FR.utf8 glibc locale installed is not sufficient to get the test to pass. To my understanding, an explicit QLocale::setDefault() call either 1) should not be necessary, or 2) it should

D22108: [TabBar] Remove exterior margins

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tabbar-margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham, ndavis Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh,

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham updated this revision to Diff 60801. ngraham added a comment. Simplify logic to address review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13048?vs=60649=60801 BRANCH arcpatch-D13048 REVISION DETAIL https://phabricator.kde.org/D13048

D22147: Better use of Qt APIs in Plasma::Theme

broulik added inline comments. INLINE COMMENTS > svg.cpp:313 > // and store them locally. > -QRegExp > sizeHintedKeyExpr(CACHE_ID_NATURAL_SIZE(QStringLiteral("(\\d+)-(\\d+)-(.+)"), > status, ratio)); > +const QRegularExpression >

D22095: Fix CMake COMMAND nested paren highlighting

smokris updated this revision to Diff 60819. smokris retitled this revision from "Fix CMake add_custom_command() paren highlighting" to "Fix CMake COMMAND nested paren highlighting". smokris edited the summary of this revision. smokris edited the test plan for this revision. smokris added a

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert added a comment. In D21563#487947 , @cullmann wrote: > I tried to reproduce the issue with and without this fix but I somehow fail. > Has somebody else more luck? Try with long log files like boot.log, dmesg.log or

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 70 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/70/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 29 Jun 2019 03:20:00 + Build duration: 3 min 5 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 65 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 29 Jun 2019 03:20:00 + Build duration: 4 min 49 sec and counting BUILD ARTIFACTS

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 60788. meven added a comment. Remove default debug option sevirity at debug REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60787=60788 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22144

D21901: Calendar events: allow plugins to show event details

ngraham added a comment. Unrelatedly, if you don't already have KOrganizer installed, it would be really nice if clicking on a day in the calendar showed a message that you need to install KOrganizer to create events, with a button that installs it via PackageKit when clicked on. That would

D22102: Implement apply-on-double-click for all grid view KCM delegates

ngraham added a comment. Maybe I should move back and examine the rationale for the proposal. Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons, wallpapers, etc. The workflow is to click on the delegate, and then click on the Apply button

D22082: WIP Add an ioslave to access KActivityStat data

meven abandoned this revision. meven added a comment. Abandoned in favor of D22144 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham, ivan Cc: ivan, kde-frameworks-devel,

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven created this revision. meven added reviewers: ivan, Frameworks, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prior to finish D7446

D22144: - Add kio recentlyused:/ to access KactivitytStats data

meven updated this revision to Diff 60789. meven added a comment. Improve declared protocol REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=60788=60789 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D22143: Add proper logging using ECMQtDeclareLoggingCategory

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:21 > > + ${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp > + Instead of relying on an undocumented cpp file name generated by ecm_qt_declare_logging_category, you rather want to have a separate SRC variable which

D22069: Localize long number strings

ngraham added a comment. Ping! What is the path forward here? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh,