D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

2019-07-19 Thread Nathaniel Graham
ngraham edited the summary of this revision.
ngraham added reviewers: Kate, KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22574

To: ngraham, #kate, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

2019-07-19 Thread Nathaniel Graham
ngraham created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  kateview's "Switch input mode" feature is currently bound to [Ctrl] + [⇧] + 
[V] This
  causes two problems:
  
  1. When the embedded konsolepart is visible, both it and Kate claim the same 
shortcu so neither works
  2. At other times, it's easily possible to accidentally enter vi mode when 
you mean to paste due to residual muscle memory from having pasted test in 
Konsole recently
  
  For these reasons, this patch changes the default shortcut to [Ctrl] + [Alt] 
+ [V], which
  is also kind of more elegant anyway since it now uses the [Alt] key and 
triggers
  alternate input modes.
  
  BUG: 409978
  FIXED-INL 5.61

TEST PLAN
  1. Compile
  2. Open Kate
  3. Hit [Ctrl] + [⇧] + [V] and see that nothing happens
  4. Copy some text
  5. Open embedded Konsole and paste text with [Ctrl] + [⇧] + [V] and see that 
it works
  6. Hit [Ctrl] + [Alt] + [V] and see that it enters vi mode

REPOSITORY
  R39 KTextEditor

BRANCH
  remap-change-input-mode-shortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22574

AFFECTED FILES
  src/view/kateview.cpp

To: ngraham
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D22570: Expose X-KDE-Wayland-Interfaces

2019-07-19 Thread Aleix Pol Gonzalez
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

TEST PLAN
  See kwin patch

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22570

AFFECTED FILES
  src/services/application.desktop

To: apol, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D17816: Support for xattrs on kio copy/move

2019-07-19 Thread Nathaniel Graham
ngraham added a comment.


  @cochise are you planning to resume work on this? If not, we may have to find 
someone else to finish it up, because I'd really like to get it in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh


D22567: TypeScript: fix keywords in conditional expressions

2019-07-19 Thread Nibaldo González
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Now, keywords are highlighted before ":" in conditional expressions, for 
example:
  
a = b ? false : true;

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  condexp-typescript

REVISION DETAIL
  https://phabricator.kde.org/D22567

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/html/test.ts.html
  autotests/input/test.ts
  autotests/reference/test.ts.ref
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D22569: [Dialog] Apply window type after changing flags

2019-07-19 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Changing flags might override the window type, ensure we set it back properly

TEST PLAN
  Changed window flags, dialog had the correct type again afterwards. KWin 
doesn't handle this properly but I'm on it. It's in preparation for 
notification quick reply feature

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22569

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-07-19 Thread Nathaniel Graham
ngraham added a comment.


  Ping. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns


D22568: Fix generator and test paths of CMake

2019-07-19 Thread Nibaldo González
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In D22095  the location of the CMake 
highlighter files was changed, the previous paths are restored.
  
  /generators/ -> /data/generators/
  /input/ -> /autotests/input/
  /reference/ -> /autotests/reference/
  /html/ -> /autotests/html/

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-paths-cmake

REVISION DETAIL
  https://phabricator.kde.org/D22568

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  autotests/html/highlight.cmake.html
  autotests/input/highlight.cmake
  autotests/reference/highlight.cmake.ref
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  generators/cmake.xml.tpl
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:67
> +  else()
> +set(HAVE_DBUSMENUQT 0)
> +  endif()

Here

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Piyush Aggarwal
brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 62069.
brute4s99 added a comment.


  updated

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22554?vs=62051=62069

BRANCH
  arcpatch-D22554

REVISION DETAIL
  https://phabricator.kde.org/D22554

AFFECTED FILES
  src/CMakeLists.txt

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, right, of course. Makes sense.

REPOSITORY
  R293 Baloo

BRANCH
  no-indexcleaner-assert (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22557

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D22419: Fix cant enter directory error on Android FTP servers

2019-07-19 Thread NXiss7
nxiss7 updated this revision to Diff 62067.
nxiss7 edited the summary of this revision.
nxiss7 added a comment.


  Fixed comment.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22419?vs=61647=62067

REVISION DETAIL
  https://phabricator.kde.org/D22419

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: nxiss7, #frameworks
Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Piyush Aggarwal
brute4s99 added a comment.


  In D22554#497984 , @nicolasfella 
wrote:
  
  > Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case
  
  
  Which line number are you referring to?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Stefan Brüns
bruns added a comment.


  In D22557#498002 , @ngraham wrote:
  
  > Shouldn't we make sure that entries get removed from the config file 
properly?
  
  
  An entry may become valid again.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D22557

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-19 Thread Gleb Popov
arrowd added a reviewer: Frameworks.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks
Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-19 Thread Gleb Popov
arrowd added a comment.


  In D22525#497556 , @cfeck wrote:
  
  > Oh, if the latter syntax also works, then you are right.
  
  
  Not sure what you mean by "also works". Current code checks if the URL ends 
with `:x:y` and turns it into `?line=x=y`. This is used to open local 
text files at the given cursor position. However, for URL's like 
`http://localhost:3000` it is invalid to perform such transformation. My patch 
checks URL scheme and applies the transformation only if it is `file://`.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd
Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-19 Thread Nathaniel Graham
ngraham added a comment.


  @bruns, is this good to go now?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 137 - Still Unstable!

2019-07-19 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/137/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 19 Jul 2019 14:16:43 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13392)18%
(1824/9898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1419/3490)28%
(794/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2025)18%
(317/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

2019-07-19 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/10/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 19 Jul 2019 14:16:38 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 14 - Still Unstable!

2019-07-19 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/14/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 19 Jul 2019 14:16:38 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3627/13391)18%
(1823/9898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1419/3490)28%
(794/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)28%
(574/2024)18%
(316/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
  

D22546: Add missing components in org.kde.plasma.components 3.0

2019-07-19 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f04584d4235a: Add missing components in 
org.kde.plasma.components 3.0 (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22546?vs=62019=62061

REVISION DETAIL
  https://phabricator.kde.org/D22546

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmacomponents3/qmldir

To: apol, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22546: Add missing components in org.kde.plasma.components 3.0

2019-07-19 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22546

To: apol, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Nathaniel Graham
ngraham added a comment.


  Shouldn't we make sure that entries get removed from the config file properly?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D22557

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


Re: kdewebkit tarball gone missing?!

2019-07-19 Thread Friedrich W. H. Kossebau
Am Freitag, 19. Juli 2019, 09:05:39 CEST schrieb Volker Krause:
> On Thursday, 18 July 2019 00:15:16 CEST René J. V. Bertin wrote:
> > Albert Astals Cid wrote:
> > > https://download.kde.org/stable/frameworks/5.60/portingAids/
> > 
> > Ah, thanks, I must have missed the announcement of its promotion.
> > 
> > So what kind of tier is kdesigner-plugin now - I still have it 
categorised
> > as a tier3 but those are supposed to depend only on tier1, tier2 and 
tier3
> > frameworks, no? ;)
> 
> Even independent of the dependency rules, webkit support in the designer
> plugin is a good point to look at.
> 
> There's three options I see:
> (1) remove webkit support from the designer plugin entirely
> (2) move webkit support from the designer plugin to a separate plugin part
> of the webkit repo
> (3) ignore the problem given it's an optional dependency
> 
> I'd vote vote for (1) as we obviously don't want to promote usage of the
> obsolete module, so not offering it in the designer palette anymore seems a
> step in that direction (and wouldn't break existing code).

IMHO the complete module kdesigner-plugin is a bit broken approach:
* being separate from the actual widget code and thus running chance of not 
getting updated in case widgets get extended/added/deprecated
* defeating the idea of independent modules in KDE Frameworks a bit, if you 
want to have designer support for KItemViews, but pulling in all the other 
widget-providing modules from KDE Frameworks.

IMHO it should be an optional feature to build per widget providing module. 
And then the plugins should simply become part of the devel packages per 
module.

I'd be willing to work on (2) to give a sample. And then work on all the 
other

Cheers
Friedrich




D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-19 Thread David Faure
dfaure added a comment.


  I like very much your proposal about using two classes to avoid reintroducing 
problems in the future.
  
  I like a lot less the use of exceptions, generally speaking... one uncaught 
exception and it's the end of the world.
  But OK I see that in this case, there is a clear layer where all exceptions 
are caught, so this typical pitfall is avoided. I guess I can make an exception 
to my rule about exceptions, haha :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-19 Thread Harald Sitter
sitter added a comment.


  Something like this https://phabricator.kde.org/P439

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Nicolas Fella
nicolasfella added a comment.


  Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22419: Fix cant enter directory error on Android FTP servers

2019-07-19 Thread NXiss7
nxiss7 edited the summary of this revision.
nxiss7 edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22419

To: nxiss7, #frameworks
Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns


D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-19 Thread Harald Sitter
sitter added a comment.


  Hm. I've had a quick look and I think the intent was that only the slavebase 
overridden functions call error or finished. So technically all internal 
functions that can have an error need to set an iError or return one so that 
the "public" function can then issue error() as needed. This seems to not very 
well enforced and probably never was, in fact there's a comment in the .h about 
this very fact
  
// 
// All the methods named ftpXyz are lowlevel methods that are not exported.
// The implement functionality used by the public high-level methods. Some
// low-level methods still use error() to emit errors. This behaviour is not
// recommended - please return a boolean status or an error code instead!
// 
  
  What I think may be best to resolve this is to split the class in two.
  
  The "public" class only has overrides of SlaveBase. It's functions are the 
only ones that may issue `error()` or `finished()`.
  The "private" class has all the supporting functions and has no access to 
SlaveBase so it cannot issue error or finished.
  This should be a very durable solution as even in the future no one will 
accidentally add another call to error or finished in one of the internal 
functions since they are in a different object and all error handling must be 
done via iError or some other system.
  
  In fact, I am thinking this is a case where one could just use exceptions. 
The private class could throw a simple exception on errors and in the public 
class we'd need nothing more than a try{}catch in all the public functions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

2019-07-19 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/4/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 19 Jul 2019 10:42:38 +
 Build duration:
1 hr 53 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-19 Thread David Faure
dfaure added a comment.


  Please wait.
  
  This is a partial revert of my earlier commit to this file -- not exactly, 
but it feels like there is a bit of a mess regarding the question of whether 
error() was already emitted or not.
  I made the assumption that statusServerError meant error was already emitted 
(by earlier function calls) but it now seems this assumption was wrong.
  But then it feels like we're playing ping-pong with this code in a way that 
will never be satisfactory, if various error cases have or have not already 
emitted error() at this point.
  This needs further research and cleanups.
  
  Well, presumably we're better off with this patch in than out, so actually if 
you want to commit, I (or someone else...) can do the research either way.
  
  Does anyone know which methods are supposed to call error() and which methods 
are supposed to just set iError and let the caller do it? Right now it seems to 
be a bit of a mess...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Andrius da Costa Ribas
andriusr added inline comments.

INLINE COMMENTS

> CMakeLists.txt:79
> +  endif()
>  endif()
>  

extra `endif()` ?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

2019-07-19 Thread Igor Poboiko
poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D22502

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D22557: [IndexCleaner] ignore non-existent entries inside config

2019-07-19 Thread Igor Poboiko
poboiko created this revision.
poboiko added reviewers: Baloo, bruns, ngraham.
Herald added projects: Frameworks, Baloo.
poboiko requested review of this revision.

REVISION SUMMARY
  If a folder was added to include/excludeFolders and then removed,
  there will be a stale entry in the config, for which `filePathToId`
  yields 0. When passed to `removeRecursively`, it might reinterpret it
  as tree root, which is not something we want (although there are
  checks for it inside `WriteTransaction`)
  
  See also D22502: [FileIndexerConfig] skip invalid entries from 
included/excludedFolders 

REPOSITORY
  R293 Baloo

BRANCH
  no-indexcleaner-assert (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22557

AFFECTED FILES
  src/file/indexcleaner.cpp

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D22555: [RFC] Add a kded module to manage various available fuse mount services

2019-07-19 Thread Fabian Vogt
fvogt added inline comments.

INLINE COMMENTS

> mountservicemanager.cpp:42
> +{
> +KConfigGroup cfg = 
> KConfigGroup(KSharedConfig::openConfig(QStringLiteral("fusemanagerrc")), 
> QStringLiteral("Fuse Services"));
> +return cfg.readEntry(url.scheme(), QString());

This line is the only place "fuse" is ever mentioned, so maybe this should be 
renamed?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22555

To: chinmoyr, fvogt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22555: [RFC] Add a kded module to manage various available fuse mount services

2019-07-19 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision.
chinmoyr added a reviewer: fvogt.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This module watches the install directories of kded modules and curates a 
list of modules having plugin Category=MountService.
  This list will be used by a kio kcm which will allow users to configure mount 
service for remote protocol.
  Once loaded this module can be used in KIOSlave::listDir to mount the url and 
in KRun::resolveUrls to convert the
  remote URL to local URL.

REPOSITORY
  R241 KIO

BRANCH
  monitorprotocol

REVISION DETAIL
  https://phabricator.kde.org/D22555

AFFECTED FILES
  src/CMakeLists.txt
  src/mountserviced/CMakeLists.txt
  src/mountserviced/mountservicemanager.cpp
  src/mountserviced/mountservicemanager.desktop
  src/mountserviced/mountservicemanager.h
  src/mountserviced/org.kde.kio.MountServiceManager.xml

To: chinmoyr, fvogt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Piyush Aggarwal
brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 62051.
brute4s99 added a comment.


  updated

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22554?vs=62048=62051

BRANCH
  arcpatch-D22554

REVISION DETAIL
  https://phabricator.kde.org/D22554

AFFECTED FILES
  src/CMakeLists.txt

To: brute4s99, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:70
> +
> +  if (TARGET Qt5::DBus)
> +qt5_add_dbus_adaptor(knotifications_SRCS 
> org.kde.StatusNotifierItem.xml

Now we have two checks for this

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-07-19 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 62049.
leinir added a comment.


  - Refactor the naming of components etc a touch (and hide private bits)
  - Fix a few bits of stray naming in the docs

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=61905=62049

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Piyush Aggarwal
brute4s99 created this revision.
brute4s99 added reviewers: nicolasfella, broulik.
brute4s99 added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
brute4s99 requested review of this revision.

REVISION SUMMARY
  remove another dependency related to DBus from Windows builds

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22554

AFFECTED FILES
  src/CMakeLists.txt

To: brute4s99, nicolasfella, broulik
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22536: Don't advertise using KPassivePopup

2019-07-19 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R239:9f55912f1ae3: Dont advertise using KPassivePopup 
(authored by nicolasfella).

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22536?vs=61999=62047

REVISION DETAIL
  https://phabricator.kde.org/D22536

AFFECTED FILES
  src/kdeui/ksystemtrayicon.h

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D17595: Upstream Dolphin's file rename dialog

2019-07-19 Thread Méven Car
meven marked 4 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham


D17595: Upstream Dolphin's file rename dialog

2019-07-19 Thread Méven Car
meven marked 4 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> sitter wrote in renamefiledialog.h:72
> You'll also want to override `event` as per 
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

Thanks
This is really arcane, I am really not found of C++.

> sitter wrote in renamefiledialog.h:76
> You can in fact make the class forward declaration and the member declaration 
> one line
> 
> `class RenameFileDialogPrivate *const d;`

I tried it but it did not work.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham


D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-19 Thread Yaroslav Sidlovsky
ZaWertun added a comment.


  In D22528#497803 , @sitter wrote:
  
  > Looks good to me. The slave indeed must issue an exit state there.
  >
  > What email address would you like to have associated with the git commit?
  
  
  zawer...@gmail.com
  
  Thanks!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22551: expose new KBusyIndicatorWidget

2019-07-19 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: alexmerry.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  recently added to kwidgetsaddons

TEST PLAN
  - shows up in desinger
  - can be added to widget
  - running through designer shows the indicator as expected

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22551

AFFECTED FILES
  src/kde.widgets
  src/kdewidgets.qrc
  src/pics/CMakeLists.txt
  src/pics/kbusyindicatorwidget.png

To: sitter, alexmerry
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D17595: Upstream Dolphin's file rename dialog

2019-07-19 Thread Harald Sitter
sitter added inline comments.

INLINE COMMENTS

> renamefiledialog.h:72
> +protected:
> +void showEvent(QShowEvent* event) override;
> +

You'll also want to override `event` as per 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

> renamefiledialog.h:75
> +private:
> +class RenameFileDialogPrivate;
> +RenameFileDialogPrivate *const d;

This is now forward declared twice.

> renamefiledialog.h:76
> +class RenameFileDialogPrivate;
> +RenameFileDialogPrivate *const d;
> +};

You can in fact make the class forward declaration and the member declaration 
one line

`class RenameFileDialogPrivate *const d;`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham


D22523: Remove visibilityChanged connection in favor of existing eventFilter

2019-07-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:d4af86d8d56d: Remove visibilityChanged connection in 
favor of existing eventFilter (authored by broulik).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22523?vs=61953=62036

REVISION DETAIL
  https://phabricator.kde.org/D22523

AFFECTED FILES
  src/kmainwindow.cpp

To: broulik, #frameworks, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-07-19 Thread Harald Sitter
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Looks good to me. The slave indeed must issue an exit state there.
  
  What email address would you like to have associated with the git commit?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D21782: Add a warning dialog with details, continue, and cancel button

2019-07-19 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible 
details section. (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21782?vs=60264=62033#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21782?vs=60264=62033

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns


D21782: Add a warning dialog with details, continue, and cancel button

2019-07-19 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns


D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

2019-07-19 Thread Méven Car
meven updated this revision to Diff 62027.
meven added a comment.


  Remove dead code

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=60913=62027

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh


D17595: Upstream Dolphin's file rename dialog

2019-07-19 Thread Méven Car
meven updated this revision to Diff 62026.
meven added a comment.


  Add context about filename #

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=62005=62026

BRANCH
  arcpatch-D17595

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham


Re: kdewebkit tarball gone missing?!

2019-07-19 Thread Volker Krause
On Thursday, 18 July 2019 00:15:16 CEST René J. V. Bertin wrote:
> Albert Astals Cid wrote:
> > https://download.kde.org/stable/frameworks/5.60/portingAids/
> 
> Ah, thanks, I must have missed the announcement of its promotion.
> 
> So what kind of tier is kdesigner-plugin now - I still have it categorised
> as a tier3 but those are supposed to depend only on tier1, tier2 and tier3
> frameworks, no? ;)

Even independent of the dependency rules, webkit support in the designer 
plugin is a good point to look at.

There's three options I see:
(1) remove webkit support from the designer plugin entirely
(2) move webkit support from the designer plugin to a separate plugin part of 
the webkit repo
(3) ignore the problem given it's an optional dependency

I'd vote vote for (1) as we obviously don't want to promote usage of the 
obsolete module, so not offering it in the designer palette anymore seems a 
step in that direction (and wouldn't break existing code).

Opinions?

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.


D19986: Install .desktop file for kded5

2019-07-19 Thread David Faure
dfaure added a comment.


  OK, changed in 
https://commits.kde.org/kded/b733c88e2d70db854cf99466ef52c9a3f9db118e

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D19986

To: davidedmundson, ivan
Cc: rjvbb, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns


D22523: Remove visibilityChanged connection in favor of existing eventFilter

2019-07-19 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Good catch.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D22523

To: broulik, #frameworks, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns