D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

ngraham edited the summary of this revision. ngraham added reviewers: Kate, KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22574 To: ngraham, #kate, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham,

D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart

ngraham created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ngraham requested review of this revision. REVISION SUMMARY kateview's "Switch input mode" feature is currently bound to [Ctrl] + [⇧] + [V] This causes two

D22570: Expose X-KDE-Wayland-Interfaces

apol created this revision. apol added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN See kwin patch REPOSITORY R309 KService BRANCH master REVISION DETAIL

D17816: Support for xattrs on kio copy/move

ngraham added a comment. @cochise are you planning to resume work on this? If not, we may have to find someone else to finish it up, because I'd really like to get it in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns,

D22567: TypeScript: fix keywords in conditional expressions

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Now, keywords are

D22569: [Dialog] Apply window type after changing flags

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Changing flags might override the window type, ensure we set it back properly TEST

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. Ping. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22568: Fix generator and test paths of CMake

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In D22095

D22554: Finer No-Dbus on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:67 > + else() > +set(HAVE_DBUSMENUQT 0) > + endif() Here REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel,

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62069. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62051=62069 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22557: [IndexCleaner] ignore non-existent entries inside config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, right, of course. Makes sense. REPOSITORY R293 Baloo BRANCH no-indexcleaner-assert (branched from master) REVISION DETAIL https://phabricator.kde.org/D22557 To: poboiko,

D22419: Fix cant enter directory error on Android FTP servers

nxiss7 updated this revision to Diff 62067. nxiss7 edited the summary of this revision. nxiss7 added a comment. Fixed comment. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22419?vs=61647=62067 REVISION DETAIL https://phabricator.kde.org/D22419 AFFECTED FILES

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. In D22554#497984 , @nicolasfella wrote: > Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case Which line number are you referring to? REPOSITORY R289 KNotifications REVISION DETAIL

D22557: [IndexCleaner] ignore non-existent entries inside config

bruns added a comment. In D22557#498002 , @ngraham wrote: > Shouldn't we make sure that entries get removed from the config file properly? An entry may become valid again. REPOSITORY R293 Baloo REVISION DETAIL

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

arrowd added a reviewer: Frameworks. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#497556 , @cfeck wrote: > Oh, if the latter syntax also works, then you are right. Not sure what you mean by "also works". Current code checks if the URL ends with `:x:y` and turns it into `?line=x=y`.

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

ngraham added a comment. @bruns, is this good to go now? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/137/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 19 Jul 2019 14:16:43 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 19 Jul 2019 14:16:38 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/14/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 19 Jul 2019 14:16:38 + Build duration: 12 min and counting BUILD ARTIFACTS

D22546: Add missing components in org.kde.plasma.components 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f04584d4235a: Add missing components in org.kde.plasma.components 3.0 (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22546: Add missing components in org.kde.plasma.components 3.0

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22546 To: apol, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22557: [IndexCleaner] ignore non-existent entries inside config

ngraham added a comment. Shouldn't we make sure that entries get removed from the config file properly? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22557 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson,

Re: kdewebkit tarball gone missing?!

Am Freitag, 19. Juli 2019, 09:05:39 CEST schrieb Volker Krause: > On Thursday, 18 July 2019 00:15:16 CEST René J. V. Bertin wrote: > > Albert Astals Cid wrote: > > > https://download.kde.org/stable/frameworks/5.60/portingAids/ > > > > Ah, thanks, I must have missed the announcement of its

D22528: KIO FTP: Fix file copy hanging when copying to existing file

dfaure added a comment. I like very much your proposal about using two classes to avoid reintroducing problems in the future. I like a lot less the use of exceptions, generally speaking... one uncaught exception and it's the end of the world. But OK I see that in this case, there is a

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Something like this https://phabricator.kde.org/P439 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

nicolasfella added a comment. Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron,

D22419: Fix cant enter directory error on Android FTP servers

nxiss7 edited the summary of this revision. nxiss7 edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: aacid, svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. Hm. I've had a quick look and I think the intent was that only the slavebase overridden functions call error or finished. So technically all internal functions that can have an error need to set an iError or return one so that the "public" function can then issue

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/4/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 19 Jul 2019 10:42:38 + Build duration: 1 hr 53 min and counting JUnit Tests Name:

D22528: KIO FTP: Fix file copy hanging when copying to existing file

dfaure added a comment. Please wait. This is a partial revert of my earlier commit to this file -- not exactly, but it feels like there is a bit of a mess regarding the question of whether error() was already emitted or not. I made the assumption that statusServerError meant error was

D22554: Finer No-Dbus on Windows

andriusr added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > + endif() > endif() > extra `endif()` ? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D22557: [IndexCleaner] ignore non-existent entries inside config

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY If a folder was added to include/excludeFolders and then removed, there will be a stale entry in the config, for

D22555: [RFC] Add a kded module to manage various available fuse mount services

fvogt added inline comments. INLINE COMMENTS > mountservicemanager.cpp:42 > +{ > +KConfigGroup cfg = > KConfigGroup(KSharedConfig::openConfig(QStringLiteral("fusemanagerrc")), > QStringLiteral("Fuse Services")); > +return cfg.readEntry(url.scheme(), QString()); This line is the only

D22555: [RFC] Add a kded module to manage various available fuse mount services

chinmoyr created this revision. chinmoyr added a reviewer: fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This module watches the install directories of kded modules and curates a list of

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62051. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62048=62051 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:70 > + > + if (TARGET Qt5::DBus) > +qt5_add_dbus_adaptor(knotifications_SRCS > org.kde.StatusNotifierItem.xml Now we have two checks for this REPOSITORY R289 KNotifications REVISION DETAIL

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 62049. leinir added a comment. - Refactor the naming of components etc a touch (and hide private bits) - Fix a few bits of stray naming in the docs REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=61905=62049

D22554: Finer No-Dbus on Windows

brute4s99 created this revision. brute4s99 added reviewers: nicolasfella, broulik. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY remove another dependency related to DBus from Windows builds

D22536: Don't advertise using KPassivePopup

This revision was automatically updated to reflect the committed changes. Closed by commit R239:9f55912f1ae3: Dont advertise using KPassivePopup (authored by nicolasfella). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22536?vs=61999=62047 REVISION

D17595: Upstream Dolphin's file rename dialog

meven marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham Cc: sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D17595: Upstream Dolphin's file rename dialog

meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS > sitter wrote in renamefiledialog.h:72 > You'll also want to override `event` as per > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B Thanks This is really arcane, I am really not

D22528: KIO FTP: Fix file copy hanging when copying to existing file

ZaWertun added a comment. In D22528#497803 , @sitter wrote: > Looks good to me. The slave indeed must issue an exit state there. > > What email address would you like to have associated with the git commit? zawer...@gmail.com

D22551: expose new KBusyIndicatorWidget

sitter created this revision. sitter added a reviewer: alexmerry. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY recently added to kwidgetsaddons TEST PLAN - shows up in desinger - can be added

D17595: Upstream Dolphin's file rename dialog

sitter added inline comments. INLINE COMMENTS > renamefiledialog.h:72 > +protected: > +void showEvent(QShowEvent* event) override; > + You'll also want to override `event` as per https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > renamefiledialog.h:75 >

D22523: Remove visibilityChanged connection in favor of existing eventFilter

This revision was automatically updated to reflect the committed changes. Closed by commit R263:d4af86d8d56d: Remove visibilityChanged connection in favor of existing eventFilter (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Looks good to me. The slave indeed must issue an exit state there. What email address would you like to have associated with the git commit? REPOSITORY R241 KIO REVISION DETAIL

D21782: Add a warning dialog with details, continue, and cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible details section. (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21782?vs=60264=62033#toc REPOSITORY R236

D21782: Add a warning dialog with details, continue, and cancel button

chinmoyr edited the summary of this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21782 To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, sbergeron,

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven updated this revision to Diff 62027. meven added a comment. Remove dead code REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21204?vs=60913=62027 BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 AFFECTED FILES

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 62026. meven added a comment. Add context about filename # REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=62005=62026 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.org/D17595 AFFECTED FILES

Re: kdewebkit tarball gone missing?!

On Thursday, 18 July 2019 00:15:16 CEST René J. V. Bertin wrote: > Albert Astals Cid wrote: > > https://download.kde.org/stable/frameworks/5.60/portingAids/ > > Ah, thanks, I must have missed the announcement of its promotion. > > So what kind of tier is kdesigner-plugin now - I still have it

D19986: Install .desktop file for kded5

dfaure added a comment. OK, changed in https://commits.kde.org/kded/b733c88e2d70db854cf99466ef52c9a3f9db118e REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D19986 To: davidedmundson, ivan Cc: rjvbb, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22523: Remove visibilityChanged connection in favor of existing eventFilter

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good catch. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D22523 To: broulik, #frameworks, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, sbergeron,