KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 44 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 07 Aug 2019 03:02:41 + Build duration: 25 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 81 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/81/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 07 Aug 2019 03:03:15 + Build duration: 19 min and counting JUnit Tests

D22795: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R276:20239e47fd06: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau).

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 06 Aug 2019 15:20:50 + Build duration: 3 min 48 sec and counting JUnit Tests

D22792: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R277:76190778d99c: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau).

D22793: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R284:12ca6c1a9db9: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau).

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 06 Aug 2019 14:06:22 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D22777: Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin

kossebau updated this revision to Diff 63204. kossebau added a comment. replace own copy with official ECMAddQtDesignerPlugin REPOSITORY R300 KDEWebKit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22777?vs=62643=63204 BRANCH useecmaddqtdesignerplugin REVISION DETAIL

D22784: Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R298:cc27fa4fa59b: Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets (authored by kossebau). REPOSITORY

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 To: apol, #frameworks, #kirigami, mart Cc: broulik, plasma-devel, fbampaloukas, domson, dkardarakos, apol,

D22946: Include API to generically implement --replace arguments

apol added a dependent revision: D22967: Let KDBusService deal with the replace option. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

apol added a comment. I wonder if it would make sense to include an enum NoOption=0 value, so that we don't need to cast the 0 into the enum (see D22967 ). Thoughts? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To:

D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ac9379916066: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D22798: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was automatically updated to reflect the committed changes. Closed by commit R263:e529dfc6dd38: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D22777: Use ECMAddQtDesignerPlugin instead of private copy

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R300:d5a670544243: Use ECMAddQtDesignerPlugin instead of private copy (authored by kossebau). REPOSITORY R300 KDEWebKit

D22777: Use ECMAddQtDesignerPlugin instead of private copy

kossebau retitled this revision from "Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin" to "Use ECMAddQtDesignerPlugin instead of private copy". kossebau edited the summary of this revision. REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D22777 To: kossebau,

D22708: [WIP] Add a kded module infra for fuse mount services

ngraham added a comment. What? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22708 To: chinmoyr Cc: ngraham, andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

This revision was automatically updated to reflect the committed changes. Closed by commit R169:19d09d1ef958: Kirigami.Icon: Fix loading bigger images when source is a URL (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D22968: Make it possible to modify contacts

apol created this revision. apol added reviewers: Frameworks, jbbgameich, bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Includes a vcard field so that backends can feed all of the data through

D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R302:8688829b71e8: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau).

D22794: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was automatically updated to reflect the committed changes. Closed by commit R246:5972d780aa43: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22794?vs=62702=63199#toc

D22725: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:080aeaab100c: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau).

D22968: Make it possible to modify contacts

apol added a dependent revision: D22969: Make it possible to modify vcards. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22791: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was automatically updated to reflect the committed changes. Closed by commit R310:c5ddbb38d455: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22791?vs=62698=63194#toc

D22796: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R265:09e0e78cc093: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON (authored by kossebau).

Coding style: white space around asterisks

Hi, Frameworks C++ coding style for pointer declarations follows the asterisk to the right approach like Qt coding style recommends. This is most often a sensible choice but is difficult to read in my opinion when there is no identifier to the right the asterisk is associated with, for example

D22975: [GridDelegate] Don't select unselected item when clicking on any of its action buttons

ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22975 To: ngraham, broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/8/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 06 Aug 2019 19:45:10 + Build duration: 14 min and counting BUILD ARTIFACTS

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 63224. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=61912=63224 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/51/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 06 Aug 2019 19:45:11 + Build duration: 8 min 46 sec and counting BUILD ARTIFACTS

D10747: Implement zwp_linux_dmabuf_v1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:1dd57d909165: Implement zwp_linux_dmabuf_v1 (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST

D22975: [GridDelegate] Don't select unselected item when clicking on any of its action buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R296:661695fdc532: [GridDelegate] Dont select unselected item when clicking on any of its action… (authored by ngraham). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D10747: Implement zwp_linux_dmabuf_v1

romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, sgureev,

D22975: [GridDelegate] Don't select unselected item when clicking on any of its action buttons

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY In 6258f33fce3af55f7cdd3b5487cd04d8e53c0b38

D22975: [GridDelegate] Don't select unselected item when clicking on any of its action buttons

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH fix-delegate-selection-on-action-trigger (branched from master) REVISION DETAIL https://phabricator.kde.org/D22975 To: ngraham, broulik, #plasma Cc: kde-frameworks-devel,

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/7/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 06 Aug 2019 19:45:10 + Build duration: 5 min 52 sec and counting JUnit Tests Name:

D22979: Security: remove support for $(...) in config keys with [$e] marker.

dfaure updated this revision to Diff 63239. dfaure added a comment. Also update docu, patch by David Edmundson, thanks REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22979?vs=63238=63239 BRANCH security_kill_popen REVISION DETAIL

D22979: Security: remove support for $(...) in config keys with [$e] marker.

dfaure created this revision. dfaure added reviewers: mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY It

D22979: Security: remove support for $(...) in config keys with [$e] marker.

aacid added a reviewer: security-team. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22979: Security: remove support for $(...) in config keys with [$e] marker.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH security_kill_popen REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc:

D22979: Security: remove support for $(...) in config keys with [$e] marker.

kossebau added inline comments. INLINE COMMENTS > options.md:70 > > If an entry is marked with `$e`, environment variables and shell commands > will > be expanded. "and shell commands" to be dropped here no? REPOSITORY R237 KConfig BRANCH security_kill_popen REVISION DETAIL

D22979: Security: remove support for $(...) in config keys with [$e] marker.

mdawson added a comment. LGTM. Regarding the test, if we want to get this change in asap due to the security focus I can submit a follow up patch re-adding it. INLINE COMMENTS > kconfigtest.cpp:530 > << "URL[$e]=file://${HOME}/foo" << endl > -<<

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 07 Aug 2019 03:02:40 + Build duration: 5 min 49 sec and counting JUnit Tests

D22958: Add initial Android support to ecm_add_app_icon

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ECMAddAppIcon.cmake:157 > +else() > +install(FILES ${icon_full} DESTINATION > ${KDE_INSTALL_QMLDIR}/org/kde/kirigami.2/icons/

D22958: Add initial Android support to ecm_add_app_icon

nicolasfella added a comment. Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein, #frameworks, mart, leinir, apol Cc: nicolasfella, kde-frameworks-devel,

D22531: [KColorSchemeManager] Optimize preview generation

This revision was automatically updated to reflect the committed changes. Closed by commit R265:31b32aac5dd0: [KColorSchemeManager] Optimize preview generation (authored by broulik). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22531?vs=61977=63170

D22528: KIO FTP: Fix file copy hanging when copying to existing file

dfaure added a comment. I can't say if this is better in or out, since it's broken in any case. We're playing ping-pong with broken code, but sure, whatever, if you think it's better with this commit than with the earlier equally broken two versions, I'm not objecting. Is your work on

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. In D22528#507373 , @dfaure wrote: > Is your work on a proper two-classes solution not ready? Nope, I haven't made any progress on it beyond what I posted. I briefly looked at a testing setup to make sure stuff

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol updated this revision to Diff 63172. apol added a comment. Remove unneeded code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22952?vs=63167=63172 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 AFFECTED FILES src/icon.cpp

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in icon.cpp:424 > What happens if you leave `format` `nullptr`, does it guess? yes, it seems to work. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22952 To: apol,

D22964: [ColorButton] Forward accepted signal from ColorDialog

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to react to the user explicitly accepting the dialog and picking a

D22964: [ColorButton] Forward accepted signal from ColorDialog

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22964 To: broulik, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22964: [ColorButton] Forward accepted signal from ColorDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R296:94413385e228: [ColorButton] Forward accepted signal from ColorDialog (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

broulik added inline comments. INLINE COMMENTS > icon.cpp:406 > +m_networkReply = qnam->get(request); > +connect(m_networkReply.data(), ::finished, this, > [this](){handleFinished(m_networkReply); }); > } Just noticed, doesn't the `m_networkReply` leak? It's not deleted in

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

sitter removed a reviewer: sitter. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D19514 To: jpalecek Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22960: Add handle icons

apol accepted this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22960 To: hein, #frameworks, apol, mart Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol updated this revision to Diff 63167. apol added a comment. Also fix a memory leak REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22952?vs=63153=63167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 AFFECTED FILES

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

broulik added inline comments. INLINE COMMENTS > icon.cpp:412 > +{ > +reply->deleteLater(); > +if (!reply) { Move this after the `!reply` check > icon.cpp:424 > +const QString filename = reply->url().fileName(); > +if (!m_loadedImage.load(reply, >

D22958: Add initial Android support to ecm_add_app_icon

hein abandoned this revision. hein added a comment. Marco explained privately he doesn't want this so I'll move it to my codebase for now until the alternative better thing appears. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein,

D22708: [WIP] Add a kded module infra for fuse mount services

chinmoyr abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22708 To: chinmoyr Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22958: Add initial Android support to ecm_add_app_icon

hein added a comment. In D22958#507299 , @nicolasfella wrote: > Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well? Mostly because I don't know what assumptions Kirigami makes. Its own macro is hardcoded to only

D22960: Add handle icons

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22960 To: hein, #frameworks, apol, mart Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D15675: [sftp] Reformat sftpProtocol::GetRequest::GetRequest()

This revision was automatically updated to reflect the committed changes. Closed by commit R320:9890674aa265: [sftp] Reformat sftpProtocol::GetRequest::GetRequest() (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15675?vs=42243=63164#toc REPOSITORY R320 KIO Extras