D23336: KDirOperator: Add follow new directories option

2019-08-24 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks, dfaure, cfeck, pino Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23201: [KDirOperator] Middle-elide labels that are too long to fit

2019-08-24 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH middle-elide-kdiroperator-labels (branched from master) REVISION DETAIL https://phabricator.kde.org/D23201 To: ngraham, #vdg, elvisangelaccio Cc: kde-frameworks-devel,

D23416: Highlighting indexer: check kateversion

2019-08-24 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Checks that files using are in version 5.53 and that contexts do not reference a

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 25 Aug 2019 03:00:42 + Build duration: 8 min 59 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 24 Aug 2019 03:04:19 + Build duration: 1 day 0 hr and counting JUnit Tests Name: projectroot

D23400: reST: handle some more corner cases, add an actual test file

2019-08-24 Thread Vladimír Vondruš
mosra updated this revision to Diff 64515. mosra added a comment. Bumped the version. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23400?vs=64481=64515 REVISION DETAIL https://phabricator.kde.org/D23400 AFFECTED FILES

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 36 - Fixed!

2019-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/36/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 25 Aug 2019 02:49:43 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Fixed!

2019-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 25 Aug 2019 02:49:43 + Build duration: 1 min 17 sec and counting JUnit Tests Name:

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-24 Thread Kevin Kofler
kkofler added a comment. If you ask me (there are 2 Kevins on this bug), I think this will work. I think it's kinda overkill (it pretty much defeats the point of having version-specific libexecdirs if we end up renaming the binaries anyway), but if it works (which should be the case), I'm

D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-08-24 Thread Nathaniel Graham
ngraham added reviewers: dfaure, cfeck, pino. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23388: add a border for the toolbars WIP

2019-08-24 Thread Aleix Pol Gonzalez
apol added a comment. Well it's the same color, it just looks okay. Set the applications' color scheme to another one and you'll see what I mean. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23388 To: camiloh, #plasma, mart, ngraham, apol Cc:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 25 Aug 2019 03:26:24 + Build duration: 1 min 40 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 25 Aug 2019 03:14:46 + Build duration: 7 min 17 sec and counting JUnit Tests Name:

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2019-08-24 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Hmm I see this is only about the (few) entries in the Places view, not about general navigation into subsubdirs. So my initial comment was a bit nonsense. INLINE COMMENTS > anthonyfieroni

D23336: KDirOperator: Add follow new directories option

2019-08-24 Thread David Faure
dfaure added a comment. This sounds like two different options to me. Sure, right now, for this use case, you need to toggle them both together, but then one day some application will want to follow dirs in treeviews, just not when creating directories, or vice versa. REVISION DETAIL

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Ivan Čukić
ivan added inline comments. INLINE COMMENTS > query.h:105 > +void setUrlFilters(const QStringList ); > +void setType(const Terms::Type ); > +void setAgent(const Terms::Agent ); I screwed up the names - plurals vs singulars here as `Agent` can contain several agents - having

D23193: Add support for Belarusian currency

2019-08-24 Thread Shubham
shubham added a reviewer: broulik. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D23193 To: shubham, #frameworks, ngraham, broulik Cc: #frameworks, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23194: Making FileJob behave consistently.

2019-08-24 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Unittests are missing. INLINE COMMENTS > filejob.h:110 > /** > - * Data from the slave has arrived. > + * Data from the slave has arrived. emitted after read(). > +

BluezQt GATT client API

2019-08-24 Thread Иван Подкурков
Hello, I have a question regarding BluezQt library. In recent commits I see that the functionality for Bluetooth Low Energy (GATT) was added, but I don't see the way to act as a client, i.e. to read GATT characteristics from other devices. There is one test called leserver.cpp /

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Ivan Čukić
ivan added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:109 > We don't have yet set function for Activity, Type, Agent, and Url only add. > Which means we would need to use query.addActivity(QStringList() << ":any")) > sometimes for instance, that is not ideal since it

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Méven Car
meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399

D23336: KDirOperator: Add follow new directories option

2019-08-24 Thread Nathaniel Graham
ngraham accepted this revision. REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks, dfaure, cfeck, pino, ngraham Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-24 Thread Christoph Cullmann
cullmann added a comment. Ok, Kevin, ok with this variant, too? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8810 To: cullmann, #frameworks, kfunk, kkofler, dfaure Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfunk, LeGast00n, GB_2, michaelh, bruns

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Méven Car
meven updated this revision to Diff 64501. meven added a comment. Only have set*(Term), add setter for date REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23399?vs=64475=64501 BRANCH master REVISION DETAIL

D23400: reST: handle some more corner cases, add an actual test file

2019-08-24 Thread Dominik Haumann
dhaumann added a comment. Nice, can you increase the "version" number in the language xml element such that we uniquely can identify the version? This is helpful, since older versions of Kate allow to download updates via the settings dialog. REPOSITORY R216 Syntax Highlighting REVISION

D23411: Fix crash in writer collection and cleanup

2019-08-24 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY WriterCollection was apparently never used. It

D23344: assert slave command finality

2019-08-24 Thread David Faure
dfaure added a comment. I see those warnings often, so I'm a bit worried that this will make kioslaves quite crashy for KDE developers for a while, including those unable to fix those issues. At least we need to fix known issues first, like kio_ftp. How about we both (and ZaWertun)

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Méven Car
meven updated this revision to Diff 64475. meven added a comment. Add QStringList setters REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23399?vs=64474=64475 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399 AFFECTED

D23336: KDirOperator: Add follow new directories option

2019-08-24 Thread Daan De Meyer
daandemeyer updated this revision to Diff 64477. daandemeyer added a comment. Split `followDirectories` option into `followNewDirectories` and `followSelectedDirectories` options. `followSelectedDirectories` only applies to tree views. Let me know if you want the option name to include that

D23400: reST: handle some more corner cases, add an actual test file

2019-08-24 Thread Vladimír Vondruš
mosra created this revision. mosra added reviewers: cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mosra requested review of this revision. REVISION SUMMARY I'm writing reST quite a lot and finally got to the point

D23193: Add support for Belarusian currency

2019-08-24 Thread Shubham
shubham updated this revision to Diff 64488. shubham added a comment. Move currency to its proper place alphabetically REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23193?vs=63838=64488 BRANCH currency REVISION DETAIL

D23393: Use special values constants in terms.cpp

2019-08-24 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R159:703b81da467c: Use special values constants in terms.cpp (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23393?vs=64462=64473

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:91 > I started my work upon the recentdocument ioslave that used it and > ForwardingSlaveBase documentation states "It has been designed to support > only local filesystem like ioslaves.. If the resulting ioslave

D23336: [KDirOperator] Add follow new directories options

2019-08-24 Thread Nathaniel Graham
ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks, dfaure, cfeck, pino, ngraham Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23336: [KDirOperator] Add follow new directories options

2019-08-24 Thread Nathaniel Graham
ngraham retitled this revision from "KDirOperator: Add follow new directories option" to "[KDirOperator] Add follow new directories options". REVISION DETAIL https://phabricator.kde.org/D23336 To: daandemeyer, #frameworks, dfaure, cfeck, pino, ngraham Cc: dhaumann, ngraham,

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ivan wrote in query.h:105 > I screwed up the names - plurals vs singulars here as `Agent` can contain > several agents - having `Agent::current` looked better than `Agents::current`. > > We'll need to do

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Méven Car
meven updated this revision to Diff 64504. meven added a comment. Use set*(Term) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64454=64504 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23061: Possiblity to change Definition data after loading

2019-08-24 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > sirgienko wrote in definition.h:339 > I more thinking in variant, when the highlighting more dynamic, and is done > more, that one time. For example, in Cantor, we rehighlight whole worksheet, > when a new variable created in curresponding

D23371: Markdown: multiple improvements and fixes

2019-08-24 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23371 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D23388: add a border for the toolbars WIP

2019-08-24 Thread Camilo Higuita
camiloh added a comment. In D23388#517778 , @apol wrote: > I don't think we can use Kirigami here, it will use the wrong color scheme. You'll have to copy over the Separator's rectangle. It seems to take the right color: In the

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Méven Car
meven planned changes to this revision. meven added a comment. inherit from SlaveBase instead of ForwardingSlaveBase REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio,

D23385: More porting from QRegExp to QRegularExpression

2019-08-24 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:b5c37d88de4e: More porting from QRegExp to QRegularExpression (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23385?vs=64443=64509

D23410: improve word completion to use highlighting to detect word boundaries

2019-08-24 Thread Christoph Cullmann
cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY This allows better completion e.g. for Perl or PHP BUG:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 53 - Fixed!

2019-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/53/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 24 Aug 2019 13:05:14 + Build duration: 5 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 24 Aug 2019 14:05:40 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

2019-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 24 Aug 2019 14:05:39 + Build duration: 2 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 35 - Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/35/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 24 Aug 2019 14:05:40 + Build duration: 2 min 29 sec and counting BUILD ARTIFACTS

D23061: Possiblity to change Definition data after loading

2019-08-24 Thread Christoph Cullmann
cullmann added a comment. I think this features fits what you need. Not sure if it is super useful in a lot other cases, as e.g. reloading the repository will reset all changes and one does need to trigger rehighlight oneself if one changes keywords. But I think the added API is small

D23201: [KDirOperator] Middle-elide labels that are too long to fit

2019-08-24 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f05f67d79cad: [KDirOperator] Middle-elide labels that are too long to fit (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23201?vs=63860=64510

D23393: Use special values constants in terms.cpp

2019-08-24 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23393 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 52 - Fixed!

2019-08-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/52/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 24 Aug 2019 13:01:22 + Build duration: 3 min 39 sec and counting BUILD ARTIFACTS

D23336: [KDirOperator] Add follow new directories options

2019-08-24 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:50a4bc8e5205: [KDirOperator] Add follow new directories options (authored by daandemeyer, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23193: Add support for Belarusian currency

2019-08-24 Thread Shubham
shubham added a comment. In D23193#513023 , @ngraham wrote: > I can't get the new currency to actually show up in KRunner when I test the patch. Does it work for you? It did worked before when I uploaded the patch first time, now

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-24 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R159:e67c20ab0f69: Add setter to Type, Activity, Agent and UrlFilter query fields (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D23193: Add support for Belarusian currency

2019-08-24 Thread Nathaniel Graham
ngraham added a comment. If our data source doesn't include the necessary data, then this can't possibly work, right? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D23193 To: shubham, #frameworks, ngraham Cc: #frameworks, kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Unstable!

2019-08-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 24 Aug 2019 18:40:30 + Build duration: 7 min 14 sec and counting JUnit Tests Name:

D23344: assert slave command finality

2019-08-24 Thread Harald Sitter
sitter added a comment. Yeah, it's certainly a very aggressive change. I also think we need this to be outside kdeinit5, otherwise unit tests won't crash since they generally should fork directly. That being said, as a first step maybe we can have this enabled on the CI and see if existing

D23410: improve word completion to use highlighting to detect word boundaries

2019-08-24 Thread Christoph Cullmann
cullmann added a comment. I am not 100% sure about the if (c.isLetterOrNumber() || c.isMark() || c == QLatin1Char('_')) change, but all other locations did only check for LetterOrNumber + _ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To:

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Ivan Čukić
ivan added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:109 > Tried implementing this in D23372 but > @ivan was not found of it because of induced complexity it entails to work > properly. Also, there are `set*` and `add*` member

D23157: Expose technology property in battery interface

2019-08-24 Thread Méven Car
meven added a dependent revision: D23392: [energy KCM] Add battery Technology. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23157 To: meven, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23393: Use special values constants in terms.cpp

2019-08-24 Thread Méven Car
meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN Compiles REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Méven Car
meven added inline comments. INLINE COMMENTS > ivan wrote in recentlyused.cpp:109 > Also, there are `set*` and `add*` member functions which can be used for > non-chained changes. We don't have yet set function for Activity, Type, Agent, and Url only add. Which means we would need to use

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

2019-08-24 Thread Volker Krause
vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-24 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Seems to work for me. But it's weird that the KIO unittests don't work for you... we should fix that. Make sure to edit the commit log so it doesn't look like this RR's description anymore, if needed. REPOSITORY R241 KIO

D23371: Markdown: multiple improvements and fixes

2019-08-24 Thread Nibaldo González
nibags updated this revision to Diff 64463. nibags added a comment. - Fix bug in blockquotes and improve integration with R Markdown REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23371?vs=64395=64463 BRANCH improve-markdown REVISION DETAIL

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-24 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 64465. leinir added a comment. - Use the image's Ready status, rather than just the url availability REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64426=64465 BRANCH knsquick-feature-parity-with-kns

D23336: KDirOperator: Add follow new directories option

2019-08-24 Thread Daan De Meyer
daandemeyer updated this revision to Diff 64466. daandemeyer added a comment. Added default value to documentation. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23336?vs=64436=64466 REVISION DETAIL https://phabricator.kde.org/D23336 AFFECTED FILES

D23336: KDirOperator: Add follow new directories option

2019-08-24 Thread Daan De Meyer
daandemeyer added a comment. The use case is showing a project tree view in an application where we want the root of the KDirOperator to stay fixed. The initial motivation for this change was replicating the File Explorer from Visual Studio Code (text editor) where one opens a folder and

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > recentlyused.h:46 > + * yesterday respectively. > + * ISODATE must be of the form -MM-DD ( is year, NN month, DD day > of month) > + * If a secondary date is passed, the filtering occurs on the date range > starting NN should be

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas,

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-24 Thread Méven Car
meven updated this revision to Diff 64454. meven added a comment. Fix ISDATE description REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64406=64454 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED