D23730: Add new protocol for 7z archives

ngraham accepted this revision. ngraham added reviewers: dfaure, pino, cfeck. ngraham added a comment. Yeah, I agree that the name is not 100% ideal, but honestly that's an implementation detail that shouldn't block this. The code and functionality look sound! REPOSITORY R320 KIO Extras

D23780: Add new protocol for 7z archives

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23780 To: nhiga, #frameworks, cfeck, pino, dfaure, meven, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23696: completion: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok, push after tagging. Thanks for taking care again! REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_completion REVISION DETAIL

D23782: Add "edit-none-border" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY F7329452: edit-none-border Icon.png For D23779

D23782: Add "edit-none-border" icon

GB_2 added a comment. In D23782#527558 , @broulik wrote: > Shouldn't it be "edit-border-none"? No, then it doesn't fall back to `edit-none`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2,

D23778: Remove superfluous >22px recent documents icons

ngraham added a comment. In D23778#527411 , @ndavis wrote: > I think we should still have 24px icons for compatibility, but since they're exactly the same as the 22px icons with wider margins, it might be better to generate 24px icons at build

D23782: Add "edit-none-border" icon

GB_2 added a comment. The fallback is needed, because Plasma 5.17 depends on Frameworks 5.62, which was already tagged and `edit-none` was the best fallback I could find. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: trickyricky26,

D23782: Add "edit-none-border" icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I think it would be better if this icon had bits int he corners like many of the existing breeze icons: F7330296: Screenshot_20190908_074450.png

D23782: Add "edit-none-border" icon

ndavis added a comment. This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than `edit-none`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26,

D23782: Add "edit-none-border" icon

broulik added a comment. In D23782#527560 , @GB_2 wrote: > No, then it doesn't fall back to `edit-none`. Alright, makes sense. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis

D23787: [baloo_file_extractor] Improve handling of large plain-text files

broulik added inline comments. INLINE COMMENTS > app.cpp:183 > +// have trouble processing them > +if ((ex->extractorProperties()["Name"].toString() == > QLatin1String("PlaintextExtractor")) && (QFileInfo(url).size() >= 10 * 1024 * > 1024)) { > +qCWarning(BALOO) <<

D23782: Add "edit-none-border" icon

GB_2 added a comment. In D23782#527672 , @ndavis wrote: > This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than `edit-none`. Yeah, maybe it's best if we just use that.

D23782: Add "edit-none-border" icon

GB_2 abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23411: Fix crash in writer collection and cleanup

astippich added inline comments. INLINE COMMENTS > apol wrote in writer.h:63 > Why's this change? This is only for cleanup and consistency with the corresponding extractor class. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns,

D23782: Add "edit-none-border" icon

ngraham added a comment. On one hand I kind of agree with @kbroulik about the name choice, but on the other hand the fallback seems appropriate too. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: ngraham, broulik,

D23782: Add "edit-none-border" icon

ndavis added a comment. What is this icon used for? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D19087 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: mgallien, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D19088: Use propertymap to store properties in Baloo::Result

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH propertymap REVISION DETAIL https://phabricator.kde.org/D19088 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D23782: Add "edit-none-border" icon

trickyricky26 added a comment. In D23782#527623 , @ndavis wrote: > What is this icon used for? @GB_2 used it here: https://phabricator.kde.org/D23779#527639. It is used for the KWin no window border context menu entry. REPOSITORY R266

D23761: Make small recent documents icons look like documents and improve clock emblems

trickyricky26 added a comment. In D23761#527355 , @meven wrote: > Is that the expected result ? > > F7328222: Screenshot_20190907_230008.png > > If so, it needs some polishing IMO. In your

D23787: [baloo_file_extractor] Improve handling of large plain-text files

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY First of all, not all plain text-based mimetypes starts with `text/`: i.e. `application/sql` for SQL dumps

D23778: Remove superfluous >22px recent documents icons

ndavis added a comment. For now In D23778#527622 , @ngraham wrote: > In D23778#527411 , @ndavis wrote: > > > I think we should still have 24px icons for compatibility, but since they're exactly

D23696: completion: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7679bf28f6c0: completion: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23766: FakeInput: add support for keyboard key press and release

davidedmundson added a comment. +1 INLINE COMMENTS > jgrulich wrote in fakeinput.h:222 > I will need a little bit of help to understand what type of key event should > be used and I don't remember where I got the information it expects codes > defined from linux/input-event-codes.h (I

D10362: Change reveal password button logic

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik, ndavis Cc: ndavis, kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/63/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Sep 2019 12:58:55 + Build duration: 7 min 41 sec and counting JUnit Tests Name:

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

davidedmundson added inline comments. INLINE COMMENTS > author.h:37 > + */ > +class Author : public QObject > +{ Use of QQmlParserStatus would help here. It means we can defer initial resetConnections until all 3 initial properties are set. REPOSITORY R304 KNewStuff REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Sep 2019 14:53:31 + Build duration: 1 min 21 sec and counting JUnit Tests Name:

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Generates additional macros in the export header which can be used for fine-grained

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

broulik added inline comments. INLINE COMMENTS > author.h:111 > + */ > +void setProfilepage(const QString ); > + `ProfilePage`? > commentsmodel.cpp:184 > +default: > +value.setValue(i18nc("The value returned for an unknown role > when requesting data from

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Current version works already quite well, developed against applying it to a few tier-1 and tier-2 KDE Frameworks modules. A few corner casess still need care, but otherwise already pretty much a prototype which is not too far from a production version. So

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

cgiboudeaux added a comment. Tests needed :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23791: ECMAddQch: add INCLUDE_DIRS argument

kossebau created this revision. kossebau added a reviewer: Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows to have headers be found by doxygen,

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Sep 2019 22:09:55 + Build duration: 8 min 53 sec and counting JUnit Tests Name:

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

ngraham added a dependent revision: D23730: Add new protocol for 7z archives. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, #frameworks, cfeck, pino, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23780: Add new protocol for 7z archives

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23780 To: nhiga, #frameworks, cfeck, pino, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23730: Add new protocol for 7z archives

ngraham edited the summary of this revision. ngraham added dependencies: D23780: Add new protocol for 7z archives, D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven

D23780: Add new protocol for 7z archives

ngraham added a dependent revision: D23730: Add new protocol for 7z archives. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23780 To: nhiga, #frameworks, cfeck, pino, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns