KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/15/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Sep 2019 09:10:35 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23935

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

[Méven Car]

meven updated this revision to Diff 66028.
meven added a comment.


  Add a KF6 clean up todo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23851?vs=65795=66028

BRANCH
  arcpatch-D23851

REVISION DETAIL
  https://phabricator.kde.org/D23851

AFFECTED FILES
  src/core/emptytrashjob.cpp

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Title of this diff must be changed before push.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23411: Fix crash in writer collection and cleanup

[Alexander Stippich]

astippich added a comment.


  friendly ping. Since this solves a crash and I want to start using the 
writers in Elisa, I would like to have it rather sooner in a frameworks release 
and I'm away the next weeks

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D23411

To: astippich, bruns, mgallien, ngraham
Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23917: Use const_iterator

[Frederik Gladhorn]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23917?vs=66021=66027

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

[Frederik Gladhorn]

gladhorn added inline comments.

INLINE COMMENTS

> romangg wrote in dpms.h:44
> Yea, maybe just write that this class is meant to create the DPMS object 
> below only. You already have the information you provided here there then.

I agree. The first two lines are actually repetitions and they don't say what 
the class is good for at all. I'll update this.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D23915

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

[Frederik Gladhorn]

gladhorn updated this revision to Diff 66026.
gladhorn retitled this revision from "Add some docstrings" to "Improve 
documentation

Some of the documentation did not say what the purpose of the
respective class was, but rather gave a tautology.
For people new to the code base it helps to mention that
DPMS is power management.

That DataDevice is for copy...".
gladhorn edited the summary of this revision.
gladhorn added a comment.


  Updating D23915: Improve documentation
  ==
  
  Some of the documentation did not say what the purpose of the
  respective class was, but rather gave a tautology.
  For people new to the code base it helps to mention that
  DPMS is power management.
  
  That DataDevice is for copy...

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23915?vs=65941=66026

BRANCH
  arcpatch-D23915

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/datadevice_interface.h
  src/server/dpms_interface.h

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks good, thanks for Windows patches.

REPOSITORY
  R39 KTextEditor

BRANCH
  modemenu-search

REVISION DETAIL
  https://phabricator.kde.org/D23935

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23917: Use const_iterator

[Frederik Gladhorn]

gladhorn updated this revision to Diff 66021.
gladhorn edited the summary of this revision.
gladhorn removed subscribers: broulik, zzag.
gladhorn added a comment.


  Fixed two missing spots

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23917?vs=65946=66021

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, broulik, 
zzag

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23935

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23917: Use const_iterator

[Frederik Gladhorn]

gladhorn added a comment.


  Yes, for me always using constBegin/constEnd makes reading the code slightly 
easier.

INLINE COMMENTS

> zzag wrote in registry.cpp:879
> constEnd

Thanks!

> zzag wrote in output_interface.cpp:119
> constEnd

Thanks!

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: broulik, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  modemenu-search

REVISION DETAIL
  https://phabricator.kde.org/D23935

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23119: Fix dates being on the wrong locale when setting an application language individually

[Alexander Semke]

asemke added a comment.


  In D23119#524720 , @aacid wrote:
  
  > In D23119#519676 , @asemke wrote:
  >
  > > The original problem in LabPlot was reported by a windows user. The 
proposed fix won't fix the problem on windows. I think the only way to get the 
proper strings on Windows is to get the current language of the application, to 
create a QLocale with the proper language and to use QLocale::toString(const 
QDateTime , const QString )... If this is correct, then we're 
are back to my original question I asked on IRC/Matrix - how to determine the 
current application language?
  >
  >
  > Are you saying that the old code actually half works on Windows?
  
  
  What works on windows well is switching of the application language in 
general:
  F7349563: labplot_ukrainisch.png 
  
  Here you see the current release candidate running on windows. The windows 
desktop is German, the application language in LabPlot was set to Ukrainian. 
This works well. What doesn't work is the handling of QDate/QDateTime that is 
shown in the menu on this screenshot and marked red. Originally this problem 
was reported to us for the German-English combination (desktop in German, 
application language English).
  
  > I find that surprising since it means that setting the LANGUAGE environment 
variable on Windows does things, which according to a quick internet search 
doesn't seem to be the case
  
  I don't understand the whole mechanism here now but I see that 
kswitchlanguagedialog_p.cpp writes the new language into the new file 
klanguageoverridesrc. The content of this file for the example above is
  
[language]
labplot2=@ByteArray(uk:en_US)
  
  I assume, based on this information, and not on the value of LANGUAGE which 
is not existing on Windows, the i18n-stuff is properly initialized and we show 
the correct strings.
  
  Btw, klanguageoverridesr is put into QStandardPaths::GenericConfigLocation 
which is C:/Users//AppData/Local on Windows.I'd say this is wrong and 
nedds to go into the Roaming folder.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: yurchor, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Kf6 ideally we drop this whole class and the new event handlers will do 
everything properly without these hacks...let's see.

REPOSITORY
  R296 KDeclarative

BRANCH
  qwheelevent

REVISION DETAIL
  https://phabricator.kde.org/D23894

To: dfaure, mart, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns