arojas added a reviewer: Frameworks.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D24020
To: arojas, #frameworks
Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/4/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sat, 21 Sep 2019 13:25:10 +
Build duration:
45 min and counting
JUnit Tests
Name:
GB_2 added a comment.
Ping.
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19620
To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh,
bruns
elvisangelaccio added inline comments.
INLINE COMMENTS
> pajamapants3000 wrote in ktextedit.cpp:373
> Thank you broulik! Could we use a `QScopedPointer` here? I see them
> throughout the KDE source, but not often for dialogs. The krazy analysis
> looked for `QPointer`, referencing blog
ognarb abandoned this revision.
ognarb added a comment.
I completly forgot about this patch and since KHTML is dead and is getting
removed from most of our apps, it doesn't makes sence to land this patch.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D19620
To:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/4/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Sat, 21 Sep 2019 13:25:10 +
Build duration:
5 min 12 sec and counting
BUILD ARTIFACTS
dfaure added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in kcoredirlister.cpp:1044
> Noted.
Actually, I was wrong.
I talked to the head of the LLVM/clang development team at Apple and he told me
that returning a const value has zero effect whatsoever. I.e. in the version of
your
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/4/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Sat, 21 Sep 2019 13:25:10 +
Build duration:
12 min and counting
BUILD ARTIFACTS
ngraham added a comment.
Isn't KHTML deprecated at this point? Does this actually need to happen?
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19620
To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis,
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REVISION SUMMARY
They are not namespaced and promote the use of pixmaps rather than
icons. Additionally their API allowing to specify
vkrause added a task: T8837: QColor support for Grantlee.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D24060
To: vkrause, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D24020
To: arojas, #frameworks, dfaure
Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:faff4ff246af: Add app icon for the Kirogi Drone control
app (authored by Rafael Brandmaier rafael.brandma...@kdemail.net).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
trickyricky26 updated this revision to Diff 66594.
trickyricky26 added a comment.
- A tiny bit more optimized
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21169?vs=57954=66594
BRANCH
kirogi-app-icon (branched from master)
REVISION DETAIL
ognarb added a comment.
kde.org/applications use the icons from breeze-icons. So I think it's worth
adding to breeze-icons or improving how the icon are fetched in
kde.org/applications.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D21169
To: trickyricky26,
trickyricky26 added a comment.
Should I land this or abandon it?
It doesn't really make a difference if the icon is in Breeze in addition to
being shipped with the app, but IMO it would also be strange to not have this
Breeze-style icon for a KDE app in Breeze.
REPOSITORY
R266 Breeze
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Shipit!
REPOSITORY
R266 Breeze Icons
BRANCH
kirogi-app-icon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21169
To: trickyricky26, hein, #vdg, ngraham
Cc:
ngraham added a comment.
+1
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D24136
To: vkrause
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
LOL I had no idea that one could do SmallIcon("foo", KIconLoader::SizeLarge)
;-)
I think 95% of the uses of these functions only specifies one argument.
Then again, I
dfaure added a comment.
kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
(and that's all I can find in all of KF5)
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D24136
To: vkrause, dfaure
Cc: dfaure, ngraham, kde-frameworks-devel, LeGast00n,
20 matches
Mail list logo
