D24434: Fix include path to kjob.h

hallas created this revision. hallas added reviewers: dfaure, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fix include path to kjob.h. When kcoreaddons is installed all the headers files

D24434: Fix include path to kjob.h

hallas added a comment. @dfaure - I just found that if you include `KListOpenFilesJob` from e.g. Dolphin then it fails because it cannot include `jobs/kjob.h` :( It would be really nice to have this commit in the coming Frameworks release, do you think that is possible? Sorry for

D24326: Add syntax highlighting for RenPy (.rpy)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:4e278a1c3e47: Add syntax highlighting for RenPy (.rpy) (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24326?vs=67235=67358

D24433: Move URL parsing methods from kioslave to query object

iasensio created this revision. iasensio added reviewers: Baloo, meven. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY This allows for query objects generated from

D23800: Use ECMGenerateExportHeader to manage deprecated API better

mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. The change looks good and builds in various combinations of CMake options (after I installed the changeset from D23789 ). I encountered that excluding

D24415: Add standard icons to support to all entries in QDialogButtonBox

GB_2 updated this revision to Diff 67336. GB_2 marked 2 inline comments as done. GB_2 added a comment. Address comments REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24415?vs=67329=67336 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 130 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/130/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 05 Oct 2019 05:43:45 + Build duration: 22 min and counting BUILD ARTIFACTS

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24419 AFFECTED

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 247 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/247/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 05 Oct 2019 05:43:45 + Build duration: 24 min and counting BUILD ARTIFACTS

D24046: Allow triggering sort from QML

jbbgameich added a comment. why not Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override { QSortFilterProxyModel::sort(column, order); } instead of adding a new function? REPOSITORY R307 KPeople REVISION DETAIL

D24416: Declare Calendar::Ptr as metatype

vkrause added a comment. Ok as such, but there seem to be unrelated changes to test scripts in this commit. REVISION DETAIL https://phabricator.kde.org/D24416 To: nicolasfella, #frameworks, vkrause

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 12:19:32 + Build duration: 1 min 53 sec and counting JUnit Tests Name:

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. Wooh! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andreaska,

D24416: Declare Calendar::Ptr as metatype

nicolasfella updated this revision to Diff 67347. nicolasfella added a comment. Revert accidental change CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24416?vs=67330=67347 BRANCH metatype REVISION DETAIL https://phabricator.kde.org/D24416 AFFECTED FILES src/calendar.h To:

D24412: Add edit-line-width icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

trickyricky26 planned changes to this revision. trickyricky26 added a comment. In D24412#542056 , @ndavis wrote: > I think something similar to this line width icon would work well: F6304104: Lines.png >

D24415: Add standard icons to support to all entries in QDialogButtonBox

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24415 To: GB_2, #frameworks, #vdg, davidedmundson, ngraham Cc: ndavis, dhaumann, davidedmundson, #vdg,

D24415: Add standard icons to support to all entries in QDialogButtonBox

davidedmundson accepted this revision. REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24415 To: GB_2, #frameworks, #vdg, davidedmundson, ngraham Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, LeGast00n,

D24412: Add edit-line-width icons

trickyricky26 updated this revision to Diff 67348. trickyricky26 added a comment. - Use design with multiple lines of different thickness REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24412?vs=67319=67348 BRANCH add-line-width-icon (branched from

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. I wonder how to untangle this dependency, because a change in Frameworks can't (shouldn't?) depend on a change in a consumer (yes, same issues as toys). REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 14:58:03 + Build duration: 1 min 15 sec and counting JUnit Tests Name:

D24416: Declare Calendar::Ptr as metatype

vkrause accepted this revision. This revision is now accepted and ready to land. BRANCH metatype REVISION DETAIL https://phabricator.kde.org/D24416 To: nicolasfella, #frameworks, vkrause

D24416: Declare Calendar::Ptr as metatype

nicolasfella closed this revision. REVISION DETAIL https://phabricator.kde.org/D24416 To: nicolasfella, #frameworks, vkrause

D24389: Fix klistopenfilesjob header file not being installed

hallas added a comment. In D24389#541644 , @dfaure wrote: > `git tag` doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so this commit will be included. > > (I do that on the first Saturday of the month) Phew :) Glad

D24384: Move Amusement to Games directory instead of Games > Toys

This revision was automatically updated to reflect the committed changes. Closed by commit R309:9f4b516eac6b: Move Amusement to Games directory instead of Games Toys (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D17595: Upstream Dolphin's file rename dialog

ngraham added a comment. In D17595#542142 , @meven wrote: > I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it. > It reminds of the importance of signing FLA to KDE

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY In freedesktop.org specification, the category is Network. Most applications under this category can also be used

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a dependency: D24424: Create kf5-network.directory. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

meven added a comment. I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it. It reminds of the importance of signing FLA to KDE e.V. So this is good to follow through the normal review process. @dfaure I

Re: Framework for encrypted storage for apps

Hi Johan, One important question here is how do you want the secrets to be unlocked. Is the user going to type in some master password every time the otpclient is started? If that is the case, you can use QCA to encrypt and decrypt the data you need to store securely. If that is not the case

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to manage deprecated API better" to "Use ECMGenerateExportHeader to manage deprecated API better". kossebau added reviewers: Frameworks, dfaure. REPOSITORY R309 KService REVISION DETAIL

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 05 Oct 2019 17:16:43 + Build duration: 1 min 10 sec and counting JUnit Tests Name:

D24429: [ConfigModule] Expose mainUi component status and error string

broulik added a dependent revision: D24430: [KCModuleLoader] Show error when QML fails to load. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently it just prints a warning to console and shows an empty dialog leaving the

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ngraham added a comment. +1 based on the explanation of following the FDO spec more closely. I'll leave Frameworks folks to figure out how to untangle the implementation details. :) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks

D24412: Add edit-line-width icons

ngraham added a comment. Much better! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24412: Add edit-line-width icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 AFFECTED FILES

D24412: Add edit-line-width icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH add-line-width-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel,

D23800: Use ECMGenerateExportHeader to manage deprecated API better

kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to manage deprecated API better" to "Use ECMGenerateExportHeader to manage deprecated API better". kossebau added reviewers: Frameworks, mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added reviewers: Frameworks, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau, #frameworks, #build_system Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24419 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24431: Restore cursor thumbnailer

broulik created this revision. broulik added reviewers: Plasma, fredrik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Baiscally just find xlib and change the link targets.