D24467: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R306 KParts

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24467

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24468: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24468

To: kossebau, #frameworks, cfeck, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/18/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 12 Oct 2019 04:28:59 +
 Build duration:
8 min 58 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 138 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/138/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 12 Oct 2019 03:16:14 +
 Build duration:
1 hr 11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_threadtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/403)66%
(264/403)55%
(33877/61424)39%
(17115/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(56/57)98%
(56/57)95%
(9501/9992)47%
(/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8659/14476)51%
(4588/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4679/8302)43%
(2023/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 24 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/24/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 11 Oct 2019 17:20:40 +
 Build duration:
10 hr and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 125 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/125/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 03:16:14 +
 Build duration:
8 min 56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: Framework for encrypted storage for apps

[Johan Ouwerkerk]

Hi all,

Many thanks for the responses so far. To address the various points raised:

It is acceptable for me if the user must type their password. Keychain
integration etc. are optional extras. QCA looks like it might be a
good fit for what I need.
One question I have with regards to keychain integration here is: are
the Windows and MacOS X platforms "properly" secure or at least
properly designed for this? That is: would it be a good addition to
use Qt Keychain for integrating with Keychains optionally on MacOS X
and/or Windows, and wail and gnash teeth for the fact it won't work on
Linux/FreeBSD?

However I feel somewhat intimidated by QCA's lack of proper publicly
accessible documentation. To give an overview of what I have tried
thus far:

 - KDE apidox which appeared to consist of a single overview page,
with a broken image (dead URL) and a dead link to examples (404):
https://api.kde.org/kdesupport-api/qca-apidocs/
 - inqlude (https://inqlude.org/libraries/qca.html) which had a link
that redirects via someone's private site to KDE Userbase which
appears to be about Qt 4.2 times (https://userbase.kde.org/QCA) and
another link that is dead (404)
 - On the advice of tsdegos on Matrix, I tried figuring out via the
headers /include what is was supposed to do. I did not get very far. I
am probably just too unfamiliar with the code structure and especially
how this is supposed to interact with the backing plugins to figure
out by myself how to do e.g. "key derivation", "salting" or
"encryption" by just looking at these headers.
 - However I did find an example on the Internet which at first glance
looks to explain how to do PBKDF#2 with QCA at least:
https://developersarea.wordpress.com/2014/11/27/cryptographic-hashes-in-qt-hmac-sha1-pbkdf2-md5/
(Scroll to the bottom of that blog post for the PBKDF#2 bits) Does
that also look reasonable to you, or are there glaring issues beside
the uses of QStrings for nearly everything?
 - I find it fairly hard to Google for this, because search terms like
"qca qt secure random" simply don't appear to return useful results
here. My background here is mostly some familiarity with JCA, so I'm
looking for things like "key derivation", "pbkdf", "secure random" in
combination with "qca" and "qt". I

So suppose I use QCA, I still have a few questions about how to go about this:

 - How do I obtain a "secure random" primitive in QCA? I can of course
make do by reading bytes from /dev/random on Linux, but it would be
nicer to have a portable primitive -- especially since the OpenSSL
plugin should be able to access such an implementation (OpenSSL).
 - How do I set up padding? I mean, sure I can pad my input manually
until I have a next multiple of #keysize bits/bytes. Is that solid
practice or does QCA already provide proper padding schemes out of the
box like PKCS#7?
  - How do I even construct the encryption itself? I can't seem to
find anything other thant public/private key encryption examples
(using some public key with OAEP), but I would like AES with a
suitable scheme/mode here. Mainly I would like a MAC on the encrypted
data because I want to be able to assert that the ciphertext is not
accidentally corrupted, say. After all if I can store the secrets in
an encrypted and robust fashion, then I can let the user export their
data safely for backup purposes.

So basically I guess that what I am asking: any examples, suggestions
or other pointers which I can use as further starting points/context
to figure this out? Thanks a lot in advance for all your help!

Kind regards,

- Johan Ouwerkerk




 -

On Sat, Oct 5, 2019 at 9:09 AM Ivan Čukić  wrote:
>
> Hi Johan,
>
> One important question here is how do you want the secrets to be unlocked.
> Is the user going to type in some master password every time the otpclient is
> started?
>
> If that is the case, you can use QCA to encrypt and decrypt the data you need
> to store securely.
>
> If that is not the case - if you don't want to always ask the user for the
> password, then you can expect quite a complicated story of how to make
> something like kwallet safe.
>
> >  1. (On KDE) these libraries wind up calling dbus. We would like to
> > avoid plain text out-of-process communication of secrets, especially
> > communication through a 'shared' channel (for obvious reasons).
> >  2. In particular with KDE Wallet it was suggested that the wallet
> > itself may, in fact, not be encrypted.
>
> Another huge problem of kwallet is that it can not authenticate which
> application is asking for the password. I was told that this could be easier
> to do with flatpaks, but it will still need significant changes to how kwallet
> works.
>
> > Another possible contender is Plasma Vault, but we don't really know
> > how that would work in the context of an app, especially a flatpak
> > app.
>
> An approach like the one taken in Plasma Vault could work for applications,
> but it would (like the QCA option previously mentioned) require the user t

D24578: Meson: Add a comment section for comment/uncomment with Kate

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  meson (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24578

AFFECTED FILES
  data/syntax/meson.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24568: Provide clang-format target with a common KDE style file

[Carl Schwan]

ognarb added a comment.


  There is probably a way to run clang-format only on a patch. See 
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
  
  But should we not prefer running clang format one time, instead of having 
only some part of the code auto-formatted?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not sure how this works, but would it be possible to have a target that 
only works on a patch? You usually want to make sure what you modified didn't 
diverge from the code.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24382

To: vkrause, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  simplify-proxy-load

REVISION DETAIL
  https://phabricator.kde.org/D24559

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

[Kai Krakow]

hurikhan77 updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krun.cpp:1101
> +return ExecutableFileOpenDialog::OpenOrExecute;
> +} else if 
> (mime.inherits(QStringLiteral("application/x-ms-dos-executable"))) {
> +return ExecutableFileOpenDialog::OpenAsExecute;

should this be in ifdef Q_OS_WIN?

On windows, *.exe is executed, not opened (with e.g. wine)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added a comment.


  +1 from me

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Noah Davis]

ndavis added a comment.


  In D24537#545451 , @kossebau wrote:
  
  > BTW, when it come to weather status icon, I dream of the possibility to 
simply compose the current status from base elements, instead of having 
pre-rendered icons.
  >
  > So there would be iconic elements for "cloud", "rain cloud", "snow cloud" 
etc. as well as  "sun" & "moon" (later could be even rendered to match moon 
phase). And those would be composed on drawing :)
  
  
  I think plasmashell can do that already, but it's just not any better than 
making an icon for every state. You'd have to move the elements around the 
screen in the code to keep them all visible, but you'd be showing basically the 
same thing that we already show with pre-made icons.
  
  > Even more cool would be the option to animate all those, e.g. on status 
change :) That's what QtQuick is for, pre-rendered icons are so 1980 :) (edit: 
actually, even then things would be composed & animated, hello C64 sprites : ) )
  
  That would be cool for some things and the weather widget might actually be a 
good place to use animated icons, but not for most things. It would just be 
distracting and make Plasma use significantly more resources.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24568: Provide clang-format target with a common KDE style file

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> KDEClangFormat.cmake:11
> +#
> +# ::
> +#

need doc

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24540: [Database] Disable read-ahead to reduce thrashing

[Kai Krakow]

hurikhan77 added a comment.


  Here's a quote:
  https://github.com/bmatsuo/lmdb-go/issues/118#issuecomment-325449496
  
  I suspect that we can safely say: The Baloo DB is always bigger than the 
available RAM (we shouldn't fight with what the desktop needs, so let's say we 
have maybe 20% of the installed RAM at our disposal which is already a high 
assumptions for typical systems).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24540

To: hurikhan77, ngraham, #baloo, bruns
Cc: bruns, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  Provides a clang-format target if wanted
  
  Example usage:
  
  include(KDEClangFormat)
  
  add clang-format target for all our real source files
  =
  
  file(GLOB_RECURSE ALL_CLANG_FORMAT_SOURCE_FILES autotests/src/*.cpp 
autotests/src/*.h src/*.cpp src/*.h templates/*.cpp templates/*.h)
  kde_clang_format(${ALL_CLANG_FORMAT_SOURCE_FILES})

TEST PLAN
  Tried that above usage thingy in KTextEditor

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

[Kai Krakow]

hurikhan77 updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

[Kai Krakow]

hurikhan77 renamed this task from "Reduce bad performance impact of running 
Baloo under certain conditions" to "Understanding and reducing bad performance 
impact of running Baloo under certain conditions".
hurikhan77 updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D24555: Add draw-arrow icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  > The design is based on `draw-line` with an arrowhead.
  
  I think this is a good design. I noticed that LibreOffice already uses a 
different icon for drawing arrows, but I think this one looks nicer.
  
  > I am not quite sure about the naming as there are already 
`draw-arrow-{up,down,forward,back}` icons that symlink to the standard arrow 
icons. I could not find an application where these are used.
  
  I think you chose the right name. It could be that those icons are wrong in 
the first place.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-draw-arrow-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24555

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11859: Reduce bad performance impact of running Baloo under certain conditions

[Kai Krakow]

hurikhan77 updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

T11859: Reduce bad performance impact of running Baloo under certain conditions

[Kai Krakow]

hurikhan77 updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

T11859: Reduce bad performance impact of running Baloo under certain conditions

[Nathaniel Graham]

ngraham added subscribers: Baloo, bruns, Frameworks.
ngraham added a project: Frameworks.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77, ngraham
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/42/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 17:13:00 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24468: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67737.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24468?vs=67431&id=67737

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24468

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kactionmenu.cpp
  src/kactionmenu.h
  src/kmessagebox.h
  src/kmultitabbar.cpp
  src/kmultitabbar.h
  src/kratingwidget.cpp
  src/kratingwidget.h
  src/kruler.cpp
  src/kruler.h
  src/ktoolbarpopupaction.cpp
  src/ktoolbarpopupaction.h

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24497: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67736.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24497?vs=67499&id=67736

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24497

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigdialog_unittest.cpp
  src/CMakeLists.txt
  src/kcmodule.cpp
  src/kcmodule.h
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h
  src/kpastetextaction.cpp
  src/kpastetextaction.h
  src/kstandardaction.cpp
  src/kstandardaction.h
  src/kstandardaction_p.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24496: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67735.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24496?vs=67498&id=67735

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24496

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigtest.cpp
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  src/core/CMakeLists.txt
  src/core/kauthorized.cpp
  src/core/kauthorized.h
  src/core/kconfig.cpp
  src/core/kconfig.h
  src/core/kconfiggroup.cpp
  src/core/kconfiggroup.h
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h
  src/core/kemailsettings.cpp
  src/core/kemailsettings.h
  src/gui/CMakeLists.txt
  src/gui/kconfiggui.cpp
  src/gui/kconfiggui.h
  src/gui/kconfigloader.cpp
  src/gui/kconfigloader.h
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24495: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67734.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24495?vs=67497&id=67734

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24495

AFFECTED FILES
  CMakeLists.txt
  autotests/klineedit_unittest.cpp
  src/CMakeLists.txt
  src/kcombobox.cpp
  src/kcombobox.h
  src/kcompletionbase.h
  src/kcompletionbox.h
  src/klineedit.cpp
  src/klineedit.h
  src/ksortablelist.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67733.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24466?vs=67429&id=67733

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kactioncollection.cpp
  src/kactioncollection.h
  src/kkeysequencewidget.cpp
  src/kkeysequencewidget.h
  src/kmainwindow.cpp
  src/kmainwindow.h
  src/kshortcutseditor.cpp
  src/kshortcutseditor.h
  src/kshortcutwidget.cpp
  src/kshortcutwidget.h
  src/ktoolbar.cpp
  src/ktoolbar.h
  src/kxmlguibuilder.cpp
  src/kxmlguibuilder.h
  tests/kmainwindowrestoretest.cpp

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67732.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24467?vs=67430&id=67732

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24467

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/browserextension.h
  src/browserrun.cpp
  src/browserrun.h
  src/readonlypart.cpp
  src/readonlypart.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67731.
kossebau added a comment.


  - disable KF group deprecation macros for now
  - set DEPRECATED_BASE_VERSION=0, to not disable any API by default

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23802?vs=67655&id=67731

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp
  src/kdeinit/ktoolinvocation.h
  src/plugin/kdbusservicestarter.cpp
  src/plugin/kdbusservicestarter.h
  src/services/kplugininfo.cpp
  src/services/kplugininfo.h
  src/services/kservice.h
  src/sycoca/ksycoca.cpp
  src/sycoca/ksycoca.h
  tests/CMakeLists.txt

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 45 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/45/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 17:13:00 +
 Build duration:
7 min 12 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.63.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6884/9076)43%
(10766/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2871/2964)48%
(6168/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D24540: [Database] Disable read-ahead to reduce thrashing

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24540

To: hurikhan77, ngraham, #baloo, bruns
Cc: bruns, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D24539: [Database] Rework handling environment flags

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:198f82eb511f: [Database] Rework handling environment 
flags (authored by hurikhan77, committed by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24539?vs=67680&id=67723

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fixes/prepare-readahead

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D23512: Avoid overloading KCModule::changed

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:aa136dbab4ae: Avoid overloading KCModule::changed 
(authored by davidedmundson).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23512?vs=66716&id=67721

REVISION DETAIL
  https://phabricator.kde.org/D23512

AFFECTED FILES
  src/kcmodule.cpp
  src/kcmodule.h

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67718.
kossebau added a comment.


  fix incompleteness of patch WRT to NET::Override
  
  While that flag is deprecated for clients, window managing code seems to
  still need to handle that flag if set by old clients, so tagging it as
  deprecated might result in premature removal of the support.
  That needs a separate plan how to make sure it#s no longer used out in the
  wild by clients. lxr.kde.org reports it still with some application code

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24465?vs=67428&id=67718

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24465

AFFECTED FILES
  CMakeLists.txt
  autotests/kstartupinfo_unittest.cpp
  autotests/kwindowsystemx11test.cpp
  autotests/kxmessages_unittest.cpp
  autotests/netwininfotestclient.cpp
  src/CMakeLists.txt
  src/kstartupinfo.cpp
  src/kstartupinfo.h
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h
  src/kwindowsystem_dummy_p.h
  src/kwindowsystem_p.h
  src/netwm_def.h
  src/platforms/osx/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem_p_wayland.h
  src/platforms/windows/kwindowsystem.cpp
  src/platforms/xcb/kkeyserver.cpp
  src/platforms/xcb/kkeyserver_x11.h
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/kwindowsystem_p_x11.h
  src/platforms/xcb/kxmessages.cpp
  src/platforms/xcb/kxmessages.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Friedrich W. H. Kossebau]

kossebau added a comment.


  BTW, when it come to weather status icon, I dream of the possibility to 
simply compose the current status from base elements, instead of having 
pre-rendered icons.
  
  So there would be iconic elements for "cloud", "rain cloud", "snow cloud" 
etc. as well as  "sun" & "moon" (later could be even rendered to match moon 
phase). And those would be composed on drawing :)
  
  Even more cool would be the option to animate all those, e.g. on status 
change :) That's what QtQuick is for, pre-rendered icons are so 1980 :)
  
  Sadly the weather applet is pretty low on my interest, actually would be 
happy to have someone take over maintainance/care.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24537: Icons for windy weather

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24537#545420 , @vkrause wrote:
  
  > Nice! We use the Breeze weather icons in KDE Itinerary too, based on 
api.met.no data, but so far didn't make use of the wind information in there 
yet.
  
  
  In case you want to make use of the wind information also when it comes to 
directions, the wind arrow icons currently only exist as Plasma theme icon 
pack, at
  
https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/weather/wind-arrows.svgz
  
  Perhaps something to make normal icon theme icons as well, if there is 
interest.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24263: edit mode action

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24537: Icons for windy weather

[Volker Krause]

vkrause added a comment.


  Nice! We use the Breeze weather icons in KDE Itinerary too, based on 
api.met.no data, but so far didn't make use of the wind information in there 
yet.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24382

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: port ftp slave to new error reporting system

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23579

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 13:22:00 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D24554: Don't build static library when BUILD_TESTING=OFF

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:f436762fb366: Don't build static library when 
BUILD_TESTING=OFF (authored by arojas).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24554?vs=67674&id=67705

REVISION DETAIL
  https://phabricator.kde.org/D24554

AFFECTED FILES
  src/solid/CMakeLists.txt

To: arojas, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24560: remove legacy space handling code

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the raw data in kioslaverc uses the format "$url $port", this format
  isn't being read inside the KCM anymore though. instead setProxyInformation
  is called with the output of KProtocolManager::proxyFor, which internally
  merges the config entry to "$url:$port" already, so the space handling in
  setProxyInformation was entirely superfluous and needlessly raising
  complexity

TEST PLAN
  saving and changing proxy settings continues to work

REPOSITORY
  R241 KIO

BRANCH
  remove-dead-proxy-load-code

REVISION DETAIL
  https://phabricator.kde.org/D24560

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  all urls need to have their ports stripped and text set, so de-duplicate
  the shared code out of the conditional branches to prevent bugs from
  making changes in one branch but not the other

TEST PLAN
  saving and changing proxy settings continues to work

REPOSITORY
  R241 KIO

BRANCH
  simplify-proxy-load

REVISION DETAIL
  https://phabricator.kde.org/D24559

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24558: fix proxy setting loading

[Harald Sitter]

sitter added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24558

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24558: fix proxy setting loading

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  when the flag isn't set we'd set the text to urlStr, urlStr however
  was the original string *with* the port. since we want the port stripped
  we need to actually set url.url() otherwise the KCM loading its own
  settings would result in
  
  Proxy: [socks://localhost:1080] Port: [1080]
  
  which when written back to the file would result in broken data as we
  do not sanitize the proxy url text WRT port when saving

TEST PLAN
  - set proxy
  - close and open kcm again
  - proxy values are what they were set to with no extra port duplication

REPOSITORY
  R241 KIO

BRANCH
  fix-proxy-load

REVISION DETAIL
  https://phabricator.kde.org/D24558

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24431: Restore cursor thumbnailer

[Adriaan de Groot]

adridg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:149
>  
> -# if(X11_Xcursor_FOUND)
> -#
> -#set(cursorthumbnail_PART_SRCS cursorcreator.cpp)
> -#
> -#add_library(cursorthumbnail MODULE ${cursorthumbnail_PART_SRCS})
> -#
> -#target_link_libraries(cursorthumbnail ${X11_Xcursor_LIB} 
> ${KIO_LIBRARIES})
> -#
> -#install(TARGETS cursorthumbnail DESTINATION ${KDE_INSTALL_PLUGINDIR})
> -#install( FILES cursorthumbnail.desktop DESTINATION 
> ${KDE_INSTALL_KSERVICES5DIR})
> -#
> -# endif()
> -#
> +if(X11_FOUND)
> +

X11_Xcursor_FOUND, since X11 can be found without Xcursor.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24431

To: broulik, #plasma, fredrik, ngraham
Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D23579: port ftp slave to new error reporting system

[Harald Sitter]

sitter updated this revision to Diff 67697.
sitter added a comment.


  move away from helper functions to redirect to q-> and instaed call via q-> 
directly

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23579?vs=67695&id=67697

BRANCH
  ftp

REVISION DETAIL
  https://phabricator.kde.org/D23579

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ftp/testCopy1
  autotests/ftp/testCopy2
  autotests/ftp/testOverwriteCopy1
  autotests/ftp/testOverwriteCopy2
  autotests/ftpd
  autotests/ftptest.cpp
  cmake/FindGem.cmake
  cmake/FindGem.cmake.in
  cmake/FindRubyExe.cmake
  src/ioslaves/ftp/ProxyTesting.md
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/ftp/ftp.h

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23579: port ftp slave to new error reporting system

[Harald Sitter]

sitter retitled this revision from "WIP: port ftp slave to new error reporting 
system" to "port ftp slave to new error reporting system".
sitter edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23579

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23579: WIP: port ftp slave to new error reporting system

[Harald Sitter]

sitter updated this revision to Diff 67695.
sitter marked 24 inline comments as done.
sitter added a comment.


  - rebase
  - ftpSendCmd now returns a bool (continues to require_result)
  - openConnection now emits opened()
  - listDir now finalize()s
  - debug--
  - ftpSendCmd's lazy login now checks the return value of the recrusive cmd 
call
  
  ftpOpenControlConnection's proxy handling is completely redone:
  
  - loosened nesting
  - socks5 is now also supported as scheme
  - reliance on eventloop is gone and replaced with actually sync behavior for 
the sync synchronousConnectToHost
- the way proxy management is done is no longer using applicationproxy but 
instead managing the proxy on the socket(s) directly. this makes things 
somewhat more explicit and gives less opportunity for errors inside Qt behavior
- now returns a composite Result type to carry both context and socket to 
the caller. contextual error forwarding is handy here because there is value in 
differntiating why authentication isn't working when e.g. kiod is defunct.
- qauthenticator use gone as it has no api outside the auth signal
- proxyAuthentication and saveProxyAuthentication have been merged into 
synchronousConnectToHost and been simplified
  - now only uses one AuthInfo object
  - realm is no longer set (came from QAuthenticator but as far as I can 
tell the QA created by QAbstractSocket has no realm set, so this never did 
anything anyway)
  - as a result the comment field in password queries is now only showing 
the hostname instead of a broken " at $hostname"
  - added ProxyTesting.md with some guidance on how to test this stuff

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23579?vs=66747&id=67695

BRANCH
  ftp

REVISION DETAIL
  https://phabricator.kde.org/D23579

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ftp/testCopy1
  autotests/ftp/testCopy2
  autotests/ftp/testOverwriteCopy1
  autotests/ftp/testOverwriteCopy2
  autotests/ftpd
  autotests/ftptest.cpp
  cmake/FindGem.cmake
  cmake/FindGem.cmake.in
  cmake/FindRubyExe.cmake
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/ftp/ftp.h

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Seems this broke the windows build on CI for some reason, please have a look:
  
https://build.kde.org/view/Failing/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/17/

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma, mart
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24493: Add draw-highlight action icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:71b9713970eb: Add draw-highlight action icons (authored 
by Rafael Brandmaier ).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24493?vs=67495&id=67694

REVISION DETAIL
  https://phabricator.kde.org/D24493

AFFECTED FILES
  icons-dark/actions/16/draw-highlight.svg
  icons-dark/actions/22/draw-highlight.svg
  icons/actions/16/draw-highlight.svg
  icons/actions/22/draw-highlight.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24493: Add draw-highlight action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-highlight-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24493

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24555: Add draw-arrow icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24555

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:5fa1a3312ab2: Make kconfig_compiler generate ctors with 
the optional parent arg (authored by ervin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24490?vs=67516&id=67691

REVISION DETAIL
  https://phabricator.kde.org/D24490

AFFECTED FILES
  autotests/kconfig_compiler/test1.cpp.ref
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test1.kcfgc
  autotests/kconfig_compiler/test10.cpp.ref
  autotests/kconfig_compiler/test11.cpp.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11.kcfgc
  autotests/kconfig_compiler/test11a.cpp.ref
  autotests/kconfig_compiler/test12.cpp.ref
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test2.cpp.ref
  autotests/kconfig_compiler/test3.cpp.ref
  autotests/kconfig_compiler/test3a.cpp.ref
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.h.ref
  autotests/kconfig_compiler/test5.kcfgc
  autotests/kconfig_compiler/test6.cpp.ref
  autotests/kconfig_compiler/test7.cpp.ref
  autotests/kconfig_compiler/test8a.cpp.ref
  autotests/kconfig_compiler/test8a.h.ref
  autotests/kconfig_compiler/test8a.kcfgc
  autotests/kconfig_compiler/test8b.cpp.ref
  autotests/kconfig_compiler/test8c.cpp.ref
  autotests/kconfig_compiler/test8c.h.ref
  autotests/kconfig_compiler/test8c.kcfgc
  autotests/kconfig_compiler/test9.cpp.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_notifiers.cpp.ref
  autotests/kconfig_compiler/test_qdebugcategory.cpp.ref
  autotests/kconfig_compiler/test_signal.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.cpp.ref
  autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref
  autotests/kconfig_compiler/test_translation_qt.cpp.ref
  src/kconfig_compiler/kconfig_compiler.cpp

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:4c3d37519684: Add convenience for defaults/dirty states 
to KCoreConfigSkeleton (authored by ervin).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24494?vs=67597&id=67692

REVISION DETAIL
  https://phabricator.kde.org/D24494

AFFECTED FILES
  autotests/kconfigskeletontest.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson, apol
Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24555: Add draw-arrow icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-draw-arrow-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24555

AFFECTED FILES
  icons-dark/actions/16/draw-arrow.svg
  icons-dark/actions/22/draw-arrow.svg
  icons/actions/16/draw-arrow.svg
  icons/actions/22/draw-arrow.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Aleix Pol Gonzalez]

apol added a comment.


  ok, let's just land this for now.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24554: Don't build static library when BUILD_TESTING=OFF

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D24554

To: arojas, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24494

To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson, apol
Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24494

To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson
Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D22520: Remove Growl support

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:e2eed147c53c: Remove Growl support (authored by 
nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22520?vs=61942&id=67687

REVISION DETAIL
  https://phabricator.kde.org/D22520

AFFECTED FILES
  src/CMakeLists.txt
  src/notifybypopup.cpp
  src/notifybypopupgrowl.cpp
  src/notifybypopupgrowl.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 124 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/124/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 07:36:32 +
 Build duration:
1 hr 22 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24540: [Database] Disable read-ahead to reduce thrashing

[Kai Krakow]

hurikhan77 updated this revision to Diff 67684.
hurikhan77 edited the summary of this revision.
hurikhan77 added a comment.


  Added depend line according to arc docs

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24540?vs=67681&id=67684

BRANCH
  fixes/readahead

REVISION DETAIL
  https://phabricator.kde.org/D24540

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo, bruns
Cc: bruns, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw added a comment.


  Any progress on this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D24540: [Database] Disable read-ahead to reduce thrashing

[Kai Krakow]

hurikhan77 updated this revision to Diff 67681.
hurikhan77 added a comment.


  Resend diff with arc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24540?vs=67629&id=67681

BRANCH
  fixes/readahead

REVISION DETAIL
  https://phabricator.kde.org/D24540

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo, bruns
Cc: bruns, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 updated this revision to Diff 67680.
hurikhan77 added a comment.


  Using single-patch-per-branch approach
  
  This feels unnatural... :-\

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24539?vs=67677&id=67680

BRANCH
  fixes/prepare-readahead

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 added a comment.


  Now arc squashed all my commits into one single diff... I'm not sure if I 
like that.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 updated this revision to Diff 67677.
hurikhan77 added a comment.


  Rebase and submit with arc
  
  - [Database] Rework handling environment flags
  - [Database] Disable read-ahead to prevent thrashing

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24539?vs=67628&id=67677

BRANCH
  fixes/readahead

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24537: Icons for windy weather

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24537: Icons for windy weather

[Noah Davis]

ndavis added a comment.


  That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly 
used to represent wind. Gray on more gray is going to be tricky as well though, 
especially when you've got partly cloudy vs cloudy. What if the wind was a bit 
more monochromatic? Wind is invisible, so it only really has shapes that are 
associated with how it moves around objects to represent it. Perhaps we can use 
darker colors for lighter backgrounds and lighter colors for darker backgrounds 
then?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 253 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/253/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 11 Oct 2019 07:36:33 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33926/61427)39%
(17136/43774)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9534/9993)47%
(4454/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8664/14477)51%
(4596/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4674/8302)43%
(2022/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 added a comment.


  In D24539#545019 , @ngraham wrote:
  
  > This doesn't apply cleanly on master. Can you rebase it?
  
  
  This is strange because I rebased it to latest master just before submitting 
it here. Maybe I used an outdated mirror. Let me check.
  
  > Also it would be nice to use `arc` to submit patches: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
  
  Ah, there it is. It isn't in the default Gentoo repository.
  
  Will check back soon.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams