D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe marked an inline comment as done.
guoyunhe added inline comments.

INLINE COMMENTS

> dfaure wrote in krun.cpp:1101
> should this be in ifdef Q_OS_WIN?
> 
> On windows, *.exe is executed, not opened (with e.g. wine)

Yes, I updated this part.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24463

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

[Yunhe Guo]

guoyunhe updated this revision to Diff 67761.
guoyunhe added a comment.


  *.exe should be normal executable in Windows

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24463?vs=67458=67761

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24463

AFFECTED FILES
  src/widgets/executablefileopendialog.cpp
  src/widgets/executablefileopendialog_p.h
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: guoyunhe, #frameworks, ngraham, dfaure
Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24468: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24468

To: kossebau, #frameworks, cfeck, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R306 KParts

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24467

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24578: Meson: Add a comment section for comment/uncomment with Kate

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Please increase the version number and commit.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  meson (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24578

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven updated this revision to Diff 67763.
meven added a comment.


  Fix slavebase.cpp following QVariant changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23523?vs=67762=67763

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven updated this revision to Diff 67762.
meven added a comment.


  Update since, use QVariant as mapConfig value

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23523?vs=65991=67762

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

meven updated this revision to Diff 67768.
meven added a comment.


  Replace more config() calls, fixes, code cleanup

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24582?vs=67767=67768

BRANCH
  next-D23523

REVISION DETAIL
  https://phabricator.kde.org/D24582

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/kcms/kio/smbrodlg.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

[Volker Krause]

vkrause updated this revision to Diff 67780.
vkrause added a comment.


  bump version to 5.64

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24294?vs=67019=67780

BRANCH
  arcpatch-D24294

REVISION DETAIL
  https://phabricator.kde.org/D24294

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause, dfaure, aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 126 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/126/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 10:10:53 +
 Build duration:
8 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24590: Port KSslErrorUiData to QSslError

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

AFFECTED FILES
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

[Kai Krakow]

hurikhan77 updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11859

To: hurikhan77
Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D24593: Modified breeze shadows

[David Edmundson]

davidedmundson added a comment.


  Please write what you've changed and why

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann updated this revision to Diff 67796.
cullmann added a comment.


  - fix coding style issue, we don't want indented case labels

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24568?vs=67739=67796

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D19088: Use propertymap to store properties in Baloo::Result

[Alexander Stippich]

astippich added a comment.


  ping @bruns
  are you going to land this series?

REPOSITORY
  R293 Baloo

BRANCH
  propertymap

REVISION DETAIL
  https://phabricator.kde.org/D19088

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Ahmad Samir]

ahmadsamir added a dependent revision: D24597: Port from deprecated KTcpSocket 
to QSslSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24597: Port from deprecated KTcpSocket to QSslSocket

[Ahmad Samir]

ahmadsamir added reviewers: hein, mlaurent.
ahmadsamir added subscribers: Konversation, kde-frameworks-devel.

REPOSITORY
  R7 Konversation

REVISION DETAIL
  https://phabricator.kde.org/D24597

To: ahmadsamir, #konversation, hein, mlaurent
Cc: kde-frameworks-devel, #konversation

D24597: Port from deprecated KTcpSocket to QSslSocket

[Ahmad Samir]

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket.

REPOSITORY
  R7 Konversation

REVISION DETAIL
  https://phabricator.kde.org/D24597

To: ahmadsamir, #konversation, hein, mlaurent
Cc: kde-frameworks-devel, #konversation

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 67790.
niccolove added a comment.


  Used scour on svg files

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67789=67790

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/13/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 15:32:00 +
 Build duration:
59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 retitled this revision from "Improve desktop layout and panel editing UX" 
to "Improve and clean up panel options menu entries".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24263: edit mode action

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> corona.cpp:419
> +} else {
> +editAction->setText(i18n("Customize Layout"));
> +}

Missing ellipsis (...)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  Uhm, I probably got Scour wrong. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24595: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KTextWidgets to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKTEXTWIDGETS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKTEXTWIDGETS_NO_DEPRECATED
- -DKTEXTWIDGETS_DEPRECATED_WARNINGS_SINCE
- -DKTEXTWIDGETS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KTextWidgets optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0,
  CURRENT.

REPOSITORY
  R310 KTextWidgets

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24595

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/widgets/ktextedit.h

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann updated this revision to Diff 67797.
cullmann added a comment.


  - add initial docs

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24568?vs=67796=67797

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann marked an inline comment as done.
cullmann added inline comments.

INLINE COMMENTS

> ognarb wrote in KDEClangFormat.cmake:11
> need doc

Added some initial docs

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann added a reviewer: Frameworks.
cullmann marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann added a comment.


  If there are more deviations from the kdelibs/frameworks coding style, please 
tell me.
  
  Otherwise, I am happy with the output of this file for KTextEditor & Kate.
  
  For the .clang-format instantiation question: I think it makes sense to 
instantiate it on initial cmake running, as otherwise the tooling users use for 
clang-format/clangd will not pick up the style.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Dominik Haumann]

dhaumann added a comment.


  I'm all for it. This would unify how we can reformat any KDE module, which is 
very much desirable.
  
  Being able to just reformat a patch sounds interesting, too, but can be added 
later still.
  
  Don't let the perfect be the enemy of the good...
  
  The example usage should go to the location that Carl pointed out.
  
  +1, can we have another iteration?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
GB_2, bencreasy, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

meven updated this revision to Diff 67767.
meven added a comment.


  Replace more config() calls, fixes, code cleanup

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24582?vs=67765=67767

BRANCH
  next-D23523

REVISION DETAIL
  https://phabricator.kde.org/D24582

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/kcms/kio/smbrodlg.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> KDEClangFormat.cmake:48
> +if(KDE_CLANG_FORMAT_EXECUTABLE)
> +configure_file(${CMAKE_CURRENT_LIST_DIR}/clang-format.cmake 
> ${CMAKE_CURRENT_SOURCE_DIR}/.clang-format @ONLY)
> +endif()

it's a bit weird to put new files in the source directory when running cmake.

Copying when running the target clang-format would probably be ok as there 
you're already doing an explicit operation which changes the source.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24400: Make hours qint64

[Albert Astals Cid]

aacid abandoned this revision.
aacid added a comment.


  Meh, just realized this patch is useless since we end up passing the quint 
variable to formatSingleDuration that passes it to QObject::tr and that one 
only supports int, so at some point there's a potential loss of range anyway

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24400

To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24584: Add a few const

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24584

To: aacid, meven
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: dfaure, vkrause.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This is needed as part of porting Koversation to use QSslSocket instead
  of KTcpSocket.

TEST PLAN
  The code compiles

REPOSITORY
  R241 KIO

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24588

AFFECTED FILES
  src/widgets/sslui.cpp
  src/widgets/sslui.h

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Ahmad Samir]

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4bfbdad31fdc: Port KSslCertificateManager to QSslError 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24294?vs=67780=67781

REVISION DETAIL
  https://phabricator.kde.org/D24294

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause, dfaure, aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:524023533886: Port (most of) the interface of 
KSslCertificateRule to QSslError (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24382?vs=67782=67783

REVISION DETAIL
  https://phabricator.kde.org/D24382

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

[Volker Krause]

vkrause updated this revision to Diff 67782.
vkrause added a comment.


  bump version number to 5.64

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24382?vs=67247=67782

BRANCH
  arcpatch-D24382

REVISION DETAIL
  https://phabricator.kde.org/D24382

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 139 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/139/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 12 Oct 2019 10:10:54 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33921/61428)39%
(17133/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9534/9993)47%
(4452/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8665/14479)51%
(4597/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4679/8302)43%
(2023/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D24590: Port KSslErrorUiData to QSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> davidedmundson wrote in KDEClangFormat.cmake:48
> it's a bit weird to put new files in the source directory when running cmake.
> 
> Copying when running the target clang-format would probably be ok as there 
> you're already doing an explicit operation which changes the source.

If we don't do this per default, user clang-format tooling like via LSP in 
Atom/Vscode/Kate will not work properly before a manual action.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

meven updated this revision to Diff 67772.
meven added a comment.


  Clean up a QVariant()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24582?vs=67771=67772

BRANCH
  next-D23523

REVISION DETAIL
  https://phabricator.kde.org/D24582

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/kcms/kio/smbrodlg.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

meven updated this revision to Diff 67771.
meven added a comment.


  Fixes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24582?vs=67768=67771

BRANCH
  next-D23523

REVISION DETAIL
  https://phabricator.kde.org/D24582

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/kcms/kio/smbrodlg.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24400: Make hours qint64

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> aacid wrote in kformatprivate.cpp:339
> because its unnecessary, qint64 / number don't need a quint64 to store it.

sorry i just realized ms is quint64, so yes sshould b quint64

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24400

To: aacid
Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/128/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 10:32:07 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven added a dependent revision: D24582: Replace usage of SlaveBase::config() 
by SlaveBase::mapConfig().

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Depends on D23523 
  
  Now that SlaveBase::config() is marked deprecated use the new function 
SlaveBase::mapConfig() instead preventing KConfig I/O when reading config

REPOSITORY
  R241 KIO

BRANCH
  next-D23523

REVISION DETAIL
  https://phabricator.kde.org/D24582

AFFECTED FILES
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

[Méven Car]

meven planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24582

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24584: Add a few const

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  These things aren't super expensive to copy, but const & is less expensive

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24584

AFFECTED FILES
  src/engine/idtreedb.cpp
  src/engine/writetransaction.cpp
  src/engine/writetransaction.h
  src/kioslaves/search/kio_search.cpp
  src/kioslaves/search/kio_search.h

To: aacid
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann added a comment.


  In D24568#545736 , @apol wrote:
  
  > I'm not sure how this works, but would it be possible to have a target that 
only works on a patch? You usually want to make sure what you modified didn't 
diverge from the code.
  
  
  I think there is some hack around that:
  http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
  
  But actually, if your sources are already clang-formatted, you just need to 
run the clang-format target once before you commit, the your new code will be 
the only thing altered.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
GB_2, bencreasy, michaelh, ngraham, bruns

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:41a209b2b6ce: Implement KSslCertificateRule with 
QSslError instead of KSslError (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24419?vs=67337=67784

REVISION DETAIL
  https://phabricator.kde.org/D24419

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp

To: vkrause, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 127 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/127/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 10:23:28 +
 Build duration:
8 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  old icons
  22px
  F7580424: elisaSmallOld.png 
  48px
  F7580438: elisaBigOld.png 
  
  updated icons
  22px
  F7580429: elisaSmall.png 
  48px
  F7580433: elisaBig.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, GB_2, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Björn Feber]

GB_2 added a comment.


  I don't think it makes sense to change the icon here if D12992 
 already does it. If you want it to 
progress then take over the revision and work on the completely new style there 
or make a ping comment and have some patience.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Björn Feber]

GB_2 added a dependent revision: D24533: Draw categories in iconview in a 
similiar style as Kirigami and new KCategoryDrawer.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kde_edu, #kde_pim, 
#kpublictransport, #amarok, ngraham
Cc: ndavis, ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24372: Compile without deprecated foreach

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ahmadsamir wrote in job.cpp:181
> IIUC, subjobs() returns a const QList &, do we still need a local const var?
> https://api.kde.org/frameworks/kcoreaddons/html/classKCompositeJob.html#aaec8d9b05c7c4194c5ba121d43f2997e

Well spotted. Unusual

> ahmadsamir wrote in dropjob.cpp:270
> m_urls is declared const in DropJobPrivate: 
> https://cgit.kde.org/kio.git/tree/src/widgets/dropjob.cpp#n142

Oh, interesting :-)

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-urifilters2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24372

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kactioncollection.h:278
>   */
> +KXMLGUI_DEPRECATED_VERSION(5, 0, "Do not rely on")
>  QT_MOC_COMPAT void removed(QAction *action);

Does this work? It's a signal. Won't this only warn at emit time? (while 
QT_MOC_COMPAT is what leads to a warning at connect time)

Asking because you didn't do this in D24465 
 for the windowChanged() signals, so 
something seems inconsistent.

> kactioncollection.h:314
> +KXMLGUI_DEPRECATED_VERSION(5, 0, "Use 
> KActionCollection::slotActionHovered()")
>  QT_MOC_COMPAT virtual void slotActionHighlighted();
> +#endif

(pre-existing) QT_MOC_COMPAT for a slot? Any idea what this might do?

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> ktoolinvocation.h:152
>   */
> -KSERVICE_DEPRECATED static void invokeBrowser(const QString ,
> +KSERVICE_DEPRECATED_VERSION(5, 0, "Use QDesktopServices::openUrl(const 
> QUrl&)")
> +static void invokeBrowser(const QString ,

No #if for this one?

REPOSITORY
  R309 KService

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67803.
kossebau marked an inline comment as done.
kossebau added a comment.


  add missing #if/#endif for KToolInvocation::invokeBrowser

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23802?vs=67731=67803

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp
  src/kdeinit/ktoolinvocation.h
  src/kdeinit/ktoolinvocation_win.cpp
  src/kdeinit/ktoolinvocation_x11.cpp
  src/plugin/kdbusservicestarter.cpp
  src/plugin/kdbusservicestarter.h
  src/services/kplugininfo.cpp
  src/services/kplugininfo.h
  src/services/kservice.h
  src/sycoca/ksycoca.cpp
  src/sycoca/ksycoca.h
  tests/CMakeLists.txt

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24600: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KItemModels to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKITEMMODELS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKITEMMODELS_NO_DEPRECATED
- -DKITEMMODELS_DEPRECATED_WARNINGS_SINCE
- -DKITEMMODELS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KItemModels optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.8.0,
  CURRENT.

REPOSITORY
  R275 KItemModels

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24600

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdescendantsproxymodel.cpp
  src/kdescendantsproxymodel.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7c0402ed9fd7: Compile without deprecated foreach 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24372?vs=67804=67808

REVISION DETAIL
  https://phabricator.kde.org/D24372

AFFECTED FILES
  src/core/batchrenamejob.cpp
  src/core/connection.cpp
  src/core/copyjob.cpp
  src/core/desktopexecparser.cpp
  src/core/job.cpp
  src/core/kprotocolinfofactory.cpp
  src/core/kprotocolmanager.cpp
  src/core/ksslcertificatemanager.cpp
  src/core/ktcpsocket.cpp
  src/core/scheduler.cpp
  src/core/tcpslavebase.cpp
  src/urifilters/ikws/ikwsopts.cpp
  src/urifilters/ikws/searchproviderdlg.cpp
  src/urifilters/shorturi/kshorturifilter.cpp
  src/widgets/accessmanager.cpp
  src/widgets/clipboardupdater.cpp
  src/widgets/delegateanimationhandler.cpp
  src/widgets/dropjob.cpp
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kdirmodel.cpp
  src/widgets/kfileitemactions.cpp
  src/widgets/kfileitemdelegate.cpp
  src/widgets/kpropertiesdialog.cpp
  src/widgets/krun_win.cpp
  src/widgets/ksslcertificatebox.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/kurifiltersearchprovideractions.cpp
  src/widgets/previewjob.cpp
  src/widgets/sslui.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:ce11545c51ec: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23802?vs=67803=67807

REVISION DETAIL
  https://phabricator.kde.org/D23802

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp
  src/kdeinit/ktoolinvocation.h
  src/kdeinit/ktoolinvocation_win.cpp
  src/kdeinit/ktoolinvocation_x11.cpp
  src/plugin/kdbusservicestarter.cpp
  src/plugin/kdbusservicestarter.h
  src/services/kplugininfo.cpp
  src/services/kplugininfo.h
  src/services/kservice.h
  src/sycoca/ksycoca.cpp
  src/sycoca/ksycoca.h
  tests/CMakeLists.txt

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:17:43 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23579: port ftp slave to new error reporting system

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Excellent work!

INLINE COMMENTS

> ftp.cpp:2635
> +
> +#pragma message "was this useful? I have no clue where or how keepalive 
> would work with ftp"
> +//authenticator->setOption(QStringLiteral("keepalive"), 
> info.keepPassword);

yeah, looks like wishful thinking remove?

> sitter wrote in ftp.h:70
> It's a good idea. Would that work though?
> 
> Currently the results rely on the implicit move operator when collecting the 
> returned result
> 
>   result = ftpGet()
> 
> if the members are const we couldn't move/copy like that anymore.
> 
> If we consider the mutability a problem I think I'd just make the members 
> private and give them getters. I don't mind much either way.

Copying bool+int+QString seems rather cheap, we lived with that until C++11 
move semantics ;-)

Private members and inline getters sounds good to me.

But yeah, no big deal, we can also trust the programmer :-)

REPOSITORY
  R241 KIO

BRANCH
  ftp

REVISION DETAIL
  https://phabricator.kde.org/D23579

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24558: fix proxy setting loading

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Err, yeah, the call to `setPort(-1)` serves no purpose at all otherwise...

REPOSITORY
  R241 KIO

BRANCH
  fix-proxy-load

REVISION DETAIL
  https://phabricator.kde.org/D24558

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:22:06 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24568: Provide clang-format target with a common KDE style file

[Albert Astals Cid]

aacid added a comment.


  > common KDE style file
  
  There's no such thing as a common KDE style

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24487: fix password error condition handling of smb mount

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/19.08

REVISION DETAIL
  https://phabricator.kde.org/D24487

To: sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24318: Make 32px document-save icon colorful

[Björn Feber]

GB_2 added a comment.


  In D24318#542048 , @ndavis wrote:
  
  > Yeah, that was a feature of the original icon that I didn't remove. I 
wasn't so sure about it either.
  
  
  If you don't like it then remove it :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R306 KParts

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24467

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24372 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24372

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/129/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:18:23 +
 Build duration:
9 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:21:40 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:22:45 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/35/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:22:33 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D24598: Update elisa icon

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham, mgallien.
astippich added a project: Elisa.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Since D12992  seems stuck, update the 
current icon
  a little bit and add a blueish gradient to the
  icon. Also remove the ugly text for the 48px icon,
  since it was not readable anyway at small sizes.

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien
Cc: kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, GB_2, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  I have no intention on taking over D12992 
 as I would like rather like to code for 
Elisa. I am no designer.
  I was unsatisfied with the icon and @mgallien agreed on some slight 
adjustments to the current one.
  D12992  has been around for ages. I hope 
that this incremental update can be agreed upon faster and land for next 
frameworks release. Especially I find the "Elisa" text ugly and worth removing 
it quickly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kactioncollection.h:314
> (pre-existing) QT_MOC_COMPAT for a slot? Any idea what this might do?

No idea. I started a few times to look up what QT_MOC_COMPAT actually is about, 
but never had quick results, so delayed into the future.

Just had a look again, but as before stranding with `MethodCompatibility` from 
qmetaobject_p.h, which seems though nowhere really used.

So far my guess has been this is some relict from Qt3 times no-one ever 
properly cleaned up?

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.
kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in ktoolinvocation.h:152
> No #if for this one?

I cannot remember this was left out on purpose, so far assume I was just 
confused by the existing if/endif spanning multiple methods, and missing out 
this one was not covered.
Updating to add an #if as well as also for its implementation.

REPOSITORY
  R309 KService

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24599: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KCodecs to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DKCODECS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKCODECS_NO_DEPRECATED
- -DKCODECS_DEPRECATED_WARNINGS_SINCE
- -DKCODECS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KCodecs optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.5.0, 5.56.0,
  CURRENT.

REPOSITORY
  R270 KCodecs

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24599

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kcodecs.cpp
  src/kcodecs.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

[Ahmad Samir]

ahmadsamir updated this revision to Diff 67804.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24372?vs=67510=67804

BRANCH
  arcpatch-D24372 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24372

AFFECTED FILES
  src/core/batchrenamejob.cpp
  src/core/connection.cpp
  src/core/copyjob.cpp
  src/core/desktopexecparser.cpp
  src/core/job.cpp
  src/core/kprotocolinfofactory.cpp
  src/core/kprotocolmanager.cpp
  src/core/ksslcertificatemanager.cpp
  src/core/ktcpsocket.cpp
  src/core/scheduler.cpp
  src/core/tcpslavebase.cpp
  src/urifilters/ikws/ikwsopts.cpp
  src/urifilters/ikws/searchproviderdlg.cpp
  src/urifilters/shorturi/kshorturifilter.cpp
  src/widgets/accessmanager.cpp
  src/widgets/clipboardupdater.cpp
  src/widgets/delegateanimationhandler.cpp
  src/widgets/dropjob.cpp
  src/widgets/kdesktopfileactions.cpp
  src/widgets/kdirmodel.cpp
  src/widgets/kfileitemactions.cpp
  src/widgets/kfileitemdelegate.cpp
  src/widgets/kpropertiesdialog.cpp
  src/widgets/krun_win.cpp
  src/widgets/ksslcertificatebox.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/kurifiltersearchprovideractions.cpp
  src/widgets/previewjob.cpp
  src/widgets/sslui.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

[Ahmad Samir]

ahmadsamir added a comment.


  I had to fix one conflict when rebasing, and basically D24419 
 ate the foreach 
src/core/ksslcertificatemanager.cpp@line 128 (by returning the result of 
calling contains() on the container, neater :)).

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24372 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24372

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kactioncollection.h:278
> Does this work? It's a signal. Won't this only warn at emit time? (while 
> QT_MOC_COMPAT is what leads to a warning at connect time)
> 
> Asking because you didn't do this in D24465 
>  for the windowChanged() signals, so 
> something seems inconsistent.

This being one of my experimental repos chance is I forgot to remove the 
KXMLGUI_DEPRECATED_VERSION here, and was blind when I checked the patch before 
uploading.
Let me check again if the deprecated attribute actually gets triggered on 
memberfunction-pointer based connect, not sure right now,

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R309 KService

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R306:b8bc88232471: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24467?vs=67732=67810

REVISION DETAIL
  https://phabricator.kde.org/D24467

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/browserextension.h
  src/browserrun.cpp
  src/browserrun.h
  src/readonlypart.cpp
  src/readonlypart.h

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kossebau wrote in kactioncollection.h:314
> No idea. I started a few times to look up what QT_MOC_COMPAT actually is 
> about, but never had quick results, so delayed into the future.
> 
> Just had a look again, but as before stranding with `MethodCompatibility` 
> from qmetaobject_p.h, which seems though nowhere really used.
> 
> So far my guess has been this is some relict from Qt3 times no-one ever 
> properly cleaned up?

Taking this from the other side: warnings when connecting to deprecated signals 
actually work. They happen in check_and_warn_compat in qobject.cpp

... this does support warning about connecting to compat slots, so my comment 
was bogus, this is fine.

For the usual case, compat signals, the code checks `signal.attributes() & 
QMetaMethod::Compatibility`.

Ah and I found where `MethodCompatibility` (which has the value 0x10) is 
actually set...
the generated moc code says

  6,2,   89,2, 0x06 /* Public */,
  8,2,   94,2, 0x16 /* Public | MethodCompatibility */,

See the second line, it has the 0x10 value in there, which means 
`MethodCompatibility` is set by value, not by name.

I'm just still a bit confused about the relation between the 0x10 metaobject 
flag and the signal attribute which has value 0x1...

  enum Attributes { Compatibility = 0x1, Cloned = 0x2, Scriptable = 0x4 };

But it must work, tst_qobject.cpp tests that QT_MOC_COMPAT ends up setting 
`QMetaMethod::Compatibility` in attributes().

Anyhow, I still believe that using the *_DEPRECATED macro on a signal only 
makes sense if we want to prevent subclasses from emitting the signal. 
Theoretical possibility, extremely unlikely for KActionCollection, but... why 
not. We can do this consistently everywhere without the need to consider the 
likeliness of subclasses, I suppose.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 93 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/93/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 12 Oct 2019 21:22:13 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6885/9077)43%
(10764/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2964)48%
(6166/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[David Faure]

dfaure added a comment.


  Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even 
just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  Don't know, just wondering (not objecting). @vkrause, any opinion?

INLINE COMMENTS

> sslui.h:42
>  RulesStorage storedRules = RecallAndStoreRules);
> +bool KIOWIDGETS_EXPORT askIgnoreSslErrors(const QSslSocket *socket,
> +RulesStorage storedRules = RecallAndStoreRules);

Missing docu, at least @since 5.64

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24584: Add a few const

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24584

To: aacid, meven
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:25:23 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24568: Provide clang-format target with a common KDE style file

[Christoph Cullmann]

cullmann added a comment.


  In D24568#546227 , @aacid wrote:
  
  > > common KDE style file
  >
  > There's no such thing as a common KDE style
  
  
  Shall we name it kdelibs coding style?
  But actually the idea is to have one, as opt in, for the repos that want that.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 12 Oct 2019 21:25:51 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D24590: Port KSslErrorUiData to QSslError

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks good, maybe i can even convince you to make fatalErrors and 
remainingErrors const?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns