D24895: [RFC] Drop implicit size from PC buttons

nicolasfella edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

ahmadsamir added a comment. In D24873#552795 , @vkrause wrote: > In D24873#552697 , @ahmadsamir wrote: > > > In D24873#552410 , @vkrause wrote: > > >

D24895: [RFC] Drop implicit size from PC buttons

broulik added a comment. Perhaps only when it has no text so icon-only can become rightfully square? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: broulik, ngraham, kde-frameworks-devel, mart,

D24641: Collect more information from version control systems

sitter added a comment. Hm, how about separate functions though? With a single stat any given build still needs N process forks even when they only want 1 value. In D24641#548394 , @thomasfischer wrote: > To clarify

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D24902 To: aacid, vkrause Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, bruns

D24895: [RFC] Drop implicit size from PC buttons

davidedmundson added a comment. Please run plasma tests/components/button.qml and tests/components/button3.qml it explains all goals visually (and shows some other PC3 issues) This patch fails "button with or without icon and textfield" should all have the same height. I

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

aacid added a comment. https://phabricator.kde.org/D24898 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH D24703 REVISION DETAIL https://phabricator.kde.org/D24703 To: vkrause, aacid Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

sitter added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24908 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

sitter edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24908 To: sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

aacid added a comment. Discarding the context is bad practice, if you discard it, it's very easy you will make a mistake when you try to i18n the text again and not pass the correct context. I'm against bringing any I18NC_NOOP variant that strips the context. This would also break

D24895: [RFC] Drop implicit size from PC buttons

ngraham added a reviewer: VDG. ngraham added a comment. Compatibility with the wide style in PC1 I think? I've always thought this was kind of weird as well. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart,

D24898: Add KLocalizedString::untranslatedText

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY returns the untraslated string of the KLocalizedString REPOSITORY R249 KI18n BRANCH master REVISION DETAIL

D24909: [PC3/button] Elide text always

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We always want the label to have the width managed by the layout

D24895: [RFC] Drop implicit size from PC buttons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It makes buttons in apps using plasma as a QQC2 style weirdly

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

dfaure added inline comments. INLINE COMMENTS > k7zip.cpp:1678 > > QByteArray inflated; > for (const QByteArray& data : qAsConst(inflatedDatas)) { This makes me realize that there could be an inflated.reserve(unpackSize) here, then, to avoid reallocations. REPOSITORY

D24908: fix default shortcut detection

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY When the default shortcut is empty the UI string "None" is used to indicate that. Alas, when mapping QKeySequences to

D24895: [RFC] Drop implicit size from PC buttons

davidedmundson added a comment. Having had a play, setting implicitWidth to unit.gridUnit * 1.6 and keeping height as-is, makes the most things pass. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg

D24895: [RFC] Drop implicit size from PC buttons

nicolasfella updated this revision to Diff 68629. nicolasfella added a comment. - Actually remove REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24895?vs=68628=68629 BRANCH mo REVISION DETAIL https://phabricator.kde.org/D24895

D24593: Modified breeze shadows

ngraham added a comment. Needs a rebase on master. It doesn't apply for me. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24593: Modified breeze shadows

niccolove added a comment. In D24593#551591 , @ngraham wrote: > Is this ready for formal review now or are you still tweaking and/or soliciting comments? Ready for review :-) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY oss-fuzz has created a file in which inflated size was smaller than unpackSize and thus crc32 was using wrong memory

D24898: Add KLocalizedString::untranslatedText

aacid added a subscriber: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid Cc: ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove updated this revision to Diff 68626. niccolove added a comment. Made missing shadow on corners less noticeable on widgets shadows REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67853=68626 BRANCH breeze-shadows

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Also add a method similar to KSslCipher::digestMethod() to TcpSlaveBase. REPOSITORY R241 KIO BRANCH

D22069: Localize long number strings

huftis added a comment. In D22069#553527 , @huftis wrote: > For non-localised formatting of numbers, use QString::number() instead of QLocale::toString(), as detailed in https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes.

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ba182f153729: Port (most of) KSslInfoDialog from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24703?vs=68619=68708

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

meven added a comment. The new bug https://bugs.kde.org/show_bug.cgi?id=413117 mentions this as well : > kio-5.63 makes kdav-19.08.2 fail with HTTP error (400) > > STEPS TO REPRODUCE > Install the mentioned packages. Try to connect to a davical server via https. > > RESULT

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a dependent revision: D24929: [pop3 kioslave] Port KTcpSocket (deprecated) to QSslSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

huftis added a comment. In D22069#553374 , @flherne wrote: > on IRC pointed out that this could affect telephone numbers. Telephone numbers are not numbers, and should never be represented internally as numbers. If they are, then that’s

D22069: Localize long number strings

huftis added a comment. In D22069#553328 , @flherne wrote: > I'm afraid this was a breaking API change -- it changes the behaviour, and not all numbers are intended to have separators added in this way. > > See

D24909: [PC3/button] Elide text always

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D24909 To: davidedmundson, #plasma, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

ahmadsamir updated this revision to Diff 68702. ahmadsamir edited the summary of this revision. ahmadsamir added a dependency: D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket. ahmadsamir added a comment. Depends on D24928 REPOSITORY

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a dependent revision: D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

flherne added a comment. I'm afraid this was a breaking API change -- it changes the behaviour, and not all numbers are intended to have separators added in this way. See https://bugs.kde.org/show_bug.cgi?id=413390 A similar pattern occurs three different times just in KDevelop, and

D24898: Add KLocalizedString::untranslatedText

apol added a comment. LGTM REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

ilic added a comment. The idea was indeed to deprecate stripping of context, and not only the macro name, for the reason Alber provided. The apparent counterexample in kuitmarkup.cpp is seen only due to macro-within-macro call and the macro expansion order, which is a situation that

D24909: [PC3/button] Elide text always

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D24909 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n,

D24898: Add KLocalizedString::untranslatedText

ilic added a comment. An apparent need for this functionality was popping up from time to time, but somehow never got too serious. Probably because each time it would have been just a convenience, since the original text could have been transported to where it is needed next to the

D22069: Localize long number strings

ngraham added a comment. Darn. :/ Is the problem only with years, or with other kinds of numbers too? Maybe we need a "don't localize this number" flag. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid

D22069: Localize long number strings

flherne added a comment. on IRC pointed out that this could affect telephone numbers. Also: numeric IDs [I bet at least something prints PIDs this way]. I don't think it makes sense to try and enumerate specific cases -- this needs a flag to determine whether localization is done,

D24936: readAndDecodePackedStreams: call reserve on inflated bytearray

dfaure added a comment. Should this be in if (folder->unpackCRCDefined) like the check for unpackSize? Disclaimer: I don't know this code. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24936 To: aacid Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2,

D24908: fix default shortcut detection

aacid added inline comments. INLINE COMMENTS > kshortcuteditwidget.cpp:72 > +m_defaultLabel->setText(defaultText); > } > this is wrong, isn't it? Or at least behaviour changing, before m_defaultLabel was set to None, when defaultText was empty. Now it's not? REPOSITORY R263

D24908: fix default shortcut detection

sitter added inline comments. INLINE COMMENTS > aacid wrote in kshortcuteditwidget.cpp:72 > this is wrong, isn't it? > > Or at least behaviour changing, before m_defaultLabel was set to None, when > defaultText was empty. Now it's not? it's initialized to None via the ctor at line 68 already.

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote: > BTW, we want to also set > -DQT_DEPRECATED_WARNINGS_SINCE=0x06 > otherwise the deprecations done with QT_DEPRECATED_VERSION in Qt's API will > not emit warnings, because QT_DEPRECATED_WARNINGS_SINCE defaults to >

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH assert-for-git REVISION DETAIL https://phabricator.kde.org/D24827 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:27:33 + Build duration: 18 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:31:52 + Build duration: 54 min and counting JUnit Tests Name:

D24932: [WIP]: Add Button to open the folder in filelight for more details

shubham created this revision. shubham added reviewers: ngraham, Frameworks. shubham added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY BUG: 408962 Note: Does not compile on my machine due to

D24931: Port KSSD internals from KSslError to QSslError

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24931 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

dfaure added a comment. I forgot to link the fix here: D24880 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24316 To: vkrause, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

aacid added a comment. No one has shown the need for those things your asking. We have clear need for untranlatedText. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. Is cipherDigestMethod() (method @ line 96) needed? the cipher name is inserted in sslMetaData a couple of lines after that. Using some test code: QList list = QSslConfiguration::supportedCiphers(); for (QSslCipher c : list) { qInfo() << c.name();

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:26:18 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 24 Oct 2019 22:27:01 + Build duration: 26 min and counting BUILD ARTIFACTS

D24938: Fix memory leak in KXzFilter::init

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY I wasn't 99% sure we need to free the filters so early since we're passing them to the functions that manipulate the

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:30:24 + Build duration: 40 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:30:36 + Build duration: 45 min and counting JUnit Tests Name:

D24936: readAndDecodePackedStreams: call reserve on inflated bytearray

aacid abandoned this revision. aacid added a comment. I don't know either. Let's not micro optimize without need and knowledge REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24936 To: aacid Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24908: fix default shortcut detection

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. ok, fair enough about the tests INLINE COMMENTS > sitter wrote in kshortcuteditwidget.cpp:72 > it's initialized to None via the ctor at line 68 already. now that I notice > it, defaultText

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:27:01 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 157 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/157/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:28:55 + Build duration: 35 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 130 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/130/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:30:43 + Build duration: 54 min and counting JUnit Tests Name:

D24936: readAndDecodePackedStreams: call reserve on inflated bytearray

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D24936 AFFECTED FILES src/k7zip.cpp To: aacid

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:28:44 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:30:18 + Build duration: 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 22:32:31 + Build duration: 1 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 156 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/156/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 17:12:47 + Build duration: 8 min 9 sec and counting JUnit Tests Name:

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause added a comment. In D24892#552838 , @kossebau wrote: > Looks good. Perfect would be if you tested KIconThemes with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is no internal usage still happening, like

D22069: Localize long number strings

aacid added a comment. numid is something we want to fix, we have a test for it, so if someone feels like working, ki18n is waiting for you :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid Cc: flherne,

D24931: Port KSSD internals from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The strings don't match all enum values exactly, as this tries to keep the same strings for the corresponding enums

D24908: fix default shortcut detection

aacid added a comment. Can this be autotested? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24908 To: sitter, dfaure Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

huftis added a comment. In D22069#553556 , @huftis wrote: > In D22069#553527 , @huftis wrote: > > > For non-localised formatting of numbers, use QString::number() instead of QLocale::toString(), as

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24902 To: aacid, vkrause Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

Am Donnerstag, 24. Oktober 2019, 22:16:47 CEST schrieb David Faure: > Git commit fb4639b0b5f2a51d124949d59b9a327bf66c8f04 by David Faure. > Committed on 24/10/2019 at 20:15. > Pushed by dfaure into branch 'frameworks/5.0'. > > KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min

D24908: fix default shortcut detection

sitter added a comment. Supposedly, I was being lazy though since there is no pre existing test and I don't exactly know if there's anything to watch out for when testing widgets (as in: I've never written a widget test before). REPOSITORY R263 KXmlGui REVISION DETAIL

D24932: [WIP]: Add Button to open the folder in filelight for more details

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpropertiesdialog.cpp:444 > { > -for (KPropertiesDialogPlugin *it : qAsConst(d->m_pageList)) { > +foreach (KPropertiesDialogPlugin *it,

[sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

Git commit fb4639b0b5f2a51d124949d59b9a327bf66c8f04 by David Faure. Committed on 24/10/2019 at 20:15. Pushed by dfaure into branch 'frameworks/5.0'. KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version This is just safety; some time ago I made them all disable API

D24939: Meson: more built-in functions and add built-in member functions

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/31/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 24 Oct 2019 22:31:55 + Build duration: 2 hr 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/54/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 24 Oct 2019 22:27:02 + Build duration: 1 hr 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.13 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.13/18/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 24 Oct 2019 22:28:48 + Build duration: 1 hr 33 min and counting JUnit Tests Name: (root)

D24938: Fix memory leak in KXzFilter::init

apol added a comment. +1 makes sense REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24938 To: aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.13/10/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 24 Oct 2019 22:28:45 + Build duration: 2 hr 46 min and counting JUnit Tests

D24939: Meson: more built-in functions and add built-in member functions

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24939 To: jpoelen,

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

mlaurent added a comment. So what is the correct fix for my case ? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns