D25059: KPluginSelector: use new KAboutPluginDialog

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpluginselector.cpp:799-803
> +PluginEntry *pluginEntry = model->data(index, 
> PluginEntryRole).value();
> +KPluginMetaData pluginMetaData = pluginEntry->pluginInfo.toMetaData();
> +
> +KAboutPluginDialog aboutPlugin(pluginMetaData, itemView());
>  aboutPlugin.exec();

Can you guard for nullptr?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25059

To: kossebau, #frameworks, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 69022.
nibags added a comment.


  - Increase margin of list - search bar in Windows

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=69005=69022

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  In D25010#556237 , @dfaure wrote:
  
  > If you change the actual values being sent to kioslaves, then this breaks 
the "wire protocol". I.e. after upgrading KF5 on a live system, kioslaves 
(started by kdeinit5 forking the "old" libkiocore) will receive numbers from 
newly started apps (which link to the "new" libkiocore), that they won't 
understand. Of course a simple `kdeinit5` in a terminal would fix that, but 
most users don't know that. (One idea that has been floating around is to 
detect changes to libKIO.so and other dependencies and auto-restart kdeinit 
when these libs are changed... But, hmm, then already-running apps will send 
old values to newly started kioslaves, problem again).
  
  
  Thank you for reminding me of this concern.
  
  > One solution is to make the enum actually use the old values (0, 2, 3) by 
doing careful mapping. That's what I thought we would do, but I see you went 
for a more flexible approach where apps can pick the exact groups of fields 
they want.
  > 
  > So another solution would be to use a different metadata key and send the 
old key (with the old value, at least a close approximation of it) for 
compatibility purposes.
  
  That's the solution I would prefer : it would allow me to add a "TODO KF6 
remove to the old metadata key", breaking the wire format should be fine then, 
so we end up with the best state for KF6.
  
  Next items:
  
  - Add compatibility to older KIO version on the wire
  - match the flags to statx flags to avoid paying for unwanted fields down to 
the syscall.

INLINE COMMENTS

> statjob.h:53
> +/// Filename, access, type, size, linkdest
> +Basic = 0x1,
> +/// uid, gid

I am open to suggestion here :

1. Should it be more granular ?

2. Are names KIO-ish ?

@kossebau :

> On a first look, the names seems very short & generic to me, having some 
> other name element might avoid semantic collisions perhaps. No idea yet, not 
> looked further.

> dfaure wrote in file.cpp:896
> Did you know you can just write `if (details & KIO::StatJob::Basic)`?
> This is more C++-like, which is probably more future-proof if one day don't 
> use QFlags anymore for these types of things.
> 
> Or did you use testFlag() for a specific reason?

I used testFlag because i was documented, and I still have to familiar myself 
with C/C++.

> dfaure wrote in listjobtest.cpp:44
> It's a bit weird to use a StatJob enum in the ListJob class. But then again, 
> it is about the stat() done by listing So this is OK, I guess.

> Does KIO::DefaultDetails make sense beyond stat in the KIO namespace? How 
> does it match other similar flags?

It was @kossebau concern as well.

I am open to suggestion to improve on that, maybe this enum should be in KIO 
namespace ?
In the meantime, it was what was made the most sense to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven updated this revision to Diff 69021.
meven marked 3 inline comments as done.
meven added a comment.


  Avoid using short and testFlag

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=68975=69021

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in deletejob.cpp:67
> "const bool" doesn't do anything in a signal, I suggest removing the const.

I am hesitant to remove `const QUrl& url` from this signal, it could save some 
space in message passing.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Tired given the time, but let's see if I get things straight this time:
  Given KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00, in the API of KConfig  we 
just see KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE. And as I just 
found, there also in no build option to completely get rid of it . Possibly the 
patch I did there I left it as I assumed a chance the enum value might be 
stored as number in config entries, so changing any enum values would break 
data. Too bad there is no related comment, I shall fix that with a follow-up 
patch, to be put into review the next day.
  So, with these considerations,
  
#if KCONFIGWIDGETS_BUILD_DEPRECATED_SINCE(5, 38)
​{ SaveOptions,   
KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE, "options_save_options", 
I18N_NOOP(" Settings"), nullptr, nullptr },
#endif
  
  should actually be always correct. We do not support people building the 
library to override any *_DISABLE_DEPRECATED_BEFORE_AND_AT settings for the 
libraries we build against.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24966: KXmlGui: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  To leave KAboutData::programIconData as a deprecated property and instead 
turn to use KPluginMetaData where the iconName property is undisputed in its 
usefullnes, I have now uploaded 3 patches for view;
  
  - D25063 : Add KAboutPluginDialog, to be 
used with KPluginMetaData
  - D25059 : KPluginSelector: use new 
KAboutPluginDialog
  - D25063 : Deprecate 
KAboutData::fromPluginMetaData, now there is KAboutPluginDialog
  
  Now, there is still the idea of using KAboutData with plugins in the 
KAboutData API, by the methods `void KAboutData::registerPluginData(const 
KAboutData )` & ` KAboutData *KAboutData::pluginData(const QString 
)`, By what lxr.kde.org reports,  the register method is still in 
use, but nothing seems to actually query the registration data by the other 
method. So possibly we could discard that pair of methods as well. Would be 
curious though what the usecase for this once was, it surely had a piurpose.
  
  So, IMHO the current patch as proposed here should not be done, instead we 
should just silence the warnings via push/pop of compiler settings stash. We 
still need to support any legacy code out there which still relies on setting 
the icon via KAboutData::setApplicationData()). Which actually might also get 
unnoticed with code only tested with Wayland, as QGuiApplication::setWindowIcon 
is without effect there and the window icon actually fetched via the desktop 
file metadata entry. And we actually have a problem if no icon is provided by 
either way... Hm... possibly we need to resurrect KAboutData::programIconName 
for this wayland-only future, so the program itself has the same set of 
metadata about itself as the shell has...  though this needs QCoreApplication 
to have a way to support us here, so any metaddata does not get out-of-sync...

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24966

To: dfaure, kossebau, elvisangelaccio, vkrause, jriddell
Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Depends on D25058 

REPOSITORY
  R244 KCoreAddons

BRANCH
  deprecateaboutdatafromPluginMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25063

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D25063: Deprecate 
KAboutData::fromPluginMetaData, now there is KAboutPluginDialog.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25058

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  The generated classes of kconfig_compiler take a KSharedConfig::Ptr by
  value, one possibility would be to make them const & but that is BIC so
  instead what we do is just move them to the only place the config is
  used so the cheaper move constructor can be used instead of the copy
  constructor

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25061

AFFECTED FILES
  autotests/kconfig_compiler/test8a.cpp.ref
  autotests/kconfig_compiler/test8c.cpp.ref
  src/kconfig_compiler/kconfig_compiler.cpp

To: aacid
Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D25023: Make kconfig_compiler generate code with const

[Albert Astals Cid]

aacid abandoned this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25023

To: aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks good to me!
  Thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ps-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D25054: Add string escape characters to PowerShell syntax.

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3d28d32776c9: Add string escape characters to PowerShell 
syntax. (authored by zrax, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25054?vs=69011=69012

REVISION DETAIL
  https://phabricator.kde.org/D25054

AFFECTED FILES
  autotests/folding/craftenv.ps1.fold
  autotests/html/craftenv.ps1.html
  autotests/input/craftenv.ps1
  autotests/reference/craftenv.ps1.ref
  data/syntax/powershell.xml

To: zrax, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D25025: decodeBCJ2: Fix assert with broken files

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D25025

To: aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax updated this revision to Diff 69011.
zrax added a comment.


  - Add test case for new escape sequences to powershell autotest

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25054?vs=69010=69011

BRANCH
  ps-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25054

AFFECTED FILES
  autotests/folding/craftenv.ps1.fold
  autotests/html/craftenv.ps1.html
  autotests/input/craftenv.ps1
  autotests/reference/craftenv.ps1.ref
  data/syntax/powershell.xml

To: zrax, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D25054: Add string escape characters to PowerShell syntax.

[Dominik Haumann]

dhaumann added a comment.


  Looks good to me.
  
  Btw, you posted several patches over the last two years. You could also apply 
for a KDE contributor account and push yourself, if you want.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D24959: Add new preferences search icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24959#556058 , @ngraham wrote:
  
  > Better now @trickyricky26?
  
  
  I do think the new version looks better, more because of the nicer 
proportions of the magnifying glass than the shadow.
  
  I think it's not optimal to add another symbol-on-single-color-circle icon, 
in addition to the bluetooth, user, accessibility etc. icons. It would be nice 
to have a more distinctive icon for this, but I don't have any concrete ideas 
for such a design. The previous icon for this was the magnifying glass on a 
file, but perhaps this isn't quite accurate here as the KCM deals with Baloo as 
well as krunner, which does more than only search for files.
  
  In any case, I would try making the symbol have 1px thickness to match the 
other similar preferences icons, perhaps even copy the symbol directly from the 
old symbol-on-file icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax updated this revision to Diff 69010.
zrax added a comment.


  - Add test case for new escape sequences to powershell autotest

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25054?vs=68996=69010

BRANCH
  ps-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25054

AFFECTED FILES
  autotests/folding/craftenv.ps1.fold
  autotests/html/craftenv.ps1.html
  autotests/input/craftenv.ps1
  autotests/reference/craftenv.ps1.ref
  data/syntax/powershell.xml

To: zrax, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 69005.
nibags added a comment.


  - Restore scroll bar margins

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=68974=69005

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25059: KPluginSelector: use new KAboutPluginDialog

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Depends on D25058 

REPOSITORY
  R295 KCMUtils

BRANCH
  useaboutplugindialog

REVISION DETAIL
  https://phabricator.kde.org/D25059

AFFECTED FILES
  src/kpluginselector.cpp

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D25059: KPluginSelector: use new 
KAboutPluginDialog.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25058

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I can push it for you.
  But I think it would be a good idea to have an unit test extended with the 
new supported syntax parts.
  Could you add that?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  When showing an About dialog for a plugin, so far a
  KAboutApplicationDialog had to be used, by generating an KAboutData object
  from the KPluginMetaData object.
  Using KAboutApplicationDialog has those disadvantages:
  
  - the icon shown in the title widget is the one of the application, not the 
plugin
  - the "Libraries" tab does not make much sense with a plugin, as it is the 
same as the shell application
  - the name KAboutApplicationDialog is a mismatch when used with a plugin

TEST PLAN
  About application dialog works as before in applications, the new about
  plugin dialog works with KDevelop's Loaded Plugins dialog as well as
  KPluginSelector.

REPOSITORY
  R263 KXmlGui

BRANCH
  addaboutplugindialog

REVISION DETAIL
  https://phabricator.kde.org/D25058

AFFECTED FILES
  src/CMakeLists.txt
  src/kaboutapplicationdialog.cpp
  src/kaboutapplicationdialog.h
  src/kaboutplugindialog.cpp
  src/kaboutplugindialog.h
  src/kabstractaboutdialog_p.cpp
  src/kabstractaboutdialog_p.h
  src/klicensedialog_p.cpp
  src/klicensedialog_p.h

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax added a comment.


  I do not have a KDE developer account, so I cannot land the change myself 
presently.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ps-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  If you change the actual values being sent to kioslaves, then this breaks the 
"wire protocol". I.e. after upgrading KF5 on a live system, kioslaves (started 
by kdeinit5 forking the "old" libkiocore) will receive numbers from newly 
started apps (which link to the "new" libkiocore), that they won't understand. 
Of course a simple `kdeinit5` in a terminal would fix that, but most users 
don't know that. (One idea that has been floating around is to detect changes 
to libKIO.so and other dependencies and auto-restart kdeinit when these libs 
are changed... But, hmm, then already-running apps will send old values to 
newly started kioslaves, problem again).
  
  One solution is to make the enum actually use the old values (0, 2, 3) by 
doing careful mapping. That's what I thought we would do, but I see you went 
for a more flexible approach where apps can pick the exact groups of fields 
they want.
  
  So another solution would be to use a different metadata key and send the old 
key (with the old value, at least a close approximation of it) for 
compatibility purposes.

INLINE COMMENTS

> file.cpp:895
>  assert(entry.count() == 0); // by contract :-)
> -switch (details) {
> -case 0:
> +short entries = 0;
> +if (details.testFlag(KIO::StatJob::Basic)) {

int is actually faster on most CPUs, and reserve() will convert it to an int 
anyway, so it might as well be an int from the beginning.

> file.cpp:896
> +short entries = 0;
> +if (details.testFlag(KIO::StatJob::Basic)) {
>  // filename, access, type, size, linkdest

Did you know you can just write `if (details & KIO::StatJob::Basic)`?
This is more C++-like, which is probably more future-proof if one day don't use 
QFlags anymore for these types of things.

Or did you use testFlag() for a specific reason?

> listjobtest.cpp:44
>  job->setUiDelegate(nullptr);
> -job->addMetaData(QStringLiteral("details"), QStringLiteral("2")); // 
> Default is 2 which means all details. 0 means just a few essential fields 
> (KIO::UDSEntry::UDS_NAME, KIO::UDSEntry::UDS_FILE_TYPE and 
> KIO::UDSEntry::UDS_LINK_DEST if it is a symbolic link. Not provided otherwise.
> +job->addMetaData(QStringLiteral("details"), 
> QString::number(KIO::StatJob::StatDefaultDetails));
>  

It's a bit weird to use a StatJob enum in the ListJob class. But then again, it 
is about the stat() done by listing So this is OK, I guess.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Please commit.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ps-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D24966: KXmlGui: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Playing with reviving my programIconName undeprecation patch (by adding a new 
property iconName w/ setter/getter), and looking through the rest of the API, I 
though now think that we should keep KAboutData untouched and leave it for 
metadata about programs, while instead making use of KPluginMetaData instead 
when it comes to plugins.
  
  As it seems KAboutData is only used with plugins to be able to reuse the 
KAboutApplicationDialog. So I have sketched a KAboutPluginDialog variant, which 
takes a KPluginMetaData instead. First tests work fine, should be uploading 
later tonight. So far tested with KDevelop, custom dialog for plugins actually 
improves things. KPluginSelector will be able to drop some code, and we can 
also deprecate KAboutData::fromPluginMetaData, as using KAboutApplicationDialog 
for a plugin was the only purpose by what lxr tells me (only in Okular & 
KDevelop).

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24966

To: dfaure, kossebau, elvisangelaccio, vkrause, jriddell
Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK, let's get this in :-)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25054

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25054: Add string escape characters to PowerShell syntax.

[Michael Hansen]

zrax created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
zrax requested review of this revision.

REVISION SUMMARY
  Powershell uses the syntax ` or `u{hex} as escape sequences within
  double-quoted strings.  This adds highlighting support for both sequences
  to the PowerShell syntax.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ps-escape (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25054

AFFECTED FILES
  data/syntax/powershell.xml

To: zrax
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24957: Add new baloo icons

[Alexander Stippich]

astippich added a comment.


  F7686927: test32.png 
  
  F7686929: test48.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  newBalooIcon

REVISION DETAIL
  https://phabricator.kde.org/D24957

To: astippich, #vdg, ngraham, bruns
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D25015#48 , @ngraham wrote:
  
  > If anything I wonder if we should make them bigger too, to better match the 
default Breeze shadows.
  
  
  I'd prefer to avoid them making more sparse because a) they look worse to me 
when applied to small objects such as notifications (you have big shadows for a 
relatively small item, they don't give the impression to be casted by that 
item) b) lots and lots of techical problem when trying to change shadow size :-/

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24742: Make non-ignorable SSL errors explicit

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24742

To: vkrause, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Björn Feber]

GB_2 added a comment.


  +1

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25049

To: ngraham, #vdg, #plasma, mart
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Oct 2019 17:18:18 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Declarative-5.64.0.xmllogs/KF5Declarative/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)18%
(11/60)18%
(11/60)15%
(503/3318)11%
(202/1883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)91%
(196/215)38%
(99/259)src.calendarevents0%
(0/3)0%
(0/3)0%
(0/63)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)50%
(150/301)37%
(50/134)src.kdeclarative.private100%
(2/2)100%
(2/2)19%
(6/31)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/7)0%
(0/7)0%
(0/362)0%
(0/170)src.qmlcontrols.kcmcontrols0%
(0/1)0%
(0/1)0%
(0/3)0%
(0/2)src.qmlcontrols.kconfig0%
(0/2)0%
(0/2)0%
(0/11)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/4)0%
(0/4)0%
(0/85)0%
(0/66)src.qmlcontrols.kioplugin0%
(0/2)0%
(0/2)0%
(0/20)0%
(0/24)src.qmlcontrols.kquickcontrols.private0%
(0/4)0%
(0/4)0%
(0/316)0%
(0/220)src.qmlcontrols.kquickcontrolsaddons7%
(1/15)7%
(1/15)5%
(65/1377)4%
(30/756)src.qmlcontrols.kwindowsystemplugin0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/36)src.quickaddons14%
(1/7)14%
(1/7)22%
(86/384)13%
(23/174)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This makes the navigeability of multi-page KCMs completely obvious. The 
buttons only show
  up in multi-page KCMs where you've navigated into a sub-page, so there is no 
visual
  regression for anyone else.

TEST PLAN
  F7686630: demo-2019-10-29_11.19.01.webm 

REPOSITORY
  R295 KCMUtils

BRANCH
  show-navigation-buttons-when-necessary (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25049

AFFECTED FILES
  src/kcmoduleqml.cpp

To: ngraham, #vdg, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

[Volker Krause]

vkrause added a comment.


  Anyone? This blocks the subsequent SSL error patches.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24742

To: vkrause, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

[Volker Krause]

vkrause added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24742

To: vkrause, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 80 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/80/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 29 Oct 2019 11:27:43 +
 Build duration:
5 hr 11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(233/299)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(193/244)59%
(96/164)

D25041: Ensure that the changedEntries property is correctly propagated

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  ensure-changedentries-is-forwarded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25041

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Nathaniel Graham]

ngraham added a comment.


  Better now @trickyricky26?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D12283: Allow to load dictionaries form a rcc

[Ahmad Samir]

ahmadsamir added a comment.


  IINM, in the commit message s/form a rcc/from an rcc/.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: ahmadsamir, kde-frameworks-devel, habacker, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich updated this revision to Diff 68979.
astippich added a comment.


  - modified icon with shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24959?vs=68779=68979

BRANCH
  newSearchIcon

REVISION DETAIL
  https://phabricator.kde.org/D24959

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-search.svg
  icons/preferences/32/preferences-desktop-search.svg

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 205 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/205/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Oct 2019 11:30:56 +
 Build duration:
2 hr 57 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.64.0.xmlacc/KF5PlasmaQuick-5.64.0.xmllogs/KF5Plasma/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4615/13256)26%
(2514/9639)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(871/920)52%
(439/852)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(775/2303)26%
(395/1495)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/59)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1529/3524)33%
(955/2870)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(749/1576)37%
(384/1045)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)7%
(7/105)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(591/2033)19%
(324/1710)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/984)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 189 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/189/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Oct 2019 11:27:45 +
 Build duration:
2 hr 52 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(233/299)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(193/244)59%
(96/164)

D24958: Delete nepomuk icon

[Alexander Stippich]

astippich added a comment.


  Thanks @broulik for the hint and @ngraham for being faster than me :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Nathaniel Graham]

ngraham added a comment.


  All of our other icons that consist of a white symbol in a blur circle have 
the shadow, so it's probably best to at least be consistent. If we decided we 
don't like the shadow, we should remove them from all of these icons at once.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25041: Ensure that the changedEntries property is correctly propagated

[Nathaniel Graham]

ngraham added a dependent revision: D24942: Require and use the new 
NewStuffQuick Button component.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25041

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Nathaniel Graham]

ngraham added a comment.


  Actually I guess it needs to.
  
  I'll fix the icon in Dolphin.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Nathaniel Graham]

ngraham added a comment.


  Gross, it even uses a pixmap rather than just using the icon directly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Kai Uwe Broulik]

broulik added a comment.


  
https://cgit.kde.org/dolphin.git/tree/src/panels/information/informationpanelcontent.cpp#n231

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

[Méven Car]

meven abandoned this revision.
meven added a comment.


  See D25010 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24999

To: meven, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Méven Car]

meven retitled this revision from "[StatJob] Use A QFlag to specify the details 
returned by statJob" to "[StatJob] Use A QFlag to specify the details returned 
by StatJob".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Alexander Stippich]

astippich added a comment.


  Can you give me a hint exactly where? I searched for usages and found none, 
and still cannot find it now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven updated this revision to Diff 68975.
meven added a comment.


  Move KIO::StatDefaultDetails to KIO::StatJob::StatDefaultDetails

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=68973=68975

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven added a comment.


  In D25010#555890 , @kossebau wrote:
  
  > Now that is a quick turn-around, +1 for doing the work :)
  >
  > No time myself to look at this closely the next days, also not that much 
into KIO, but here some quick feedback with an API police hat on.
  
  
  Your comments are already of great value, given this needs some polishing.
  
  > Would be also good to have some patches which make use of the new API, so 
one could better judge the usefulness.
  
  The interest here is to have a modern API and better documented that is was 
and more features.
  In the meantime I have ported the rest of KIO to use it.

INLINE COMMENTS

> kossebau wrote in jobremotetest.cpp:70
> As reader of this code here alone, I wonder what KIO::StatJob::Basic means. 
> To understand what this code does, I would first have to look at the API dox, 
> not good.
> So possibly Basic should get a different name, at least contain "Detail" term 
> perhaps. "Basic" also needs context to have semantics, I could e.g. not tell 
> instantly what basic details are. So perhaps needs to be more expliciti here.

I guess so, "Basic" here lacks context.
But the documentation will be much faster to get than before with the 0 field.

> kossebau wrote in statjob.h:181
> I wonder if this should not be rather a member of StatJob, instead of being 
> on generic KIO namespace level.
> It feels unbalanced to have the enum being in the class, but a util flag set 
> not.

Great suggestion !
I wanted to do that but I just did not find a way to have StatDefaultDetails 
part of StatJob namespace given 
`Q_DECLARE_OPERATORS_FOR_FLAGS(StatJob::Details)` must be declared outside of 
StatJob class.

Adding it to the enum should just work, working on it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

[Kai Uwe Broulik]

broulik added a comment.


  Note that Dolphin still uses that icon for its information panel when in 
search mode.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24958

To: astippich, ngraham, bruns
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 68974.
nibags added a comment.


  - Fix font size/style

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=68828=68974

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in statjob.h:181
> I wonder if this should not be rather a member of StatJob, instead of being 
> on generic KIO namespace level.
> It feels unbalanced to have the enum being in the class, but a util flag set 
> not.

Actually, this could be part of the StatJob::StatDetail enum, no? Having 
combinations of lfags in the enum itself (to be used as shortcuts) is usual 
practice and also should not conflict with Q_DECLARE_FLAGS, IIRC (would need to 
check).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven updated this revision to Diff 68973.
meven added a comment.


  Fix jobs details argument passing and fix setDetails(int)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=68971=68973

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> jobremotetest.cpp:70
>  {
> -KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, 0, 
> KIO::HideProgressInfo);
> +KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, 
> KIO::StatJob::Basic, KIO::HideProgressInfo);
>  job->setUiDelegate(nullptr);

As reader of this code here alone, I wonder what KIO::StatJob::Basic means. To 
understand what this code does, I would first have to look at the API dox, not 
good.
So possibly Basic should get a different name, at least contain "Detail" term 
perhaps. "Basic" also needs context to have semantics, I could e.g. not tell 
instantly what basic details are. So perhaps needs to be more expliciti here.

> copyjob.cpp:365
>  const QUrl dest = m_asMethod ? m_dest.adjusted(QUrl::RemoveFilename) : 
> m_dest;
> -KIO::Job *job = KIO::stat(dest, StatJob::DestinationSide, 2, 
> KIO::HideProgressInfo);
> +KIO::Job *job = KIO::stat(dest, StatJob::DestinationSide, 
> KIO::StatDefaultDetails, KIO::HideProgressInfo);
>  qCDebug(KIO_COPYJOB_DEBUG) << "CopyJob: stating the dest" << m_dest;

Fear the same as said for Basic is true with Default. I would prefer explicit 
flags here as code reader.

> statjob.h:181
> +/// @since 5.64
> +constexpr static StatJob::StatDetails StatDefaultDetails = 
> StatJob::StatDetail::Basic | StatJob::StatDetail::User | 
> StatJob::StatDetail::Time | StatJob::StatDetail::Acl | 
> StatJob::StatDetail::ResolveSymlink;
> +

I wonder if this should not be rather a member of StatJob, instead of being on 
generic KIO namespace level.
It feels unbalanced to have the enum being in the class, but a util flag set 
not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven updated this revision to Diff 68971.
meven marked an inline comment as done.
meven added a comment.


  Wrap setDetails with #if KIOCORE_ENABLE_DEPRECATED_SINCE, use the new API 
throughout the rest of KIO

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=68969=68971

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> statjob.h:96
> +
>  /**
>   * Selects the level of @p details we want.

All deprecated API should be also wrapped in visibility controls., so same 
#if/#endif also here.

Basic structure:

  if deprecated api should be visible to compiler & Co (e.g. docs generator)
  API docs
  warning attribute if should be emitted 
  method declaration
  endif

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Méven Car]

meven updated this revision to Diff 68969.
meven marked 8 inline comments as done.
meven added a comment.


  Rename StatJob::Detail to StatJob::StatDetail, KIO::DefaultDetails to 
KIO::StatDefaultDetails, add deprecation doc and macro

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=68893=68969

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  src/core/statjob.cpp
  src/core/statjob.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 54 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/54/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 29 Oct 2019 11:27:45 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalable

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 29 Oct 2019 11:27:45 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.scalable

D24958: Delete nepomuk icon

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:34fa249177e1: Delete nepomuk icon (authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24958?vs=68778=68967

REVISION DETAIL
  https://phabricator.kde.org/D24958

AFFECTED FILES
  icons-dark/preferences/32/nepomuk.svg
  icons/preferences/32/nepomuk.svg

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

[Alexander Stippich]

astippich added a comment.


  New proposal
  F7684533: preferences-desktop-search2.png 

  
  However, I am not a fan of the shadow. It is barely visbile anyways at such 
small sizes, and it looks weird with the handle

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 204 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/204/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Oct 2019 10:29:41 +
 Build duration:
31 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskAll nodes of label ‘SUSEQt5.12’ are offlineReady to run at Tue Oct 29 11:00:59 UTC 2019Resuming build at Tue Oct 29 11:00:59 UTC 2019 after Jenkins restartRunning on Docker Swarm-e3e45416503b in /home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[Pipeline] }[2019-10-29T11:01:30.182Z] Cloning repository git://anongit.kde.org/plasma-framework[2019-10-29T11:01:30.208Z]  > git init /home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.12 # timeout=10[2019-10-29T11:01:30.253Z] Fetching upstream changes from git://anongit.kde.org/plasma-framework[2019-10-29T11:01:30.254Z]  > git --version # timeout=10[2019-10-29T11:01:30.263Z]  > git fetch --tags --force --progress git://anongit.kde.org/plasma-framework +refs/heads/*:refs/remotes/origin/* # timeout=120[Pipeline] // stage[Pipeline] }[2019-10-29T11:01:33.025Z] java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps[2019-10-29T11:01:33.026Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.onResume(SynchronousNonBlockingStepExecution.java:75)[2019-10-29T11:01:33.026Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)[2019-10-29T11:01:33.026Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)[2019-10-29T11:01:33.026Z] 	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)[2019-10-29T11:01:33.026Z] 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)[2019-10-29T11:01:33.026Z] 	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)[2019-10-29T11:01:33.026Z] 	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)[2019-10-29T11:01:33.027Z] 	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)[2019-10-29T11:01:33.027Z] 	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[2019-10-29T11:01:33.027Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:1011)[2019-10-29T11:01:33.027Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:989)[2019-10-29T11:01:33.027Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)[2019-10-29T11:01:33.027Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:37)[2019-10-29T11:01:33.027Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-29T11:01:33.027Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-29T11:01:33.027Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)[2019-10-29T11:01:33.028Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)[2019-10-29T11:01:33.028Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)[2019-10-29T11:01:33.028Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-29T11:01:33.028Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-29T11:01:33.028Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-29T11:01:33.028Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-29T11:01:33.028Z] 	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/83/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Oct 2019 10:07:17 +
 Build duration:
54 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskAll nodes of label ‘SUSEQt5.12’ are offlineReady to run at Tue Oct 29 11:00:59 UTC 2019Resuming build at Tue Oct 29 11:00:59 UTC 2019 after Jenkins restartRunning on Docker Swarm-0b382fc15c3b in /home/jenkins/workspace/Frameworks/kdeclarative/kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-29T11:01:33.130Z] java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps[2019-10-29T11:01:33.130Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.onResume(SynchronousNonBlockingStepExecution.java:75)[2019-10-29T11:01:33.130Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)[2019-10-29T11:01:33.131Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)[2019-10-29T11:01:33.131Z] 	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)[2019-10-29T11:01:33.131Z] 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)[2019-10-29T11:01:33.131Z] 	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)[2019-10-29T11:01:33.131Z] 	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)[2019-10-29T11:01:33.131Z] 	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)[2019-10-29T11:01:33.131Z] 	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[2019-10-29T11:01:33.131Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:1011)[2019-10-29T11:01:33.131Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:989)[2019-10-29T11:01:33.131Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)[2019-10-29T11:01:33.131Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:37)[2019-10-29T11:01:33.131Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-29T11:01:33.131Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-29T11:01:33.131Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)[2019-10-29T11:01:33.131Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)[2019-10-29T11:01:33.131Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)[2019-10-29T11:01:33.131Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-29T11:01:33.131Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-29T11:01:33.131Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-29T11:01:33.131Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-29T11:01:33.131Z] 	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Now that is a quick turn-around, +1 for doing the work :)
  
  No time myself to look at this closely the next days, also not that much into 
KIO, but here some quick feedback with an API police hat on.
  
  Would be also good to have some patches which make use of the new API, so one 
could better judge the usefulness.

INLINE COMMENTS

> statjob.h:50
>  
> +enum Detail {
> +/// Filename, access, type, size, linkdest

Is there other KIO API which has similar enums, where some consistency would be 
good to have?

On a first look, the names seems very short & generic to me, having some other 
name element might avoid semantic collisions perhaps. No idea yet, not looked 
further.

> statjob.h:50
>  
> +enum Detail {
> +/// Filename, access, type, size, linkdest

Please add @since comment

> statjob.h:91
> + * Selects the level of @p details we want.
> + */
> +void setDetails(StatJob::Details details);

Please add @since

> statjob.h:103
>   */
>  void setDetails(short int details);
>  

Not deprecated now?

> statjob.h:174
> +
> +constexpr static StatJob::Details DefaultDetails = StatJob::Detail::Basic | 
> StatJob::Detail::User | StatJob::Detail::Time | StatJob::Detail::Acl | 
> StatJob::Detail::ResolveSymlink;
> +

Does KIO::DefaultDetails make sense beyond stat in the KIO namespace? How does 
it match other similar flags?
Perhaps should be more bound to "stat" by the name.
Please also add documentation, incl. "@since"

> statjob.h:206
> + * @return the job handling the operation.
> + */
> +KIOCORE_EXPORT StatJob *stat(const QUrl , KIO::StatJob::StatSide side,

Please add @since

> statjob.h:209
> + StatJob::Details details, JobFlags flags = 
> DefaultFlags);
>  /**
>   * Find all details for one file or directory.

Please wrap the deprecated API call (incl. API dox comment) with visibilty 
controlling #if/#endif., so here

  #if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64)

> statjob.h:234
>   * @param flags Can be HideProgressInfo here
>   * @return the job handling the operation.
>   */

Please add "@deprecated Since 5.64. Use KIO::stat(const QUrl &, 
KIO::StatJob::StatSide, StatJob::Details int, JobFlags)"

For all the recommended details to add when deprecating API (also with the new 
deprecation macros), please see
https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API

> statjob.h:239
>   short int details, JobFlags flags = 
> DefaultFlags);
>  
>  #if KIOCORE_ENABLE_DEPRECATED_SINCE(4, 0)

#endif

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D12283: Allow to load dictionaries form a rcc

[Ralf Habacker]

habacker added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  In D12283#249520 , @vonreth wrote:
  
  > While the disk use of the installation goes down the ram usage explodes as 
QResource doesn't use mmap 
https://github.com/qt/qtbase/blob/a37dd93defd91b79fb6730d0ff0515a66a0d3972/src/corelib/io/qresource.cpp#L1037
  
  
  Would adding a mmap implementation on Windows like 
https://github.com/witwall/mman-win32 be an option  ?

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12283

To: vonreth, mlaurent
Cc: kde-frameworks-devel, habacker, LeGast00n, GB_2, michaelh, ngraham, bruns, 
#frameworks

D24736: Grab the keyboard when KeySequenceItem is recording

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:7ede04501eda: Grab the keyboard when KeySequenceItem is 
recording (authored by davidre).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24736?vs=68144=68960

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre, #frameworks, davidedmundson, apol
Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25041: Ensure that the changedEntries property is correctly propagated

[Dan Leinir Turthra Jensen]

leinir added reviewers: Frameworks, KNewStuff, apol, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25041

To: leinir, #frameworks, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25041: Ensure that the changedEntries property is correctly propagated

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Without this change, for some reason unknown to me, the alias
  seems to fail quietly (that is, you can still read the property,
  but it does not forward the changed signal).
  
  This was discovered during the course of reviewing D24942 
.
  
  Expose the amount of changed entries
  
  Since changedEntries is only a forwarding type, and not a true list
  in the QML sense, there's no good way to get the number of entries
  (without for e.g. changing changedEntries to a model, which just
  seems like overkill)

REPOSITORY
  R304 KNewStuff

BRANCH
  ensure-changedentries-is-forwarded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25041

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25039: Fix Clazy performance issues, const &, noexcept

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  - Fix a lot of missing const & or &, avoiding copying mostly QString.
  - Add noexept to KFileItem and UDSEntre Move and copy constructors.
  - Make an implicit conversion explicit

TEST PLAN
  ctest

REPOSITORY
  R241 KIO

BRANCH
  clazy-perf

REVISION DETAIL
  https://phabricator.kde.org/D25039

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/kcoredirlister.cpp
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/knewfilemenu.cpp
  src/gui/faviconrequestjob.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/help/kio_help.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookieserver.h
  src/ioslaves/trash/tests/testtrash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/kpac/script.cpp
  src/widgets/kdirmodel.cpp
  src/widgets/kfileitemactions.cpp
  src/widgets/kpropertiesdialog.cpp
  src/widgets/krun.cpp
  src/widgets/sslui.cpp

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[Ahmad Samir]

ahmadsamir added a comment.


  In D24951#554516 , @dfaure wrote:
  
  > A sort model allows to define any sorting criteria you want (see 
QSortFilterProxyModel::lessThan), so this is technically possible: the criteria 
would say "if A is a match and B isn't, then A  I'm not 100% sure that things jumping around while typing is a good idea 
though.
  
  
  In this case it would have to be "if A is shorter than B"; also this is a 
tree model, we want to sort based on the leaf nodes (.desktop Name=), but not 
on parent nodes (the category names), I am not sure that is 
possible/straightforward with that item model.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven added a comment.


  In D24962#555443 , @dfaure wrote:
  
  > Can't wait to get clang-format fully automated into the review workflow
  
  
  Such a time saver it would be.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68946.
meven marked 5 inline comments as done.
meven added a comment.


  Mostly formatting, change style to init m_ioworker and check it in worker()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68872=68946

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24982: Small improvements in some XML files

[Christoph Cullmann]

cullmann added a comment.


  Could we perhaps just do some minimal checking like "no dynamic stuff at all" 
=> turn off all captures?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24982

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann