D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

[Laurent Montel]

mlaurent added a comment.


  "Also QStringLiteral is missing on some strings." it can be fix in other 
patch.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

[Laurent Montel]

mlaurent updated this revision to Diff 72444.
mlaurent added a comment.


  use QLatin1Char('\n')

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26317?vs=72440=72444

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26317

AFFECTED FILES
  src/docbookl10nhelper.cpp

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

[Anthony Fieroni]

anthonyfieroni added a comment.


  Will be better if you use QLatin1Char('\n'), "\n" will call strlen on which 
is unneeded. Also QStringLiteral is missing on some strings.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n

REPOSITORY
  R269 BluezQt

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26320

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26319: Port endl to \n (QFile flushs data when deleted)

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n (endl is Qt:: namespaced in qt5.15)

REPOSITORY
  R289 KNotifications

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26319

AFFECTED FILES
  src/notifybylogfile.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26319: Port endl to \n (QFile flushs data when deleted)

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26319

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26318

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n

REPOSITORY
  R266 Breeze Icons

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26318

AFFECTED FILES
  autotests/scalabletest.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n

REPOSITORY
  R238 KDocTools

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26317

AFFECTED FILES
  src/docbookl10nhelper.cpp

To: mlaurent
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26313: Add application/vnd.apple.pkpass icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Nice work!
  
  Looks like the 64px version got a part of it knocked out of position:
  F7851485: Screenshot_20191230_204235.PNG 

  
  Once that's fixed, run it through an optimizer and copy these to the 
icons-dark folder.
  
  
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26313

To: broulik, #vdg, vkrause, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26313: Add application/vnd.apple.pkpass icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: VDG, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 397987

TEST PLAN
  My boarding passes have nice icons now :)
  
  Since pkpass can also be used for concert tickets and exhibition entrance 
passes, I felt adding an airplane was wrong. While I loved the QR code idea, it 
didn't really work out well at 16px size, neither did an Aztec code, so I chose 
to use a "wallet" (basically wallet-open, adjusted) icon instead.
  
  16
  F7851384: Screenshot_20191231_005159.png 

  22
  F7851385: Screenshot_20191231_005204.png 

  32
  F7851386: Screenshot_20191231_005210.png 

  48
  F7851387: Screenshot_20191231_005213.png 

  64
  F7851389: Screenshot_20191231_005217.png 

  (note I have high dpi, so the actual pixels are doubled)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26313

AFFECTED FILES
  icons/mimetypes/16/application-vnd.apple.pkpass.svg
  icons/mimetypes/22/application-vnd.apple.pkpass.svg
  icons/mimetypes/32/application-vnd.apple.pkpass.svg
  icons/mimetypes/64/application-vnd.apple.pkpass.svg

To: broulik, #vdg, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg added a dependent revision: D26311: Handle output logical size changes.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26308

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg added a dependent revision: D26309: feat: replace replication source 
with logical size API.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26308

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg added a comment.


  I thought about adding separate events/requests for an 
immutable`logical_size` just giving always back the current logical size of the 
output and `logical_size_override` always giving back the explicitly set 
logical size or an invalid size if none is set.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26308

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg added a comment.


  This is an alternative to D23619  with 
more patches to come as discussed with David back then.

INLINE COMMENTS

> outputdevice.h:98
>  };
> +
>  struct Mode {

rm

> outputdevice.xml:293
> +
> +
> +Returns the logical size in compositor space. This event is 
> always sent after

fix summary

> outputdevice.xml:296
> +the logical size is changed and can be triggered by explicit 
> logical size changes
> +in the configruation interface or implicitly through a scale or 
> mode change.
> +

spelling

> outputdevice_interface.h:86
>  };
> +
>  enum class ModeFlag {

rm

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26308

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  This adds protocol methods and API to query and set explicitly the logical 
size
  of an output where the logical size is defined as the internal representation
  of this output in the compositor space.

TEST PLAN
  Tested with output replications through KScreen.

REPOSITORY
  R127 KWayland

BRANCH
  replicaSize

REVISION DETAIL
  https://phabricator.kde.org/D26308

AFFECTED FILES
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26306: Define more documentation search paths (also custom)

[Luigi Toscano]

ltoscano added subscribers: asturmlechner, maximilianocuria, rikmills, arojas, 
rdieter, lbeltrame, cgiboudeaux.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26306

To: ltoscano
Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, 
asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26306: Define more documentation search paths (also custom)

[Luigi Toscano]

ltoscano created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  New search paths:
  
  - (GenericDataLocation)/help
  - a custom path (absolute path), which can be defined during compile time by 
setting KDOCTOOLS_CUSTOM_DOC_PATH
  
  Also, make sure that the first item looks into
  KDE_INSTALL_DOCSBUNDLEDIR anyway.
  
  The addition of /help (usually /usr/share/help) paves
  the way for using that directory as new default value for
  KDE_INSTALL_DOCSBUNDLEDIR.

TEST PLAN
  The test passes and the list of directories contains
  the expected entries.

REPOSITORY
  R238 KDocTools

BRANCH
  extra-doc-paths

REVISION DETAIL
  https://phabricator.kde.org/D26306

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/documentcustomdirtest.cpp
  autotests/documentdirstest.cpp
  config-kdoctools.h.cmake
  src/xslt.cpp

To: ltoscano
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava added a subscriber: bport.
tcanabrava added a comment.


  Not really as all the calls are the same, just split into classes and
  logical bits. I haven’t write a single line of logic.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

Re: D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

Not really as all the calls are the same, just split into classes and
logical bits. I haven’t write a single line of logic.

On Mon, 30 Dec 2019 at 19:00 Nathaniel Graham 
wrote:

> ngraham added a comment. View Revision
> 
>
> At this point, it seems more like a total rewrite than a refactor...
>
> *REPOSITORY*
> R237 KConfig
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D26202
>
> *To: *tcanabrava, Frameworks, ervin, bport
> *Cc: *ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
>

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26303

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl method for compiling against qt5.15

REPOSITORY
  R309 KService

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26303

AFFECTED FILES
  src/sycoca/vfolder_menu.cpp
  tests/pluginlocator/plugintest.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R298 KDesignerPlugin

REVISION DETAIL
  https://phabricator.kde.org/D26302

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl for compiling against qt5.15

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26302

AFFECTED FILES
  src/kgendesignerplugin.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl for compiling against qt5.15

REPOSITORY
  R294 KBookmarks

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26301

AFFECTED FILES
  src/kbookmarkimporter_ns.cpp
  src/kbookmarkimporter_opera.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D26301

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D26300

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n for compiling against qt5.15

REPOSITORY
  R301 KEmoticons

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26300

AFFECTED FILES
  src/providers/pidgin/pidgin_emoticons.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to Qt::endl in qt5.15

REPOSITORY
  R280 Prison

BRANCH
  compile_against_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26299

AFFECTED FILES
  src/tools/prison-datamatrix.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26299: endl is namespaced in qt5.15

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D26299

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

[Nicolas Fella]

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25702

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26006: Deprecate KPixmapProvider

[Nicolas Fella]

nicolasfella added a comment.


  Done in D25702 

REPOSITORY
  R284 KCompletion

BRANCH
  pmp

REVISION DETAIL
  https://phabricator.kde.org/D26006

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

[Nicolas Fella]

nicolasfella updated this revision to Diff 72414.
nicolasfella added a comment.


  - Update version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25702?vs=70795=72414

BRANCH
  arcpatch-D25702

REVISION DETAIL
  https://phabricator.kde.org/D25702

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/kurlpixmapprovider.cpp
  src/widgets/kurlpixmapprovider.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 244 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/244/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 30 Dec 2019 19:19:23 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella updated this revision to Diff 72413.
nicolasfella added a comment.


  - Fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=70804=72413

BRANCH
  arcpatch-D25705

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25705: Deprecate KIO::pixmapForUrl

[Nicolas Fella]

nicolasfella added a comment.


  In D25705#571458 , @apol wrote:
  
  > What do you mean by `Can easily be done otherwise.`?
  
  
  You can get an icon name for the icon with KIO::iconNameForUrl and then use 
QIcon API if you really need a pixmap

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25696: Remove dead code

[Nicolas Fella]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6281990dd4e9: Remove dead code (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25696?vs=70780=72412

REVISION DETAIL
  https://phabricator.kde.org/D25696

AFFECTED FILES
  src/widgets/ksslinfodialog.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26198: Deprecate KCModuleContainer

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:34686047d57c: Deprecate KCModuleContainer (authored by 
nicolasfella).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26198?vs=72121=72410

REVISION DETAIL
  https://phabricator.kde.org/D26198

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kcmodulecontainer.cpp
  src/kcmodulecontainer.h

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R270 KCodecs

BRANCH
  l-ununsed-bool (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26208

To: ahmadsamir, dfaure, ngraham
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25743: Expose IndexerState enum to QML

[Nathaniel Graham]

ngraham added a comment.


  Now this patch no longer applies cleanly after those changes; needs a rebase.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D26202: WIP: Refactor KConfigXT

[Nathaniel Graham]

ngraham added a comment.


  At this point, it seems more like a total rewrite than a refactor...

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26055: Enable wheel events on Slider {}

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:66122410a11d: Enable wheel events on Slider {} (authored 
by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26055?vs=71744=72405

REVISION DETAIL
  https://phabricator.kde.org/D26055

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Slider.qml
  tests/components/slider3.qml

To: apol, #plasma, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26245: Set SYSCONFDIR to /etc when CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr

[Piotr Wójcik]

pwojcik updated this revision to Diff 72404.
pwojcik added a comment.


  Corrected logic, so it is is in line with GNUInstallDirs. Explained in 
comment. Added tests.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26245?vs=72258=72404

REVISION DETAIL
  https://phabricator.kde.org/D26245

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake
  tests/CMakeLists.txt
  tests/KDEInstallDirsTest/vars_in_sync/CMakeLists.txt

To: pwojcik, kossebau, alexmerry
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:935e54ce1aad: [plasmashell] Update docs for 
panelTakesFocus to make it generic (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26175?vs=72043=72398

REVISION DETAIL
  https://phabricator.kde.org/D26175

AFFECTED FILES
  src/client/plasmashell.h
  src/client/protocols/plasma-shell.xml
  src/server/plasmashell_interface.h

To: davidedmundson, #kwin, romangg
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25965: [plasmashell] Add signal for panelTakesFocus changing

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c25377a48183: [plasmashell] Add signal for 
panelTakesFocus changing (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25965?vs=71472=72397

REVISION DETAIL
  https://phabricator.kde.org/D25965

AFFECTED FILES
  autotests/client/test_plasmashell.cpp
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/51/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 30 Dec 2019 16:35:17 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov added a dependent revision: D26244: Install all kcm plugins into kcms 
subdir.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26294

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov updated this revision to Diff 72393.
volkov added a comment.


  change branch

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26294?vs=72392=72393

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26294

AFFECTED FILES
  src/kcmoduleloader.cpp

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26294

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REPOSITORY
  R295 KCMUtils

BRANCH
  xxx

REVISION DETAIL
  https://phabricator.kde.org/D26294

AFFECTED FILES
  src/kcmoduleloader.cpp

To: volkov
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25743: Expose IndexerState enum to QML

[David Edmundson]

davidedmundson added a comment.


  > Thanks, now it compiles! I'm not sure it's working perfectly though. I 
updated D25447  to use this, but it's 
claiming that my indexer is suspended, while  balooctl status disagrees.
  
  There were several other problems with the QML plugin which I've hopefully 
fixed up separately.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/49/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 30 Dec 2019 15:45:25 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.66.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testXdgShellV6
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27288/32232)53%
(11008/20683)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12527/12598)50%
(6595/13085)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6332/7469)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7975/9509)64%
(2400/3771)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 30 Dec 2019 15:45:25 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D26292: [KSambaShare] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch().

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression-ksambashare (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26292

AFFECTED FILES
  src/core/ksambashare.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 243 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/243/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 30 Dec 2019 15:04:19 +
 Build duration:
9 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26265: Fix crash on non-unix based systems

[Shubham]

shubham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26265

To: shubham, ngraham, pino
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

[Méven Car]

meven added a comment.


  Seems fine to me, indeed this bool was never changed

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D26208

To: ahmadsamir, dfaure
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D26208

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added reviewers: dfaure, apol.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D26118

To: ahmadsamir, #frameworks, mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 30 Dec 2019 14:08:55 +
 Build duration:
2 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 30 Dec 2019 14:06:29 +
 Build duration:
1 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kfileplacesview.h:157
>  Q_PRIVATE_SLOT(d, void adaptItemSize())
> -Q_PRIVATE_SLOT(d, void _k_placeClicked(const QModelIndex &))
> +Q_PRIVATE_SLOT(d, void _k_placeClicked(const QModelIndex &)) // TODO 
> remove
>  Q_PRIVATE_SLOT(d, void _k_placeEntered(const QModelIndex &))

For KF6 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: meven, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:88e5a8c10c02: In qt5.15 endl is namespaced. But 
qCCritical already add a \n at the end so we… (authored by mlaurent).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26290?vs=72376=72378

REVISION DETAIL
  https://phabricator.kde.org/D26290

AFFECTED FILES
  src/platforms/xcb/kkeyserver.cpp

To: mlaurent, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  remove_endl_qCCritical (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26290

To: mlaurent, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 72377.
tcanabrava added a comment.


  - Reorganize code
  - Fix filename
  - Fix Static Methods
  - Fix name generation
  - Call forgotten function in the right place
  - Fix signal generation - remove stray bit of code

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=72371=72377

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Remove not necessary endl

REPOSITORY
  R278 KWindowSystem

BRANCH
  remove_endl_qCCritical (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26290

AFFECTED FILES
  src/platforms/xcb/kkeyserver.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26290: In qt5.15 endl is namespaced. But qCCritical already add a \n at the end so we can remove it

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D26290

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 72371.
tcanabrava added a comment.


  - Regression: Remove space from the autogen preamble
  - Whitespace regression
  - Fix hasNamespace: logic was inverted
  - Space issues and scope
  - Use whitespace() function to manage indentation level
  - Space fixes and minor nitpicks

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=72349=72371

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> kcolorschememanager.cpp:220
> +{
> +return createSchemeSelectionMenu(QIcon(),QString(), QString(), parent);
> +}

why not to use reasonable default values here like 
QIcon::fromTheme(QStringLiteral("preferences-desktop-color") and i18n("Color 
Scheme")? This function should be used then by all applications and this will 
help to get a more consistent behavior across the different applications.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D26285: [KuitFormatterPrivate] Start porting QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, ilic, dfaure, mlaurent, aacid.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Port toVisualText() and finalizeVisualText() to use QRegularExpression.
  Replace ENTITY_SUBRX macro with a QString.

TEST PLAN
  make && ctest

REPOSITORY
  R249 KI18n

BRANCH
  l-finalizeVisualText (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26285

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, ltoscano, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Dominik Haumann]

Hi,

Stephen Kelly  schrieb am So., 29. Dez. 2019, 15:03:

>
> On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote:
> > Why are you proposing to do a step back instead to the old state, which
> > everyone including you considered not that satisfying?
>
> Because it's a temporary situation. We still have a way forward in KF6
> (which will open in a few months).
>
>
> Generally, getting Grantlee into KF5 now also establishes the wrong
> precedent. Grantlee should be split into two repos each with a tier 1
> library (KF6::TextDocument and KF6::TextTemplate). The two are
> independent and have nothing to do with each other aside from
> authorship. That seems to be something you were objecting to, so I want
> to make sure that's something addressed on its own. The two KF6
> libraries will then follow the KF6 naming conventions etc.
>

With my KTextEditor hat on: KF6:TextDocument implies somehow a link to
QTextDocument or KF6:TextEditor, which both is incorrect, right?

Before starting this work, let's clarify whether we can find a more unique
name (like KF6:GrantleeTextDocument).

Since I haven't used Grantlee yet, I sm likely not the best person to find
a better name ;)

Best regards
Dominik

>

D26117: [solid] Clarify referencing of DeviceInterface

[Anthony Fieroni]

anthonyfieroni added a comment.


  I've using the patch till now with no issues.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26117

To: anthonyfieroni, broulik, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

[Robert Hoffmann]

hoffmannrobert added a comment.


  In D21563#584220 , @dhaumann wrote:
  
  > @hoffmannrobert: by the way, looking at your phabricator activity, you 
should get a KDE contributor account, if you don't have one already.
  
  
  I applied for one and added you as a supporter, thanks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert, #kate, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, 
GB_2, domson, michaelh, bruns, demsking, sars

D21563: Fix empty pages in print preview and lines printed twice

[Robert Hoffmann]

hoffmannrobert added a comment.


  In D21563#584218 , @dhaumann wrote:
  
  > @hoffmannrobert: Are you maybe also interested in looking into 
https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this 
time about the very last line that seems to be wrong...
  
  
  Yes, I can reproduce the bug. I'll look into it in about two weeks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert, #kate, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, 
GB_2, domson, michaelh, bruns, demsking, sars