D26600: Refator fstab handling

[David Hallas]

hallas added a comment.


  @meven - I am a little unsure if I have broken the fix you have done in 
commit c97f0b2a3076731b35435f200bd09a22859f3e03 
 - 
could you please check?
  
  I have not tested with NFS or SMB mounts.
  
  Finally, I think this code could be moved to a more general library in KDE 
Frameworks, because it appears that we have this functionality in multiple 
places. We have at least a partial copy of this in 
solid/src/solid/devices/backends/hal and probably also other places.

INLINE COMMENTS

> call_system_command.cpp:1
> +/***
> + *   Copyright (C) 2019 by David Hallas  *

I think the Copyright notice needs to include the original authors of this 
function

> filesystem_table_parser.cpp:2
> +/***
> + *   Copyright (C) 2019 by David Hallas  *
> + * *

I think the Copyright notice needs to include the original authors of this 
function

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26600

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26600: Refator fstab handling

[David Hallas]

hallas created this revision.
hallas added reviewers: Frameworks, bruns, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Refactor fstab handling
  
  Splits the fstab/mtab handling code into smaller pieces and allow unit
  testing of each one. The reafacting allows us to use the various classes
  individually, e.g. use the FilesystemTableParser for parsing any
  fstab/mtab style file.
  
  This refactoring is a prerequisite for adding proper support for
  fuseiso, since fuseiso maintains it's own mtab file, which we would like
  to parse and use.

TEST PLAN
  Unit tests
  Tested manually with Plasma Vaults

REPOSITORY
  R245 Solid

BRANCH
  fstabhandling_rewrite

REVISION DETAIL
  https://phabricator.kde.org/D26600

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/filesystem_entry_test.cpp
  autotests/filesystem_entry_test.h
  autotests/filesystem_table_parser_test.cpp
  autotests/filesystem_table_parser_test.h
  autotests/system_filesystem_table_test.cpp
  autotests/system_filesystem_table_test.h
  src/solid/devices/backends/fstab/CMakeLists.txt
  src/solid/devices/backends/fstab/call_system_command.cpp
  src/solid/devices/backends/fstab/call_system_command.h
  src/solid/devices/backends/fstab/filesystem_entry.cpp
  src/solid/devices/backends/fstab/filesystem_entry.h
  src/solid/devices/backends/fstab/filesystem_table_parser.cpp
  src/solid/devices/backends/fstab/filesystem_table_parser.h
  src/solid/devices/backends/fstab/filesystem_table_watcher.cpp
  src/solid/devices/backends/fstab/filesystem_table_watcher.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h
  src/solid/devices/backends/fstab/fstabmanager.cpp
  src/solid/devices/backends/fstab/fstabmanager.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h
  src/solid/devices/backends/fstab/fstabwatcher.cpp
  src/solid/devices/backends/fstab/fstabwatcher.h
  src/solid/devices/backends/fstab/system_filesystem_table.cpp
  src/solid/devices/backends/fstab/system_filesystem_table.h

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> containmentactions.h:67
>  
> +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 64)
>  /**

The visibility wrappers also need bumping to 5, 67, so the version were the API 
got deprecated, to not break things for people who use 
*_DISABLE_DEPRECATED_BEFORE_AND_AT with 5.64-5.66 and who still use this API.

Will fix directly now. just mentioning here as reminder for future similar 
deprecation patches.

And yes, this data duplication sucks, but no-one found a way around yet for 
this macro magic to have the features of control both about visibility and 
warnings separately.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26595: Add network-wireless-hotspot icon

[Nathaniel Graham]

ngraham added a comment.


  Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:
  
  F7878586: Screenshot_20200111_220052.png 

  
  For the 16 and 22px versions, maybe reduce the number of waves and increase 
the spacing between them. And do we even need an 8px version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22875: Offer toolTipDelay as a plasma unit

[Aleix Pol Gonzalez]

apol abandoned this revision.
apol added a comment.


  This was eventually fixed in a different way

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22875

To: apol, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23586: Improve code that detects useful elements in an Svg file

[Aleix Pol Gonzalez]

apol updated this revision to Diff 73324.
apol added a comment.


  address fregl's commetn

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23586?vs=65005=73324

BRANCH
  arcpatch-D23586

REVISION DETAIL
  https://phabricator.kde.org/D23586

AFFECTED FILES
  src/plasma/svg.cpp

To: apol, #plasma, #frameworks
Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23586: Improve code that detects useful elements in an Svg file

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23586

To: apol, #plasma, #frameworks
Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:591aceb3f926: Make use of KPluginMetaData where we can 
(authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23682?vs=73322=73323

REVISION DETAIL
  https://phabricator.kde.org/D23682

AFFECTED FILES
  src/plasma/CMakeLists.txt
  src/plasma/containment.cpp
  src/plasma/containmentactions.cpp
  src/plasma/containmentactions.h
  src/plasma/dataengine.cpp
  src/plasma/dataengine.h
  src/plasma/private/dataengine_p.h
  src/plasma/private/storage.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/scripting/dataenginescript.cpp
  src/plasma/scripting/dataenginescript.h
  src/plasma/theme.cpp
  src/plasma/theme.h

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

apol updated this revision to Diff 73322.
apol added a comment.


  Addressed kossebau's comments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23682?vs=68546=73322

BRANCH
  arcpatch-D23682

REVISION DETAIL
  https://phabricator.kde.org/D23682

AFFECTED FILES
  src/plasma/CMakeLists.txt
  src/plasma/containment.cpp
  src/plasma/containmentactions.cpp
  src/plasma/containmentactions.h
  src/plasma/dataengine.cpp
  src/plasma/dataengine.h
  src/plasma/private/dataengine_p.h
  src/plasma/private/storage.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/scripting/dataenginescript.cpp
  src/plasma/scripting/dataenginescript.h
  src/plasma/theme.cpp
  src/plasma/theme.h

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

apol marked 8 inline comments as done.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26596: Drop unused dependency

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:08b1eabe3f54: Drop unused dependency (authored by 
asturmlechner).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26596?vs=73318=73320

REVISION DETAIL
  https://phabricator.kde.org/D26596

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

[Andreas Sturmlechner]

asturmlechner closed this revision.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D26597

To: asturmlechner, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R252 Framework Integration

BRANCH
  no-have-x11

REVISION DETAIL
  https://phabricator.kde.org/D26597

To: asturmlechner, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R252 Framework Integration

BRANCH
  unused-deps

REVISION DETAIL
  https://phabricator.kde.org/D26596

To: asturmlechner, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26596: Drop unused dependency

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  unused-deps

REVISION DETAIL
  https://phabricator.kde.org/D26596

AFFECTED FILES
  CMakeLists.txt

To: asturmlechner
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26597: Drop HAVE_X11 remnants

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  no-have-x11

REVISION DETAIL
  https://phabricator.kde.org/D26597

AFFECTED FILES
  src/kstyle/CMakeLists.txt
  src/kstyle/config-kstyle.h.cmake
  src/kstyle/kstyle.cpp

To: asturmlechner
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/28/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 11 Jan 2020 20:05:44 +
 Build duration:
4 hr 11 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D26594: Deprecate raiseWidget

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:b5ba64a0545d: Deprecate raiseWidget (authored by 
nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26594?vs=73314=73317

REVISION DETAIL
  https://phabricator.kde.org/D26594

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotification.h

To: nicolasfella, #frameworks, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26594: Deprecate raiseWidget

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  raise

REVISION DETAIL
  https://phabricator.kde.org/D26594

To: nicolasfella, #frameworks, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26588: Simplify usage of QMimeDatabase.

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26588

To: dfaure, chinmoyr, ngraham, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

[Carson Black]

cblack edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

[Carson Black]

cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  hotspot-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26595

AFFECTED FILES
  icons-dark/devices/16/network-wireless-hotspot.svg
  icons-dark/devices/22/network-wireless-hotspot.svg
  icons-dark/devices/32/network-wireless-hotspot.svg
  icons-dark/devices/8/network-wireless-hotspot.svg
  icons/devices/16/network-wireless-hotspot.svg
  icons/devices/22/network-wireless-hotspot.svg
  icons/devices/32/network-wireless-hotspot.svg
  icons/devices/8/network-wireless-hotspot.svg

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26594: Deprecate raiseWidget

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It is unused. Furthermore, it relies on QtWidgets API which we try to get rid 
of in KNotifications. I assume the intention of this method was to raise the 
window when the notification is clicked, but this should be done by settng a 
default action and using appropriate QWindow API.

REPOSITORY
  R289 KNotifications

BRANCH
  raise

REVISION DETAIL
  https://phabricator.kde.org/D26594

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotification.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26588: Simplify usage of QMimeDatabase.

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26588

To: dfaure, chinmoyr, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava added a comment.


  Looking at the review you it's a bis strange to see that I'v touched some 
test reference generated code, I did this only on *whitespace only changes* 
where the new whitespace made more sense than the old one.
  there is *one* bug I havent fixed on this code that I plan to fix tomorrow, 
as it's almost 9:45 and it's saturday. I believe that this code is getting near 
review quality.
  I'v also rebased against master as some other people also started to change 
this code - I already got a few conflicts, so I really need to rush this before 
it gets unmergeable.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73310.
tcanabrava added a comment.


  - Fix whitespace on the reference code / genreator

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73301=73310

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26191: Add support for FileJob->truncate() in smb/sftp slaves

[Alexander Saoutkin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:3bb841890e5a: Add support for FileJob-truncate() in 
smb/sftp slaves (authored by feverfew).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26191?vs=73308=73309

REVISION DETAIL
  https://phabricator.kde.org/D26191

AFFECTED FILES
  CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h
  sftp/sftp.protocol
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_file.cpp
  smb/smb.json

To: feverfew, sitter, dfaure, fvogt
Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D26191: Add support for FileJob->truncate() in smb/sftp slaves

[Alexander Saoutkin]

feverfew updated this revision to Diff 73308.
feverfew added a comment.


  - Merge branch 'master' into arcpatch-D26191
  - adhere to protcol -> json switch

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26191?vs=73306=73308

BRANCH
  arcpatch-D26191

REVISION DETAIL
  https://phabricator.kde.org/D26191

AFFECTED FILES
  CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h
  sftp/sftp.protocol
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_file.cpp
  smb/smb.json

To: feverfew, sitter, dfaure, fvogt
Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D26191: Add support for FileJob->truncate() in smb/sftp slaves

[Alexander Saoutkin]

feverfew updated this revision to Diff 73306.
feverfew added a comment.


  Cleanup code according to comments

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26191?vs=72584=73306

BRANCH
  arcpatch-D26191

REVISION DETAIL
  https://phabricator.kde.org/D26191

AFFECTED FILES
  CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h
  sftp/sftp.protocol
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_file.cpp
  smb/smb.protocol

To: feverfew, sitter, dfaure, fvogt
Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.13 - Build # 42 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.13/42/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 11 Jan 2020 18:02:01 +
 Build duration:
3 hr 21 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I agree with the approach. Just naming needs to be improved.
  
  I'd call the method "showMenu" or "showPopup".
  DelayPopup hints at a builtin timer, better call it something like 
DontShowPopup (even though some people don't like negative flags). 
ManualShowPopup? ExplicitShowPopup?
  And it shouldn't be in the job_base.h enum, which can be used by all jobs.
  Better add something to DropJob specifically.
  
  The new method also needs docu including @since.
  
  Thanks!

INLINE COMMENTS

> dropjob.cpp:416
> +
> +void DropJob::menuPopup(const QPoint , QAction *atAction) {
> +Q_D(DropJob);

This '{' goes on its own line.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73301.
tcanabrava added a comment.


  - More whiteespaces fixed
  - Fix *space only* issues with the  test reference headers
  - More whitespace fixes, only six files to go
  - Way more tests passing - space fixes

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73292=73301

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26057: Deprecate the top-level IconSize() function

[David Faure]

dfaure added a comment.


  Please port kdeclarative.
  
  kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not 
declared in this scope
  
pixmap = 
QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop));
  
  Detected by http://www.davidfaure.fr/2020/542.diff (to be applied to 
kdeclarative)
  
  Thanks.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause, apol
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/27/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 11 Jan 2020 17:59:30 +
 Build duration:
2 hr 2 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘WindowsMSVCQt5.13’Running on Windows Builder 2 in C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] bat[2020-01-11T20:01:38.582Z] [2020-01-11T20:01:38.583Z] C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13>if exist "C:\CI\Software Installs\kholidays" rmdir /s /q "C:\CI\Software Installs\kholidays" [Pipeline] checkout[2020-01-11T20:01:38.724Z] No credentials specified[2020-01-11T20:01:38.731Z] Cloning the remote Git repository[2020-01-12T05:01:39.706Z] Cloning repository git://anongit.kde.org/kholidays[2020-01-12T05:01:39.707Z]  > git init C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13 # timeout=10[2020-01-12T05:01:51.852Z] Fetching upstream changes from git://anongit.kde.org/kholidays[2020-01-12T05:01:51.852Z]  > git --version # timeout=10[2020-01-12T05:01:51.930Z]  > git fetch --tags --progress -- git://anongit.kde.org/kholidays +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-11T20:02:14.583Z] ERROR: Error fetching remote repo 'origin'[2020-01-11T20:02:14.583Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kholidays[2020-01-11T20:02:14.583Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-11T20:02:14.583Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-11T20:02:14.583Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-11T20:02:14.583Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-11T20:02:14.583Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress -- git://anongit.kde.org/kholidays +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-11T20:02:14.583Z] stdout: [2020-01-11T20:02:14.583Z] stderr: fatal: read error: Invalid argument[2020-01-11T20:02:14.583Z] [2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-11T20:02:14.583Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-11T20:02:14.583Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)[2020-01-11T20:02:14.583Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-11T20:02:14.583Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-11T20:02:14.583Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.FutureTask.run(Unknown Source)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)[2020-01-11T20:02:14.583Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)[2020-01-11T20:02:14.583Z] 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)[2020-01-11T20:02:14.583Z] 	at java.lang.Thread.run(Unknown Source)[2020-01-11T20:02:14.583Z] 	Suppressed: 

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 53 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/53/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 11 Jan 2020 19:28:09 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/76/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 19:28:08 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 19:28:07 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 19:28:05 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 270 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/270/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 11 Jan 2020 18:00:15 +
 Build duration:
1 hr 47 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.67.0.xmllogs/KF5KIO/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34762/62007)40%
(17666/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10144)47%
(4508/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8699/14613)51%
(4527/8855)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4685/8323)43%
(2070/4802)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 52 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/52/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 11 Jan 2020 18:03:37 +
 Build duration:
1 hr 44 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.67.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27279/32234)53%
(10998/20683)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12510/12598)50%
(6581/13085)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6339/7471)65%
(1838/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7976/9509)64%
(2402/3771)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 54 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/54/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 11 Jan 2020 18:03:55 +
 Build duration:
1 hr 43 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.67.0.xmllogs/KF5WindowSystem/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowsystem_threadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7258/9613)55%
(3524/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3068/3162)52%
(1285/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3363/4719)60%
(1935/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/140/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 19:28:04 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

D26588: Simplify usage of QMimeDatabase.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  suffixForFileName is case insensitive, no need to lowercase the path.
  
  Also no need to call toDisplayString, only the path matters.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26588

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: dfaure, chinmoyr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73292.
tcanabrava added a comment.


  - Fix many small whitespace issues

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73290=73292

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/95/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 11 Jan 2020 17:57:39 +
 Build duration:
1 hr 17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.67.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6896/9077)43%
(10753/24757)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2893/2985)49%
(6176/12687)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/798)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(422/827)47%
(988/2121)src.lib.util100%
(15/15)100%
(15/15)83%
(986/1183)51%
(1006/1989)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/55/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:05:25 +
 Build duration:
1 hr 3 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/139/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:04:50 +
 Build duration:
1 hr 0 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Running on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-11T19:04:50.289Z] No credentials specified[2020-01-11T19:04:50.314Z] Cloning the remote Git repository[2020-01-11T19:04:50.451Z] ERROR: Error cloning remote repo 'origin'[2020-01-11T19:04:50.451Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/plasma-framework +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-11T19:04:50.451Z] stdout: [2020-01-11T19:04:50.451Z] stderr: fatal: Could not read from remote repository.[2020-01-11T19:04:50.451Z] [2020-01-11T19:04:50.451Z] Please make sure you have the correct access rights[2020-01-11T19:04:50.451Z] and the repository exists.[2020-01-11T19:04:50.451Z] [2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-11T19:04:50.451Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-11T19:04:50.451Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-11T19:04:50.451Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-11T19:04:50.451Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-11T19:04:50.451Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-11T19:04:50.451Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-11T19:04:50.451Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-11T19:04:50.451Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-11T19:04:50.451Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-11T19:04:50.451Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1[2020-01-11T19:04:50.451Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2020-01-11T19:04:50.451Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-11T19:04:50.451Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2020-01-11T19:04:50.451Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-11T19:04:50.451Z] 		at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source)[2020-01-11T19:04:50.451Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-11T19:04:50.451Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-11T19:04:50.451Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-11T19:04:50.451Z] 		at com.sun.proxy.$Proxy80.execute(Unknown Source)[2020-01-11T19:04:50.451Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-11T19:04:50.451Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-11T19:04:50.451Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-11T19:04:50.451Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-11T19:04:50.451Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-11T19:04:50.451Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-11T19:04:50.451Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-11T19:04:50.451Z] 		... 4 more[Pipeline] }[Pipeline] // 

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 52 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/52/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 11 Jan 2020 17:55:58 +
 Build duration:
1 hr 9 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘SUSEQt5.13’Running on Docker Swarm-659fe221e177 in /home/jenkins/workspace/Frameworks/extra-cmake-modules/kf5-qt5 SUSEQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2020-01-11T19:05:00.488Z] No credentials specified[2020-01-11T19:05:00.502Z] Cloning the remote Git repository[2020-01-11T19:05:00.538Z] Cloning repository git://anongit.kde.org/extra-cmake-modules[2020-01-11T19:05:00.565Z]  > git init /home/jenkins/workspace/Frameworks/extra-cmake-modules/kf5-qt5 SUSEQt5.13 # timeout=10[2020-01-11T19:05:00.609Z] Fetching upstream changes from git://anongit.kde.org/extra-cmake-modules[2020-01-11T19:05:00.609Z]  > git --version # timeout=10[2020-01-11T19:05:00.626Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/extra-cmake-modules +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-11T19:05:00.685Z] ERROR: Error cloning remote repo 'origin'[2020-01-11T19:05:00.685Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/extra-cmake-modules +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-11T19:05:00.685Z] stdout: [2020-01-11T19:05:00.685Z] stderr: fatal: Could not read from remote repository.[2020-01-11T19:05:00.685Z] [2020-01-11T19:05:00.685Z] Please make sure you have the correct access rights[2020-01-11T19:05:00.685Z] and the repository exists.[2020-01-11T19:05:00.685Z] [2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-11T19:05:00.685Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-11T19:05:00.685Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-11T19:05:00.685Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-11T19:05:00.685Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-11T19:05:00.685Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-11T19:05:00.685Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-11T19:05:00.685Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-11T19:05:00.685Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-11T19:05:00.685Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-11T19:05:00.685Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-659fe221e177[2020-01-11T19:05:00.685Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2020-01-11T19:05:00.685Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-11T19:05:00.685Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2020-01-11T19:05:00.685Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-11T19:05:00.685Z] 		at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source)[2020-01-11T19:05:00.685Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-11T19:05:00.685Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-11T19:05:00.685Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-11T19:05:00.685Z] 		at com.sun.proxy.$Proxy80.execute(Unknown Source)[2020-01-11T19:05:00.685Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-11T19:05:00.685Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-11T19:05:00.685Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-11T19:05:00.685Z] 		at 

KDE CI: Frameworks » kxmlrpcclient » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlrpcclient/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:04:09 +
 Build duration:
1 hr 0 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Running on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Frameworks/kxmlrpcclient/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-11T19:04:40.313Z] No credentials specified[2020-01-11T19:04:40.316Z] Cloning the remote Git repository[2020-01-11T19:04:40.375Z] ERROR: Error cloning remote repo 'origin'[2020-01-11T19:04:40.376Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kxmlrpcclient +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-11T19:04:40.376Z] stdout: [2020-01-11T19:04:40.376Z] stderr: fatal: read error: Connection reset by peer[2020-01-11T19:04:40.376Z] [2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-11T19:04:40.376Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-11T19:04:40.376Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-11T19:04:40.376Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-11T19:04:40.376Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-11T19:04:40.376Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-11T19:04:40.376Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-11T19:04:40.376Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-11T19:04:40.376Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-11T19:04:40.376Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-11T19:04:40.376Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1[2020-01-11T19:04:40.376Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2020-01-11T19:04:40.376Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-11T19:04:40.376Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2020-01-11T19:04:40.376Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-11T19:04:40.376Z] 		at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source)[2020-01-11T19:04:40.376Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-11T19:04:40.376Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-11T19:04:40.376Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-11T19:04:40.376Z] 		at com.sun.proxy.$Proxy80.execute(Unknown Source)[2020-01-11T19:04:40.376Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-11T19:04:40.376Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-11T19:04:40.376Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-11T19:04:40.376Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-11T19:04:40.376Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-11T19:04:40.376Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-11T19:04:40.376Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-11T19:04:40.376Z] 		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }[2020-01-11T19:04:41.045Z] ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[2020-01-11T18:48:05.674Z] Cloning 

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:04:34 +
 Build duration:
1 hr 0 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Running on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Frameworks/oxygen-icons5/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-11T19:04:44.641Z] No credentials specified[2020-01-11T19:04:44.663Z] Cloning the remote Git repository[2020-01-11T19:04:44.925Z] ERROR: Error cloning remote repo 'origin'[2020-01-11T19:04:44.925Z] hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/oxygen-icons5 +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-11T19:04:44.925Z] stdout: [2020-01-11T19:04:44.925Z] stderr: fatal: read error: Connection reset by peer[2020-01-11T19:04:44.925Z] [2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:787)[2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-11T19:04:44.925Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-11T19:04:44.925Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-11T19:04:44.925Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-11T19:04:44.925Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-11T19:04:44.925Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-11T19:04:44.925Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-11T19:04:44.925Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-11T19:04:44.925Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-11T19:04:44.925Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-11T19:04:44.925Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1[2020-01-11T19:04:44.925Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2020-01-11T19:04:44.925Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-11T19:04:44.925Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2020-01-11T19:04:44.925Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-11T19:04:44.925Z] 		at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source)[2020-01-11T19:04:44.925Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2020-01-11T19:04:44.925Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2020-01-11T19:04:44.925Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2020-01-11T19:04:44.925Z] 		at com.sun.proxy.$Proxy80.execute(Unknown Source)[2020-01-11T19:04:44.925Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1105)[2020-01-11T19:04:44.925Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-11T19:04:44.925Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-11T19:04:44.925Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-11T19:04:44.925Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-11T19:04:44.925Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-11T19:04:44.925Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-11T19:04:44.925Z] 		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }[2020-01-11T19:04:45.418Z] ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[2020-01-11T18:48:10.046Z] Cloning repository 

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:04:02 +
 Build duration:
1 hr 0 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.13’Running on FreeBSD Builder 1 in /usr/home/jenkins/workspace/Frameworks/kxmlgui/kf5-qt5 FreeBSDQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkout[2020-01-11T19:03:54.887Z] No credentials specified[2020-01-11T19:03:54.911Z] Cloning the remote Git repository[2020-01-11T18:47:20.277Z] Cloning repository git://anongit.kde.org/kxmlgui[2020-01-11T18:47:20.277Z]  > git init /usr/home/jenkins/workspace/Frameworks/kxmlgui/kf5-qt5 FreeBSDQt5.13 # timeout=10[2020-01-11T18:47:20.322Z] Fetching upstream changes from git://anongit.kde.org/kxmlgui[2020-01-11T18:47:20.322Z]  > git --version # timeout=10[2020-01-11T18:47:20.393Z]  > git fetch --tags --force --progress -- git://anongit.kde.org/kxmlgui +refs/heads/*:refs/remotes/origin/* # timeout=120[2020-01-11T19:04:34.478Z] ERROR: Error fetching remote repo 'origin'[2020-01-11T19:04:34.478Z] hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kxmlgui[2020-01-11T19:04:34.478Z] 	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:899)[2020-01-11T19:04:34.478Z] 	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1114)[2020-01-11T19:04:34.478Z] 	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1145)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2020-01-11T19:04:34.478Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2020-01-11T19:04:34.478Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2020-01-11T19:04:34.478Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2020-01-11T19:04:34.478Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2020-01-11T19:04:34.478Z] 	at java.lang.Thread.run(Thread.java:748)[2020-01-11T19:04:34.478Z] Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git://anongit.kde.org/kxmlgui +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2020-01-11T19:04:34.478Z] stdout: [2020-01-11T19:04:34.478Z] stderr: fatal: read error: Connection reset by peer[2020-01-11T19:04:34.478Z] [2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2372)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1985)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:80)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:563)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2020-01-11T19:04:34.478Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2020-01-11T19:04:34.478Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2020-01-11T19:04:34.478Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2020-01-11T19:04:34.478Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2020-01-11T19:04:34.478Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)[2020-01-11T19:04:34.478Z] 	... 4 more[2020-01-11T19:04:34.478Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 1[2020-01-11T19:04:34.478Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2020-01-11T19:04:34.478Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2020-01-11T19:04:34.478Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2020-01-11T19:04:34.478Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2020-01-11T19:04:34.478Z] 		at sun.reflect.GeneratedMethodAccessor234.invoke(Unknown Source)[2020-01-11T19:04:34.478Z] 		at 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 161 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/161/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Jan 2020 18:05:04 +
 Build duration:
58 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.67.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(453/2037)18%
(172/939)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)98%
(143/146)59%
(54/92)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/154)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/164/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:03:02 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/46/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:03:37 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 262 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/262/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:00:15 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/43/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sat, 11 Jan 2020 17:56:48 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:02:27 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 18:01:50 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/55/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 17:58:14 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/34/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 17:58:29 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/67/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 17:57:59 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/90/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 17:57:39 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/47/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 11 Jan 2020 17:56:50 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/87/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 11 Jan 2020 17:55:58 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D24401: Use exposed DBus methods to switch activities in CLI

[Christian Muehlhaeuser]

muesli added a comment.


  @ivan Do you think we can merge this now?

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D24401

To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73290.
tcanabrava added a comment.


  - Rebase on master

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=72715=73290

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Abandoned in favor of D26407  using 
KMountPoint which does close to the same thing as solid.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: bruns, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven updated this revision to Diff 73282.
meven marked 2 inline comments as done.
meven added a comment.


  Move static variables to KFileItemPrivate::getMountPoints

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=73261=73282

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

[Tranter Madi]

trmdi marked 5 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

[Tranter Madi]

trmdi retitled this revision from "Popup menu again to reposition it" to "Add 
KIO::DelayPopup flag and DropJob::menuPopup()".
trmdi edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26484: Popup menu again to reposition it

[Tranter Madi]

trmdi updated this revision to Diff 73273.
trmdi added a comment.


  - use the flag approach and add DropJob::menuPopup()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26484?vs=73175=73273

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26484

AFFECTED FILES
  src/core/job_base.h
  src/widgets/dropjob.cpp
  src/widgets/dropjob.h

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26484: Popup menu again to reposition it

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dropjob.cpp:415
> `QCursor::pos()` should be avoided as it's not reliable on wayland.
> 
> The whole "popup() again" here looks like a workaround to me. Can't this be 
> fixed on the plasma side?

> Can't this be fixed on the plasma side?

I think it can't, because KIO::DropJob popup the menu, only afterward Plasma 
adds new items into it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26484: Popup menu again to reposition it

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dropjob.cpp:415
> `QCursor::pos()` should be avoided as it's not reliable on wayland.
> 
> The whole "popup() again" here looks like a workaround to me. Can't this be 
> fixed on the plasma side?

I'm having a plan to make it popup only one time.

> QCursor::pos() should be avoided as it's not reliable on wayland.

this is how it does currently, I just copy the original code. This could need 
to be resolved in another patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26484: Popup menu again to reposition it

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dropjob.cpp:415
> +// popup again to update position. BUG: 415917
> +menu->popup(window ? window->mapToGlobal(m_relativePos) : 
> QCursor::pos());
>  }

`QCursor::pos()` should be avoided as it's not reliable on wayland.

The whole "popup() again" here looks like a workaround to me. Can't this be 
fixed on the plasma side?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:6f08f7ae576a: KMainWindow: fix autoSaveSettings to catch 
QDockWidgets being shown again (authored by kossebau).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26501?vs=73004=73265

REVISION DETAIL
  https://phabricator.kde.org/D26501

AFFECTED FILES
  src/kmainwindow.cpp

To: kossebau, #frameworks, #kdevelop, dfaure
Cc: SGOrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Popup menu again to reposition it

[Tranter Madi]

trmdi added a comment.


  In D26484#591782 , @dfaure wrote:
  
  > Sorry I have no idea about the calling side in plasma. It sounds buggy 
indeed, if those are all calls on the same DropJob instance.
  
  
  Yes, you could check it here: 
https://phabricator.kde.org/source/plasma-framework/browse/master/src/scriptengines/qml/plasmoid/containmentinterface.cpp
  So do you mean this should be fixed to call 
`DropJob::setApplicationActions()` only one time?
  
  And do you @mart agree with that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven retitled this revision from "KFileItem: Improve isSlow to not block when 
a network mount is unresponsive, make SkipMimeTypeFromContent skip only on 
network fs" to "KFileItem: Improve isSlow to not block when a network mount is 
unresponsive, make SkipMimeTypeFromContent skip only on slow fs".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26532: Don't use KWindowSystem on Android

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  I agree with the reasoning, we can break BC on Android.

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause, apol, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

[Méven Car]

meven updated this revision to Diff 73261.
meven added a comment.


  remove a commo in comment, fix @since version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=73260=73261

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

[Méven Car]

meven updated this revision to Diff 73260.
meven marked an inline comment as done.
meven added a comment.


  And KMountPoint::List::findByPathDirectly to check mount point without 
resolving symlinks

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=72738=73260

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26159: Drop KWindowSystem dependency

[David Edmundson]

davidedmundson added a comment.


  There's a big difference between "I want to raise my window" and I "I want to 
raise $random window".
  
  We don't need to use this kwindowsystem api for the former, but kwin and 
plasma's task manager still need to use the latter.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26159

To: davidedmundson, apol
Cc: dfaure, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[David Faure]

dfaure added a comment.


  Right, from a performance point of view, I believe this code was flushing far 
too much. In fact even now those calls to flush() are all unnecessary. Just one 
flush before closing the file is enough to be sure, or even without it, it will 
work (socket notifier says closed => stream flushes)

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26487: [Kuit] Revert changes in parseUiMarker()

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:fff18126b973: [Kuit] Revert changes in parseUiMarker() 
(authored by ahmadsamir).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26487?vs=72955=73251

REVISION DETAIL
  https://phabricator.kde.org/D26487

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26159: Drop KWindowSystem dependency

[David Faure]

dfaure added a comment.


  Why isn't KWindowSystem::activateWindow deprecated then? Because of the 
`time` argument?

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26159

To: davidedmundson, apol
Cc: dfaure, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  catchdockwidgetsshowninstate

REVISION DETAIL
  https://phabricator.kde.org/D26501

To: kossebau, #frameworks, #kdevelop, dfaure
Cc: SGOrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Popup menu again to reposition it

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry I have no idea about the calling side in plasma. It sounds buggy 
indeed, if those are all calls on the same DropJob instance.

INLINE COMMENTS

> dropjob.cpp:409
>  d->m_appActions = actions;
> +auto m_relativePos = d->m_relativePos;
> +auto window = KJobWidgets::window(this);

The m_ prefix is for member variables. Don't use it for a local stack variable.

> dropjob.cpp:414
>  menu->addExtraActions(d->m_appActions, d->m_pluginActions);
> +// popup again to update position. BUG: 415917
> +menu->popup(window ? window->mapToGlobal(m_relativePos) : 
> QCursor::pos());

Doesn't this flicker?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26487: [Kuit] Revert changes in parseUiMarker()

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  l-parseMarkup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26487

To: ahmadsamir, #frameworks, ilic, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krecentfilesmenu.cpp:99
> +setIcon(QIcon::fromTheme(QStringLiteral("document-open-recent")));
> +const QString fileName = 
> QStringLiteral("%1/%2recentfiles").arg(QStandardPaths::writableLocation(QStandardPaths::AppDataLocation),
>  QCoreApplication::applicationName());
> +d->m_settings = new QSettings(fileName, QSettings::Format::IniFormat, 
> this);

maybe %2_recentfiles to improve readability?

> krecentfilesmenu.cpp:189
> +delete *it;
> +d->m_entries.erase(it);
> +rebuildMenu();

How does this work, given that `it` is a const_iterator?
I smell compilation errors on some compilers/OS/debug-or-release mode.

findEntry is only used for add/remove, I guess it shouldn't return a 
const_iterator but an iterator.

> nicolasfella wrote in krecentfilesmenu.cpp:85
> New entries are pushed to the front, which works in constant time for 
> std::list and linear time for std::vector
> When the maximum is reached the last element is removed which works in 
> constant time for both.
> 
> We could turn it around and add new items to the back and iterate reverse, 
> but then removing the front item would take linear time for std::vector
> 
> Given that n is small (<10 by default) it shouldn't matter much anyway

That's the theory as it was taught in schools years ago.

In practice, moving N pointers that are in the same CPU cache line (because 
they are in a std::vector) is faster than findEntry accessing nodes all over 
memory (because of std::list), which means loading N different areas of memory 
into the CPU cache.
Because the element type is a pointer (and not a complex value class), that 
"linear time" is a single memmove, hopefully.

Anyway, as you say, it doesn't really matter so I'm happy to let it go, I just 
wanted to say that I still do believe std::vector is better suited :)

> broulik wrote in krecentfilesmenu.cpp:150
> If we're rewriting this thing anyway, can we please make sure it does not 
> block application startup checking if those files exist, as can happen if you 
> had opened files on an NFS mount before.
> 
> Either do it only when the menu is opened (aboutToShow) and/or asynchronously.

Blocking in aboutToShow is even worse in terms of user experience, isn't it?

If the NFS mount was manual, this will just fail and not block, anyway.
But with automounting this can go very wrong indeed.

You know what I think don't mount network drives, use KIO :)

> cfeck wrote in krecentfilesmenu.cpp:215
> Should we truncate the current list if the new max items is smaller?

^ this comment hasn't been addressed yet.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[Alexander Semke]

asemke added a comment.


  +1

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns