D26839: demote plugin load errors from warning to debug level + reword

2020-01-22 Thread Michael Pyne
mpyne accepted this revision. mpyne added a comment. Agreed, let's commit. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26839 To: sitter, mpyne, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

2020-01-22 Thread Noah Davis
ndavis added a comment. In D26758#599231 , @davidedmundson wrote: > Please be sure to run the relevant tests in > > tests/components/ > > with qmlscene > > It'll find more than running random applets Unfortunately, those have

D26801: Really fix the Windows backend for KNotifications

2020-01-22 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 74190. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26801?vs=74005=74190 BRANCH arcpatch-D26801 REVISION DETAIL

D26860: Readapt code to new kconfig code

2020-01-22 Thread Laurent Montel
mlaurent added a comment. it replace D26432 I don't know why it created a new version REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26860: Readapt code to new kconfig code

2020-01-22 Thread Laurent Montel
mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to "\n" as it's qt namespaced TEST PLAN autotest ok REPOSITORY R237 KConfig BRANCH port_endl

D26860: Readapt code to new kconfig code

2020-01-22 Thread Laurent Montel
mlaurent added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

2020-01-22 Thread Laurent Montel
mlaurent abandoned this revision. mlaurent added a comment. created a new one D26860 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26432 To: mlaurent, dfaure, tcanabrava Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n,

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

2020-01-22 Thread Cyril Rossi
crossi abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26082 To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven Cc: plasma-devel, meven, bport, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26832: Add icon for application/sql

2020-01-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is an alias to `text/x-sql` but we don't resolve those when looking up icons.

D25698: New query mechanism for applications: KApplicationTrader

2020-01-22 Thread David Faure
dfaure updated this revision to Diff 74073. dfaure added a comment. Improve docu REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25698?vs=73890=74073 BRANCH kapplicationtrader REVISION DETAIL https://phabricator.kde.org/D25698 AFFECTED FILES

D25698: New query mechanism for applications: KApplicationTrader

2020-01-22 Thread David Faure
dfaure marked 2 inline comments as done. dfaure added inline comments. INLINE COMMENTS > dhaumann wrote in kapplicationtrader.cpp:87 > I would prefer the std::erase(std::remove_if(...), ...end()); idiom here. > > Assuming the list is a vector this will be much faster, or do you have to >

D25698: New query mechanism for applications: KApplicationTrader

2020-01-22 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > dfaure wrote in kapplicationtrader.cpp:87 > Order is very important here, it's the order of preference. > > But doesn't erase(remove_if()) preserve order? I thought it did. cppreference says it does: > Relative order of the elements that remain

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-22 Thread Kevin Ottens
ervin accepted this revision. ervin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in settings.cpp:173 > I still want to be able to specify what `config` (constructor argument) to > use for autotests After discussing with kai, let's mark

D26202: Refactor KConfigXT

2020-01-22 Thread Kevin Ottens
ervin added a comment. Well a couple of them are a bit more invasive than just dealing with spaces but fair enough. I wouldn't mind an answer to my question though just to feel less stupid: https://phabricator.kde.org/D26202#inline-151385 REPOSITORY R237 KConfig BRANCH

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-01-22 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74098. zzag added a comment. Specify the parent object REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26503?vs=73010=74098 BRANCH port-to-shadows-api REVISION DETAIL

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car
meven updated this revision to Diff 74071. meven added a comment. Don't add by default 'Modifield Today' and 'Modifield Yesterday' when recentlyused:/ is present REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=73995=74071 BRANCH arcpatch-D26782

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car
meven updated this revision to Diff 74072. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74071=74072 BRANCH arcpatch-D26782 REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Cyril Rossi
crossi abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

2020-01-22 Thread Cyril Rossi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee3176ce5641: Expose KConfig settings to allow registration in KCM Notification (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26202: Refactor KConfigXT

2020-01-22 Thread Tomaz Canabrava
tcanabrava added a comment. @ervin since they are just nitpicks I'll fix in code and land the patch. REPOSITORY R237 KConfig BRANCH rework_kconfig_compiler REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: davidre, bcooksley,

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Cyril Rossi
crossi planned changes to this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Cyril Rossi
crossi reclaimed this revision. This revision now requires changes to proceed. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26202: Refactor KConfigXT

2020-01-22 Thread Tomaz Canabrava
tcanabrava marked 26 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in KConfigCodeGeneratorBase.cpp:80 > This is an odd indentation logic, is it to stay close to the original? (which > I'd actually support, just trying to understand where that's coming

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Kevin Ottens
ervin added a comment. Well, even though you didn't have a direct use anymore it doesn't mean this patch was useless. I think it'd be worth fixing the last issue I pointed out and merging it. I seem to remember someone else requested this feature. REPOSITORY R296 KDeclarative REVISION

D26839: demote plugin load errors from warning to debug level + reword

2020-01-22 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: mpyne. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY while they are errors from our POV the callers POV may be that they'll simply try

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-22 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. it's ok for me. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26701 To: dfaure, broulik, pino, mlaurent Cc: alexeymin, kde-frameworks-devel,

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-22 Thread Laurent Montel
mlaurent added a comment. It's not used in kmail it seems. we use this class in kmail-account-wizard only. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin, dfaure Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26701: Add KFileCustomDialog constructor with a startDir parameter.

2020-01-22 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26701 To: dfaure, broulik, pino, mlaurent Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26768: Revert "Revert "WIP: Refactor KConfigXT""

2020-01-22 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26768 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: Refactor KConfigXT

2020-01-22 Thread Tomaz Canabrava
This revision was automatically updated to reflect the committed changes. Closed by commit R237:95aee1294e32: Refactor KConfigXT (authored by tcanabrava). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=74118=74121 REVISION DETAIL

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car
meven updated this revision to Diff 74123. meven added a comment. Fix comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26782?vs=74072=74123 BRANCH arcpatch-D26782_1 REVISION DETAIL https://phabricator.kde.org/D26782 AFFECTED FILES

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D26782_1 REVISION DETAIL https://phabricator.kde.org/D26782 To: meven, ngraham, #vdg, #plasma, hein Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3dfa0c1c2f87: KFilePlacesModel: On new profile in recent show only recentlyused:/ based… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Just a tiny nitpick left. INLINE COMMENTS > managedconfigmodule.cpp:175 > + , d->_skeletons.end() > + , [](const

D26841: hardware tool: define syntax via syntax arg

2020-01-22 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this way the commands syntax is always immediately visible in the help text. nothing infurates me more than help that

D26202: Refactor KConfigXT

2020-01-22 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 74118. tcanabrava marked an inline comment as done. tcanabrava retitled this revision from "Refactor KConfigXT " to "Refactor KConfigXT". tcanabrava added a comment. - Rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-22 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 74119. leinir added a comment. - Add a voting method to the Ratings component (separate to editable) - Use the votable prop to add voting UI to entry details - Hook up to the functions which do the actual vote/comment work REPOSITORY R304 KNewStuff

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Cyril Rossi
crossi updated this revision to Diff 74125. crossi added a comment. Clean the list properly REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26046?vs=73411=74125 REVISION DETAIL https://phabricator.kde.org/D26046 AFFECTED FILES

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread David Redondo
davidre created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davidre requested review of this revision. REVISION SUMMARY Before it was always false for every inline note. REPOSITORY R39 KTextEditor BRANCH underMouse

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 278 - Still Unstable!

2020-01-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/278/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 14:42:35 + Build duration: 9 min 10 sec and counting JUnit Tests Name:

D26832: Add icon for application/sql

2020-01-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R266:6be022ac5f4a: Add icon for application/sql (authored by broulik). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26832?vs=74093=74129 REVISION DETAIL

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Cyril Rossi
crossi updated this revision to Diff 74128. crossi added a comment. code style REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26046?vs=74125=74128 REVISION DETAIL https://phabricator.kde.org/D26046 AFFECTED FILES

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-22 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread David Redondo
davidre edited the test plan for this revision. davidre added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26840 To: davidre, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D26839: demote plugin load errors from warning to debug level + reword

2020-01-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26839 To: sitter, mpyne, ngraham Cc: ngraham, kde-frameworks-devel,

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-22 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

2020-01-22 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 74113. leinir added a subscriber: mart. leinir added a comment. Progressing steadily, with some layout fixing assistance from Marco. Also, ensure you're using kirigami master for the best experience ;) - Forward the userCanComment information from

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

2020-01-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileplacesmodel.cpp:358 > + > +// don't add by default "Modifield Today" and "Modifield Yesterday" > when recentlyused:/ is present > +if

D26832: Add icon for application/sql

2020-01-22 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26832 To: broulik, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread Sven Brauch
brauch added a comment. Hm, yeah, looking at the code I think you might need to call `updateView()` in case a focus in or out happened. Can you try if that makes a difference? REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL

D26779: Updates nasm.xml with the latest instructions

2020-01-22 Thread Christoph Cullmann
cullmann added a comment. I will push this, thanks for the patch! REPOSITORY R216 Syntax Highlighting BRANCH nasm (branched from master) REVISION DETAIL https://phabricator.kde.org/D26779 To: meganomic, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel,

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread David Redondo
davidre added a comment. I stumbled upon while doing https://invent.kde.org/kde/kdevelop/merge_requests/92 REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL https://phabricator.kde.org/D26840 To: davidre, #ktexteditor, cullmann Cc: cullmann,

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

2020-01-22 Thread Noah Davis
ndavis retitled this revision from "[WIP] Fix the size and pixel alignment of checkboxes and radiobuttons" to "Fix the size and pixel alignment of checkboxes and radiobuttons". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis,

D26841: hardware tool: define syntax via syntax arg

2020-01-22 Thread Stefan Brüns
bruns added a comment. Please do proper capitalization in the summary. And "nothing infurates me more" is not relevant for a commit message. Otherwise LGTM. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26841 To: sitter Cc: bruns, kde-frameworks-devel,

D26848: Don't assume the manager and menu have the same lifetime

2020-01-22 Thread David Redondo
davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY The menu we retun can outlive the manager. So we can't use it or its members in slots when connecting to signals of

D26848: Don't assume the manager and menu have the same lifetime

2020-01-22 Thread David Redondo
davidre added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26848 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26793: Exclude the KSharedConfig::openStateConfig from the sip parser

2020-01-22 Thread Juraj Oravec
SGOrava abandoned this revision. SGOrava added a comment. Done in https://phabricator.kde.org/D26815 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26793 To: SGOrava, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread Sven Brauch
brauch added a comment. My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is tagged dirty, it gets repainted correctly, but too late. REPOSITORY R39

D26670: ki18n_wrap_ui: error when file doesn't exist

2020-01-22 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this ok the way it is now, or? REPOSITORY R249 KI18n BRANCH error (branched from master) REVISION DETAIL https://phabricator.kde.org/D26670 To: davidre,

D26779: Updates nasm.xml with the latest instructions

2020-01-22 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7a4b9f691733: Updates nasm.xml with the latest instructions (authored by meganomic, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D26841: hardware tool: define syntax via syntax arg

2020-01-22 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26841 To: sitter Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable. Btw., does somebody use that now for something useful? REPOSITORY R39 KTextEditor BRANCH underMouse (branched from master) REVISION DETAIL

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

2020-01-22 Thread Benjamin Port
This revision was automatically updated to reflect the committed changes. Closed by commit R293:71fb41ae9ae8: Migrate config from KConfig to KConfigXt in order to allow KCM to use it (authored by bport). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D25015: Update breeze theme shadows

2020-01-22 Thread Niccolò Venerandi
niccolove updated this revision to Diff 74153. niccolove added a comment. Corrected masks to be more similiar to original shapes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25015?vs=73844=74153 BRANCH bettershadows (branched from

D25015: Update breeze theme shadows

2020-01-22 Thread Dominic Hayes
The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. I feel like the shadows might be slightly overcompensating in shadow strength for the small shadow span (it looks kinda weird on first glance), but apart from that minor nitpick, I'd say this is good to go.

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread Sven Brauch
brauch added a comment. Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing. Is it possible that the line (and thus the note) is not properly marked for repaint when the underMouse

D25015: Update breeze theme shadows

2020-01-22 Thread Niccolò Venerandi
niccolove added a comment. I found a way to make masks that follow the current shape by copying it and making them slightly bigger than original ones. Regarding panels and tooltips: using different roundings (1px vs 3px) seemed inconsistent to me, so I tried to ask in the VDG chat if they

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

2020-01-22 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26840: Correctly set underMouse() for inline notes

2020-01-22 Thread David Redondo
davidre added a comment. In D26840#599082 , @brauch wrote: > Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing. > > Is it possible that

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

2020-01-22 Thread David Edmundson
davidedmundson added a comment. Please be sure to run the relevant tests in tests/components/ with qmlscene It'll find more than running random applets REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26758 To: ndavis, #plasma, #vdg

D26855: Add icon for KTrip

2020-01-22 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The icon itself is not new, it has been shipped in the ktrip repo already. To include KTrip in

D26855: Add icon for KTrip

2020-01-22 Thread Nicolas Fella
nicolasfella added reviewers: Breeze, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26855 To: nicolasfella, #breeze, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2020-01-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. If @ndavis says it's okay, I say shipit! REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg, ngraham, The-Feren-OS-Dev

D26858: Provide an implementation for the tablet interface

2020-01-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Implements the necessary classes to have proper support for the tablet and pen.

D25015: Update breeze theme shadows

2020-01-22 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg, ngraham, The-Feren-OS-Dev, ndavis Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin,

D26858: Provide an implementation for the tablet interface

2020-01-22 Thread Aleix Pol Gonzalez
apol added a dependent revision: D26859: Implement the tablet wayland protocol in kwin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26858 To: apol, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns