D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74348. mlaurent added a comment. Trim better calling toString() REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74295=74348 BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/100/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 25 Jan 2020 01:54:48 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

D26900: Support multiple values in XDG_CURRENT_DESKTOP

dfaure updated this revision to Diff 74337. dfaure added a comment. use splitRef and QVector REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26900?vs=74326=74337 BRANCH xdg_current_deskto REVISION DETAIL https://phabricator.kde.org/D26900 AFFECTED

D26903: allow programLogo property to be a QIcon, too

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann, apol Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26900: Support multiple values in XDG_CURRENT_DESKTOP

apol added inline comments. INLINE COMMENTS > kservice.cpp:658 > > -QStringList > currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP"))); > +QStringList > currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP")).split(QLatin1Char(':'), >

D25698: New query mechanism for applications: KApplicationTrader

dfaure updated this revision to Diff 74335. dfaure added a comment. improve unittest, let the name match more queries REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25698?vs=74334=74335 BRANCH kapplicationtrader REVISION DETAIL

D25698: New query mechanism for applications: KApplicationTrader

dfaure updated this revision to Diff 74334. dfaure added a comment. Port to erase(remove_if), add unittest for OnlyShowIn, which showed inconsistencies => now removed from results of both methods. REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D25798: Deprecated allowAsDefault

ngraham added a comment. Thanks! REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26564: Clean kbuildsycoca4 support

hein added a comment. Let's wait until branching, there's still some KDE 4 apps people use. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26564 To: meven, ervin, #frameworks, hein Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26840: Correctly set underMouse() for inline notes

brauch added a comment. I'm sorry, updateView is the wrong function to call, you need updateDirty. I tried it out, like this it works: if (e->buttons() == Qt::NoButton) { auto noteData = inlineNoteAt(e->globalPos()); if (noteData.m_position.isValid()) { if

D26903: allow programLogo property to be a QIcon, too

dhaumann added a comment. Looks good to me, and very much in line with the other `canConvert` statements before. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26903 To: cullmann Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26903: allow programLogo property to be a QIcon, too

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY rational: QIcon allows for better passing of HiDPI aware icons to the dialog TEST PLAN make && make test

D25798: Deprecated allowAsDefault

ngraham added a comment. This makes `kde-cli-tools` fail to build for me with Qt 5.14 on openSUSE Tumbleweed: [ 43%] Linking CXX executable ../bin/kioclient5 /home/nate/kde/src/kde-cli-tools/keditfiletype/mimetypedata.cpp: In member function ‘QStringList

D26840: Correctly set underMouse() for inline notes

davidre added a comment. In D26840#599974 , @brauch wrote: > Then it seems like the line is not tagged correctly. Maybe try `tagLines(note.position.line(), note.position.line())`? I think the column being the same is not what the function being

D26900: Support multiple values in XDG_CURRENT_DESKTOP

dfaure created this revision. dfaure added reviewers: apol, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The Desktop Entry spec says "If $XDG_CURRENT_DESKTOP is set then it contains a

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 281 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/281/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 24 Jan 2020 18:24:43 + Build duration: 6 min 25 sec and counting JUnit Tests Name:

D26878: Add missing renamed event when a destination file already existed

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fe5913b1346a: Add missing renamed event when a destination file already existed (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74324. meven marked 3 inline comments as done. meven added a comment. Clean up + QVERIFY REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74316=74324 BRANCH arcpatch-D26878 REVISION DETAIL

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26878: Add missing renamed event when a destination file already existed

dfaure accepted this revision. dfaure added a comment. Nice work! Thanks for the unittest extension. INLINE COMMENTS > jobtest.cpp:1731 > + > +qDebug() << sourceFile << renamedFile; > +QVERIFY2(job->exec(), qPrintable(job->errorString())); Please clean up before committing >

D26131: Braces around for, break early.

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26131 To: tcanabrava, ervin, dfaure Cc: ervin, patrickelectric, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26867: New class: KConfigTypeInformation

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26867 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26868 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added reviewers: dfaure, ervin. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26898: expose an id for the wallpaper

mart updated this revision to Diff 74320. mart added a comment. plasmoidId to avoid potential future clashes with QML id REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26898?vs=74319=74320 BRANCH phab/wallpaperid REVISION DETAIL

D26898: expose an id for the wallpaper

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY The id of the wallpaper, is really the id of the containment, as there will always be a

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74316. meven added a comment. Remove a bad unused REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74311=74316 BRANCH arcpatch-D26878 REVISION DETAIL https://phabricator.kde.org/D26878 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 280 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/280/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 24 Jan 2020 14:33:38 + Build duration: 6 min 32 sec and counting JUnit Tests Name:

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

apol added a comment. Looks good otherwise, this code is pretty well tested too, so I quite trust we aren't breaking it horribly. Trying to compile the rest of KDE Software against this patch would also be useful. INLINE COMMENTS > kconfigloader.cpp:127 > } else if (name

D26897: Fix two warnings, missing Q_FALLTHROUGH

This revision was automatically updated to reflect the committed changes. meven marked an inline comment as done. Closed by commit R241:e6807dea4735: Fix two warnings, missing Q_FALLTHROUGH (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26897: Fix two warnings, missing Q_FALLTHROUGH

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > copyjob.cpp:1223 > m_bAutoRenameDirs = true; > // fall through > +Q_FALLTHROUGH(); The comments are somewhat redundant now x2

D26897: Fix two warnings, missing Q_FALLTHROUGH

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26897

D26878: Add missing renamed event when a destination file already existed

meven edited the test plan for this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 To: meven, #frameworks, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74311. meven added a comment. Avoid touching a line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26878?vs=74310=74311 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 AFFECTED FILES

D26878: Add missing renamed event when a destination file already existed

meven updated this revision to Diff 74310. meven retitled this revision from "Add missing renamed events when a destination file already existed" to "Add missing renamed event when a destination file already existed". meven added a comment. Add tests, add renamed events when autorename was

D26878: Add missing renamed events when a destination file already existed

meven retitled this revision from "Add missing renamed event when a destination file already existed" to "Add missing renamed events when a destination file already existed". REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26878 To: meven, #frameworks,

D26878: Add missing renamed event when a destination file already existed

meven retitled this revision from "Add a missing renamed event when a destination file already existed" to "Add missing renamed event when a destination file already existed". meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. > I will try to cook up a more complete solution over the weekend. If you can explain what you would prefer instead, I can help find time. INLINE COMMENTS > bruns wrote in app.cpp:119 > This is a little bit confusing, as the lmdb code uses `rc == LMDB_OK

D25583: Quit baloo_file_extractor if DB transaction fails

bruns added a comment. ... and sorry for the late answer ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D25583: Quit baloo_file_extractor if DB transaction fails

bruns added a comment. I will try to cook up a more complete solution over the weekend. INLINE COMMENTS > app.cpp:119 > } else { > -m_tr->commit(); > +bool rc = m_tr->commit(); > delete m_tr; This is a little bit confusing, as the lmdb code uses `rc == LMDB_OK

D26848: Don't assume the manager and menu have the same lifetime

davidre marked 4 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26848 To: davidre, #frameworks Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns