D27028: Switch from download.k.o to autoconfig

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> khotnewstuff.knsrc:2
>  [KNewStuff3]
> -ProvidersUrl=http://download.kde.org/ocs/providers.xml
> +ProvidersUrl=http://autoconfig.kde.org/ocs/providers.xml
>  Categories=KDE Wallpaper 1920x1200,KDE Wallpaper 1600x1200

Shouldn't it be in https ?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27028

To: leinir, bcooksley, #frameworks
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 284 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/284/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 03 Feb 2020 04:20:03 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

T11627: Improve KIO asynchronicity

[Méven Car]

meven updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T11627

To: meven
Cc: broulik, ognarb, #dolphin, #frameworks, meven, dfaure, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D26749: WIP: Support NDK r20 and Qt 5.14

[Francis Herne]

flherne added a comment.


  Thanks for this.
  
  ADB log of the Kirigami problem, which results in a blank screen ['gredit' is 
the name of the app]:
  
libgredit_arm64-v8a.so: QQmlApplicationEngine failed to load component
libgredit_arm64-v8a.so: qrc:/main.qml:5:1: Type Kg.ApplicationWindow 
unavailable
libgredit_arm64-v8a.so: 
file:///data/app/org.qtproject.example.gredit-n9QHCzgETccPFueeH24YPQ==/lib/arm64/ApplicationWindow.qml:
 No such file or directory
  
  The `--Added-by-androiddeployqt--` dir in the APK, which previously contained 
these QML files, is no longer created.
  
  The file contents now seem to appear in an RCC file at 
`assets/android_rcc_bundle.rcc`, but clearly Kirigami isn't understanding this.
  
  Icons packaged by `kirigami_package_breeze_icons` no longer appear under 
`assets`.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26749

To: vkrause
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27104: Convert license statements to SPDX headers

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> krcc.cpp:4
> +
> +   SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR 
> LicenseRef-KDE-Accepted-LGPL
>  */

Same thing here

> krcc.h:4
>  
> -   This library is free software; you can redistribute it and/or modify
> -   it under the terms of the GNU Library General Public License as published
> -   by the Free Software Foundation; either version 2 of the License or
> -   ( at your option ) version 3 or, at the discretion of KDE e.V.
> -   ( which shall act as a proxy as in section 14 of the GPLv3 ), any later 
> version.
> -
> -   This library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Library General Public License for more details.
> -
> -   You should have received a copy of the GNU Library General Public License
> -   along with this library; see the file COPYING.LIB.  If not, write to
> -   the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> -   Boston, MA 02110-1301, USA.
> +   SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR 
> LicenseRef-KDE-Accepted-LGPL
>  */

The original license doesn't make sense.

If it's LGPL-2.0 or LGPL-3.0, the GPL 3 clause cannot be invoked

This needs some code archeology to understand where the issue comes from

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27104

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

ahmadsamir added a comment.


  I'll try and add some unit tests to catch those issues...

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D27112

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27112: Fix errors in the QRegularExpression porting commit

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, drosca, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Properties::parse():
  
  - The regex is case sensitive
  - Fix copy/paste error, it's just one space " "
  
  Fix porting of capturedTexts().last() of QRegExp; it should be 
match.captured(1)
  with QRegularExpression if there's one capturing group in the pattern;
  QRegExp capturedTexts() first element is the 0 capturing group which
  captures the whole matched string.

REPOSITORY
  R269 BluezQt

BRANCH
  l-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27112

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, #frameworks, drosca, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27097: Port from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 74871.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Add test plan section

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27097?vs=74850=74871

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27097

AFFECTED FILES
  autotests/kfindtest.cpp
  autotests/kfindtest.h
  autotests/krichtextedittest.cpp
  src/CMakeLists.txt
  src/findreplace/kfind.cpp
  src/findreplace/kfind.h
  src/findreplace/kfind_p.h
  src/findreplace/kfinddialog.cpp
  src/findreplace/kreplace.cpp
  src/findreplace/kreplace.h
  src/widgets/krichtextedit.cpp

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Banning QNetworkAccessManager

[Volker Krause]

I agree on the problem of QNAM's default, see also https://conf.kde.org/en/
akademy2019/public/events/135 on that subject.

On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote:
[...]
> Prior to now, i've taken the approach of advertising that
> QNetworkAccessManager is broken and needs a flag set within
> applications when used, however unfortunately this seems to have been
> an ineffective approach and cases of broken behaviour continue to
> appear (despite this brokeness being known about and advertised since
> back in the Qt 4.x series when this class was introduced)
> 
> Therefore, given the Qt Project is unlikely to change their position
> on this, I would like to propose the following:

The Qt Project is actually in favor of changing at least the redirection 
default to exactly what we want it to be.
https://codereview.qt-project.org/c/qt/qtbase/+/273175 has the change, and got 
approval both by Lars and one of the maintainers. It is merely stuck in 
dealing with the unit test fallout in Qt's CI that somebody has to take care 
of. Doesn't immediately help us of course, but claiming Qt is unwilling to 
change this is simply wrong.

> 1) That effective immediately, QNetworkAccessManager and it's children
> classes be banned and prohibited within KDE software, to be enforced
> by server side hooks.
> 2) That we fork QNetworkAccessManager and the associated classes
> within the appropriate Framework (to be determined), where the
> defective behaviour can then be corrected.

While this might solve the redirection problem, it brings us yet another then 
unmaintained HTTP implementation next to the one in KIO, which is a far bigger 
problem long term. We need less of those, not more.

To address the problem of people not using the correct defaults, I did propose 
a much less extreme approach in the above mentioned talk at Akademy, namely 
having a KNetworkAccessManager as a sub-class of QNAM in a low-tier frameworks 
that essentially just enables redirects and HSTS. QNAM's implementation isn't 
the problem after all, the defaults are.

Commit hooks warning about QNAM usage might still be a good idea, but as a 
warning only. Hard blocking QNAM-using code would block at least three repos I 
spend a lot of time on currently, none of which even talks to KDE servers.

If you need to take more drastic measures against code not doing this 
correctly regardless, you can do that my dropping the server-side workarounds. 
Yes, that would break the affected application possibly, but at least it would 
not cause massive collateral damage for the people using this correctly.

It would also help to know where specifically we have that problem, so we can 
actually solve it, and so we can figure out why we failed to fix this there 
earlier.

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

[Méven Car]

meven added a comment.


  I have currently a couple of patches touching the same lines, so I will 
postpone this land after to save me some rebasing time.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25301

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> jobtest.cpp:82
> +// to make sure io is not too fast
> +qputenv("KIOSLAVE_FILE_ENABLE_TESTMODE", "1");
> +

It'd be nice to have an #idef BUILD_TEST to only include this code path only 
when tests are compiled.
I didn't know how to achieve this.

> dfaure wrote in jobtest.cpp:2045
> Does this mean the file could be made smaller again?
> 
> (to reduce disk-space requirements)

I have reduced the size space needed to a smaller value than before this patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven updated this revision to Diff 74870.
meven marked 3 inline comments as done.
meven added a comment.


  Reduce the size of the tempfile for JobTest::cancelCopyAndCleanDest and 
restrict testMode slowness to copy where destination is slow

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25117?vs=74570=74870

BRANCH
  arcpatch-D25117

REVISION DETAIL
  https://phabricator.kde.org/D25117

AFFECTED FILES
  autotests/jobtest.cpp
  src/core/filecopyjob.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22801: [KIO] silence a QFileInfo warning

[René J . V . Bertin]

rjvbb added a comment.


  Whatever, I'm staying at 5.60.0 anyway, with whatever patches I deem 
appropriate.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks, dfaure
Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27106: Convert license statements to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27106: Convert license statements to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX markers and
  add license files.

REPOSITORY
  R235 Attica

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27106

AFFECTED FILES
  COPYING
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/configtest.cpp
  autotests/persontest.cpp
  autotests/privatedatatest.cpp
  autotests/providertest.cpp
  src/accountbalance.cpp
  src/accountbalance.h
  src/accountbalanceparser.cpp
  src/accountbalanceparser.h
  src/achievement.cpp
  src/achievement.h
  src/achievementparser.cpp
  src/achievementparser.h
  src/activity.cpp
  src/activity.h
  src/activityparser.cpp
  src/activityparser.h
  src/atticabasejob.cpp
  src/atticabasejob.h
  src/atticautils.cpp
  src/atticautils.h
  src/buildservice.cpp
  src/buildservice.h
  src/buildservicejob.cpp
  src/buildservicejob.h
  src/buildservicejoboutput.cpp
  src/buildservicejoboutput.h
  src/buildservicejoboutputparser.cpp
  src/buildservicejoboutputparser.h
  src/buildservicejobparser.cpp
  src/buildservicejobparser.h
  src/buildserviceparser.cpp
  src/buildserviceparser.h
  src/category.cpp
  src/category.h
  src/categoryparser.cpp
  src/categoryparser.h
  src/cloud.cpp
  src/cloud.h
  src/cloudparser.cpp
  src/cloudparser.h
  src/comment.cpp
  src/comment.h
  src/commentparser.cpp
  src/commentparser.h
  src/config.cpp
  src/config.h
  src/configparser.cpp
  src/configparser.h
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/contentparser.h
  src/deletejob.cpp
  src/deletejob.h
  src/distribution.cpp
  src/distribution.h
  src/distributionparser.cpp
  src/distributionparser.h
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/downloaditem.cpp
  src/downloaditem.h
  src/downloaditemparser.cpp
  src/downloaditemparser.h
  src/event.cpp
  src/event.h
  src/eventparser.cpp
  src/eventparser.h
  src/folder.cpp
  src/folder.h
  src/folderparser.cpp
  src/folderparser.h
  src/forum.cpp
  src/forum.h
  src/forumparser.cpp
  src/forumparser.h
  src/getjob.cpp
  src/getjob.h
  src/homepageentry.cpp
  src/homepageentry.h
  src/homepagetype.cpp
  src/homepagetype.h
  src/homepagetypeparser.cpp
  src/homepagetypeparser.h
  src/icon.cpp
  src/icon.h
  src/itemjob.cpp
  src/itemjob.h
  src/knowledgebaseentry.cpp
  src/knowledgebaseentry.h
  src/knowledgebaseentryparser.cpp
  src/knowledgebaseentryparser.h
  src/license.cpp
  src/license.h
  src/licenseparser.cpp
  src/licenseparser.h
  src/listjob.cpp
  src/listjob.h
  src/listjob_inst.cpp
  src/message.cpp
  src/message.h
  src/messageparser.cpp
  src/messageparser.h
  src/metadata.cpp
  src/metadata.h
  src/parser.cpp
  src/parser.h
  src/person.cpp
  src/person.h
  src/personparser.cpp
  src/personparser.h
  src/platformdependent.h
  src/platformdependent_v2.cpp
  src/platformdependent_v2.h
  src/postfiledata.cpp
  src/postfiledata.h
  src/postjob.cpp
  src/postjob.h
  src/privatedata.cpp
  src/privatedata.h
  src/privatedataparser.cpp
  src/privatedataparser.h
  src/project.cpp
  src/project.h
  src/projectparser.cpp
  src/projectparser.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h
  src/publisher.cpp
  src/publisher.h
  src/publisherfield.cpp
  src/publisherfield.h
  src/publisherfieldparser.cpp
  src/publisherfieldparser.h
  src/publisherparser.cpp
  src/publisherparser.h
  src/putjob.cpp
  src/putjob.h
  src/qtplatformdependent.cpp
  src/qtplatformdependent_p.h
  src/remoteaccount.cpp
  src/remoteaccount.h
  src/remoteaccountparser.cpp
  src/remoteaccountparser.h
  src/topic.cpp
  src/topic.h
  src/topicparser.cpp
  src/topicparser.h
  src/version.h.cmake
  tests/projecttest/main.cpp
  tests/projecttest/projecttest.cpp
  tests/projecttest/projecttest.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27104: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX markers and add license files
  compatible with REUSE.software specification.

REPOSITORY
  R243 KArchive

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27104

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/deprecatedtest.cpp
  autotests/karchivetest.cpp
  autotests/karchivetest.h
  autotests/kcompressiondevicetest.cpp
  autotests/kcompressiondevicetest.h
  autotests/kfiltertest.cpp
  autotests/kfiltertest.h
  autotests/klimitediodevicetest.cpp
  autotests/klimitediodevicetest.h
  examples/bzip2gzip/main.cpp
  examples/helloworld/main.cpp
  examples/tarlocalfiles/main.cpp
  examples/unzipper/main.cpp
  src/k7zip.cpp
  src/k7zip.h
  src/kar.cpp
  src/kar.h
  src/karchive.cpp
  src/karchive.h
  src/karchive_p.h
  src/karchivedirectory.h
  src/karchiveentry.h
  src/karchivefile.h
  src/kbzip2filter.cpp
  src/kbzip2filter.h
  src/kcompressiondevice.cpp
  src/kcompressiondevice.h
  src/kcompressiondevice_p.h
  src/kfilterbase.cpp
  src/kfilterbase.h
  src/kfilterdev.cpp
  src/kfilterdev.h
  src/kgzipfilter.cpp
  src/kgzipfilter.h
  src/klimitediodevice.cpp
  src/klimitediodevice_p.h
  src/knonefilter.cpp
  src/knonefilter.h
  src/krcc.cpp
  src/krcc.h
  src/ktar.cpp
  src/ktar.h
  src/kxzfilter.cpp
  src/kxzfilter.h
  src/kzip.cpp
  src/kzip.h
  src/kzipfileentry.h
  tests/k7ziptest.cpp
  tests/kartest.cpp
  tests/krcctest.cpp
  tests/ktartest.cpp
  tests/kziptest.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27104: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27104

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27103: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr added a reviewer: dfaure.
cordlandwehr added a comment.


  Can you have a look at the KDAB license statement changes? Specifically the 
point that now the copyright statement explicitly states the copyright for both 
the author and the company, where previously the author's copyright was only 
implicitly stated.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 283 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/283/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 02 Feb 2020 16:08:39 +
 Build duration:
9 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27103: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27103: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX markers and add REUSE.software
  compliant licesne files. This update also includes several copyright holder
  clarifications for contracted contributors, where only implicitly the
  copyright for the authors was stated inside the copyright statement of
  the company.

REPOSITORY
  R275 KItemModels

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27103

AFFECTED FILES
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  autotests/bihash/benchmarks.cpp
  autotests/bihash/functionalitytest.cpp
  autotests/kcolumnheadersmodeltest.cpp
  autotests/kconcatenaterows_qml.cpp
  autotests/kdescendantsproxymodel_smoketest.cpp
  autotests/kdescendantsproxymodeltest.cpp
  autotests/kextracolumnsproxymodeltest.cpp
  autotests/klinkitemselectionmodeltest.cpp
  autotests/klinkitemselectionmodeltest.h
  autotests/kmodelindexproxymappertest.cpp
  autotests/knumbermodeltest.cpp
  autotests/krearrangecolumnsproxymodeltest.cpp
  autotests/krecursivefilterproxymodeltest.cpp
  autotests/kselectionproxymodel_smoketest.cpp
  autotests/kselectionproxymodeltest.cpp
  autotests/kselectionproxymodeltestsuite.cpp
  autotests/kselectionproxymodeltestsuite.h
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  autotests/proxymodeltestsuite/dynamictreemodel.h
  autotests/proxymodeltestsuite/dynamictreewidget.cpp
  autotests/proxymodeltestsuite/dynamictreewidget.h
  autotests/proxymodeltestsuite/eventloggerregister.cpp
  autotests/proxymodeltestsuite/eventloggerregister.h
  autotests/proxymodeltestsuite/indexfinder.h
  autotests/proxymodeltestsuite/modelcommander.cpp
  autotests/proxymodeltestsuite/modelcommander.h
  autotests/proxymodeltestsuite/modeldumper.cpp
  autotests/proxymodeltestsuite/modeldumper.h
  autotests/proxymodeltestsuite/modeleventlogger.cpp
  autotests/proxymodeltestsuite/modeleventlogger.h
  autotests/proxymodeltestsuite/modelselector.cpp
  autotests/proxymodeltestsuite/modelselector.h
  autotests/proxymodeltestsuite/modelspy.cpp
  autotests/proxymodeltestsuite/modelspy.h
  autotests/proxymodeltestsuite/modeltest.cpp
  autotests/proxymodeltestsuite/modeltest.h
  autotests/proxymodeltestsuite/persistentchangelist.h
  autotests/proxymodeltestsuite/proxymodeltest.cpp
  autotests/proxymodeltestsuite/proxymodeltest.h
  autotests/test_model_helpers.h
  src/core/kbihash_p.h
  src/core/kbreadcrumbselectionmodel.cpp
  src/core/kbreadcrumbselectionmodel.h
  src/core/kcheckableproxymodel.cpp
  src/core/kcheckableproxymodel.h
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/core/kconcatenaterowsproxymodel.cpp
  src/core/kconcatenaterowsproxymodel.h
  src/core/kdescendantsproxymodel.cpp
  src/core/kdescendantsproxymodel.h
  src/core/kextracolumnsproxymodel.cpp
  src/core/kextracolumnsproxymodel.h
  src/core/klinkitemselectionmodel.cpp
  src/core/klinkitemselectionmodel.h
  src/core/kmodelindexproxymapper.cpp
  src/core/kmodelindexproxymapper.h
  src/core/knumbermodel.cpp
  src/core/knumbermodel.h
  src/core/krearrangecolumnsproxymodel.cpp
  src/core/krearrangecolumnsproxymodel.h
  src/core/krecursivefilterproxymodel.cpp
  src/core/krecursivefilterproxymodel.h
  src/core/kselectionproxymodel.cpp
  src/core/kselectionproxymodel.h
  src/core/kvoidpointerfactory_p.h
  src/qml/kconcatenaterowsproxymodel_qml.cpp
  src/qml/kconcatenaterowsproxymodel_qml.h
  src/qml/plugin.cpp
  src/qml/plugin.h
  tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp
  tests/proxymodeltestapp/breadcrumbdirectionwidget.h
  tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp
  tests/proxymodeltestapp/breadcrumbnavigationwidget.h
  tests/proxymodeltestapp/breadcrumbswidget.cpp
  tests/proxymodeltestapp/breadcrumbswidget.h
  tests/proxymodeltestapp/checkablewidget.cpp
  tests/proxymodeltestapp/checkablewidget.h
  tests/proxymodeltestapp/descendantpmwidget.cpp
  tests/proxymodeltestapp/descendantpmwidget.h
  tests/proxymodeltestapp/kidentityproxymodelwidget.cpp
  tests/proxymodeltestapp/kidentityproxymodelwidget.h
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.h
  tests/proxymodeltestapp/lessthanwidget.cpp
  tests/proxymodeltestapp/lessthanwidget.h
  tests/proxymodeltestapp/main.cpp
  tests/proxymodeltestapp/mainwindow.cpp
  tests/proxymodeltestapp/mainwindow.h
  tests/proxymodeltestapp/matchcheckingwidget.cpp
  tests/proxymodeltestapp/matchcheckingwidget.h
  tests/proxymodeltestapp/modelcommanderwidget.cpp
  tests/proxymodeltestapp/modelcommanderwidget.h
  tests/proxymodeltestapp/proxyitemselectionwidget.cpp
  tests/proxymodeltestapp/proxyitemselectionwidget.h
  tests/proxymodeltestapp/proxymodeltestwidget.cpp
  tests/proxymodeltestapp/proxymodeltestwidget.h
  

D26951: Remove old code that is not used anymore

[David Redondo]

davidre added a comment.


  I just took a look at KSelector and it actually inherits minimum and maximum 
properties from QAbstractSlider so we could just drop these custom properties 
for KF6

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:db859852b577: Remove old code that is not used anymore 
(authored by davidre).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26951?vs=74856=74857

REVISION DETAIL
  https://phabricator.kde.org/D26951

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D26951

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22801: [KIO] silence a QFileInfo warning

[David Faure]

dfaure added a comment.


  I disagree. Invalid method call, you get a warning already from Qt, no need 
to bloat this method more.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks, dfaure
Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

[David Redondo]

davidre updated this revision to Diff 74856.
davidre added a comment.


  Update comment

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26951?vs=74450=74856

BRANCH
  arcpatch-D26951

REVISION DETAIL
  https://phabricator.kde.org/D26951

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22801: [KIO] silence a QFileInfo warning

[René J . V . Bertin]

rjvbb added a comment.


  I might (if I can find the trouble location) but IMHO KIO should still 
account for the possibility of this situation too (or more in general, bail out 
this function for any path that cannot be a mountpoint).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks, dfaure
Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Fixing QNetworkAccessManager use for KDE services

[Friedrich W. H. Kossebau]

Hi Ben,

sorry to hear about this pain you have in all the good work you do that allows 
us to enjoy the high reliability of the KDE services. I would like to help to 
reduce that pain.

Am Samstag, 1. Februar 2020, 23:24:14 CET schrieb Ben Cooksley:
> Hi all,
> 
> For an extremely long time now, it has been a known issue with the
> QNetworkAccessManager that by default it does not follow redirects as
> issued by the server it is accessing. This is something the Qt Project
> has refused to address using the justification of 'behavioural
> compatibility'

This justification makes sense to me. People who have had in their code manual 
redirect handling would not be happy if Qt suddenly starts to do things 
internally in potentially other ways.

Also are they announcing in the API dox to consider changing the default:
"For backwards compatibility the default value is 
QNetworkRequest::ManualRedirectPolicy. This may change in the future and some 
type of auto-redirect policy will become the default; clients relying on 
manual redirect handling are encouraged to set this policy explicitly in their 
code."
https://doc.qt.io/qt-5/qnetworkaccessmanager.html#setRedirectPolicy

> This behaviour is contrary to that of just about every other HTTP
> stack (with the exception of libcurl from my understanding) and is
> behaviour that nobody expects.

In my case it would be: nobody thought about.
When talking to a given hardcoded address, e.g. to query a data blob, and it 
no longer resolves I would rather expect by default that the service is no 
longer existing. Mentally driven by C++ ABI concepts that method names & 
signatures have to be stable ;)
Possibly admins/web service developers might think different, as they might 
like to be flexible under which urls to respond to requests, given redirects 
exists in the protocol and thus invite to be used.
Might be a clash of cultures to some degree.

> As a consequence of this (broken) behaviour, Sysadmin has been
> effectively forced to implement workarounds and other compatibility
> measures in place to keep applications functional.

It is also the consequence of no developers having picked up the new built-in 
redirect accepting options having appeared in Qt 5.6 or 5.9 (more control).
And they have not done so because they (at least me) have not been aware that 
KDE sysadmins would like to be flexible when it comes to data/web services on 
KDE servers and the addresses under which they are available. See below for 
proposal how to fix that.

[...]

> Therefore, given the Qt Project is unlikely to change their position
> on this, I would like to propose the following:
> 1) That effective immediately, QNetworkAccessManager and it's children
> classes be banned and prohibited within KDE software, to be enforced
> by server side hooks.
> 2) That we fork QNetworkAccessManager and the associated classes
> within the appropriate Framework (to be determined), where the
> defective behaviour can then be corrected.

I cannot see how both help with released code out there already in the wild. 
To prepare future released code to be supportive to your redirecting desires 
when it comes to KDE services, I would rather propose this:

A) Document the need to enable redirects in requests when using KDE server 
services in the coding policies as well in the documentation of the respective 
KDE services, including code examples how to write those.
B) Have a rally to fix all current code.
C) Have an issue on bugreports.qt.io to see that Qt 6 will have changed the 
default, to what web service developers/admins would prefer.

E.g. in KDevelop code there is a query for https://projects.kde.org/
kde_projects.xml. What kind of redirect support do KDE server admins expect to 
be supported? So what QNetworkRequest::RedirectPolicy value should be set? 
What QNetworkRequest::maximumRedirectsAllowed?
Ideally one could find answers to these questions on community.kde.org.

Cheers
Friedrich

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23879

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I don't really know KConfigDialogManager. But indeed KSelector has properties 
with those names so if someone wanted to use e.g. KGradientSelector here it 
sounds like this would be useful -> just adjust the comment?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Re: D26877: Simplify calls to whitespace() and use it in more places.

[Tomaz Canabrava]

I like indentedStream.


On Sun, 2 Feb 2020 at 11:36 David Faure  wrote:

> dfaure requested changes to this revision.
> dfaure added a comment.
> This revision now requires changes to proceed. View Revision
> 
>
> I don't like it either. It doesn't "read" well.
> Looking at cout or qDebug it's much more common to [the usual stream] <<
> [some modifier] << some more stuff.
>
> Maybe it can be solved with naming though.
> indentedStream() << ...
> ?
>
> *REPOSITORY*
> R237 KConfig
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D26877
>
> *To: *tcanabrava, dfaure, ervin
> *Cc: *kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
>

D26877: Simplify calls to whitespace() and use it in more places.

[Tomaz Canabrava]

tcanabrava added a subscriber: ervin.
tcanabrava added a comment.


  I like indentedStream.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26877

To: tcanabrava, dfaure, ervin
Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26877: Simplify calls to whitespace() and use it in more places.

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I don't like it either. It doesn't "read" well.
  Looking at cout or qDebug it's much more common to `[the usual stream] << 
[some modifier] << some more stuff`.
  
  Maybe it can be solved with naming though.
  indentedStream() << ... 
  ?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26877

To: tcanabrava, dfaure, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Well spotted.
  
  Sorry for the delay in my review.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25301

To: meven, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22801: [KIO] silence a QFileInfo warning

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  The bug is in the caller, fix it there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22801

To: rjvbb, #frameworks, dfaure
Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25302: Remove stale symlink

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks ok, although a unittest would have been even better.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D25302

To: sandsmark, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in jobtest.cpp:2045
> Making an ioslave reading an env var for testing purposes is not a great 
> alternative.

Does this mean the file could be made smaller again?

(to reduce disk-space requirements)

> file_unix.cpp:317
> +
> +if (testMode) {
> +QThread::usleep(150);

Maybe in testMode, the slave can become particularly slow for one given 
filename. 
E.g. if (testMode && fileName.contains("slow"))

This way, for other files, it remains fast, and for that one file it can be 
really reliably slow (possibly sleeping for a whole second, or something like 
that).

It also makes the more generically named "KIOSLAVE_FILE_ENABLE_TESTMODE" 
available for enabling other kinds of "test mode" in the ioslave (the filename 
acting as an additional switch).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

[Simon Depiets]

sdepiets added a comment.


  In D26342#585867 , @mludwig wrote:
  
  > I'd support such a change for the BackgroundChecker as well. KTextEditor 
needs a way to do its own language detection or override the detected language.
  
  
  I've updated the diff

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

[Simon Depiets]

sdepiets updated this revision to Diff 74851.
sdepiets added a comment.


  Allow overriding to disable auto language detection in BackGround Checker

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26342?vs=72540=74851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26342

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h

To: sdepiets, #frameworks
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27097: Port from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  A couple of notes:
  
  - "Incremental" search isn't used by anything in KDE, AFAICS from 
lxr.kde.org, remove it (in a separate diff)?
  - Nothing in KDE uses the static KFind::find(... QRegExp..) directly; should 
we make the new one that takes a QRegularExpression private? the same question 
applies to KReplace::replce(... QRegExp).

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27097

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.14/6/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sun, 02 Feb 2020 09:49:19 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 156 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/156/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 02 Feb 2020 09:43:24 +
 Build duration:
5 min 48 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.67.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6927/9112)43%
(10794/24836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2897/2990)49%
(6191/12720)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/799)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 85 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/85/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 02 Feb 2020 09:38:24 +
 Build duration:
3 min 56 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)85%
(73/86)85%
(73/86)71%
(5716/8104)48%
(2479/5189)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)96%
(1522/1589)50%
(667/1344)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services100%
(30/30)100%
(30/30)63%
(1919/3060)42%
(746/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2079/2747)60%
(1014/1677)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/82/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 02 Feb 2020 09:38:24 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 111 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/111/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 02 Feb 2020 09:38:24 +
 Build duration:
2 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)85%
(73/86)85%
(73/86)71%
(5717/8104)48%
(2479/5189)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)96%
(1522/1589)50%
(667/1344)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services100%
(30/30)100%
(30/30)63%
(1919/3060)42%
(746/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2080/2747)60%
(1014/1677)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

D27097: Port from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, mlaurent, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Port QRegExp::setMinimal() by making the regex pattern non-greedy, where
  possible.
  
  Deprecate the KFind::find() and KReplace::replace() methods that take a
  QRegExp.

REPOSITORY
  R310 KTextWidgets

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27097

AFFECTED FILES
  autotests/kfindtest.cpp
  autotests/kfindtest.h
  autotests/krichtextedittest.cpp
  src/CMakeLists.txt
  src/findreplace/kfind.cpp
  src/findreplace/kfind.h
  src/findreplace/kfind_p.h
  src/findreplace/kfinddialog.cpp
  src/findreplace/kreplace.cpp
  src/findreplace/kreplace.h
  src/widgets/krichtextedit.cpp

To: ahmadsamir, #frameworks, mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 84 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/84/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 02 Feb 2020 09:23:09 +
 Build duration:
6 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(71/86)83%
(71/86)61%
(4943/8085)39%
(2045/5187)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)72%
(1150/1588)31%
(423/1344)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services93%
(28/30)93%
(28/30)50%
(1516/3042)31%
(551/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2081/2747)61%
(1019/1675)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 110 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/110/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 02 Feb 2020 09:23:08 +
 Build duration:
6 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(71/86)83%
(71/86)61%
(4943/8085)39%
(2041/5187)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)72%
(1150/1588)31%
(421/1344)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services93%
(28/30)93%
(28/30)50%
(1516/3042)31%
(551/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2081/2747)61%
(1017/1675)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/14/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sun, 02 Feb 2020 09:23:08 +
 Build duration:
2 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/81/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 02 Feb 2020 09:23:08 +
 Build duration:
1 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 109 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/109/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 02 Feb 2020 09:19:08 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 311 lines...][2020-02-02T09:20:17.348Z] -- Generating done[2020-02-02T09:20:17.348Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-02T09:20:18.242Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kservice --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-02T09:20:18.504Z] Scanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8[2020-02-02T09:20:18.504Z] [  1%] Generating kbuildsycoca5.8[2020-02-02T09:20:19.541Z] Note: Writing kbuildsycoca5.8[2020-02-02T09:20:19.541Z] [  1%] Built target docs-kbuildsycoca5-kbuildsycoca5-8[2020-02-02T09:20:19.541Z] Scanning dependencies of target KF5Config_QCH[2020-02-02T09:20:19.541Z] [  1%] Built target KF5Config_QCH[2020-02-02T09:20:19.541Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-02-02T09:20:19.541Z] [  1%] Built target KF5CoreAddons_QCH[2020-02-02T09:20:19.541Z] Scanning dependencies of target copy_servicetypes[2020-02-02T09:20:19.541Z] [  1%] Built target copy_servicetypes[2020-02-02T09:20:19.541Z] Scanning dependencies of target KF5Service_QCH[2020-02-02T09:20:19.541Z] [  2%] Generating src/KF5Service.qch, src/KF5Service.tags[2020-02-02T09:20:20.511Z] Building up file structure...[2020-02-02T09:20:20.511Z] Insert custom filters...[2020-02-02T09:20:20.511Z] Insert help data for filter section (1 of 1)...[2020-02-02T09:20:20.511Z] Insert files...[2020-02-02T09:20:20.511Z] Insert contents...[2020-02-02T09:20:20.511Z] Insert indices...[2020-02-02T09:20:20.511Z] Documentation successfully generated.[2020-02-02T09:20:20.779Z] [  2%] Built target KF5Service_QCH[2020-02-02T09:20:20.779Z] Scanning dependencies of target copy_menu[2020-02-02T09:20:20.779Z] [  2%] Built target copy_menu[2020-02-02T09:20:20.779Z] Scanning dependencies of target docs-desktoptojson-desktoptojson-8[2020-02-02T09:20:20.779Z] [  2%] Generating desktoptojson.8[2020-02-02T09:20:21.370Z] Note: Writing desktoptojson.8[2020-02-02T09:20:21.637Z] [  2%] Built target docs-desktoptojson-desktoptojson-8[2020-02-02T09:20:21.637Z] Scanning dependencies of target KF5Service_autogen[2020-02-02T09:20:21.637Z] [  3%] Automatic MOC for target KF5Service[2020-02-02T09:20:22.224Z] [  3%] Built target KF5Service_autogen[2020-02-02T09:20:22.224Z] [  4%] Generating klauncher_iface.cpp, klauncher_iface.h[2020-02-02T09:20:22.224Z] [  5%] [FLEX][TraderLexer] Building scanner with flex 2.6.4[2020-02-02T09:20:22.488Z] [  5%] [BISON][TraderParser] Building parser with bison 3.5[2020-02-02T09:20:22.488Z] services/yacc.y:83.1-12: warning: deprecated directive: ���%pure-parser���, use ���%define api.pure��� [-Wdeprecated][2020-02-02T09:20:22.488Z]83 | %pure-parser[2020-02-02T09:20:22.488Z]   | ^~~~[2020-02-02T09:20:22.488Z]   | %define api.pure[2020-02-02T09:20:22.488Z] services/yacc.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother][2020-02-02T09:20:22.488Z] [  6%] Generating klauncher_iface.moc[2020-02-02T09:20:23.068Z] Scanning dependencies of target KF5Service[2020-02-02T09:20:23.068Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/KF5Service_autogen/mocs_compilation.cpp.o[2020-02-02T09:20:24.478Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservice.cpp.o[2020-02-02T09:20:27.804Z] [  7%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kserviceaction.cpp.o[2020-02-02T09:20:29.210Z] [  8%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicefactory.cpp.o[2020-02-02T09:20:31.157Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicegroup.cpp.o[2020-02-02T09:20:33.734Z] [ 10%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicegroupfactory.cpp.o[2020-02-02T09:20:34.687Z] [ 10%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kserviceoffer.cpp.o[2020-02-02T09:20:36.078Z] [ 11%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetype.cpp.o[2020-02-02T09:20:38.019Z] [ 12%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypefactory.cpp.o[2020-02-02T09:20:39.989Z] [ 13%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypeprofile.cpp.o[2020-02-02T09:20:41.928Z] [ 13%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypetrader.cpp.o[2020-02-02T09:20:43.340Z] [ 14%] Building CXX object src/CMakeFiles/KF5Service.dir/services/ktraderparse.cpp.o[2020-02-02T09:20:45.259Z] [ 15%] Building CXX object 

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.14/13/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sun, 02 Feb 2020 09:19:08 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 289 lines...][2020-02-02T09:20:04.989Z]  * KF5CoreAddons (required version >= 5.67.0)[2020-02-02T09:20:04.989Z]  * KF5Crash (required version >= 5.67.0)[2020-02-02T09:20:04.989Z]  * KF5DBusAddons (required version >= 5.67.0)[2020-02-02T09:20:04.989Z]  * Gettext[2020-02-02T09:20:04.989Z]  * KF5I18n (required version >= 5.67.0)[2020-02-02T09:20:04.989Z]  * FLEX, Fast Lexical Analyzer, [2020-02-02T09:20:04.989Z]Required for the Trader parser[2020-02-02T09:20:04.989Z]  * BISON (required version >= 2.4.1), general-purpose parser generator, [2020-02-02T09:20:04.989Z]Required for the Trader parser[2020-02-02T09:20:04.989Z]  * Doxygen (required version >= 1.8.13)[2020-02-02T09:20:04.989Z]Needed for API dox QCH file generation[2020-02-02T09:20:04.989Z]  * QHelpGenerator, Part of Qt5 tools[2020-02-02T09:20:04.989Z]Needed for API dox QCH file generation[2020-02-02T09:20:04.989Z]  * Qt5Concurrent[2020-02-02T09:20:04.989Z]  * Qt5Test[2020-02-02T09:20:04.989Z]  * Qt5 (required version >= 5.12.0)[2020-02-02T09:20:04.989Z] [2020-02-02T09:20:04.989Z] -- Configuring done[2020-02-02T09:20:05.935Z] -- Generating done[2020-02-02T09:20:05.935Z] -- Build files have been written to: C:/CI/Job Build/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2020-02-02T09:20:06.734Z] [2020-02-02T09:20:06.734Z] C:\CI\Job Build>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" [2020-02-02T09:20:06.734Z] **[2020-02-02T09:20:06.734Z] ** Visual Studio 2019 Developer Command Prompt v16.4.3[2020-02-02T09:20:06.734Z] ** Copyright (c) 2019 Microsoft Corporation[2020-02-02T09:20:06.734Z] **[2020-02-02T09:20:07.679Z] [vcvarsall.bat] Environment initialized for: 'x64'[2020-02-02T09:20:08.287Z] [1/127] Running utility command for copy_servicetypes[2020-02-02T09:20:08.288Z] [2/127] Running utility command for copy_menu[2020-02-02T09:20:09.367Z] [3/127] Generating kbuildsycoca5.8[2020-02-02T09:20:09.367Z] Note: Writing kbuildsycoca5.8[2020-02-02T09:20:10.010Z] [4/127] Generating desktoptojson.8[2020-02-02T09:20:10.010Z] Note: Writing desktoptojson.8[2020-02-02T09:20:10.649Z] [5/127] Automatic MOC for target KF5Service[2020-02-02T09:20:10.649Z] [6/127] [FLEX][TraderLexer] Building scanner with flex 2.6.4[2020-02-02T09:20:10.649Z] [7/127] Generating klauncher_iface.cpp, klauncher_iface.h[2020-02-02T09:20:10.926Z] [8/127] Generating klauncher_iface.moc[2020-02-02T09:20:11.240Z] [9/127] [BISON][TraderParser] Building parser with bison 3.0.4[2020-02-02T09:20:19.718Z] [10/127] Generating src/KF5Service.qch, src/KF5Service.tags[2020-02-02T09:20:23.296Z] [11/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kmimetypefactory.cpp.obj[2020-02-02T09:20:23.296Z] [12/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kserviceaction.cpp.obj[2020-02-02T09:20:23.296Z] [13/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kmimetypetrader.cpp.obj[2020-02-02T09:20:23.296Z] [14/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kservicetypeprofile.cpp.obj[2020-02-02T09:20:23.296Z] [15/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kautostart.cpp.obj[2020-02-02T09:20:23.296Z] [16/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kservicegroupfactory.cpp.obj[2020-02-02T09:20:23.296Z] [17/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kservicefactory.cpp.obj[2020-02-02T09:20:23.296Z] [18/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kservicetype.cpp.obj[2020-02-02T09:20:23.296Z] [19/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kserviceoffer.cpp.obj[2020-02-02T09:20:23.569Z] [20/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kservicegroup.cpp.obj[2020-02-02T09:20:23.569Z] ..\src\services\kservicegroup.cpp(414): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2020-02-02T09:20:24.172Z] [21/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\kservice.cpp.obj[2020-02-02T09:20:25.164Z] [22/127] Building CXX object src\CMakeFiles\KF5Service.dir\kdeinit\ktoolinvocation.cpp.obj[2020-02-02T09:20:25.453Z] [23/127] Building CXX object src\CMakeFiles\KF5Service.dir\sycoca\ksycocadevices.cpp.obj[2020-02-02T09:20:25.742Z] [24/127] Building CXX object src\CMakeFiles\KF5Service.dir\services\ktraderparse.cpp.obj[2020-02-02T09:20:26.013Z] [25/127] Building CXX object 

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/83/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 02 Feb 2020 09:19:08 +
 Build duration:
1 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 305 lines...][2020-02-02T09:20:08.785Z]   exclude them by setting the source file property SKIP_AUTOMOC:[2020-02-02T09:20:08.785Z] [2020-02-02T09:20:08.785Z] set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)[2020-02-02T09:20:08.785Z] [2020-02-02T09:20:08.785Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-02-02T09:20:08.785Z] [2020-02-02T09:20:08.785Z] -- Generating done[2020-02-02T09:20:08.785Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-02T09:20:09.617Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kservice --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-02-02T09:20:09.879Z] Scanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8[2020-02-02T09:20:09.879Z] [  1%] Generating kbuildsycoca5.8[2020-02-02T09:20:10.456Z] Note: Writing kbuildsycoca5.8[2020-02-02T09:20:10.456Z] [  1%] Built target docs-kbuildsycoca5-kbuildsycoca5-8[2020-02-02T09:20:10.456Z] Scanning dependencies of target KF5Config_QCH[2020-02-02T09:20:10.456Z] [  1%] Built target KF5Config_QCH[2020-02-02T09:20:10.456Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-02-02T09:20:10.456Z] [  1%] Built target KF5CoreAddons_QCH[2020-02-02T09:20:10.456Z] Scanning dependencies of target copy_servicetypes[2020-02-02T09:20:10.456Z] [  1%] Built target copy_servicetypes[2020-02-02T09:20:10.456Z] Scanning dependencies of target KF5Service_QCH[2020-02-02T09:20:10.456Z] [  2%] Generating src/KF5Service.qch, src/KF5Service.tags[2020-02-02T09:20:11.025Z] Building up file structure...[2020-02-02T09:20:11.025Z] Insert custom filters...[2020-02-02T09:20:11.025Z] Insert help data for filter section (1 of 1)...[2020-02-02T09:20:11.025Z] Insert files...[2020-02-02T09:20:11.025Z] Insert contents...[2020-02-02T09:20:11.025Z] Insert indices...[2020-02-02T09:20:11.025Z] Documentation successfully generated.[2020-02-02T09:20:11.025Z] [  2%] Built target KF5Service_QCH[2020-02-02T09:20:11.025Z] Scanning dependencies of target copy_menu[2020-02-02T09:20:11.025Z] [  2%] Built target copy_menu[2020-02-02T09:20:11.025Z] Scanning dependencies of target docs-desktoptojson-desktoptojson-8[2020-02-02T09:20:11.025Z] [  2%] Generating desktoptojson.8[2020-02-02T09:20:11.595Z] Note: Writing desktoptojson.8[2020-02-02T09:20:11.595Z] [  2%] Built target docs-desktoptojson-desktoptojson-8[2020-02-02T09:20:11.595Z] Scanning dependencies of target KF5Service_autogen[2020-02-02T09:20:11.595Z] [  3%] Automatic MOC for target KF5Service[2020-02-02T09:20:11.858Z] [  3%] Built target KF5Service_autogen[2020-02-02T09:20:12.117Z] [  4%] Generating klauncher_iface.cpp, klauncher_iface.h[2020-02-02T09:20:12.117Z] [  5%] [FLEX][TraderLexer] Building scanner with flex 2.6.4[2020-02-02T09:20:12.117Z] [  5%] [BISON][TraderParser] Building parser with bison 3.5[2020-02-02T09:20:12.117Z] services/yacc.y:83.1-12: warning: deprecated directive: ���%pure-parser���, use ���%define api.pure��� [-Wdeprecated][2020-02-02T09:20:12.117Z]83 | %pure-parser[2020-02-02T09:20:12.117Z]   | ^~~~[2020-02-02T09:20:12.117Z]   | %define api.pure[2020-02-02T09:20:12.117Z] services/yacc.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother][2020-02-02T09:20:12.117Z] [  6%] Generating klauncher_iface.moc[2020-02-02T09:20:12.380Z] Scanning dependencies of target KF5Service[2020-02-02T09:20:12.380Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/KF5Service_autogen/mocs_compilation.cpp.o[2020-02-02T09:20:13.324Z] [  7%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetype.cpp.o[2020-02-02T09:20:14.707Z] [  8%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypefactory.cpp.o[2020-02-02T09:20:15.647Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypeprofile.cpp.o[2020-02-02T09:20:17.036Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypetrader.cpp.o[2020-02-02T09:20:18.420Z] [ 10%] Building CXX object src/CMakeFiles/KF5Service.dir/services/ktraderparse.cpp.o[2020-02-02T09:20:18.988Z] [ 11%] Building CXX object src/CMakeFiles/KF5Service.dir/services/ktraderparsetree.cpp.o[2020-02-02T09:20:19.927Z] [ 12%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kplugininfo.cpp.o[2020-02-02T09:20:21.838Z] [ 13%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/ksycoca.cpp.o[2020-02-02T09:20:23.758Z] [ 13%] Building CXX object 

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/80/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 02 Feb 2020 09:19:08 +
 Build duration:
1 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 291 lines...][2020-02-02T09:20:09.480Z] [  6%] Generating klauncher_iface.moc[2020-02-02T09:20:09.480Z] services/yacc.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother][2020-02-02T09:20:09.753Z] Scanning dependencies of target KF5Service[2020-02-02T09:20:10.061Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/KF5Service_autogen/mocs_compilation.cpp.o[2020-02-02T09:20:10.061Z] [  7%] Building CXX object src/CMakeFiles/KF5Service.dir/kdeinit/ktoolinvocation.cpp.o[2020-02-02T09:20:10.061Z] [  8%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kautostart.cpp.o[2020-02-02T09:20:10.061Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kmimetypefactory.cpp.o[2020-02-02T09:20:10.061Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservice.cpp.o[2020-02-02T09:20:10.061Z] [ 10%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kmimetypetrader.cpp.o[2020-02-02T09:20:10.061Z] [ 11%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kserviceaction.cpp.o[2020-02-02T09:20:10.061Z] [ 12%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicefactory.cpp.o[2020-02-02T09:20:10.061Z] [ 13%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicegroup.cpp.o[2020-02-02T09:20:10.061Z] [ 14%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicegroupfactory.cpp.o[2020-02-02T09:20:10.061Z] [ 14%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kserviceoffer.cpp.o[2020-02-02T09:20:14.529Z] [ 15%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetype.cpp.o[2020-02-02T09:20:14.529Z] [ 16%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypefactory.cpp.o[2020-02-02T09:20:14.529Z] [ 17%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypeprofile.cpp.o[2020-02-02T09:20:14.529Z] [ 17%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kservicetypetrader.cpp.o[2020-02-02T09:20:14.529Z] [ 18%] Building CXX object src/CMakeFiles/KF5Service.dir/services/ktraderparse.cpp.o[2020-02-02T09:20:15.580Z] [ 19%] Building CXX object src/CMakeFiles/KF5Service.dir/services/ktraderparsetree.cpp.o[2020-02-02T09:20:15.896Z] [ 20%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kplugininfo.cpp.o[2020-02-02T09:20:16.552Z] [ 21%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/ksycoca.cpp.o[2020-02-02T09:20:16.836Z] Building up file structure...[2020-02-02T09:20:16.836Z] Insert custom filters...[2020-02-02T09:20:16.836Z] Insert help data for filter section (1 of 1)...[2020-02-02T09:20:16.836Z] Insert files...[2020-02-02T09:20:16.836Z] Insert contents...[2020-02-02T09:20:16.836Z] Insert indices...[2020-02-02T09:20:16.836Z] Documentation successfully generated.[2020-02-02T09:20:17.457Z] [ 22%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/ksycocadict.cpp.o[2020-02-02T09:20:17.457Z] [ 22%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/ksycocadevices.cpp.o[2020-02-02T09:20:20.229Z] [ 23%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/ksycocafactory.cpp.o[2020-02-02T09:20:20.229Z] [ 24%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/ksycocaentry.cpp.o[2020-02-02T09:20:20.229Z] [ 25%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kmemfile.cpp.o[2020-02-02T09:20:20.229Z] [ 26%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kbuildservicefactory.cpp.o[2020-02-02T09:20:20.229Z] [ 26%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kbuildmimetypefactory.cpp.o[2020-02-02T09:20:20.229Z] [ 27%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kbuildservicetypefactory.cpp.o[2020-02-02T09:20:20.229Z] [ 27%] Built target KF5Service_QCH[2020-02-02T09:20:20.519Z] [ 27%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kbuildsycoca.cpp.o[2020-02-02T09:20:20.519Z] [ 28%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kbuildservicegroupfactory.cpp.o[2020-02-02T09:20:20.519Z] [ 29%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kctimefactory.cpp.o[2020-02-02T09:20:21.597Z] [ 30%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/kmimeassociations.cpp.o[2020-02-02T09:20:21.597Z] [ 31%] Building CXX object src/CMakeFiles/KF5Service.dir/sycoca/vfolder_menu.cpp.o[2020-02-02T09:20:22.588Z] [ 32%] Building CXX object src/CMakeFiles/KF5Service.dir/plugin/kplugintrader.cpp.o[2020-02-02T09:20:24.084Z] [ 32%] Building CXX object src/CMakeFiles/KF5Service.dir/plugin/kdbusservicestarter.cpp.o[2020-02-02T09:20:24.084Z] [ 33%] Building CXX object src/CMakeFiles/KF5Service.dir/servicesdebug.cpp.o[2020-02-02T09:20:24.084Z] [ 34%] Building 

D27082: [Tests]Make radiobutton3.qml use PC3

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Regardless of issues, the change for the test is correct.
  
  We should break the test to highlight issues. Ship it!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart