D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. So I think this is ready to be merged and I would do so this weekend REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham, cfeck Cc: apol, cfeck, dhaumann,

D27508: Remove unnecessary monochrome app icons

ndavis added a comment. T10413 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27508 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27508: Remove unnecessary monochrome app icons

ngraham abandoned this revision. ngraham added a comment. What's the phab task you filed about this again? I can't find it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27508 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 311 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/311/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 21 Feb 2020 04:42:11 + Build duration: 8 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 303 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/303/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 21 Feb 2020 04:42:12 + Build duration: 6 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 436 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/436/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Feb 2020 04:42:12 + Build duration: 5 min 49 sec and counting BUILD ARTIFACTS

D27245: Ki18n: Convert license headers to SPDX statements

kossebau added a comment. What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root directory? Could that not be removed given the new copy `LICENSES/LGPL-2.1-only.txt`? Or are both copies required? If so, why? Similar question also for any other repo. REPOSITORY R249

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/110/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 21 Feb 2020 01:49:37 + Build duration: 1 min 34 sec and counting JUnit Tests Name:

D27535: Add XdgOutputV1 version 2

apol added a comment. +1 LGTM INLINE COMMENTS > xdgoutput_interface.cpp:319 > +} > +if (wl_resource_get_version(d->resource) < > ZXDG_OUTPUT_V1_DESCRIPTION_SINCE_VERSION) { > +return; noob question: what would happen if you didn't have this check? REPOSITORY R127

D27535: Add XdgOutputV1 version 2

davidedmundson updated this revision to Diff 76077. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27535?vs=76076=76077 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27535 AFFECTED FILES

D27535: Add XdgOutputV1 version 2

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Will be useful for making plasma widgets not move about on multi

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added inline comments. INLINE COMMENTS > kateviewhelpers.cpp:1963 > const int s = qMin(m_iconAreaWidth * > devicePixelRatioF(), h * devicePixelRatioF()) - 2; > -px_mark = px_mark.scaled(s, s, > Qt::KeepAspectRatio,

D21795: [KAuth] Add support for action details in Polkit1 backend.

feverfew added a comment. Ok I've commandeered this on request, as we're so close to getting this done. I've simply addressed sitter's comments here seeming as they're simple enough to do so without understanding the code that well. I haven't actually tested this in any capacity, as again,

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added a comment. See e.g. how bookmark mark symbols become crisp in bigger sizes (though they take advantage currently in being mostly regular lines and thus partially cope with pixelscaling): F8116357: Screenshot_20200221_003940.png

Re: Submitting Grantlee as a KF5 Framework

Hi Daniel, Am Donnerstag, 20. Februar 2020, 22:14:29 CET schrieb Daniel Nicoletti: > Yes, an user just raised an issue which I fixed in one PR, > however the PR is 5yo, should I redo it in gitlab? > Shouldn't the GitHub repo be removed or marked as moved to KDE? Seems you missed that Grantlee

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added a comment. https://invent.kde.org/kde/kate/merge_requests/68 would be the respective patch for Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n,

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau created this revision. kossebau added reviewers: Kate, KDevelop. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY Symbols used for marks can be used in different sizes,

D27520: add readdirplus2 support for samba>=4.12

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but please wait for @asn's undoubtedly more expert review. :) REPOSITORY R320 KIO Extras BRANCH readdirplus2 REVISION DETAIL https://phabricator.kde.org/D27520 To: sitter,

D27508: Remove unnecessary monochrome app icons

ndavis added a comment. In D27508#614856 , @ngraham wrote: > Removing the monochrome system-help icon is what's needed to fix 417879, though. If we can't do that, then we can't fix the bug. We're back to needing to solve the fundamental

D27508: Remove unnecessary monochrome app icons

ngraham added a comment. Removing the monochrome system-help icon is what's needed to fix 417879, though. If we can't do that, then we can't fix the bug. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27508 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel,

D21795: [KAuth] Add support for action details in Polkit1 backend.

feverfew updated this revision to Diff 76073. feverfew added a comment. - add const & REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=76071=76073 BRANCH arcpatch-D21795 REVISION DETAIL https://phabricator.kde.org/D21795 AFFECTED FILES

Re: Banning QNetworkAccessManager

El dijous, 20 de febrer de 2020, a les 14:29:47 CET, Allen Winter va escriure: > On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > > escriure: > > > Additionally, improved documentation, a possible

D21795: [KAuth] Add support for action details in Polkit1 backend.

feverfew updated this revision to Diff 76071. feverfew marked 4 inline comments as done. feverfew added a comment. - Rebase - Respond to sitter's comments REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=63880=76071 BRANCH arcpatch-D21795

D21795: [KAuth] Add support for action details in Polkit1 backend.

feverfew commandeered this revision. feverfew added a reviewer: chinmoyr. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter,

Re: Submitting Grantlee as a KF5 Framework

Yes, an user just raised an issue which I fixed in one PR, however the PR is 5yo, should I redo it in gitlab? Shouldn't the GitHub repo be removed or marked as moved to KDE? Em sáb., 21 de dez. de 2019 às 10:23, Friedrich W. H. Kossebau < kosse...@kde.org> escreveu: > Hi Stephen, > > Am Samstag,

D26983: Enable adding place as first child

gvgeo added a comment. After some digging, I found that KBookmarkGroup has more items that the KFilePlacesModel. It is impossible to make `KBookmark` move at the end of a `BookmarkGroup`, if the item is not in the `KFilePlacesModel`. I don't see a better solution than the current

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella added a comment. Thanks for the patch, makes sense. Please make the commit message a bit more elaborate REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: kde-frameworks-devel,

D27528: Adapt action numbering in Android to work like in KNotifications

jbbgameich added reviewers: nicolasfella, vkrause. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Couple of screenshots more from this patch: F8115905: Screenshot_20200220_194559.png F8115907: Screenshot_20200220_194611.png F8115910: Screenshot_20200220_194622.png

D27528: Adapt action numbering in Android to work like in KNotifications

cacahueto created this revision. cacahueto added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cacahueto requested review of this revision. REPOSITORY R289 KNotifications BRANCH

D27444: Added top area

niccolove added a comment. In D27444#614762 , @mart wrote: > - i would provide one single svg with top and bottom areas so one can use something like that as a footer as well (and probably a frame that has nothing rounded) > - if you have a

D27444: Added top area

mart added a comment. i also wonder if the normal "toolbar2 element already existing can be used.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27444: Added top area

mart added a comment. some considerations: - this toparea will need to "overflow" its parent for the exact distance needed to perfectly fuse with the background, and has to work with both dialogs and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the exact same

D27527: Add new `smiley-add` icons

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY FEATURE: 417298 FIXED-IN: 5.68 TEST PLAN F8115850: smiley-add.png

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 20 Feb 2020 16:55:45 + Build duration: 1 min 57 sec and counting JUnit Tests

Re: Banning QNetworkAccessManager

El jue., 20 de feb. de 2020 a la(s) 10:30, Allen Winter (win...@kde.org) escribió: > > On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > > escriure: > > > Additionally, improved documentation, a

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.14 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.14/10/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 20 Feb 2020 14:41:19 + Build duration: 31 min and counting JUnit Tests

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

apol added a comment. +1 code looks much better! REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham, cfeck Cc: apol, cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n,

D27520: add readdirplus2 support for samba>=4.12

sitter created this revision. sitter added reviewers: ngraham, asn. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY unlike the dirent itering we do not need a separate stat call

Re: Banning QNetworkAccessManager

On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > escriure: > > Additionally, improved documentation, a possible KNAM and/or driving the > > QNAM > > changes upstream can still be done alongside

D27463: KconfigXT: Add a value attribute to Enum field choices

crossi added inline comments. INLINE COMMENTS > meven wrote in KConfigXmlParser.cpp:203 > If you don't mind I am putting aside the second part as it is not directly > related to this PR, i.e name attribute validation. (FYI we had > KConfigXmlParser::validateNameAndKey) I guess there are more

D27497: Fix code generation for entries with min/max

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me INLINE COMMENTS > test_param_minmax.h.ref:25 > + { > +qDebug() << "setFoo: value " << v << " is less than the minimum > value of 0.01"; > +v = 0.01;

D27463: KconfigXT: Add a value attribute to Enum field choices

meven edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 76040. meven marked an inline comment as done. meven added a comment. Warn user about / . : being forbidden in choice's attribute name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75969=76040 BRANCH

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added inline comments. INLINE COMMENTS > bport wrote in KConfigXmlParser.cpp:203 > Can we do a test on more than ' ' value, proably solve other case. > And we probably want to limit what is a correct value, any string seems a bit > too large, some character can be problematic when we

D27463: KconfigXT: Add a value attribute to Enum field choices

bport added inline comments. INLINE COMMENTS > KConfigXmlParser.cpp:203 > } > +else if (choice.name.contains(QLatin1Char(' '))) { > +std::cerr << "Tag attribute 'name' cannot contain a > space. You can use attribute 'value' to pass any string as the choice value."

Re: Banning QNetworkAccessManager

On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > > I agree on the problem of QNAM's default,

D27508: Remove unnecessary monochrome app icons

ndavis added a comment. I don't know what hotspot is used for, but the other ones are probably used by 3rd party apps. The virt-manager and system-help icons are definitely used by 3rd party apps in places where monochrome icons should be. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27152: Introduce FilesystemEntry class

meven accepted this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: Fixing QNetworkAccessManager use

On Thu, Feb 20, 2020 at 2:09 AM Friedrich W. H. Kossebau wrote: > > Am Mittwoch, 19. Februar 2020, 08:05:01 CET schrieb Ben Cooksley: > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > It would also help to know where specifically we have that problem, so we > > > can actually solve