date:20200228

D26342: Allow overriding to disable auto language detection

2020-02-28 Thread Simon Depiets

sdepiets added a reviewer: mludwig.
sdepiets added a comment.


  Can we get some traction on this?
  It's a relatively light change that doesn't affect the default Sonnet 
behavior.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 146 - Still Unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/146/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 28 Feb 2020 23:38:51 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-28 Thread Friedrich W. H. Kossebau

kossebau added a comment.


  In D27150#619735 , @bruns wrote:
  
  > You have ommited to update the minimum ECM version in all cases AFAICS.
  
  
  Because that bump is done by the release scripts, and I did not want to mess 
with them.
  
  In general it is expected that all of ECM & KF master depends on latest 
master of their peers. The dep version is only bumped in time for release 
preparation.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: bruns, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-28 Thread Stefan Brüns

bruns added a comment.


  @kossebau - you have pushed commits depending on this change to several 
repositories, sometimes without waiting for acceptance, sometimes even 
bypassing Phabricator review completely.
  
  You have ommited to update the minimum ECM version in all cases AFAICS.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: bruns, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-28 Thread Stefan Brüns

bruns added inline comments.

INLINE COMMENTS

> CMakeLists.txt:9
>  include(FeatureSummary)
>  find_package(ECM 5.67.0 NO_MODULE)
>  set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake 
> Modules." URL "https://commits.kde.org/extra-cmake-modules;)

Obviously, this is no longer true. This now depends on an unreleased ECM 
version ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27269

To: kossebau, #build_system, #frameworks, broulik, mlaurent, dfaure
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D27178: Use ecm_qt_install_logging_categories over manual categories file

2020-02-28 Thread Stefan Brüns

bruns added inline comments.

INLINE COMMENTS

> CMakeLists.txt:7
>  include(FeatureSummary)
>  find_package(ECM 5.67.0  NO_MODULE)
>  set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake 
> Modules." URL "https://commits.kde.org/extra-cmake-modules;)

Obviously, this is no longer true. This now depends on an unreleased ECM 
version ...

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27178

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D25315: KDirModel: implement showing "/" as a root node, optionally

2020-02-28 Thread Raphael Rosch

rrosch added a comment.


  > Keep only matters for further calls to openUrl, not the first one. It's 
about whether to *add* or *replace* the currently open URL.
  >  KDirModel takes care of that.
  
  Ah ok, so it's going to do that without me needing to explicitly specify 
"Keep"?
  
  >> I couldn't however get the following to work:
  >> 
  >>   QModelIndex index = getIndexFromUrl("/home/myuser");
  > 
  > Invalid URL, that's a path, not a URL. You need QUrl::fromLocalFile().
  
  Sorry that was me using shorthand to illustrate the problem, the url in the 
code is an absolute url stored in a variable with the schema and all the 
necessary things.
  
  >> Which should show the node for "/home" as the root, but is instead giving 
me a flat listing of all the child nodes without "/home" as the root.
  > 
  > Oh, hmm, that's not how setRootIndex works (that's a *view* feature, we 
can't change that).
  >  I changed the model to have one more node for "/", while I see now that 
what you want is that it *always* shows a root node even when the root is 
another directory.
  
  Yeah that was my intent with the above. How come it doesn't work in the view 
for `file:///home/myuser` but it works for `file:///`?
  
  In any case, the code here you provided works great for at least `file:///` 
and that gets us quite far. How much of a rework would getting it to work with 
subdirectories (like `file:///home/myuser`) take?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-28 Thread Raphael Rosch

rrosch accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25315: KDirModel: implement showing "/" as a root node, optionally

2020-02-28 Thread David Faure

dfaure planned changes to this revision.
dfaure added a comment.

  In D25315#619436 , @rrosch wrote:

  > Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I 
had to change the call in my code that was originally:
  >
  >   model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep); 
  >
  > [to]   model->openUrl(QUrl::fromLocalFile("/"), KDirModel::ShowRoot);
  >  and don't really know the implications of the change at this point. (Will 
it "Keep"? Does it matter that I now call the model's openURL vs the 
dirLister's?)

  It's part of the documentation for this change, that you're actually supposed 
to call model->openUrl(). So yes it matters :-)

  Keep only matters for further calls to openUrl, not the first one. It's about 
whether to *add* or *replace* the currently open URL.
  KDirModel takes care of that.

  > I couldn't however get the following to work:
  > 
  >   QModelIndex index = getIndexFromUrl("/home/myuser");

  Invalid URL, that's a path, not a URL. You need QUrl::fromLocalFile().

  >   if (index.isValid()) {
  >   treeView->setRootIndex(index.parent());
  >   }
  > 
  >   

  > Which should show the node for "/home" as the root, but is instead giving 
me a flat listing of all the child nodes without "/home" as the root.

  Oh, hmm, that's not how setRootIndex works (that's a *view* feature, we can't 
change that).
  I changed the model to have one more node for "/", while I see now that what 
you want is that it *always* shows a root node even when the root is another 
directory.

  > (Also, it would be great to have a setRootPath() that works in conjunction 
to expandToUrl or openUrl, to save processing cycles wasted on loading the 
parts of the model that won't be shown in the new rootIndex, like 
https://doc.qt.io/qt-5/qfilesystemmodel.html#setRootPath )

  Yes it sounds like that's exactly what's needed in KDirModel. Damn, I need to 
rework all this then.

  > As it is relevant, I also tested the patch at 
http://www.davidfaure.fr/2019/kdirmodel_haschildren.diff for `hasChildren()`, 
which works as expected! Thank you!

  Thanks, posted as D27731 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-28 Thread David Faure

dfaure added a reviewer: rrosch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-28 Thread David Faure

dfaure created this revision.
dfaure added reviewers: apol, ahmadsamir, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  We either have the information at hand (in populated dirs)
  or we query the filesystem (in non-populated dirs).

TEST PLAN
  Tested by Raphael Rosch in D25315 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27731

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: dfaure, apol, ahmadsamir, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-02-28 Thread Volker Krause

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This matters for user code doing some more advanced layouting or size
  computations, especially once we remove the hardcoded minimum sizes
  in here for proper high dpi support.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27730

AFFECTED FILES
  CMakeLists.txt
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/CMakeLists.txt
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/code128barcode.cpp
  src/lib/code39barcode.cpp
  src/lib/code93barcode.cpp
  src/lib/datamatrixbarcode.cpp
  src/lib/prison.h
  src/lib/qrcodebarcode.cpp
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  tests/barcode.qml

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

2020-02-28 Thread Volker Krause

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This avoids unnecessary allocations. This also un-exports QRCodeBarcode,
  which is declared in a non-installed header file.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27727

AFFECTED FILES
  src/lib/code39barcode.cpp
  src/lib/code39barcode.h
  src/lib/code93barcode.cpp
  src/lib/code93barcode.h
  src/lib/datamatrixbarcode.cpp
  src/lib/datamatrixbarcode.h
  src/lib/qrcodebarcode.cpp
  src/lib/qrcodebarcode.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause

This revision was automatically updated to reflect the committed changes.
Closed by commit R271:417607275368: Deprecate KDBusConnectionPool (authored by 
vkrause).

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27607?vs=76316=76652

REVISION DETAIL
  https://phabricator.kde.org/D27607

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdeinitinterface.cpp

To: vkrause, davidedmundson
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-28 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, let's land that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27430

To: sommer, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
gennad, GB_2, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars, dhaumann

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

2020-02-28 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.


  I think this should go in now. I think the usage of the API is correct even 
for HiDPI.
  In KF6, we should just fold that interface into the main class.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

2020-02-28 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:978e23b2c44c: Add FreeCAD FCMacro extension to the python 
highlighting definition (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27486?vs=75942=76647#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27486?vs=75942=76647

REVISION DETAIL
  https://phabricator.kde.org/D27486

AFFECTED FILES
  data/syntax/python.xml

To: martonmiklos, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

2020-02-28 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, makes sense, will increase version myself.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27486

To: martonmiklos, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27580: Updates for CMake 3.17

2020-02-28 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:fb8e0b2777a2: Updates for CMake 3.17 (authored by 
cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27580?vs=76182=76646

REVISION DETAIL
  https://phabricator.kde.org/D27580

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27580: Updates for CMake 3.17

2020-02-28 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the update!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27580

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-28 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c41ed480a504: C++: constinit keyword and std::format 
syntax for strings. Improvement printf… (authored by jpoelen, committed by 
cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27714?vs=76591=76645#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27714?vs=76591=76645

REVISION DETAIL
  https://phabricator.kde.org/D27714

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-28 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Nice! Thanks for the improvements ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27714

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

2020-02-28 Thread David Edmundson

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The problem occurs in the following situation:
  
  Widgets and such often change state and emit they're changed on the
  initial load. This is typically a bug, but easy to hit and hard to find.
  
  To resolve this KCModule::showEvent() queues up a
  KCModule::changed(false) after loading. It hides the problem for
  widgets.
  
  This ends up causing a bigger problem for the QML side.
  
  If during load ConfigModule::setNeedsSave(true) is called we set
  d->_needsSave to true
  We emit ConfigModule::changed(true) which we proxy through to
  KCModule::changed(true)
  
  We then process the queued KCModule::setChanged(false) from the earlier
  KCModule::showEvent so we disable the button
  
  But problematically any subsequent changes in the KCM which call
  ConfigModule::setNeedsSave(true) now no-op and don't get proxied.
  
  This patch resolves the issue by keeping the syncronisation between
  KCModule and ConfigModule working in both directions.
  
  It is an alternative to D27452 . It's not 
as neat but it's safer.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27724

AFFECTED FILES
  src/kcmoduleqml.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause, davidedmundson
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause

vkrause added a comment.


  ping?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D27607

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 260 - Still Unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/260/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 28 Feb 2020 14:49:30 +
 Build duration:
2 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 152 - Still Unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/152/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 28 Feb 2020 14:49:30 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 145 - Still unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/145/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 28 Feb 2020 14:49:30 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D27628: Buttons: allow to scale up icons

2020-02-28 Thread Kai Uwe Broulik

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Lovely.
  
  - Media controller is fine now
  - Pin on systray popup is fine
  - buttons in NM applet are fine

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/anothersizehint

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-28 Thread Harald Sitter

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Much better. Since nobody has input on the deprecations I guess they must be 
alright. Do have a look into using QDBusError::InvalidArgs before landing 
though.

INLINE COMMENTS

> DBusHelperProxy.cpp:120
>  if (reply.type() == QDBusMessage::ErrorMessage) {
> +if (reply.errorName() == 
> QStringLiteral("org.freedesktop.DBus.Error.InvalidArgs")) {
> +// For backwards compatibility if helper binary was built 
> with older KAuth version.

Probably better to us the abstraction enum `if (watcher->error().type() == 
QDBusError::InvalidArgs) {`

> kauthaction.h:108
> + */
> +enum AuthDetail {
> +DetailOther = 0,

consider enum class

REPOSITORY
  R283 KAuth

BRANCH
  arcpatch-D21795_1

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

D25315: KDirModel: implement showing "/" as a root node, optionally

2020-02-28 Thread Raphael Rosch

rrosch added a comment.


  Ok, I found one of the "implications". With 
`model->dirLister()->openUrl(m_initURL, KDirLister::Keep);` I can list KIO urls 
like `remote:`, `font:`, and `applications:`, but with 
`model->openUrl(m_initURL, KDirModel::ShowRoot);` I cannot, and only seems to 
display the the local filesystem (specifically it lists "/"). I can probably 
work around it, but just wanted to pass that info along. I think it would be 
great if the "root" could be shown for these as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D25315: KDirModel: implement showing "/" as a root node, optionally

2020-02-28 Thread Raphael Rosch

rrosch added a comment.


  Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had 
to change the call in my code that was originally:
  
model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep);
  
  to
  
model->openUrl(QUrl::fromLocalFile("/"), KDirModel::ShowRoot);
  
  and don't really know the implications of the change at this point. (Will it 
"Keep"? Does it matter that I now call the model's openURL vs the dirLister's?)
  
  I couldn't however get the following to work:
  
QModelIndex index = getIndexFromUrl("/home/myuser");
if (index.isValid()) {
treeView->setRootIndex(index.parent());
}
  
  Which should show the node for "/home" as the root, but is instead giving me 
a flat listing of all the child nodes without "/home" as the root. Am I doing 
something wrong here? That part is called on a slot for the signal 
`::expand`. (Also, it would be great to have a setRootPath() that 
works in conjunction to expandToUrl or openUrl, to save processing cycles 
wasted on loading the parts of the model that won't be shown in the new 
rootIndex, like https://doc.qt.io/qt-5/qfilesystemmodel.html#setRootPath )
  
  As it is relevant, I also tested the patch at 
http://www.davidfaure.fr/2019/kdirmodel_haschildren.diff for `hasChildren()`, 
which works as expected! Thank you!
  
  ---
  
  For the curious, I just downloaded the source rpm for `kf5-kio`, installed it 
as unprivileged user, edited the .spec file to include the raw diff here as a 
the //second// patch, and the raw diff for D25249 
 as the //first// patch (and copying them 
to `~/rpmbuild/SOURCES/` of course). I also had to change the `Release: ` line 
to something greater than the one already there so it installs without 
conflicts (I changed mine from "1" to "2patched"). Then just
  
rpmbuild -bb ~/rpmbuild/SPECS/kf5-kio.spec 
  
  and install the relevant rpms. No need to rebuild all of KF5 from git (which 
I started to attempt and bailed pretty quickly after thinking this might be the 
easier/faster/less space-using way. Knowing this process will be useful for 
newcomers to help test features on their system without the daunting (and 
probably impossible due to limited space) task of compiling all of KF5. This 
could be added to the dev documentation somewhere.
  
  In any case, thanks again for implementing the feature! (Next step is to try 
to follow the same procedure to test the "crash on close of view" fix you 
submitted for Qt5, thanks also for that!)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D25743: Expose IndexerState enum to QML

2020-02-28 Thread David Edmundson

davidedmundson added a comment.


  > Ping.
  
  Will do on Sunday (after tagging)

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, bruns, abrahams

D27707: Use kcoreaddons_add_plugin for kded module

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:4ad7ceea349b: Use kcoreaddons_add_plugin for kded module 
(authored by nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27707?vs=76569=76612

REVISION DETAIL
  https://phabricator.kde.org/D27707

AFFECTED FILES
  src/daemon/CMakeLists.txt
  src/daemon/accounts.desktop
  src/daemon/kded_accounts.json

To: nicolasfella, #frameworks, bshah, leinir, apol

D27706: Random cmake cleanup

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:3f4fc9d4071b: Random cmake cleanup (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27706?vs=76567=76611#toc

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27706?vs=76567=76611

REVISION DETAIL
  https://phabricator.kde.org/D27706

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt

To: nicolasfella, #frameworks, bshah, leinir, apol

D27705: Use QStringLiteral

2020-02-28 Thread Nicolas Fella

nicolasfella marked an inline comment as done.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27705

To: nicolasfella, #frameworks, bshah, leinir, apol
Cc: apol

D27705: Use QStringLiteral

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:be294dcc69e7: Use QStringLiteral (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27705?vs=76566=76610#toc

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27705?vs=76566=76610

REVISION DETAIL
  https://phabricator.kde.org/D27705

AFFECTED FILES
  src/kcm/accounts.cpp
  src/lib/createaccountjob.cpp
  src/lib/getcredentialsjob.cpp
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir, apol
Cc: apol

D27709: Move job classes to kaccounts lib and rename to *Job

2020-02-28 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:2030bb498ed3: Move job classes to kaccounts lib and 
rename to *Job (authored by nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27709?vs=76580=76609

REVISION DETAIL
  https://phabricator.kde.org/D27709

AFFECTED FILES
  example/accounts.qml
  src/declarative/CMakeLists.txt
  src/declarative/kaccountsdeclarativeplugin.cpp
  src/jobs/accountservicetoggle.cpp
  src/jobs/accountservicetoggle.h
  src/jobs/createaccount.cpp
  src/jobs/createaccount.h
  src/kcm/package/contents/ui/AvailableAccounts.qml
  src/kcm/package/contents/ui/AvailableServices.qml
  src/lib/CMakeLists.txt
  src/lib/accountservicetogglejob.cpp
  src/lib/accountservicetogglejob.h
  src/lib/createaccountjob.cpp
  src/lib/createaccountjob.h
  src/lib/uipluginsmanager.cpp

To: nicolasfella, #frameworks, bshah, leinir

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid

aacid added a comment.


  In D27633#619369 , @aacid wrote:
  
  > In D27633#619365 , @aacid wrote:
  >
  > > I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  > >
  > > @nicolasfella can you please look at it?
  >
  >
  > On top of that that's a BIC change, you can't do BIC changes on KF5 repos, 
so revert?
  
  
  kaccount-integrations is not a KF5 repo ^_^

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: aacid, lbeltrame

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid

aacid added a comment.


  In D27633#619365 , @aacid wrote:
  
  > I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  >
  > @nicolasfella can you please look at it?
  
  
  On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so 
revert?

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: aacid, lbeltrame

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 442 - Still Unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/442/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 28 Feb 2020 10:28:44 +
 Build duration:
9 min 31 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34810/62089)40%
(17695/43856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4547/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14617)51%
(4514/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 317 - Still Unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/317/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 28 Feb 2020 10:28:43 +
 Build duration:
7 min 35 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34815/62090)40%
(17692/43852)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4545/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14617)51%
(4514/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 308 - Still Unstable!

2020-02-28 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/308/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 28 Feb 2020 10:28:44 +
 Build duration:
7 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27654: [kio] Fix running konsole on Wayland

2020-02-28 Thread Wolfgang Bauer

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:07ab04bfe774: Fix running konsole on Wayland (authored by 
wbauer).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27654?vs=76387=76607

REVISION DETAIL
  https://phabricator.kde.org/D27654

AFFECTED FILES
  src/core/desktopexecparser.cpp

To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid

aacid added a comment.


  I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  
  @nicolasfella can you please look at it?

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: aacid, lbeltrame

D27707: Use kcoreaddons_add_plugin for kded module

2020-02-28 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  plug

REVISION DETAIL
  https://phabricator.kde.org/D27707

To: nicolasfella, #frameworks, bshah, leinir, apol

D27706: Random cmake cleanup

2020-02-28 Thread Aleix Pol Gonzalez

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  cmakecleanup

REVISION DETAIL
  https://phabricator.kde.org/D27706

To: nicolasfella, #frameworks, bshah, leinir, apol

D27705: Use QStringLiteral

2020-02-28 Thread Aleix Pol Gonzalez

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  if you want to have this, it could make sense to enforce it from cmake.

INLINE COMMENTS

> createaccount.cpp:195
>  base.append(authData.method());
> -base.append("/");
> +base.append(QStringLiteral("/"));
>  base.append(authData.mechanism());

Use QLatin1Char here.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  arcpatch-D27705

REVISION DETAIL
  https://phabricator.kde.org/D27705

To: nicolasfella, #frameworks, bshah, leinir, apol
Cc: apol

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2020-02-28 Thread Emirald Mateli

emateli added a comment.


  Well, this patch is more or less complete but it doesn't make sense to be 
deployed without batch operations from KIO as it would spawn a job for each 
file to be renamed.
  
  Like I stated in my last comment, I tried to give adding batch renaming a go 
but it felt like I needed some time to familiarize myself with kio internals 
first. So to save everyone time, I was hoping someone who has worked KIO more 
extensively is willing to implement the batch rename stuff since he'll be a lot 
faster than I. Once that is merged we can resume work here.
  
  That said I'll be giving the batch stuff another try.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, 
ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27717: fix min/max entries with dpointer

2020-02-28 Thread Henri Chain

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:f98feb169813: fix min/max entries with dpointer (authored 
by hchain).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27717?vs=76600=76604

REVISION DETAIL
  https://phabricator.kde.org/D27717

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_dpointer.kcfg
  src/kconfig_compiler/kconfig_compiler.cpp

To: hchain, meven, ervin
Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27717: fix min/max entries with dpointer

2020-02-28 Thread Méven Car

meven accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27717

To: hchain, meven, ervin
Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27717: fix min/max entries with dpointer

2020-02-28 Thread Kevin Ottens

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27717

To: hchain, meven, ervin
Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27717: fix min/max entries with dpointer

2020-02-28 Thread Henri Chain

hchain created this revision.
hchain added reviewers: meven, ervin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hchain requested review of this revision.

REVISION SUMMARY
  D27497  was causing cases with dpointer + 
min/max to fail
  Specifically, this okular build: 
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5 
SUSEQt5.12/175/console

TEST PLAN
  Added min/max to dpointer autotest

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27717

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_dpointer.kcfg
  src/kconfig_compiler/kconfig_compiler.cpp

To: hchain, meven, ervin
Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27709: Move job classes to kaccounts lib and rename to *Job

2020-02-28 Thread Dan Leinir Turthra Jensen

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  As i was going to do this as part of something else, i obviously think this 
is a good idea ;) And yes, the thought process behind it was indeed that this 
is something that'd just make sense in general, not just from QML.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  decl

REVISION DETAIL
  https://phabricator.kde.org/D27709

To: nicolasfella, #frameworks, bshah, leinir

54 matches

Mail list logo