T11950: Reduce the pain of working on monochrome Breeze icons

ndavis added a comment. @davidhurka pretty impressive. I'll have to try it myself. If the dependencies are minimal and it's easy to use, it might be worth it to have the tool in the breeze icons repo. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham, ndavis Cc: davidhurka,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#625470 , @ngraham wrote: > However dragging a URL still doesn't show the menu; it just downloads the entire page. We need the drop menu in this case because it's probably more common to want to create a link to

D27910: Make sure warning output is enabled before testing if the correct warning is printed

dfaure added a comment. I suggest a better solution: QStandardPaths::setTestModeEnabled(true) in initTestCase(). Then the user settings won't interfere with the unittest. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To: sandsmark, dfaure Cc: apol,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Huh. Sorry about the delays and the need to update version numbers once more. My last two comments are still not fixed. To see the issues, grep for "direcly" ('t' missing) and "Details

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

dfaure updated this revision to Diff 77381. dfaure added a comment. Ensure no duplicates in partsForMimeType REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27966?vs=77340=77381 REVISION DETAIL https://phabricator.kde.org/D27966 AFFECTED FILES

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

dfaure added inline comments. INLINE COMMENTS > aacid wrote in partloader.h:59 > What's the use for this? The function below doesn't let me chose which one i > want (i guess it always uses the one with the most preference?), so why would > i need to query which parts are available? > > Maybe

T11950: Reduce the pain of working on monochrome Breeze icons

davidhurka added a comment. Whoops, this Task went past me //while// I created breeze-icon-cleaner . What a pity! I think with this tool, we can check the remaining four tasks of the TODO in the task description. Sounds optimistic?

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

aacid added inline comments. INLINE COMMENTS > partloader.h:59 > + */ > +KPARTS_EXPORT QVector partsForMimeType(const QString > ); > + What's the use for this? The function below doesn't let me chose which one i want (i guess it always uses the one with the most preference?), so why

D27965: [KPasswdServer] replace foreach with range/index-based for

apol added a comment. Having the iterated value change under the hood will eventually break. I'd suggest preferring QList::erase to QList::removeOne. INLINE COMMENTS > kpasswdserver.cpp:648 > + static_cast(time(nullptr)) > current->expireTime) { >

D27913: Icons for emoji categories

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think I'll want to update some of these icons in the future, particularly the animal icon since that's using another project's mascot. Still, I don't think it'll be a problem since the

D27916: Add Overpass QL highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:fdc762d23fdc: Add Overpass QL highlighting (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27916?vs=77179=77372#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. Nice, drag-and-drop now correctly shows the menu for the case of dragging an icon from Kickoff or the task manager. However dragging a URL still doesn't show the menu; it just downloads the entire page. We need the drop menu in this case because it's probably more

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added a comment. In D27464#625403 , @broulik wrote: > Didn't we have a dedicated protocol for window menu in plasma-integration? Or is this just for reading? We surely don't want all apps to use plasma surface interface for announcing the

D27464: Add application menu dbus paths to org_kde_plasma_window interface

broulik added a comment. In D27464#625405 , @zzag wrote: > Could you please clarify what you mean by "plasma surface interface"? The thing we use in plasmashell to position panels and everything absolutely REPOSITORY R127 KWayland

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added a comment. In D27464#625403 , @broulik wrote: > Didn't we have a dedicated protocol for window menu in plasma-integration? That protocol is for announcing global menus. > Or is this just for reading? Yes, it's for

D27464: Add application menu dbus paths to org_kde_plasma_window interface

broulik added a comment. Didn't we have a dedicated protocol for window menu in plasma-integration? Or is this just for reading? We surely don't want all apps to use plasma surface interface for announcing the global menu?

D27965: [KPasswdServer] replace foreach with range/index-based for

meven added a comment. In D27965#625381 , @apol wrote: > Looks good to me, I wonder why you turned some to for+iterators. Those modified the list as they iterated through the list : `authList->removeOne(current);` REPOSITORY R241 KIO

D27455: FileWidgets: Ignore Return events from KDirOperator

meven added a comment. Well I meant to do some checking, despite this works, it does not look nice. Adding a test would be nice too. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc:

D27965: [KPasswdServer] replace foreach with range/index-based for

apol added a comment. Looks good to me, I wonder why you turned some to for+iterators. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: apol, kde-frameworks-devel,

D27455: FileWidgets: Ignore Return events from KDirOperator

ngraham added a comment. Ping REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27152: Introduce FilesystemEntry class

meven added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:209 > add temporary for fstype The temporary for fstype is gone it seems. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc:

D27928: [VIM Mode] Add g g commands

gikari added a comment. I added a unit test, but I do not know why it is failing. Actually I do not know if I've added it correctly at all. Help is very necsasary. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: dhaumann,

D27928: [VIM Mode] Add g g commands

gikari updated this revision to Diff 77355. gikari added a comment. - Add unit-test REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27928?vs=77199=77355 BRANCH g-up-g-down-commands (branched from master) REVISION DETAIL

D27504: smb faster copy to local

ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D26841: hardware tool: define syntax via syntax arg

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:8dfb727dd105: hardware tool: define syntax via syntax arg (authored by sitter). REPOSITORY R245 Solid CHANGES

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Mar 2020 13:35:11 + Build duration: 1 min 51 sec and counting JUnit Tests Name:

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77351. trmdi added a comment. Move comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77350=77351 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFECTED

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi retitled this revision from "Allow users to change dropAction to MoveAction through workspace kcm" to "Allow users to change dropAction to MoveAction through kdeglobals". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc:

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > Essentially, apply the change from the man page example to the code here: > > if (pos != sbPart->size) { > int errsv = errno; > qCDebug(KIO_SFTP_LOG) << "Failed to seek to" << sbPart->size << "bytes

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace kcm

trmdi updated this revision to Diff 77350. trmdi added a comment. Address meven's comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77349=77350 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951

D27951: Allow users to change dropAction to MoveAction through workspace kcm

meven added a comment. This does not include the workspace-option kcm setting. So I would title this "Allow users to change dropAction to MoveAction through a dndToMove kdeglobal setting" INLINE COMMENTS > dropjob.cpp:288 > } > +if

D27951: Allow users to change dropAction to MoveAction through workspace kcm

trmdi retitled this revision from "Allow users to change dropAction to MoveAction through workspace-option kcm" to "Allow users to change dropAction to MoveAction through workspace kcm". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure,

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi updated this revision to Diff 77349. trmdi added a comment. Move fileItem back to the local scope REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77329=77349 BRANCH add-dndToMove (branched from master) REVISION DETAIL

D27928: [VIM Mode] Add g g commands

dhaumann added a comment. The intimidating one :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking,

D27455: FileWidgets: Ignore Return events from KDirOperator

cfeck edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26969: fix type namespace requirement

This revision was automatically updated to reflect the committed changes. Closed by commit R283:e6877dfa4fe6: fix type namespace requirement (authored by sitter). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26969?vs=77262=77344 REVISION DETAIL

D27504: smb faster copy to local

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe,

D27504: smb faster copy to local

sitter retitled this revision from "WIP: RFC: smb faster copy to local" to "smb faster copy to local". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel,

D27504: WIP: RFC: smb faster copy to local

sitter updated this revision to Diff 77343. sitter added a comment. - rebase - move transfer impls to cpp - new unpop function to make the ring usage more consistent and make sure neither thread can overtake the other - new test for transfer tech. notably simulating imbalance in

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir added a comment. In D27965#625234 , @meven wrote: > Please wait for a second review, I am not authoritative here. OK, thanks. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure added a revision: D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato,

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure added a revision: D27967: KParts: add unittest for PartLoader, required shuffling things around. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner,

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

dfaure created this revision. dfaure added reviewers: aacid, nicolasfella, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY It's based on the JSON metadata embedded into the plugins in

D27965: [KPasswdServer] replace foreach with range/index-based for

meven added a comment. Please wait for a second review, I am not authoritative here. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n,

D27965: [KPasswdServer] replace foreach with range/index-based for

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack,

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-http-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27963 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. ahmadsamir added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

crossi added a comment. Tested as an alternative to D27944 At initialization, the apply button is enabled. Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled. REPOSITORY R295 KCMUtils REVISION

D27964: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27964 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27964: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27964

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use prefix increment operator. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-http-foreach

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven added inline comments. INLINE COMMENTS > dropjob.cpp:150 > Qt::KeyboardModifiers m_keyboardModifiers; > +KFileItemList m_fileItems; > +KFileItemListProperties m_itemProps; I think you don't need a member here, a local variable should suffice. REPOSITORY R241 KIO REVISION

D27704: Drop FindAccountsFileDir.cmake

lbeltrame requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella, #frameworks, bshah, leinir, lbeltrame Cc: lbeltrame

D27704: Drop FindAccountsFileDir.cmake

lbeltrame reopened this revision. lbeltrame added a comment. This revision is now accepted and ready to land. "No one using it" is not correct. Or at least, `ACCOUNTS_SERVICES_DIR`, set in that file, is used by kaccounts-providers. I'll revert the change (breaks building other projects), but