D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir updated this revision to Diff 77477. ahmadsamir added a comment. - I missed one foreach before - Use erase() instead of remove(), safer to work on QList iterators REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77339=77477 BRANCH

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kdirmodeltest_gui.cpp:92 > It doesn't look "normal" : without the ShowRoot feature, you wouldn't see the > "/" root node. > So I would say the test program is valid, no matter what the starting > directory is. > > (I was

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 327 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/327/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 02:12:25 + Build duration: 7 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 326 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/326/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Mar 2020 02:05:18 + Build duration: 6 min 47 sec and counting JUnit Tests Name:

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Fixed in https://commits.kde.org/kio/440bec1b3524f168fc04898a09ac51457c79ed3b REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R309:7d4b33677fdd: Properly read the X-Flatpak-RenamedFrom string list from desktop files (authored by apol). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

dfaure updated this revision to Diff 77474. dfaure added a comment. Document how to load a part from a given KPluginMetaData REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27966?vs=77381=77474 REVISION DETAIL https://phabricator.kde.org/D27966 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. You need to add it to the file `src/declarativeimports/plasmaextracomponents/qml/qmldir` or else it doesn't get installed in a way that anything can see it. REPOSITORY R242

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D27953 To: apol, dfaure Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dalbers added a comment. This doesn't seem to compile: [ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o cd /usr/src/kio-git/src/build/src/ioslaves/file && /usr/lib/ccache/bin/c++ -DKCOMPLETION_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054100

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

aacid added inline comments. INLINE COMMENTS > dfaure wrote in partloader.h:59 > This is an excellent point, thanks for this feedback. > > Loading a part from a given KPluginMetadata is extremely simple, though: > > KPluginLoader loader(md.fileName()); > m_part =

D27997: Fix cmake warning

This revision was automatically updated to reflect the committed changes. Closed by commit R309:64ae18840457: Fix cmake warning (authored by apol). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27997?vs=77466=77470 REVISION DETAIL

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

apol added a comment. In D27953#626192 , @dfaure wrote: > How? You think we should change all our config files to use ';'? Welcome to migration hell. > > (I looked at the KConfig history, and in fact the separator was initially a method

D27953: Properly read the X-Flatpak-RenamedFrom string list from desktop files

apol retitled this revision from "Properly read string lists from desktop files when parsing the files" to "Properly read the X-Flatpak-RenamedFrom string list from desktop files". apol edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL

D27953: Properly read string lists from desktop files when parsing the files

apol updated this revision to Diff 77467. apol added a comment. Fix as suggested REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27953?vs=77305=77467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27953 AFFECTED FILES

D27997: Fix cmake warning

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH warning REVISION DETAIL https://phabricator.kde.org/D27997 To: apol, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27997: Fix cmake warning

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY cmake complains about these files, just skip them for moc/uic. TEST PLAN Builds without

D25315: KDirModel: implement showing a root node for the requested URL

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kdirmodeltest_gui.cpp:92 > I did test the /usr/share/fonts path :); it's just that starting at "/" > looked "normal", whereas starting at a specific dir conveyed the goal of this > change better, to me anyway. It doesn't look

D27953: Properly read string lists from desktop files when parsing the files

dfaure added a comment. How? You think we should change all our config files to use ';'? Welcome to migration hell. (I looked at the KConfig history, and in fact the separator was initially a method argument which defaulted to comma, I was wrong about it being ';' initially. No idea

D27953: Properly read string lists from desktop files when parsing the files

broulik added a comment. Do we have a task to clean that mix up for kf6 on the work board? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D27953 To: apol, dfaure Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27953: Properly read string lists from desktop files when parsing the files

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This sounds wrong. The XDG-mandated entries use XDG separators, but the KDE entries don't (for instance, grepping my installed desktop files I can see those:

D27965: [KPasswdServer] replace foreach with range/index-based for

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

dfaure added a comment. In D27965#625676 , @ahmadsamir wrote: > In D27965#625526 , @apol wrote: > > > Having the iterated value change under the hood will eventually break. I'd suggest preferring

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 325 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/325/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Mar 2020 21:36:30 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4b4ed81cc5f3: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27963: [http_cache_cleaner] replace foreach usage with QDir::removeRecursively()

ahmadsamir updated this revision to Diff 77462. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27963?vs=77336=77462 BRANCH l-http-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D27963

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 324 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/324/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Mar 2020 21:17:08 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9537bca2b542: [StatJob] Use A QFlag to specify the details returned by StatJob (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77386=77460

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added a comment. Yep, that's what "Accepted" means ;) REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added reviewers: VDG, davidedmundson. ngraham accepted this revision. ngraham added a subscriber: davidedmundson. ngraham added a comment. Fantastic. I'm approving this since my concerns have been resolved and it works as you've indended it, but don't land it as it needs more

D27918: [Config] Remove/deprecate disableInitialUpdate

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bdbf837dfe1a: [Config] Remove/deprecate disableInitialUpdate (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27918?vs=77184=77457 REVISION

D23926: Move "Details" tab to second place in Properties dialog

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in kpropertiesdialog.cpp:645 > /home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: > ‘class KService’ has no member named ‘serviceId’ > > `QStringLiteral` Build failure from this issue is not resolved yet >

D27985: Include s_kcrashErrorMessage in our traces

apol updated this revision to Diff 77452. apol added a comment. Include a usage in the test app, adapt to changes in kcrash REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77424=77452 BRANCH master REVISION DETAIL

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77451. apol marked an inline comment as done. apol added a comment. We were already creating a QByteArray, just keep it instead of allocating constantly REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77425=77451

D23926: Move "Details" tab to second place in Properties dialog

mthw updated this revision to Diff 77450. mthw added a comment. Sorry about that, I should have checked waht I am sending. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=77445=77450 BRANCH master REVISION DETAIL

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R282:fa9ef0d84898: NetworkManager-Qt: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D27952: Simplify minimum size handling

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27952 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27989 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. For future reference, you can rebase like so: git fetch git rebase origin/master Also please make sure your code at least compiles before submitting a patch or a

D23926: Move "Details" tab to second place in Properties dialog

mthw updated this revision to Diff 77445. mthw added a comment. I don't really know how to do a rebase propertly so I hope I managed to do the same manually. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=77388=77445 BRANCH master REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven added a comment. Ok to merge ? REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY preferredSize() is an improvement over what minimumSize() used to do, with taking

D27918: [Config] Remove/deprecate disableInitialUpdate

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27918 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D27986: Allow providing an error message from the application

sitter added a comment. Unit test? (: I also wonder if maybe this should be lazy allocated. The vast majority of applications probably will never set it, so allocating the memory on first use should be better for the great majority of applications while making no difference for the gdb

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#625881 , @ngraham wrote: > Excellent. The behavior seems correct to me now. There are a few more issues I've like to bring up: > > - While dragging, the cursor always shows a "copying" icon, even though with

D27985: Include s_kcrashErrorMessage in our traces

sitter added a comment. Probably should also get added to one of the parser tests to make sure it doesn't fall on the face. Talking about parser, I feel like this might benefit from highlighting somehow, currently it's very squished in with the random stuff in the header. That'll make

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77433. trmdi added a comment. Apply only when all the sources and the dest are on a same device. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77391=77433 BRANCH add-dndToMove (branched from master) REVISION

D27928: [VIM Mode] Add g g commands

gikari added a comment. Yes, my case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking,

D27928: [VIM Mode] Add g g commands

cullmann added a comment. I will try to take a look as soon as I have time, if nobody else is faster. Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To:

D27133: kconfig_compiler : generate kconfig settings with subgroup

apol added a comment. The patch and the feature sound good to me, the resulting xml feels a bit weird and could use some clarification. INLINE COMMENTS > test_subgroups.kcfg:21 > + > + > + It feels odd to reference the parent name rather than having a group inside the

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham added a comment. Yes, looks very nice. Please feel free to work on this. My efforts were not very successful due to limited CMake knowledge and use of shell scripts instead of something more cross-platform like Python. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi added a comment. @dfaure, any opinion on this revision ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi updated this revision to Diff 77426. crossi added a comment. rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27133?vs=77049=77426 REVISION DETAIL https://phabricator.kde.org/D27133 AFFECTED FILES autotests/kconfig_compiler/CMakeLists.txt

D27986: Allow providing an error message from the application

apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Allows us keep the message provided by QQuickWindow::sceneGraphError to later have

D27985: Include s_kcrashErrorMessage in our traces

apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY CCBUG: 375913 TEST PLAN Called `kill -SIGSEGV plasma-discover` and got to see the string I

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. Excellent. The behavior seems correct to me now. There are a few more issues I've like to bring up: - While dragging, the cursor always shows a "copying" icon, even though with the patch local drags result in a move. Anytime the file will be moved without

D23926: Move "Details" tab to second place in Properties dialog

ngraham added a comment. This needs a rebase. INLINE COMMENTS > kpropertiesdialog.cpp:643 > +if (ptr->serviceId() == > QStringLitteral("baloofilepropertiesplugin")) { > +q->insertPluginAt(plugin,1); > +} else { space before the comma REPOSITORY R241 KIO

D27983: Make find-location show a magnifier on a map, to be different to mark-location

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is a waaay nicer and more visually communicative icon. You did the stylesheet perfectly and everything is pixel-aligned. Excellent

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham added a dependent revision: D27979: [WIP] Add top area to notifications. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n,

D21466: Recommend rebooting after installing Samba

apol added a comment. So yes, Discover will notify about updates. That doesn't mean it should be shown here too. If anything, we should be pushing for such updates to happen at startup/shutdown because it doesn't seem like the user benefits from it being swapped at runtime, but that's

D27983: Make find-location show a magnifier on a map, to be different to mark-location

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27983: Make find-location show a magnifier on a map, to be different to mark-location

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This changes find-location, and adds the 22px variant. BUG: 407061

D25334: Added transparent blue background to tabbars

ngraham added a comment. Is there a reason why we can't do this? I like it... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77418. niccolove added a comment. Trailing spaces REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77408=77418 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77408. niccolove added a comment. use heading instead of header REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77405=77408 BRANCH master REVISION DETAIL

D27444: Added plasmoid heading svg

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added plasmoid heading svg

niccolove retitled this revision from "Added top area" to "Added plasmoid heading svg". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27444: Added top area

niccolove updated this revision to Diff 77407. niccolove added a comment. Changed filename to heading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77272=77407 BRANCH top_area (branched from master) REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77405. niccolove added a comment. bottomPadding rather than bottomMargin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77404=77405 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77404. niccolove added a comment. Missed a PlasmoidHeading. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77402=77404 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77402. niccolove added a comment. Local is not a type REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77271=77402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D25334: Added transparent blue background to tabbars

niccolove abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27445: Move tasks from 3px to 2px

niccolove abandoned this revision. niccolove added a comment. I'd actually prefer to make the task manager extend to panel borders. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: ndavis, ngraham,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

ahmadsamir added a comment. In D27965#625526 , @apol wrote: > Having the iterated value change under the hood will eventually break. I'd suggest preferring QList::erase to QList::removeOne. Actually, the code also uses 'delete current',

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 273 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/273/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 11 Mar 2020 08:35:32 + Build duration: 3 min 51 sec and counting JUnit Tests Name:

D27913: Icons for emoji categories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:90ed6fdf4317: Icons for emoji categories (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27913?vs=77169=77393

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 159 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/159/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Mar 2020 08:35:32 + Build duration: 3 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 166 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/166/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 11 Mar 2020 08:35:32 + Build duration: 1 min 49 sec and counting JUnit Tests Name:

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77391. trmdi added a comment. Code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77390=77391 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFECTED

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77390. trmdi added a comment. Code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77389=77390 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFECTED

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77389. trmdi added a comment. Apply only when all items are local. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77351=77389 BRANCH add-dndToMove (branched from master) REVISION DETAIL

D23926: Move "Details" tab to second place in Properties dialog

mthw updated this revision to Diff 77388. mthw added a comment. - Made recomemded changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23926?vs=66003=77388 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23926 AFFECTED FILES

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77386. meven added a comment. Improve comment of StatJob *statDetails REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77385=77386 BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77385. meven added a comment. Fix typo, make StatJob::setDetails(KIO::StatDetail detail) build only when build_deprecated(5.69) is set REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=77235=77385 BRANCH