KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.14 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/6/ Project: kf5-qt5 AndroidQt5.14 Date of build: Sun, 15 Mar 2020 09:33:01 + Build duration: 2 min 29 sec and counting

D28058: KWayland: Convert license headers to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as required by REUSE specification.

D28058: KWayland: Convert license headers to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28058 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25815: Transmission-Qt tray icon added

ngraham added a comment. @ndavis, since you already submitted an alternative icon, maybe you could take this over. @vinzenzv would that be okay with you? REVISION DETAIL https://phabricator.kde.org/D25815 To: vinzenzv, #vdg, ndavis, ngraham Cc: broulik, ndavis, ngraham, iasensio,

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

dfaure created this revision. dfaure added reviewers: apol, davidedmundson, elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN kioexec --tempfiles does_not_exist /tmp/foo Used to exit with

D28058: KWayland: Convert license headers to SPDX

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D28058 To: cordlandwehr, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:018f223692de: [KPasswdServer] replace foreach with range/index-based for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27965?vs=77554=77648

D27947: Port away from deprecated QList::toSet()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:30d964096430: Port away from deprecated QList::toSet() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27947?vs=77287=77649 REVISION DETAIL

D28030: Also expose the true minimum size to QML

This revision was automatically updated to reflect the committed changes. Closed by commit R280:e0dec83dd692: Also expose the true minimum size to QML (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28030?vs=77578=77650 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 332 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/332/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Mar 2020 09:33:21 + Build duration: 2 hr 10 min and counting JUnit Tests Name:

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

ahmadsamir added a comment. I tested it; before applying the diff: $ /usr/lib64/libexec/kf5/kioexec --tempfiles does_not_exist /tmp/foo command= "does_not_exist" args= ("does_not_exist", "/tmp/foo") EXEC "does_not_exist /tmp/foo" EXEC done $ echo $? 0 $

D28020: New class ProcessLauncherJob in KIOGui

dfaure planned changes to this revision. dfaure added inline comments. INLINE COMMENTS > davidedmundson wrote in kprocessrunner.cpp:39 > WId as an int is problematic for wayland. > > Can we do QWindow*? it'll allow adding support in future. > > For the compatibility path we can loop through

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 333 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/333/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Mar 2020 11:43:28 + Build duration: 24 min and counting JUnit Tests Name: projectroot

D27947: Port away from deprecated QList::toSet()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kcoredirlister-toset (branched from master) REVISION DETAIL https://phabricator.kde.org/D27947 To: ahmadsamir, #frameworks, dfaure, meven Cc: apol, kde-frameworks-devel,

D27989: Add a new set of barcode size functions

This revision was automatically updated to reflect the committed changes. Closed by commit R280:838f886c380f: Add a new set of barcode size functions (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27989?vs=77441=77647 REVISION DETAIL

D27986: Allow providing an error message from the application

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: KIO: try to assign an icon to action submenus

On vendredi 13 mars 2020 21:19:42 CET Chloe Kudryavtsev wrote: > On 3/13/20 2:18 PM, David Faure wrote: > > On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: > >> Currently, action submenus (X-KDE-Submenu) have no icons. > >> This patch makes it inherit the icon of the first action. > >

D28056: KWindowSystem: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files according to REUSE specification.

D28056: KWindowSystem: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28056 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28056: KWindowSystem: Convert license headers to SPDX expressions

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D28056 To: cordlandwehr, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-kpasswdserver (branched from master) REVISION DETAIL https://phabricator.kde.org/D27965 To: ahmadsamir, #frameworks, dfaure, meven Cc: apol, kde-frameworks-devel, LeGast00n,

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77702. ngraham added a comment. Don't auto-collapse when the default action button is clicked; this can interfere with actions where you want the button to show a custom expanded view, as in the Networks widget REPOSITORY R242 Plasma Framework

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 335 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/335/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 05:01:25 + Build duration: 8 min 48 sec and counting JUnit Tests Name:

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28060 To: dfaure, apol, davidedmundson, elvisangelaccio Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#627849 , @elvisangelaccio wrote: > > With dndToMove=true in kdeglobals, drag files will move them without showing the menu. (holding Shift shows it) > > Are we going to expose this setting in Plasma?

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 334 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/334/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Mar 2020 18:41:56 + Build duration: 36 min and counting JUnit Tests Name: projectroot

D27985: Include s_kcrashErrorMessage in our traces

This revision was automatically updated to reflect the committed changes. Closed by commit R871:39ed9cf6449e: Include s_kcrashErrorMessage in our traces (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77452=77676 REVISION DETAIL

D28020: New class ProcessLauncherJob in KIOGui

dfaure updated this revision to Diff 77682. dfaure added a comment. - Don't block in start(), make it fully async - Add waitForStarted() for KRun (with unittests) - Add test for non-existing executables, with and without kioexec - after making sure that the command isn't trivial, by

D28061: Reduce unneeded dependencies

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28061 To: apol, #frameworks, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D17816: Support for xattrs on kio copy/move

usta requested changes to this revision. usta added inline comments. INLINE COMMENTS > cochise wrote in jobtest.cpp:573 > {set,get}fattr = linux command > {set.get}extattr = BSD command > {set.get}xtattr = MacOS command > > This command could have a little more consistency... but you have

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh jeez. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27854 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77695. ngraham added a comment. Use `StyledText` instead of `RichText` because `RichText` doesn't support eliding (see https://bugreports.qt.io/browse/QTBUG-16567) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77701. ngraham added a comment. - Create a re-usable public `toggleExpanded()` function and use it internally - Make the busy indicator a bit smaller so it doesn't make the list item taller when it appears REPOSITORY R242 Plasma Framework (Library)

D27772: [WriteTransaction] Extend position test case

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27772 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D27855: [Debug] Improve readability of positioninfo debug format

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27855 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D27853: [WriteTransactionTest] Test removal of positions only

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27853 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27771 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D17816: Support for xattrs on kio copy/move

usta added inline comments. INLINE COMMENTS > jobtest.cpp:573 > +} else if (command == "setextattr") { > +command = "getextatr"; > +} I am not sure but it looks like there is a typo here getextatr ---> getextattr but not sure , can someone make a comment about this ? REPOSITORY

D17816: Support for xattrs on kio copy/move

cochise added a comment. In D17816#627925 , @pino wrote: > xattrs on the Linux tmpfs have been supported for many years, almost a decade. But only enough to support ACL. > The tmpfs filesystem supports extended attributes (see

D17816: Support for xattrs on kio copy/move

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > cochise wrote in jobtest.cpp:573 > xtattr = MacOS command > It uses a single command to read and write. All of these are spelled with two consecutive 't'. The code has a single 't' : getextatr. > dfaure

D25815: Transmission-Qt tray icon added

ndavis commandeered this revision. ndavis edited reviewers, added: vinzenzv; removed: ndavis. REVISION DETAIL https://phabricator.kde.org/D25815 To: ndavis, #vdg, ngraham, vinzenzv Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2,

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28060 To: dfaure, apol, davidedmundson, elvisangelaccio Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28061: Reduce unneeded dependencies

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to translate a test app that is not even being installed. Make it a QGuiApplication so less

D17816: Support for xattrs on kio copy/move

cochise added a comment. In D17816#627918 , @bruns wrote: > Not true in general ... please add back, and **check** if the destination FS supports XAttrs. If not, print a warning and SKIP Not true in general. But test the copies to /tmp,

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77688. ngraham added a comment. Fix one thing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77687=77688 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D28033: Create ExpandableListItem

ngraham marked 5 inline comments as done. ngraham added a comment. By switching to the PC3 `BusyIndicator`, I'm now seeing a binding loop that doesn't make sense to me: file:///home/nate/kde/usr/lib64/qml/org/kde/plasma/components.3/ExpandableListItem.qml:191:13: QML BusyIndicator:

D17816: Support for xattrs on kio copy/move

pino added a comment. In D17816#627921 , @cochise wrote: > In D17816#627918 , @bruns wrote: > > > Not true in general ... please add back, and **check** if the destination FS supports XAttrs. If

D17816: Support for xattrs on kio copy/move

cochise added inline comments. INLINE COMMENTS > cochise wrote in jobtest.cpp:573 > {set,get}fattr = linux command > {set.get}extattr = BSD command > {set.get}xtattr = MacOS command > > This command could have a little more consistency... xtattr = MacOS command It uses a single command to read

D17816: Support for xattrs on kio copy/move

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:568 > + > +void JobTest::compareXattr(const QString , const QString , QString > ) > +{ remove the command parameter from the method, use e.g. a

D28033: Create ExpandableListItem

niccolove added a comment. AFAIK, there should be a easy way to add animations to the highlight effect. An example is the print one, where clicking on it will animate the highlight. It should also be possible to make the highlight effect fly over elements instead of always being on the

D28033: Create ExpandableListItem

davidedmundson requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: davidedmundson, bruns, niccolove, cblack, davidre,

D27986: Allow providing an error message from the application

This revision was automatically updated to reflect the committed changes. Closed by commit R285:6177c81d04a7: Allow providing an error message from the application (authored by apol). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77552=77675

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77687. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77686=77687 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D27951: Allow users to change dropAction to MoveAction through kdeglobals

elvisangelaccio added a comment. > With dndToMove=true in kdeglobals, drag files will move them without showing the menu. (holding Shift shows it) Are we going to expose this setting in Plasma? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi,

Re: KIO: try to assign an icon to action submenus

On 3/15/20 12:19 PM, David Faure wrote: > On vendredi 13 mars 2020 21:19:42 CET Chloe Kudryavtsev wrote: >> On 3/13/20 2:18 PM, David Faure wrote: >>> On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote: Currently, action submenus (X-KDE-Submenu) have no icons. This patch makes it

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28060 To: dfaure, apol, davidedmundson, elvisangelaccio Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

bruns added a comment. > - Removed tests for copy/move to another partition, as this should fail. The destination filesystem don't support xattr. Not true in general ... please add back, and **check** if the destination FS supports XAttrs. If not, print a warning and SKIP REPOSITORY

D28033: Create ExpandableListItem

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in ExpandableListItem.qml:2 > It shouldn't be in PC3. It's new API from qqc2.A Where should it live? PC2? Kirigami? > davidedmundson wrote in ExpandableListItem.qml:23 > Unused? Not unused, it's needed for `Highlight`,

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77686. ngraham marked 4 inline comments as done. ngraham added a comment. - Address review comments - Improve inline comments for clarify - Use a pointing hand cursor when hovering over the item to indicate that it's clickable - Make subtitle

D28061: Reduce unneeded dependencies

apol updated this revision to Diff 77678. apol added a comment. polish REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28061?vs=77677=77678 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28061 AFFECTED FILES

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77691. ngraham added a comment. Add TODOs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77688=77691 BRANCH ExpandableListItem (branched from master) REVISION DETAIL