KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 339 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/339/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 04:50:36 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 472 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/472/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 04:50:35 +
 Build duration:
8 min 34 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35191/62414)40%
(17734/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9937/10400)47%
(4580/9774)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8758/14650)51%
(4538/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 348 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/348/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 20 Mar 2020 04:50:35 +
 Build duration:
8 min 47 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35179/62414)40%
(17727/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9937/10400)47%
(4580/9774)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8749/14649)51%
(4538/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2076/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4286)36%
(1300/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D27255: nota

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  The dotted lines are placed on half pixels, which we should avoid doing.
  Depending on the look you're going for, you could do either one of the 
following:
  
  - Align the 1px thick lines to the pixel grid
  - Expand the dotted lines to 2px thickness and set their opacity to 50%. This 
preserves the current look and make it continue to look that way at larger 
scales.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/118/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 01:52:51 +
 Build duration:
3 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/66/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 00:07:19 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 73 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/73/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 20 Mar 2020 00:07:19 +
 Build duration:
6 min 58 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27664/32711)53%
(11148/20975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12590/12665)50%
(6631/13161)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6334/7478)65%
(1837/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8141/9767)63%
(2447/3879)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 114 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/114/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 00:07:19 +
 Build duration:
6 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27664/32711)53%
(11147/20975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12590/12665)50%
(6631/13161)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6334/7478)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8141/9767)63%
(2447/3879)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 113 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/113/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 23:36:23 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 47 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.server.kwayland_testTabletInterface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(241/272)89%
(241/272)84%
(27364/32683)53%
(11041/20973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12579/12665)50%
(6622/13161)autotests.server83%
(5/6)83%
(5/6)73%
(373/512)38%
(177/468)src.client96%
(73/76)96%
(73/76)85%
(6339/7480)65%
(1838/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server94%
(118/126)94%
(118/126)82%
(7992/9746)62%
(2404/3877)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/65/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 23:36:23 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testTabletInterfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 72 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/72/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 19 Mar 2020 23:36:23 +
 Build duration:
4 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 47 test(s)Failed: projectroot.autotests.server.kwayland_testTabletInterface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(241/272)89%
(241/272)84%
(27368/32681)53%
(11048/20973)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12591/12665)50%
(6632/13161)autotests.server83%
(5/6)83%
(5/6)73%
(373/512)38%
(177/468)src.client96%
(73/76)96%
(73/76)85%
(6332/7478)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server94%
(118/126)94%
(118/126)82%
(7991/9746)62%
(2403/3877)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D26858: Provide an implementation for the tablet interface

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a009c8c0d91a: Provide an implementation for the tablet 
interface (authored by apol).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26858?vs=78028=78055

REVISION DETAIL
  https://phabricator.kde.org/D26858

AFFECTED FILES
  CMakeLists.txt
  autotests/server/CMakeLists.txt
  autotests/server/test_tablet_interface.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/tablet_interface.cpp
  src/server/tablet_interface.h

To: apol, #kwin, #frameworks, zzag, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta closed this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta added a commit: R237:67630e49d69c: Autotest file showing wrong File path.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta added a reviewer: hchain.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

To: usta, meven, aacid
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28151: Autotest file showing wrong File path

[Ömer Fadıl Usta]

usta created this revision.
usta added a reviewer: meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
usta requested review of this revision.

REVISION SUMMARY
  It look like this is a trivial typo but causing tests doesnt work correctly

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28151

AFFECTED FILES
  autotests/kconfig_compiler/test_param_minmax.kcfgc
  autotests/kconfig_compiler/test_properties_minmax.kcfgc

To: usta, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 347 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/347/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 19 Mar 2020 20:37:47 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35201/62414)40%
(17739/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9939/10400)47%
(4578/9774)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8759/14650)51%
(4545/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4690/8332)43%
(2077/4812)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 338 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/338/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 20:37:47 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/64/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 20:40:37 +
 Build duration:
5 min 19 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 471 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/471/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 20:37:47 +
 Build duration:
5 min 51 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.69.0.xmllogs/KF5KIO/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(274/410)67%
(274/410)56%
(35195/62415)40%
(17741/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(59/59)100%
(59/59)96%
(9937/10400)47%
(4578/9774)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(105/119)88%
(105/119)60%
(8757/14650)51%
(4543/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8332)43%
(2078/4816)src.gui100%
(4/4)100%
(4/4)87%
(276/318)58%
(145/250)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(708/1294)40%
(418/1038)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4286)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:ff9cadf00f21: [server] Dont make assumptions about 
the order of damage_buffer and attach… (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28147?vs=78041=78044

REVISION DETAIL
  https://phabricator.kde.org/D28147

AFFECTED FILES
  src/server/surface_interface.cpp

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:14b7f2c7ee72: [DesktopExecParser] Open 
{ssh,telnet,rlogin}:// urls with ktelnetservice (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27999?vs=77964=78043

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir added a comment.


  In D27999#630756 , @feverfew wrote:
  
  > Quick testing with `fish` protocol doesn't break anything KIOFuse side. 
Going to page in @ngraham, if it works for him with `smb` it's an all good from 
the "KIOFuse people" ;)
  >
  > Sorry for the delay!
  
  
  No problem. :)

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Heh, I'm having some de ja vu.
  
  I did this already, for the same situation  for the same bug:   
  https://bugs.kde.org/show_bug.cgi?id=397834#c19
  
  https://phabricator.kde.org/D28147
  
  for damage()
  
  Then damageBuffer got introduced with the existing bug!

REPOSITORY
  R127 KWayland

BRANCH
  dont-assume-that-damage-buffer-must-be-called-before-attach

REVISION DETAIL
  https://phabricator.kde.org/D28147

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

[Vlad Zahorodnii]

zzag added a comment.


  In general, the idea of raising a protocol error when the client tries to 
damage a surface with no buffer seems sensible. But the spec doesn't say 
damage_buffer requests must be followed by attach requests and we can't really 
predict the future.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28147

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The spec says nothing about the order between damage_buffer and attach
  requests.

TEST PLAN
  Firefox doesn't become frozen. Although there are still issues with resizing.

REPOSITORY
  R127 KWayland

BRANCH
  dont-assume-that-damage-buffer-must-be-called-before-attach

REVISION DETAIL
  https://phabricator.kde.org/D28147

AFFECTED FILES
  src/server/surface_interface.cpp

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25515: Only extract lyrics when the plain text flag is set

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems sane.

REPOSITORY
  R286 KFileMetaData

BRANCH
  lyricsExtraction

REVISION DETAIL
  https://phabricator.kde.org/D25515

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24895: [RFC] Drop implicit size from PC buttons

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart, #vdg
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Nathaniel Graham]

ngraham added a comment.


  Shipit!

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Alexander Saoutkin]

feverfew added a reviewer: ngraham.
feverfew accepted this revision.
feverfew added a subscriber: ngraham.
feverfew added a comment.


  Quick testing with `fish` protocol doesn't break anything KIOFuse side. Going 
to page in @ngraham, if it works for him with `smb` it's an all good from the 
"KIOFuse people" ;)
  
  Sorry for the delay!

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27210: add KDEconnect Icons

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Also this needs the corresponding dark versions submitted as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27210

To: mbruchert, #vdg, #kde_connect, ngraham
Cc: ngraham, albertvaka, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27235: add calindori icon in the new pm style

[Nathaniel Graham]

ngraham added a comment.


  Generally LGTM, though I agree that the hole in the top seems unnecessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27235

To: mbruchert, dkardarakos, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27255: nota

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27504: smb faster copy to local

[Nathaniel Graham]

ngraham added a comment.


  Still +1 functionally.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27760: WIP | Added BatchMoveJob

[Nathaniel Graham]

ngraham added a comment.


  The general concept seems sane to me, but let's make sure @dfaure agrees.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham updated this revision to Diff 78036.
ngraham added a comment.


  Forgot one more thing

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78035=78036

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham updated this revision to Diff 78035.
ngraham added a comment.


  Don't forget kirigamiplasmastyle

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78031=78035

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  D28143: Add "veryLongDuration" animation duration 

  
  D28144: Make animation durations consistent with Kirigami values 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now longDuration is 120ms and shortDuration is 24ms. This presents 
three problems:
  
  - The durations are far too fast, especially shortDuration, which is so fast 
that it seems like there is no animation at all.
  - The durations are not consistent with Kirigami, which uses 150 for short 
and 250 for long.
  - There is no longer value available, as with the one being added to Kirigami 
in D28143 .
  
  Accordingly, this patch makes the short and long values consistent with 
Kirigami's values,
  and adds a new `veryLongDuration` value to match the one being added to 
Kirigami in D28143 .

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  In fact it looks like Kirigami already uses 150 for short and 250 for long, 
so there's an argument for making Plasma consistent with that. Will submit 
patches.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26858: Provide an implementation for the tablet interface

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78028.
apol added a comment.


  rebase

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26858?vs=78027=78028

BRANCH
  arcpatch-D26858

REVISION DETAIL
  https://phabricator.kde.org/D26858

AFFECTED FILES
  CMakeLists.txt
  autotests/server/CMakeLists.txt
  autotests/server/test_tablet_interface.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/tablet_interface.cpp
  src/server/tablet_interface.h

To: apol, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D26858

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78027.
apol added a comment.


  Fix the refcounting
  Expose teh set_cursor interface as well

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26858?vs=77926=78027

BRANCH
  arcpatch-D26858

REVISION DETAIL
  https://phabricator.kde.org/D26858

AFFECTED FILES
  CMakeLists.txt
  autotests/server/CMakeLists.txt
  autotests/server/test_tablet_interface.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/tablet_interface.cpp
  src/server/tablet_interface.h

To: apol, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Christoph Feck]

cfeck added a comment.


  Are more changes planned?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: cfeck, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Marco Martin]

mart added a comment.


  In D28033#630450 , @ngraham wrote:
  
  >
  
  
  
  
  > shortDuration: 150ms
  >  longDuration: 250ms
  >  veryLongDuration: 500ms
  
  veryLongDuration doesn't sound too good, but if longduration goes 500ms 
probably a lot of existing things are going to look way too slow so +1 for 
compatibility

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D18878: Force NT1 protocol when listing smb:// network [work in progress]

[Mikhail Novosyolov]

mikhailnov abandoned this revision.
mikhailnov added a comment.


  +1, it is nod needed with recent WSD support

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, broulik, ngraham
Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 171 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/171/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 14:45:10 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 178 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/178/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 19 Mar 2020 14:45:06 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 285 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/285/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 14:45:06 +
 Build duration:
3 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D27927: Use more flexible shebang

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:485e7be3b7ef: Use more flexible shebang (authored by 
tcberner, committed by sitter).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27927?vs=77198=78011

REVISION DETAIL
  https://phabricator.kde.org/D27927

AFFECTED FILES
  generate-24px-versions.sh

To: tcberner, #freebsd, sitter, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25984: Load translations

[Volker Krause]

vkrause added a comment.


  In D25984#589426 , @mart wrote:
  
  > ping, what's the current status of this?
  
  
  There's also https://phabricator.kde.org/D27595, which might address the 
same/a similar issue.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: vkrause, mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra

D28129: Read the new message string after rather than before

[Harald Sitter]

sitter added a comment.


  Quick recap from what we talked about on telegram: putting the print after 
the bt is most definitely going to throw off the backtrace parsing logic, so 
doing it this way would require extensive changes there, which is a dangerous 
place to make extensive changes.
  Or we could define a simple function to ignore errors 
https://stackoverflow.com/questions/17923865/gdb-stops-in-a-command-file-if-there-is-an-error-how-to-continue-despite-the-er
 but that's also a bit faffy.
  Another completely standalone approach would be to change BacktraceGenerator 
(I think?) to invoke the print in a completely independent gdb invocation i.e. 
separate the print call from the regular batchcommands and have drkonqi 
assemble it back into the final report. That way the actual tracing batch 
command couldn't fail on the print.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28129

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27617: [breeze-icons] Add telegram-desktop tray icons

[David Redondo]

davidre added a comment.


  In D27617#630440 , @ilya-fedin 
wrote:
  
  > In D27617#629987 , @ngraham 
wrote:
  >
  > > Would it help this use case if we moved the Telegram icon into the Plasma 
theme for now, pending a fix in Telegram itself?
  >
  >
  > There is nothing to do on Telegram side. Everything that Telegram can get 
is icon theme name (sometime), does the icon exist, the icon itself and its 
sizes. Adding a dependency on kde frameworks is not a way, of course.
  >
  > In D27617#630392 , @IlyaBizyaev 
wrote:
  >
  > > Btw that overlay is always as tiny as on your screenshot, so not usable 
for a counter
  >
  >
  > +1. Moreover, icon is not recolored even with IconName + OverlayIconPixmap.
  
  
  Oh yes that's true :/. It's a similiar bug to the one I fixed not long ago. 
It seems the SNI desperately needs the change as outlined in the other diff by 
removing all the rendering from the data engine. This way also the sizing of 
the overlay, I think I noticed it being inconsistent between pixmap and 
overlayname path.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs, ndavis
Cc: davidre, ilya-fedin, broulik, alexeymin, IlyaBizyaev, ndavis, ngraham, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson added a comment.


  Relevant docs on the spec we're moving towards: 
https://github.com/systemd/systemd/pull/14846

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson updated this revision to Diff 78002.
davidedmundson added a comment.


  rebase on David F's work

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27883?vs=77071=78002

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27883

AFFECTED FILES
  src/gui/kprocessrunner.cpp
  src/gui/kprocessrunner_p.h

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/63/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 14:04:41 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson marked 6 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

zzag added a comment.


  Urgh, the authorship information is screwed up. :/

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for 
the xkb  keymap (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14910?vs=77916=78000

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/CMakeLists.txt
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D18878: Force NT1 protocol when listing smb:// network [work in progress]

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  We now have WS-Discovery support, so I don't think this patch is needed.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, broulik, ngraham
Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26794

To: leinir
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  I agree 150ms for shortDuration is much more sensible; the current speed it 
too short to even notice that something is animating. I think we need more 
durations though. My proposal would be something like this:
  
  shortDuration: 150ms
  mediumDuration: 250ms
  longDuration: 500ms
  
  Or, for compatibility with existing types:
  
  shortDuration: 150ms
  longDuration: 250ms
  veryLongDuration: 500ms

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D27617: [breeze-icons] Add telegram-desktop tray icons

[Ilya Fedin]

ilya-fedin added a comment.


  In D27617#629987 , @ngraham wrote:
  
  > Would it help this use case if we moved the Telegram icon into the Plasma 
theme for now, pending a fix in Telegram itself?
  
  
  There is nothing to do on Telegram side. Everything that Telegram can get is 
icon theme name (sometime), does the icon exist, the icon itself and its sizes. 
Adding a dependency on kde frameworks is not a way, of course.
  
  In D27617#630392 , @IlyaBizyaev 
wrote:
  
  > Btw that overlay is always as tiny as on your screenshot, so not usable for 
a counter
  
  
  +1. Moreover, icon is not recolored even with IconName + OverlayIconPixmap.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs, ndavis
Cc: davidre, ilya-fedin, broulik, alexeymin, IlyaBizyaev, ndavis, ngraham, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D18878: Force NT1 protocol when listing smb:// network [work in progress]

[Harald Sitter]

sitter removed a reviewer: sitter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, broulik
Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D25984: Load translations

[Harald Sitter]

sitter removed a reviewer: sitter.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

[Vlad Zahorodnii]

zzag added a comment.


  Maybe it would be worth to send an email to wm-spec-list proposing to 
deprecate LAUNCHED_BY, but on the other hand fixing X11 stuff in any way is 
like beating a dead horse.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28016

To: dfaure, zzag, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27883: Register spawned applications as an independent cgroups

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in kprocessrunner.cpp:281
> Who defines this environment variable?

I figured startplasma?

It's just so we don't change existing code with new frameworks

> apol wrote in kprocessrunner.cpp:302
> *signatuRe
> 
> Also I'm not sure I understand...

Maybe unused wasn't the right term.

I was saying this list will be empty. Maybe that's an unhelpful comment as you 
can see it's empty from the code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27871: sftp: fix seekPos + file resuming when part file is of size 11

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:d8cf85ec2f0f: sftp: fix seekPos + file resuming when part 
file is of size 11 (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27871?vs=77036=77991

REVISION DETAIL
  https://phabricator.kde.org/D27871

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, 
mikesomov

D28078: guard against duplicated service discoveries

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:ba96d3b93a96: smb: guard against duplicated service 
discoveries (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28078?vs=77737=77990

REVISION DETAIL
  https://phabricator.kde.org/D28078

AFFECTED FILES
  smb/discovery.h
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp
  smb/wsdiscoverer.h

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I don't 100% agree that "it doesn't seem used".
  
  It's used in KStartupInfoData::Private::to_text() which affects what gets 
written out over the wire to everyone else.
  At which point we can't just look internally at what we happen to use in KDE, 
we need to ask if anyone else in the world uses that property.
  
  From what I can tell, kwin doesn't read it back in any form, the spec does 
explicitly say it's optional, and not even GTK sets it...so it's probably safe.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28016

To: dfaure, zzag, broulik, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28020: New class ProcessLauncherJob in KIOGui

[David Edmundson]

davidedmundson added a comment.


  In D28020#630185 , @dfaure wrote:
  
  > Ah there was still the WId question. I'll remove it before anyone starts 
using this API.
  >
  > We can always add a setter later if we want to (but if it's just for the 
unused setLaunchedBy, I'm not convinced...)
  
  
  For wayland (which currently lacks a spec for this!) I will probably end up 
needing a QWindow
  
  But as you say, we can always add a setter later.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28020

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  In D27617#630339 , @davidre wrote:
  
  > Huh that case is working what I found that `IconName` and `OverlayIconName` 
is currently broken, see D28107 .
  >  `IconName and `OverlayIconPixmap` work fine  here F8184158: 
Screenshot_20200319_102827.PNG 
  >
  > If it doesn't for you please file a bug so we can investigate that.
  
  
  Btw that overlay is always as tiny as on your screenshot, so not usable for a 
counter

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs, ndavis
Cc: davidre, ilya-fedin, broulik, alexeymin, IlyaBizyaev, ndavis, ngraham, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:f1dcbddf12ea: Fix update scenarios with no explicit 
downloadlink selected (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27544?vs=77818=77989#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27544?vs=77818=77989

REVISION DETAIL
  https://phabricator.kde.org/D27544

AFFECTED FILES
  CMakeLists.txt
  src/core/engine.cpp
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store, ahiemstra
Cc: ahiemstra, alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Arjen Hiemstra]

ahiemstra accepted this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store, ahiemstra
Cc: ahiemstra, alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/88/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 10:22:57 +
 Build duration:
4 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/74/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 19 Mar 2020 10:23:12 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 286 lines...][2020-03-19T10:24:07.328Z] -- The following REQUIRED packages have been found:[2020-03-19T10:24:07.328Z] [2020-03-19T10:24:07.328Z]  * Qt5Network (required version >= 5.13.1)[2020-03-19T10:24:07.328Z]  * Qt5Qml[2020-03-19T10:24:07.328Z]  * Qt5QuickWidgets[2020-03-19T10:24:07.328Z]  * Qt5 (required version >= 5.12.0)[2020-03-19T10:24:07.328Z]  * KF5ItemViews (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-19T10:24:07.328Z]  * KF5GuiAddons (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * Gettext[2020-03-19T10:24:07.328Z]  * KF5I18n (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * KF5Service (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-19T10:24:07.328Z]  * KF5Auth (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * KF5Codecs (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-19T10:24:07.328Z]  * KF5WidgetsAddons (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * KF5ConfigWidgets (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * KF5XmlGui (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * Qt5Quick (required version >= 5.12.0)[2020-03-19T10:24:07.328Z]  * KF5CoreAddons (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2020-03-19T10:24:07.328Z]  * KF5Package (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * KF5Declarative (required version >= 5.68.0)[2020-03-19T10:24:07.328Z]  * Doxygen (required version >= 1.8.13)[2020-03-19T10:24:07.328Z]Needed for API dox QCH file generation[2020-03-19T10:24:07.328Z]  * QHelpGenerator, Part of Qt5 tools[2020-03-19T10:24:07.328Z]Needed for API dox QCH file generation[2020-03-19T10:24:07.328Z]  * Qt5Core[2020-03-19T10:24:07.328Z] [2020-03-19T10:24:07.328Z] -- Configuring done[2020-03-19T10:24:07.328Z] -- Generating done[2020-03-19T10:24:07.328Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-19T10:24:09.010Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcmutils --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5KCMUtils_autogen[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5ConfigWidgets_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5Codecs_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5Auth_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5Config_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5Service_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2020-03-19T10:24:09.010Z] [  0%] Built target KF5CoreAddons_QCH[2020-03-19T10:24:09.010Z] [  0%] Built target KF5ConfigWidgets_QCH[2020-03-19T10:24:09.010Z] [  0%] Built target KF5Auth_QCH[2020-03-19T10:24:09.010Z] [  0%] Built target KF5WidgetsAddons_QCH[2020-03-19T10:24:09.010Z] [  0%] Built target KF5Config_QCH[2020-03-19T10:24:09.010Z] [  0%] Built target KF5Codecs_QCH[2020-03-19T10:24:09.010Z] [  6%] Automatic MOC for target KF5KCMUtils[2020-03-19T10:24:09.010Z] [  6%] Built target KF5Service_QCH[2020-03-19T10:24:09.010Z] Scanning dependencies of target KF5KCMUtils_QCH[2020-03-19T10:24:09.010Z] [ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[2020-03-19T10:24:09.265Z] [ 12%] Built target KF5KCMUtils_autogen[2020-03-19T10:24:09.562Z] Scanning dependencies of target KF5KCMUtils[2020-03-19T10:24:09.562Z] Building up file structure...[2020-03-19T10:24:09.562Z] Insert custom filters...[2020-03-19T10:24:09.562Z] Insert help data for filter section (1 of 1)...[2020-03-19T10:24:09.562Z] Insert files...[2020-03-19T10:24:09.562Z] Insert contents...[2020-03-19T10:24:09.562Z] Insert indices...[2020-03-19T10:24:09.562Z] Documentation successfully generated.[2020-03-19T10:24:09.562Z] [ 18%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/KF5KCMUtils_autogen/mocs_compilation.cpp.o[2020-03-19T10:24:09.562Z] [ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[2020-03-19T10:24:09.562Z] [ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kpluginselector.cpp.o[2020-03-19T10:24:09.562Z] [ 43%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o[2020-03-19T10:24:09.562Z] [ 37%] Building CXX object 

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 107 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/107/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 10:23:11 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 286 lines...][2020-03-19T10:24:01.255Z] -- The following REQUIRED packages have been found:[2020-03-19T10:24:01.255Z] [2020-03-19T10:24:01.255Z]  * Qt5Network (required version >= 5.12.7)[2020-03-19T10:24:01.255Z]  * Qt5Qml[2020-03-19T10:24:01.255Z]  * Qt5QuickWidgets[2020-03-19T10:24:01.255Z]  * Qt5 (required version >= 5.12.0)[2020-03-19T10:24:01.255Z]  * KF5ItemViews (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-19T10:24:01.255Z]  * KF5GuiAddons (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * Gettext[2020-03-19T10:24:01.255Z]  * KF5I18n (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * KF5Service (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-19T10:24:01.255Z]  * KF5Auth (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * KF5Codecs (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-19T10:24:01.255Z]  * KF5WidgetsAddons (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * KF5ConfigWidgets (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * KF5XmlGui (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * Qt5Quick (required version >= 5.12.0)[2020-03-19T10:24:01.255Z]  * KF5CoreAddons (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2020-03-19T10:24:01.255Z]  * KF5Package (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * KF5Declarative (required version >= 5.68.0)[2020-03-19T10:24:01.255Z]  * Doxygen (required version >= 1.8.13)[2020-03-19T10:24:01.255Z]Needed for API dox QCH file generation[2020-03-19T10:24:01.255Z]  * QHelpGenerator, Part of Qt5 tools[2020-03-19T10:24:01.255Z]Needed for API dox QCH file generation[2020-03-19T10:24:01.255Z]  * Qt5Core[2020-03-19T10:24:01.255Z] [2020-03-19T10:24:01.255Z] -- Configuring done[2020-03-19T10:24:01.255Z] -- Generating done[2020-03-19T10:24:01.255Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-19T10:24:03.294Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcmutils --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5Auth_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5Service_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5KCMUtils_autogen[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5ConfigWidgets_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5Codecs_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5Config_QCH[2020-03-19T10:24:03.294Z] [  0%] Built target KF5Service_QCH[2020-03-19T10:24:03.294Z] [  6%] Built target KF5CoreAddons_QCH[2020-03-19T10:24:03.294Z] [  6%] Automatic MOC for target KF5KCMUtils[2020-03-19T10:24:03.294Z] [  6%] Built target KF5Auth_QCH[2020-03-19T10:24:03.294Z] [  6%] Built target KF5WidgetsAddons_QCH[2020-03-19T10:24:03.294Z] [  6%] Built target KF5Codecs_QCH[2020-03-19T10:24:03.294Z] [  6%] Built target KF5ConfigWidgets_QCH[2020-03-19T10:24:03.294Z] [  6%] Built target KF5Config_QCH[2020-03-19T10:24:03.294Z] Scanning dependencies of target KF5KCMUtils_QCH[2020-03-19T10:24:03.294Z] [ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[2020-03-19T10:24:03.560Z] [ 12%] Built target KF5KCMUtils_autogen[2020-03-19T10:24:03.560Z] Scanning dependencies of target KF5KCMUtils[2020-03-19T10:24:03.560Z] [ 18%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[2020-03-19T10:24:03.560Z] [ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/KF5KCMUtils_autogen/mocs_compilation.cpp.o[2020-03-19T10:24:03.560Z] [ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleloader.cpp.o[2020-03-19T10:24:03.560Z] [ 37%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/ksettingswidgetadaptor.cpp.o[2020-03-19T10:24:03.560Z] [ 43%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o[2020-03-19T10:24:03.560Z] [ 56%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kpluginselector.cpp.o[2020-03-19T10:24:03.560Z] [ 56%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleqml.cpp.o[2020-03-19T10:24:03.560Z] [ 62%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleproxy.cpp.o[2020-03-19T10:24:03.560Z] [ 68%] 

D28130: Introduce api for passive notifications

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications 
(authored by mart).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77983=77987

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart, broulik
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28131: listen to passiveNotificationRequested

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:3fe22e067a73: listen to passiveNotificationRequested 
(authored by mart).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28131?vs=77984=77988

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  phab/passiveNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28131

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart, broulik
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28131: listen to passiveNotificationRequested

[Marco Martin]

mart updated this revision to Diff 77984.
mart added a comment.


  - const QVariant 

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28131?vs=77941=77984

BRANCH
  phab/passiveNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart updated this revision to Diff 77983.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77982=77983

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart updated this revision to Diff 77982.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77940=77982

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow which is better to not have inconsitencies

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir added a comment.


  In D27999#630329 , @dfaure wrote:
  
  > Only if an external browser is set, but yeah.
  
  
  Right, I missed the bit about the external browser; however with the recent 
change to fallback to mimeapps.list if external browser is empty, it "should" 
be OK...

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ExpandableListItem.qml:230
> If it's multiplied by a factor it's not a "standard duration" anymore.

to me this tells more that

- default durations right now are waaay too short
- we don't take into account that for movements and resizes, the actual 
duration should be a function of the travel distance, rather than a fixed 
duration

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Marco Martin]

mart added a comment.


  In D28033#630073 , @ngraham wrote:
  
  > (WRT duration) What should I do then? Hardcode something? Add a new 
duration in a separate patch? The only standard durations we have are all quite 
short; neither one feels suitable for the animation I'm using here.
  
  
  to me the real problem is really the default settings for durations 
longDuration became 150ms or so, (shortduration is something so short that 
usually the animation frames just gets dropped altogether so it's pointless to 
even use it ever)
  I know this was done in the attempt of improving animations, but the end 
effect is ridiculous and makes animations actually looking worse, either 
comically fast (super fast fades are ok, item movements or resizes shouldn't 
actually be too fast, or be perceived as threatening) or no frames rendered at 
all even if there is code for it
  the original default values of 150 and 250 msecs for short and long were 
quite fine actually
  
  also, we should probably start into looking using SmoothedAnimation speed 
more rather than durations (to not fix travel time, but travel speed) (as 
animators don't support it and we would need something that reacts to global 
animations settings probably we would need our implementation of the speed 
concept)
  
  https://valhead.com/2016/05/05/how-fast-should-your-ui-animations-be/
  https://www.nngroup.com/articles/too-fast-ux/
  
https://uxdesign.cc/the-ultimate-guide-to-proper-use-of-animation-in-ux-10bd98614fa9

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D27617: [breeze-icons] Add telegram-desktop tray icons

[David Redondo]

davidre added a comment.


  In D27617#630336 , @IlyaBizyaev 
wrote:
  
  > In D27617#630228 , @ngraham 
wrote:
  >
  > > So... how do we fix this so that you can use a nice monochrome Breeze 
icon in your system tray? Whose code needs to change?
  >
  >
  >
  >
  > 1. SNI implementation in Plasma needs to be fixed to properly support 
OverlayIconPixmap 

 with IconName. From what I understand, since it affects a data engine and that 
is considered public API, this might have to wait for Plasma 6
  > 2. Since old versions of Plasma will still have the issue, and other SNI 
implementations likely don't support this either, this can't become the default 
behavior for Telegram; so there has to be a way for Telegram to check if an SNI 
implementation supports what it needs
  > 3. Then Telegram code needs to add a special case for that.
  >
  >   Since I feel like a proxy at this point, tagging @davidre and @ilya-fedin.
  
  
  Huh that case is working what I found that `IconName` and `OverlayIconName` 
is currently broken, see D28107 .
  `IconName and `OverlayIconPixmap` work fine  here F8184158: 
Screenshot_20200319_102827.PNG 
  
  If it doesn't for you please file a bug so we can investigate that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs, ndavis
Cc: davidre, ilya-fedin, broulik, alexeymin, IlyaBizyaev, ndavis, ngraham, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Ilya Bizyaev]

IlyaBizyaev added subscribers: ilya-fedin, davidre.
IlyaBizyaev added a comment.


  In D27617#630228 , @ngraham wrote:
  
  > So... how do we fix this so that you can use a nice monochrome Breeze icon 
in your system tray? Whose code needs to change?
  
  
  
  
  1. SNI implementation in Plasma needs to be fixed to properly support 
OverlayIconPixmap 

 with IconName. From what I understand, since it affects a data engine and that 
is considered public API, this might have to wait for Plasma 6
  2. Since old versions of Plasma will still have the issue, and other SNI 
implementations likely don't support this either, this can't become the default 
behavior for Telegram; so there has to be a way for Telegram to check if an SNI 
implementation supports what it needs
  3. Then Telegram code needs to add a special case for that.
  
  Since I feel like a proxy at this point, tagging @davidre and @ilya-fedin.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs, ndavis
Cc: davidre, ilya-fedin, broulik, alexeymin, IlyaBizyaev, ndavis, ngraham, 
kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[David Faure]

dfaure added a comment.


  Only if an external browser is set, but yeah.

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

[David Redondo]

davidre added a comment.


  I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> configmodule.h:507
> + */
> +void showPassiveNotification(const QString , QVariant timeout = 
> QVariant(), const QString  = QString(), const QJSValue  = 
> QJSValue());
>  Q_SIGNALS:

`const QVariant &`

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns