D28637: Use ecm_setup_qtplugin_macro_names

This revision was automatically updated to reflect the committed changes. Closed by commit R295:d16f10e2ee1e: Use ecm_setup_qtplugin_macro_names (authored by kossebau). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28637?vs=79539=79548 REVISION DETAIL

D28637: Use ecm_setup_qtplugin_macro_names

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH useECMSetupQtPluginMacroNames REVISION DETAIL https://phabricator.kde.org/D28637 To: kossebau, #frameworks, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. I haven't been working on it. There's an outstanding request to do this in a combination of CMake and Python, so it's cross-platform for Windows users of Breeze Icons too (see D27557#622879 ). Honestly I need to re-do the

D28636: Use ecm_setup_qtplugin_macro_names

This revision was automatically updated to reflect the committed changes. Closed by commit R308:423f9b88e0ca: Use ecm_setup_qtplugin_macro_names (authored by kossebau). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28636?vs=79538=79541 REVISION DETAIL

D28636: Use ecm_setup_qtplugin_macro_names

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH useECMSetupQtPluginMacroNames REVISION DETAIL https://phabricator.kde.org/D28636 To: kossebau, #frameworks, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D28637: Use ecm_setup_qtplugin_macro_names

kossebau created this revision. kossebau added reviewers: Frameworks, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Avoids all the explicit boilerplate needed, consistent with other KF

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28636: Use ecm_setup_qtplugin_macro_names

kossebau created this revision. kossebau added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Avoids all the explicit boilerplate needed, consistent with other KF

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. @ngraham How’s your progress with the bash script? I’m currently trying to understand bash syntax. Maybe I can do it, if you don’t have done it already. TASK DETAIL https://phabricator.kde.org/T12855 To: davidhurka Cc: ndavis, ngraham, kde-frameworks-devel,

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 413 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/413/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 06 Apr 2020 20:50:49 + Build duration: 41 sec and counting CONSOLE OUTPUT [...truncated 296

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/20/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 20:50:49 + Build duration: 1 min 13 sec and counting JUnit Tests Name:

D27263: RFC: Accent colour for KColorScheme

ngraham added a comment. Whoops, my bad. Tested this and found that setting an accept color seems to work for apps, but unsetting it doesn't go back to the color-scheme-provided one. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack,

D28444: Add ECMCargo module

cblack updated this revision to Diff 79521. cblack added a comment. Add STATIC_LIBNAME and DYNAMIC_LIBNAME options REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=79430=79521 BRANCH cblack/cargo-integration REVISION DETAIL

D28444: Add ECMCargo module

IlyaBizyaev added a comment. I don't have enough CMake knowledge to give code comments, but here are some things I can notice in case they help in review: 1. The function specifically mentions Cargo workspace, which is basically a Rust alternative to `TEMPLATE = subdirs` in qmake. It

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 79517. cblack added a comment. Fix typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75311=79517 BRANCH kcolorscheme-accent (branched from master) REVISION DETAIL

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka added a comment. Is it OK now? Any other review comments? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson Cc: davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2,

D27848: Remove the panel tooltip icon

ngraham added a comment. Fixed in 7aaee715aff2a3fadf950f686a8be5e0d49c3297 and did it the correct way in 1f0cf38dbf2eb7de2b7fe09ef82bbb281a296a68

D27840: Introduce SettingState* elements to ease KCM writing

crossi added a dependent revision: D28629: [WIP] Port KCM to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: broulik, kde-frameworks-devel,

D27848: Remove the panel tooltip icon

davidre added a comment. In D27848#643045 , @ngraham wrote: > See the parent task. > > This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these

D27848: Remove the panel tooltip icon

broulik added a comment. > For all panel widgets which are all governed by a single place: `plasma-desktop/desktoppackage/contents/applet/CompactApplet.qml` Imho an unacceptable behavior break for a Frameworks component. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27848: Remove the panel tooltip icon

ngraham added a comment. See the parent task. This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these tooltips, because they're either redundant or inconsistent with the icon that you're

D28460: Add KCModuleStateProbe as base class for plugin

bport updated this revision to Diff 79496. bport added a comment. Take in consideration feedbacks REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28460?vs=78969=79496 REVISION DETAIL https://phabricator.kde.org/D28460 AFFECTED FILES

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Now we have less than 130 icons which are different in icons/ and icons-dark/, and less than 100 icons which we should keep as dark version. Maybe we can keep event less. I have sorted them into two files. F8221155: dark_icons_to_keep.txt

D27840: Introduce SettingState* elements to ease KCM writing

crossi added a dependent revision: D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma

D28532: Introduce more user-visible error reporting for installations

This revision was automatically updated to reflect the committed changes. Closed by commit R304:eb23f549ea9b: Introduce more user-visible error reporting for installations (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D28624: Print a warning if runner is incompatible with KRunner

davidre created this revision. davidre added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Useful for finding out why runner isn't loaded even though it's enabled in

D28620: Add readmes clarifying state of plasma component versions

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0051a4f919b6: Add readmes clarifying state of plasma component versions (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28620: Add readmes clarifying state of plasma component versions

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D28620 To: davidedmundson, #plasma, apol, romangg, mart Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH more-installation-error-handling (branched from master) REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc:

D28620: Add readmes clarifying state of plasma component versions

romangg accepted this revision. romangg added a comment. If you want to you can also add a ⚠️ (`:warning:`) emoticon to the deprecated text and in both some headings with `#`, `##`, etc. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/19/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 13:47:53 + Build duration: 1 min 30 sec and counting JUnit Tests Name:

D28620: Add readmes clarifying state of plasma component versions

davidedmundson updated this revision to Diff 79479. davidedmundson added a comment. use .md REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28620?vs=79467=79479 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28620

D28620: Add readmes clarifying state of plasma component versions

romangg added a comment. README.md is common for viewing in modern code hosting solutions with markdown support. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D28620 To: davidedmundson, #plasma,

D28620: Add readmes clarifying state of plasma component versions

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D28620 To: davidedmundson, #plasma, apol Cc:

D27848: Remove the panel tooltip icon

davidre added a comment. I think this was done at the wrong level. If we don't want icons in the systray then the way would be to net set the property in the systray and not ignore the property in the generic component but keep the property for api stability purposes. Now we have a

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir updated this revision to Diff 79474. leinir added a comment. - Merge branch 'master' into more-installation-error-handling - Actually read the error (not just all) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79195=79474 BRANCH

D28606: Add iconSize property to PC2 ToolButton

ndavis abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma, mart Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28599: [configview] Simplify code / workaround Qt5.15 crash

davidedmundson updated this revision to Diff 79469. davidedmundson added a comment. setContextProprerties REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28599?vs=79423=79469 BRANCH master REVISION DETAIL

D28599: [configview] Simplify code / workaround Qt5.15 crash

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0417bf61d53a: [configview] Simplify code / workaround Qt5.15 crash (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 06 Apr 2020 11:21:17 + Build duration: 7 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 11:21:17 + Build duration: 6 min 3 sec and counting JUnit Tests Name:

D28620: Add readmes clarifying state of plasma component versions

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN N/A REPOSITORY R242 Plasma Framework (Library) BRANCH

D28463: do not install testengine

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6e39c1de5bb3: do not install testengine (authored by sitter). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28463?vs=78974=79464 REVISION

D28606: Add iconSize property to PC2 ToolButton

mart added a comment. I don't think we should put any new feature in plasmacomponents2. it will be removed in qt6 anyways and work should be more concentrated to a) port away from it altogether abd b) if the pc3 version doesn't work, put effort in fixing that REPOSITORY R242 Plasma

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

This revision was automatically updated to reflect the committed changes. Closed by commit R320:daec307b59e9: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27804: smb: add hack to support spaces in workgroup names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:f40191a147c9: smb: add hack to support spaces in workgroup names (authored by sitter). CHANGED PRIOR TO COMMIT

D27902: smb: figure out the best host to use for the UDS_URL

sitter abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela,

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

davidedmundson added a comment. > He said he wouldn't accept patches that do that for notifications or KRunner because of the issues with PC3 I doubt that's what was meant. There have definitely been some bad patches that blindly ported to PC3 without adequate testing. That's