D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

zzag added a comment. Thanks, this patch looks good to me. Although it would be nice to see the kwin side before leaving a +1. :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi, kde-frameworks-devel,

D28882: Create protocol to manage video feeds

zzag added a comment. In D28882#658780 , @apol wrote: > > In future, it might be faster to put up just the interface xml for review first. > > @davidedmundson @zzag I don't really see how it would have made a difference, you only decided

Re: Information regarding upcoming Gitlab Migration

Hi Olivier, On Mon, Apr 27, 2020 at 10:49:46PM +0200, Olivier Churlaud wrote: > >Because in order to search for something, you need to know it exists. > > > >If you are just casually browsing, then the search can't help you. > > I don't think people casually browse our repos. What use case is

Re: Information regarding upcoming Gitlab Migration

Hi Ingo, On Mon, Apr 27, 2020 at 03:46:13PM +0200, Ingo Klöcker wrote: > > > I'm sorry, but I don't think that this is solved by your proposal for the > > > KDE PIM projects because not everything related to KDE PIM (e.g. relevant > > > frameworks like kcontacts, kholidays, kpeople and soon kdav)

Re: Information regarding upcoming Gitlab Migration

Hi Nate, On Mon, Apr 27, 2020 at 07:45:23AM -0600, Nate Graham wrote: > Trying to categorize everything into a single group cannot succeed because > many projects could logically belong to multiple groups (e.g > plasma-framework is a framework that's a part of Plasma; Discover is an app > that's

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

apol added inline comments. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:144 > +QPair key(surface, seat); > +if (m_inhibitors.contains(key)) { > +return m_inhibitors[key]; Just `return m_inhibitors.value({ surface, seat })` to save a look-up and a few lines of

D28882: Create protocol to manage video feeds

apol added a comment. > In future, it might be faster to put up just the interface xml for review first. @davidedmundson @zzag I don't really see how it would have made a difference, you only decided to review it 7 to 10 days after I first submitted it. 路 > What about using

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81386. bport added a comment. fix qobject macro indentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81385=81386 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81385. bport added a comment. fix test, and take in consideration zzag feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81361=81385 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added a comment. @broulik ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29153 To: dfaure, ahmadsamir, broulik, ngraham, mdlubakowski Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29206 To: dfaure, ahmadsamir, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

ahmadsamir accepted this revision. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in kprocessrunner.cpp:55 > I see what you're saying. > > It's the name of the spec, though. >

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29170 To: dfaure, ahmadsamir Cc: ngraham, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29239: [KPlotting] foreach is gone, build with -DQT_NO_FOREACH

This revision was automatically updated to reflect the committed changes. Closed by commit R277:a6c269a6b2ce: [KPlotting] foreach is gone, build with -DQT_NO_FOREACH (authored by ahmadsamir). REPOSITORY R277 KPlotting CHANGES SINCE LAST UPDATE

D29239: [KPlotting] foreach is gone, build with -DQT_NO_FOREACH

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting BRANCH l-no-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29239 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D29232: [WIP][RFC]Introduce the Header color set

ndavis added inline comments. INLINE COMMENTS > davidre wrote in kcolorscheme.cpp:271 > I would have expected at least of one the new colors to have the same value > as this one. Why is that? The only one that might is Active, but that's not really used much right now. REPOSITORY R265

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 21:07:57 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

D29233: [Solid] Port foreach to range/index for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:dd878b1c2933: [Solid] Port foreach to range/index for (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29233?vs=81359=81382 REVISION DETAIL

D29239: [KPlotting] foreach is gone, build with -DQT_NO_FOREACH

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R277 KPlotting BRANCH l-no-foreach (branched from master) REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 21:00:42 + Build duration: 2 min 1 sec and counting JUnit Tests Name:

D29229: [KPlotting] Port foreach (deprecated) to range for

This revision was automatically updated to reflect the committed changes. Closed by commit R277:8281cb629ffa: [KPlotting] Port foreach (deprecated) to range for (authored by ahmadsamir). REPOSITORY R277 KPlotting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29229?vs=81339=81380

D29221: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType

This revision was automatically updated to reflect the committed changes. Closed by commit R245:c4e8755ac324: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

Re: Information regarding upcoming Gitlab Migration

Le 27 avril 2020 22:33:12 GMT+02:00, Ben Cooksley a écrit : >On Tue, Apr 28, 2020 at 8:31 AM Albert Astals Cid >wrote: >> >> El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va >escriure: >> > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: >> > > >> > > Hi, >> > >

Re: Information regarding upcoming Gitlab Migration

El dilluns, 27 d’abril de 2020, a les 3:40:01 CEST, Bhushan Shah va escriure: > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham added a dependent revision: D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack,

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

ngraham created this revision. ngraham added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY New standard shortcuts were added in D28802 and

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 8:31 AM Albert Astals Cid wrote: > > El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va escriure: > > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > > wrote: > > > > > > Hi, > > > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > >

Re: Information regarding upcoming Gitlab Migration

El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va escriure: > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > >

D29232: [WIP][RFC]Introduce the Header color set

davidre added inline comments. INLINE COMMENTS > kcolorscheme.cpp:271 > static const DecoDefaultColors defaultDecorationColors = { > { 61, 174, 233 }, // Focus > { 147, 206, 233 }, // Hover I would have expected at least of one the new colors to have the same value as this one.

Re: Information regarding upcoming Gitlab Migration

El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va escriure: > In part I am mostly re-iterating what Ben already mentioned in different > messages. > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > > Does this mean that to clone it we'll have to go "git clone > >

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/76/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 19:45:51 + Build duration: 6 min 49 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/68/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 19:45:51 + Build duration: 6 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 567 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/567/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 27 Apr 2020 19:45:51 + Build duration: 5 min 15 sec and counting BUILD ARTIFACTS

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added a comment. In D29170#658605 , @ngraham wrote: > What does this mean for AppImages? They are not desktop files, they don't come into this code path (which takes a KService as input). Clicking on a +x AppImage asks for

D29095: Change mouse icon to have better dark theme contrast

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D29095 REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari, ngraham Cc: bruns, ouwerkerk, ndavis,

D29170: Detect executables without +x permission in $PATH to improve error message

ngraham added a comment. What does this mean for AppImages? REPOSITORY R241 KIO BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170 To: dfaure, ahmadsamir Cc: ngraham, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/67/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 19:25:36 + Build duration: 12 min and counting BUILD ARTIFACTS

D29233: [Solid] Port foreach to range/index for

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH l-foreach-3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29233 To: ahmadsamir, #frameworks, dfaure, bruns, meven Cc: kde-frameworks-devel, LeGast00n,

D29229: [KPlotting] Port foreach (deprecated) to range for

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29229 To: ahmadsamir, #frameworks, dfaure, apol, meven Cc: kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/75/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 19:25:36 + Build duration: 8 min 22 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 566 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/566/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 27 Apr 2020 19:25:36 + Build duration: 5 min 7 sec and counting BUILD ARTIFACTS

D29221: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH l-mediumtypes (branched from master) REVISION DETAIL https://phabricator.kde.org/D29221 To: ahmadsamir, #frameworks, dfaure, meven, bruns Cc: kde-frameworks-devel, LeGast00n,

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81377. dfaure added a comment. Remove unused QFileInfo include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29170?vs=81376=81377 BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29216 To: dfaure, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81376. dfaure added a comment. Remove QDir::current REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29170?vs=81275=81376 BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170 AFFECTED FILES

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kprocessrunner.cpp:65 > I guess there is no need to use QDir::current() any more. Good point, removing. REPOSITORY R241 KIO BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170 To: dfaure,

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kprocessrunner.cpp:55 > IMHO, the word "entry" here is confusing, the first thing that comes to mind > is that an entry (i.e. a line) in the file is invalid. I see what you're saying. It's the name of the spec, though.

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 1:46 AM Nate Graham wrote: > > > > On 4/27/20 4:38 AM, Aleix Pol wrote: > > Does this mean that to clone it we'll have to go "git clone > > kde:games/knetwalk" or something along the lines? > > > > If that's the case I'd much prefer if we didn't do this, at the moment > >

D29232: [WIP][RFC]Introduce the Header color set

cblack added inline comments. INLINE COMMENTS > ndavis wrote in kcolorscheme.h:133 > I think it would be good to explain the issue about enums being converted > into plain integers here so that people know why they shouldn't depend on it. > Also, is there a way to hide this from the

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

ahmadsamir added a comment. Otherwise makes sense. INLINE COMMENTS > kprocessrunner.cpp:55 > +if (!service->isValid()) { > +emitDelayedError(i18n("The desktop entry file\n%1\nis not valid.", > service->entryPath())); > +return; IMHO, the word "entry" here is confusing,

D29095: Change mouse icon to have better dark theme contrast

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29095: Change mouse icon to have better dark theme contrast

ndavis updated this revision to Diff 81374. ndavis added a comment. - Change kmousetool and preferences-desktop-mouse to symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81211=81374 BRANCH arcpatch-D29095 REVISION DETAIL

D29095: Change mouse icon to have better dark theme contrast

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

romangg added inline comments. INLINE COMMENTS > zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:129 > We probably need to ask folks in `#wayland` whether inhibitors outlive the > manager object. In general objects created through some interface can outlive the interface bind if not

D28882: Create protocol to manage video feeds

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. > In future, it might be faster to put up just the interface xml for review first. ++ --- What about using existing `wl_output` objects? The `add_source` event can be

D29101: KNewStuff: Fix file path and process call

ngraham added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. I don't want to be selfish, but I'm not really used to the coding style in this patch. Could you please move method definitions outside class declarations? INLINE COMMENTS >

D29232: [WIP][RFC]Introduce the Header color set

mart requested review of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

mart retitled this revision from "[WIP][RFC]Introduce the Tools color set" to "[WIP][RFC]Introduce the Header color set". mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL

D29232: [WIP][RFC]Introduce the Tools color set

ndavis added inline comments. INLINE COMMENTS > kcolorscheme.h:133 > * Number of color sets. > + * Note: don't use this > * @since 5.65 I think it would be good to explain the issue about enums being converted into plain integers here so that people know why they

D29232: [WIP][RFC]Introduce the Tools color set

ndavis added inline comments. INLINE COMMENTS > kcolorscheme.h:127 > +/** > + * Colors for header areas that thould be used both by the top > toolbar and the titlebar titlebar. > + * @since 5.69 - `thould` - `titlebar titlebar` REPOSITORY R265 KConfigWidgets BRANCH

D29232: [WIP][RFC]Introduce the Tools color set

mart updated this revision to Diff 81363. mart added a comment. call it Header REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29232?vs=81352=81363 BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 565 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/565/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 27 Apr 2020 16:04:46 + Build duration: 12 min and counting BUILD ARTIFACTS

D29232: [WIP][RFC]Introduce the Tools color set

ndavis added a comment. I personally think it should be Header since Tools sound ambiguous and oddly limited to anyone unfamiliar with the context behind this patch REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg,

Re: Information regarding upcoming Gitlab Migration

Hello Bhushan! Thank you for you work on the Gitlab migration! The lists look good! Here are some ideas that I have, in case you think they can be considered before we transition: • The "applications" category is somewhat misleading to me: it does not include all KDE applications, and not

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 74 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/74/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 16:04:46 + Build duration: 8 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/66/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 27 Apr 2020 16:04:46 + Build duration: 5 min 19 sec and counting BUILD ARTIFACTS

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81361. bport added a comment. Use client not display for KeyboardShortcutsInhibitorInterface REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81358=81361 REVISION DETAIL https://phabricator.kde.org/D29231

D29084: Make the HTML file template more useful

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5adaa7cba102: Make the HTML file template more useful (authored by gszymaszek). REPOSITORY R241 KIO CHANGES SINCE

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 7:52 AM, Nate Graham wrote: On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing

Re: Information regarding upcoming Gitlab Migration

Hi, Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin

Re: Information regarding upcoming Gitlab Migration

On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: > [adding sysad...@kde.org in CC, please make sure you keep it in CC] > > On Mon, Apr 27, 2020 at 02:03:48PM +0200, Ingo Klöcker wrote: > > On Montag, 27. April 2020 13:19:07 CEST Ben Cooksley wrote: > > > That requires that you know it

Re: Information regarding upcoming Gitlab Migration

Le lundi 27 avril 2020, 13:19:07 CEST Ben Cooksley a écrit : > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > > [Please keep

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing kcontacts with kdepim should be possible, then

Re: Information regarding upcoming Gitlab Migration

On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol, wrote: > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin team wants to

Re: Information regarding upcoming Gitlab Migration

On 4/27/20 4:38 AM, Aleix Pol wrote: Does this mean that to clone it we'll have to go "git clone kde:games/knetwalk" or something along the lines? If that's the case I'd much prefer if we didn't do this, at the moment it's already uncomfortable for me to remember the URL for some of the

D29233: [Solid] Port foreach to range/index for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, bruns, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R245 Solid BRANCH l-foreach-3 (branched from master) REVISION DETAIL

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

apol added a comment. Code looks good overall, I'd say you'll get to polish the weird bits when developing the kwin side. In fact, this probably could be implemented within kwin considering what we discussed last week. We could remove the weirdness we have to keep its ABI. INLINE

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81358. bport marked an inline comment as done. bport added a comment. added const to wrong line REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81355=81358 REVISION DETAIL https://phabricator.kde.org/D29231

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

This revision was automatically updated to reflect the committed changes. Closed by commit R127:185f40195dc0: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order (authored by bport). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81355. bport added a comment. Cyril feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81351=81355 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES autotests/server/CMakeLists.txt

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Tools color set

ngraham added a task: T10201: Window titlebars. REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

crossi added inline comments. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:92 > +{ > +return d->m_surface; > +} indentation is missing > keyboard_shortcuts_inhibit_interface.h:39 > +void setActive(bool active); > +bool isActive(); > +private: Should be const REPOSITORY

D29232: [WIP][RFC]Introduce the Tools color set

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. +1 to the approach here. I assume this would probably replace the `WM` set in kdeglobals for all practical usage? REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL

D29232: [WIP][RFC]Introduce the Tools color set

mart retitled this revision from "Introduce the Tools color set" to "[WIP][RFC]Introduce the Tools color set". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29232: Introduce the Tools color set

mart created this revision. mart added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY This introduces two concepts: a new color set for Tools (or: titlebar? open question)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 15:22:51 + Build duration: 5 min 17 sec and counting JUnit Tests Name:

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport created this revision. bport added reviewers: zzag, davidedmundson, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Depends on D29054 . REPOSITORY

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport added a dependent revision: D29231: [WIP] Add keyboard_shortcuts_inhibit protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29222: Fix update auto selection

ngraham added a comment. Are you on a case-insensitive filesystem? :p /home/nate/kde/src/knewstuff/src/core/engine.cpp: In member function ‘void KNSCore::Engine::downloadLinkLoaded(const KNSCore::EntryInternal&)’: /home/nate/kde/src/knewstuff/src/core/engine.cpp:650:91: error:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. This version looks great to me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29188: [FileWatch] Remove redundant watchIndexedFolders() slot

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1793785420b7: [FileWatch] Remove redundant watchIndexedFolders() slot (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29188?vs=81201=81347

D29188: [FileWatch] Remove redundant watchIndexedFolders() slot

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29188 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov,

D29095: Change mouse icon to have better dark theme contrast

ngraham added a comment. +1, very nice. `icons/preferences/32/preferences-desktop-mouse.svg` still shows the old one from an earlier version of this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns,

D29200: test the extractNothing flag

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH testNoExtraction REVISION DETAIL https://phabricator.kde.org/D29200 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D29199: honor the extractMetaData flag

ngraham accepted this revision. REPOSITORY R286 KFileMetaData BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81341. apol added a comment. Address review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=81113=81341 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29223: Update Taiwanese holidays

nhiga added a comment. In D29223#658229 , @cgiboudeaux wrote: > I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? The new file name follows the same naming scheme used by the PRC

  1   2   >